From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1062DAC0967 for ; Fri, 24 Nov 2023 03:06:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WXjDQLfureU7BMxhj/j1K6hMjWaZC4OdljAvHtxAhMI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700795209; v=1; b=nHN80IEZYZvWgsvnwU18xj8CHj0SKeCr1q/yhTteeWeodAtbMnf4XVhgDzL57REgJQgR2YX9 5btmIqTAOnSp8lh4PGJ5EKksXrtuVwr9hsYx6QCWO6vXlYSABdIQx6vACJYvW5TsjquXuZ0rhtb INMKA4tFllpEZ7nBnEEQI6O8= X-Received: by 127.0.0.2 with SMTP id 15UwYY7687511x0cWPnRyyyU; Thu, 23 Nov 2023 19:06:49 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.128434.1700795209188966686 for ; Thu, 23 Nov 2023 19:06:49 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="396265565" X-IronPort-AV: E=Sophos;i="6.04,223,1695711600"; d="scan'208";a="396265565" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2023 19:06:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="833571114" X-IronPort-AV: E=Sophos;i="6.04,223,1695711600"; d="scan'208";a="833571114" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Nov 2023 19:06:48 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 23 Nov 2023 19:06:47 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 23 Nov 2023 19:06:47 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 23 Nov 2023 19:06:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MFXPxSTJ/O0ujW+mjk2gYkjePbT4aF+3kc/7AljzetVKBU2RE4t7nzZkEH94JHJx3Tuybxz+Uw9WV+9+WY8MtSMQtZPG3r6KKhIvYtPc39l+pPEfmLnuJxX6XxDYjXmTPOOcH/yWxvGmjd76oSeBJlf3d4cXW8psKz9QvtITpu0RY1zoKZNCrDY+UwmBWiSnetPnxZixJoXVuOljRdwom6SFsNsPEFHDoszZPs9LNJ/HPKY0oLfYSsnG7lGTtDqPTuqckDSDYbwoQVfil9POseSH6DyEP/5nFwV0tpBoDAIvbM3UTaicAMC6swa18SemETMCHXSOHM6mDZdvpgaqJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bIHU3/JpbzM76Jr3Ny8fnTBTU05PDdc7a3K8Xl+olaI=; b=E7fn3xe2A4W/pN4eMU8KRWTfxypjVe+8GD8VmKIP5/57uWfASAPj24xe8i/Y8Ec72D374J7jD3r/Lubofw1KxHBc7t9X/xRhBM7JP8dgebcXtF0AyMAjOP804k8RmhN52OEfZHEu6xhfI5SP4b4ezlerqCvxcbmP0spajUodLP0lNeyw6W2EBSNzdJmjXSiuLV5uqlWSsdyLYHEm54izup5/65ekZeafdSvq95/GbNvVPCrftCKYeQTYiy/5Yn6Ny0fNbDb3jhpJU3bumAXSLy+0wUDOuJOimkaS0HmRbPeb14WR5WKdcOFtrPHOwbPxmhLSzUBDxiAmMwp/uKY3CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from SJ0PR11MB5037.namprd11.prod.outlook.com (2603:10b6:a03:2ac::21) by CY5PR11MB6368.namprd11.prod.outlook.com (2603:10b6:930:38::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.19; Fri, 24 Nov 2023 03:06:41 +0000 X-Received: from SJ0PR11MB5037.namprd11.prod.outlook.com ([fe80::ec24:9b2b:7dab:8a2b]) by SJ0PR11MB5037.namprd11.prod.outlook.com ([fe80::ec24:9b2b:7dab:8a2b%7]) with mapi id 15.20.7025.020; Fri, 24 Nov 2023 03:06:41 +0000 From: "Yuanhao Xie" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Tom Lendacky , "Laszlo Ersek" Subject: Re: [edk2-devel] [Patch V3 1/3] UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE. Thread-Topic: [Patch V3 1/3] UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE. Thread-Index: AQHaHQplFEfOC69MA0emYYEWaCAwIbCHG+eAgAGwDkA= Date: Fri, 24 Nov 2023 03:06:40 +0000 Message-ID: References: <20231122060834.3467-1-yuanhao.xie@intel.com> <20231122060834.3467-2-yuanhao.xie@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5037:EE_|CY5PR11MB6368:EE_ x-ms-office365-filtering-correlation-id: 461980dc-41b4-41d4-1bf1-08dbec9a619c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: kbZ6D1auKcV3uuXhicL5vnuFMD0qQngUTGavtUsK4GMlyDzYgDo3rvswn2FDhdJqYSZNqK6rPljsijT5zYgjQxiZiddQzLImYRq7pmEgaO8VgRPfU6LN+FnSATPlskL7u2IjseQKv2hEHpClc+Bk/cQ3zSV9BEHd1dD3RaFLOoYqvyUzzyYP4kaXf5sAQ2suarFxHvfNEJah+nJ9DrDnjhZ9NFYxhJYeZfe5/D9C5Pi3P68vBEKWmT5m6FtkfdtsPEUubzuV+wvA5FZZmgBT/jHIo8UZ1ZC1vPD2YPFHP5sdRnTavILBNrgZsURMuwof+A7xCph18+kRciOReV25yyUQ9b+s73DlPlJgme5AuoYUv2YFenS2Uwl7Dd4R5UsNi2M1S+kFhQz6iUtRZtKQjzEaqZ+a2IrkEFuKkKKPlUBl2i3MreOi60ejXKoCl1c4q0p9WnsADCzXTHu62Cjf36RHn2l14P20PldmfsSSnKNo/Z18WCyG3cXR38Rddc3NrxBqrbvL6iekMDftZxbnGNvQKy7W9/5Adc1bNJ6tYDRi+lQbKGeSf2DoonD941991r9O1tGtI4rTAnwxbblUmWAShkbXZgeo0y/FJQQJj8VyMb430O3q5cS6BEXDy1Ip x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Jg3Tj/2uClbA7ySwLOfyJLn58sX9u9uaArwYPE/4xAeBELnI79wQnWBq4vZs?= =?us-ascii?Q?mbuY2x1U9zY4Q40B3F+LZ4kBttzeuQh5oj8pwQNCeMteyvOiJjF5ipA/NuVg?= =?us-ascii?Q?4GC2QOiHkNte02qn3UzMWg4KYj2mnJwn6OEhhZrfll0PS2YtgTBVnAod51y0?= =?us-ascii?Q?cQlHpRkaeRAo9lzJbjv2AGDCkV85uhj0IpsNkHt3IL+zrJrvG/I+geTFAX/W?= =?us-ascii?Q?UVF9AABup4eSHKbFucnYOF/krfDgMW6tl5nyowtjFiL4rSz4hCCBUwXkkxPU?= =?us-ascii?Q?8PrUKTJxdZSitpQ2GBanKMVhEH47ZHtXt25nExoFijA17tphotd0wUm7HVTc?= =?us-ascii?Q?+T51Q427PFEEBRbD19zwy6Otq649+HJUPPGRw2QSRXqF28un0pdBq6p+7amm?= =?us-ascii?Q?4t0cq6TmI17/olw2w2308IAPDWGZlzJ0+suHmvgBR4f/O0FvGyQT1GFQj08t?= =?us-ascii?Q?RIZw7YuJvwJbwZlmd+eR7Is5MzLqAQ9+MEnbudWEr+f86PU9ekh1ueywCodf?= =?us-ascii?Q?OwlYTfgZWA9nN7RpBU6tc+GxEVLKQrds9/xssl9w4wXKfuAfsqHhQZloRSbR?= =?us-ascii?Q?SAAhWgJrYL+R5jces49iTkp4CxLmqlIuLPRMWuKpgQhXaEdF5EALZSlQ4Va7?= =?us-ascii?Q?MkcZAXqAogDAf93EeCLEikZyUmlvQ5+OiBkcqjmRZRWpCv4JG4st3upjQraV?= =?us-ascii?Q?SvFiYaNr+/GyLeS3Qgnc92PJPjxMVH+xn2In0Rfw6K8zN1X18sL2QEVQtboc?= =?us-ascii?Q?qRybkjmJTOaB38yJVww7CuHT5QIizao2SZ3jEiYiN9oQhlNlbhUie8yAk6pm?= =?us-ascii?Q?0cGKBjmhBYcE2rtSfmf2rIWRIFMexCqAX0C//h/DlHo0mV/DvoouAM77wEyR?= =?us-ascii?Q?RzK8Xnclk8rrto9FWygIMvF+3bJT6F9hulv4mPRdPtGWGzLzbcd1f95OFxnb?= =?us-ascii?Q?Ur20txRz1fV6v+NuAYwxq6RKpO37MtC89zDt8hEewAfTaeb+XhE70DRUbsY7?= =?us-ascii?Q?4Kw2UanlKHVmSCh04tY/7oyigiSJr+PmLVoZWio7/RkX6Xz1bwgrm4R6HOG1?= =?us-ascii?Q?u86e6sL7BpdY94m4s/Qu9UkD/PN3+BNOaaLsWvqWBs/9UFEsTbJBhwN3mADv?= =?us-ascii?Q?Wfw5rPCW1gEvP1yEcIHHGNaCRv/LyD/vQ85jTGjEqfGfyXHM1jlFFK7pJ/W8?= =?us-ascii?Q?UxXLoWAw868jqaSw4xYMdizPf39OX45BXRu+SH6Zl++WJU5ZL+Yko0ErI3TK?= =?us-ascii?Q?XE8cBEl3cBvIfOpM5IEsPkiL05roT/wJGkGwDCOMnOZR8+Uwk7bSBfXh3U20?= =?us-ascii?Q?sa7mdAbElIhqJgFnFuKDjqZeI8BGv8+zygRguJ8o7ZRnQUkYvktp+fXRVhR1?= =?us-ascii?Q?1ytHl0LZse/C11SvRCO8fx/n4iaG+jPGBqnt5ZeqrCiaPU0asVHscY42Ffdx?= =?us-ascii?Q?OsBENH0Y07xetbxVVO8/RaWpVcS+oEPta8EaNKYSHb4Ny9oYngVfb72jg5ML?= =?us-ascii?Q?SOdY4bZNvqhZ/+KnRKBCHHhzHfwHRdW4hAJXznDLcUBOrh2RLzFNf6RZLU5I?= =?us-ascii?Q?/wdX0zo0b2H/XTpVCL1S/Enx/Utan2R7CFaMvQme?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5037.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 461980dc-41b4-41d4-1bf1-08dbec9a619c X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2023 03:06:40.9686 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ShgDF5NZmCM9MfB9sLRfwBc6DmGow5VU9CtElFFybeVTN0zgoW/GSEnuMLBI9HgMFz6IyJB6cLmPtPfxO5Fa5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6368 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuanhao.xie@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: pT4mQhrB4lPK04VJGNmKpUTgx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=nHN80IEZ; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Ray, In V4, the GetMicrocodePathInfoFromHob() removal is in patch 1 instead of t= he patch 3. Comments of MTRRs syncing is a updated. Thanks Yuanhao -----Original Message----- From: Ni, Ray =20 Sent: Thursday, November 23, 2023 9:18 AM To: Xie, Yuanhao ; devel@edk2.groups.io Cc: Dong, Eric ; Kumar, Rahul R ; Tom Lendacky ; Laszlo Ersek Subject: RE: [Patch V3 1/3] UefiCpuPkg/MpInitLib: Eliminate redundant micro= code loading in DXE. > - MicrocodeDetect (CpuMpData, ProcessorNumber); > - // > - // Sync BSP's MTRR table to AP > + // Synchronizing the MTRR table to the AP is always essential. > + // During the DXE phase, it cannot be omitted like loading=20 > + microcode, // as the PEI and DXE may be in different bit modes. "as the PEI and DXE may be in different bit modes" is not the reason that M= TRR sync needs to be performed in DXE phase. The reason is some code might change MTRR on BSP only after CpuMp PPI servi= ce is not available and before CpuMp Protocol is available. That is in early DXE phase before CpuMp protocol is installed. > // > MtrrSetAllMtrrs (&CpuMpData->MtrrTable); } -----Original Message----- From: Ni, Ray =20 Sent: Thursday, November 23, 2023 9:19 AM To: Xie, Yuanhao ; devel@edk2.groups.io Cc: Dong, Eric ; Kumar, Rahul R ; Tom Lendacky ; Laszlo Ersek Subject: RE: [Patch V3 1/3] UefiCpuPkg/MpInitLib: Eliminate redundant micro= code loading in DXE. >=20 > - if (!GetMicrocodePatchInfoFromHob ( > - &CpuMpData->MicrocodePatchAddress, > - &CpuMpData->MicrocodePatchRegionSize > - )) > - { Can you delete the GetMicrocodePathInfoFromHob() in this patch instead of t= he 3rd patch? -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111692): https://edk2.groups.io/g/devel/message/111692 Mute This Topic: https://groups.io/mt/102744598/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-