From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6C37EAC026A for ; Fri, 26 Jan 2024 02:49:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1JhOlixwHTsRVqPsy+mvI0T20gv0qXZnp1rUcyjaFwo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706237363; v=1; b=L8+g1t66qIRGJi9Tt5GepyxptLQOirE2DPJp/okMjaFQpOvkkfubYgL44aCZisrQSJAJhtnN 1RtnqP6Lyc39VRI/qAKsaGAA2Lqb5Ug+N+/j5P2XaMpcKHAUWccUjJ6XrxS4moJFXJBISBnFYAL 5XK+bXShpAq8/F3JOvMzl05c= X-Received: by 127.0.0.2 with SMTP id AKxjYY7687511xtLhXbMMYPl; Thu, 25 Jan 2024 18:49:23 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.6900.1706237363110306019 for ; Thu, 25 Jan 2024 18:49:23 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10964"; a="406106571" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="406106571" X-Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2024 18:49:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="2465686" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Jan 2024 18:49:23 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Jan 2024 18:49:21 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 25 Jan 2024 18:49:21 -0800 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 25 Jan 2024 18:49:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kya5YLdbJHMNW+AJaWYMeQ2NsuByCwrh2uTPPifbfUMLsRztOJjsjExeN//c8koOUg2tms0WH1e5gF4nOPOynaG/3Z07M9l402TpxtSvimgoeJuFIZGRsPrm3zGPADQql+5hyVmXT8n7VTNMIt1Uq6dCq6Y8IjaPEZBQR2n6yyWDD1JXXr8FcRmbpNiMBUraR6O0fymQ/l4CSZQf2FPSeuKzJ7+buU0tBFlwqWdYFUfe96S1D7X1suqEOYGsu8+EB9XzvV2w7wq13SyAONgT09pZaQqcnbNGyU0P8iDizl2SMfcoY6rpVbmVfz9ll/Vwm16UrUk2g85/rdQBCP6QQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aye+UpUpydBYo6Hh+fQB7q2cUYlji1jYZKkpPts/qSs=; b=ZW3pnNkVWs6wfffFH9lGRigKk+wj7ygr9v4vifndZKzJQi3qvT0Gc+HGfISL9RadqP2OJjf5fiPDDmMpkXqyIglypgpLGWvOQDilB220OxwVrwsIRRdgSNK3fe5USuwZfpP7mfkDhXH/wBPX3DAvgALjMwZxekkxt7Ww/8qfBJnyEEK9f5ZR38Eoh1kODK7CN6Scc/H6y4kVsNHTIMNqQiCjUqk24ZLx0lu6XCTonIgtTHxNlp5bdhKxFMfBd5byFk8OMRNFD6B02P2kywivuAaQ91Vxc4LlF2fEX/gpycEC5xDJf64QuYqaXzdQsQC2QFD9SSCjZW3T6RZ/tS2tZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from SJ0PR11MB5053.namprd11.prod.outlook.com (2603:10b6:a03:2af::17) by PH8PR11MB7096.namprd11.prod.outlook.com (2603:10b6:510:214::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26; Fri, 26 Jan 2024 02:49:13 +0000 X-Received: from SJ0PR11MB5053.namprd11.prod.outlook.com ([fe80::89f8:cfb2:fa7c:9301]) by SJ0PR11MB5053.namprd11.prod.outlook.com ([fe80::89f8:cfb2:fa7c:9301%2]) with mapi id 15.20.7228.027; Fri, 26 Jan 2024 02:49:13 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" , "Ni, Ray" CC: Liming Gao , =?iso-8859-1?B?TOFzemzzIMlyc2Vr?= , Oliver Steffen Subject: Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable Thread-Topic: [edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable Thread-Index: AQHaT2d+ffTKPKoy/ky0i2DTqD+UEbDqbboAgAAEXgCAAO4k8A== Date: Fri, 26 Jan 2024 02:49:13 +0000 Message-ID: References: <20240125082057.309133-1-kraxel@redhat.com> <20240125082057.309133-2-kraxel@redhat.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5053:EE_|PH8PR11MB7096:EE_ x-ms-office365-filtering-correlation-id: 769392fe-6819-46f7-8a50-08dc1e196134 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Vbx8Gl42aXSv6o9BklNFAjZXWZnWnBs4GHtbnAuULduNCTA1VqZPCKN4BazSnJhuQxoB+3ZxEsxL+hYTkCYXn39wlImLANrfkw/hCSd9ew49k7MmH7s/MazELI1r/kkkUT8UkuHTAxMwDAdlZOi4Ekh3WghZjRQuswTEh0o9KT7Rp00PBHxIgVXnCxxNDiUuJa1HJvK7sze5I/Bn29t8pUiHDXMnlvMwEJ/LZHHAC2PPvxJ7LWRQwAcAwNx192ldfAaHUb/Y3Ix40DUwMwk3+EmVhqM89vUxR2RGUAfxP52lL9Gn42MauJ91cUx1ceRD4bLFci0EJc1C4JzgqqAtkArOlquS/kHFi2rGAxrbo35iHaejngU+n3BXAWNXI6XrNyVUXlaZfz0rKZRIi81scMuWKB1B7ju81sJxFxnEhtj7ereaaYlXZ4WSBdhJyepKhwYrcbAkYYWpMj9YOjgfzSMt13n3+F23SIC0TV7UN9Tn/s+ESsoNxtKK/nBwteUPN89iv+meh9oXLRoIef71EtqQmN0xRNwcTJ/yXnXLuXKNC/UeCCKzMv3HSSnGdSM3Cbgm6Py9DLTzyvv56vXQQU2M1YzmEl1wZoxbV5bd8MM= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?/+xhLJtAEulE5wmXQKueiwkx4BgHKdGrbIlZnjm3eOPHzIXppVfwjsy1ct?= =?iso-8859-1?Q?q12ajupwaz1WyB9Bib4QCdcjs5U34d/xxfMuIm7G/le/PV0NKgZZk1Kxjm?= =?iso-8859-1?Q?sOxSHpF+UrNsijTi4xmcCZ/q5Zr+YYXm1lEJR/CPcMqBSwJSlBC2t2tglm?= =?iso-8859-1?Q?B/TmRC+LaBN9HPsm1NWTV0HXhvYujkgpPRtqkyq4Td83pC97x06EnmHO8r?= =?iso-8859-1?Q?oK4zFNyDmT9qeoXZw8mwjxguNchMgGFO+sOSSZMkpLtsQ3oJctcRbTWg3J?= =?iso-8859-1?Q?HNn9PojeTcrNqKy6G8xaPdme4KSSL4gq3CrzRmZE1/7t19ERz5Hcnwq0/8?= =?iso-8859-1?Q?BittHgbWnP5smTnTJw1TT7JJM89oiXQKOvoRF6LltQ2M9csYm84DbJ/i2O?= =?iso-8859-1?Q?AwGSNu1vO73Gjx246z6IjPmAt9sqnU+TQyiznzyKjYB7/2vHZkbhNI8nMm?= =?iso-8859-1?Q?PbwvIoO6iuiFow88Nq7cRwURXvOPlmp/NDyI9BMEuuB0eh/vcbDjxi9yj2?= =?iso-8859-1?Q?BHFF9aOUoUVJbmp7xpROhjIHEqTN124HkAXe0bI8IoueIIlNUYEOWZrl2D?= =?iso-8859-1?Q?E5SpmPK+q6J0dWx2sk1OO3c0h2NZ4Nn0/FQacoJ8dHrTPori5dMd9nZQf3?= =?iso-8859-1?Q?kq5gvBHU7PGykNksg82Nv7/ulSufJWmYvpj1gFSNoxnAPeZaNMlQiE16q9?= =?iso-8859-1?Q?XzcIz3XK8EP+C3MSK5s63iT+ylDTwejMmXYNGf3eYa+974nMo8CSlYW4xo?= =?iso-8859-1?Q?BMA0EFZCr89Mb+4jPb6VrG2nDc6m2a1f9G7fT0WU16s4593IxtnMwEXNHb?= =?iso-8859-1?Q?axJAsF9ctZ3sOj4Ji8jR7uGQ/lYBrN4FBLW6JTrO66GKPdi6TVoaPN4uaK?= =?iso-8859-1?Q?pLFIp4xVYNf99wQBPAJUD7MKn+6bSnbrGi9dLp5KowPvuiov+/2Tz8GXQg?= =?iso-8859-1?Q?nBWANx3BBi3j3tuiKJSt2Q5zv5+xIgtbKyFXYXAaLcQHGst679T3Oj7sFh?= =?iso-8859-1?Q?rUU+EbyDCPSN5w36r0YkPAYSyKX+eMImZeFEqSl0R/gQjrzkvAa+qucB5N?= =?iso-8859-1?Q?6CDEZ27yyg76fMBd+zBpt9RbXWTZm2KgS+qc5oLZMD9mfNzMPApVrS+ylA?= =?iso-8859-1?Q?qnZuCNVuDtisxg95YRkq2bNYsjnnFWdVK4GHqflYMKpdxVy86rIHiylKTH?= =?iso-8859-1?Q?9ZNnkF1cm12uv3y0m1ii+cY+mDeG+FW0Wa7igZvXS7WXJo6iuIhxKkxB8P?= =?iso-8859-1?Q?CUBVoBdjOKawQa7SaaM+HSkyEm3BBXyhf4XG/GKz/JFhCXqOfCVKiqECKc?= =?iso-8859-1?Q?lTMKDbSr0FMc5dQfnHuq7RQZSa5e6T2Ubk5GRMZOCbmZJ5u45gAUrspn7O?= =?iso-8859-1?Q?eVXP5IhzhZj91dT7nJXLxaorZzQv/L3EjfEoAT8/PxL+6MEiLgIjtPxvZB?= =?iso-8859-1?Q?Asaoe8Ty3WH66q+iClcwiRDsyEVmQlXhKAezacW5CWY+r/nfHT71msyKDm?= =?iso-8859-1?Q?xdyto9QhLw/Jk+OhEKHNUJJkIDNT8eRcGdUZcOSb9K5sd02Txta1LcfrST?= =?iso-8859-1?Q?zMfSNS3MJLoKtq7fHN5rQJR2a4Li+RrDkuVfXFCNKWzCbEMkC8EfHXoH9E?= =?iso-8859-1?Q?FMR0rxcilOMQWSYW1himBl1ZnxOO8fKHeL?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5053.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 769392fe-6819-46f7-8a50-08dc1e196134 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2024 02:49:13.3154 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wy6trhcTbMU2/VdDmQ1sgb6RofydS15hn4NBJs79Lrj5kTQMvWFGYUEyys00A21H9YF4hXd3grVQrYTh1AFObg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7096 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: imwEBO67rB7ZvgO2SPcP30OUx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=L8+g1t66; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Gerd, For the PCD, it current has below usage. 1) for 32-bit PEI and 64-bit DXE, this PCD will decide if use 5 level pagin= g in DXE. 2) for 64-bit PEI and DXE, reset vector chooses if use 5 level paging in ea= rly phase. But BIOS can still switch paging mode based on this PCD later. Since this PCD can be dynamic, we can let user to choose different paging m= ode in BIOS setup menu, and use this paging mode on reboot. You may want to use one BIOS to support machine with different la57 capabil= ity, I assume two possible ways: 1) make the PCD as dynamic, and set it based on la57 capability. 2) Remove the ASSERT in DxeIpl Both are fine for me. Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Thursday, January 25, 2024 8:17 PM > To: Ni, Ray > Cc: devel@edk2.groups.io; Liming Gao ; L=E1szl= =F3 > =C9rsek ; Oliver Steffen > Subject: Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename > PcdUse5LevelPageTable to PcdEnable5LevelPageTable >=20 > On Thu, Jan 25, 2024 at 12:01:46PM +0000, Ni, Ray wrote: > > Rename an existing PCD might break lots of platform builds. > > > > When 5-level paging capability was added to ResetVector, I also > > considered to remove the PcdUse5LevelPageTable reference from C code. > > > > Let me think about it... >=20 > Purging this completely from the source code is fine with me too. >=20 > From OVMF point of view this is not needed, all backward compatibility > concerns for old guests without 5-level paging support can be solved by j= ust > removing la57 capability from the vCPU (qemu -cpu host,la57=3Doff). >=20 > take care, > Gerd >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114491): https://edk2.groups.io/g/devel/message/114491 Mute This Topic: https://groups.io/mt/103950404/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-