From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web09.74381.1638265390760092922 for ; Tue, 30 Nov 2021 01:43:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=YWit3ew9; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: zhiguang.liu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10183"; a="260137175" X-IronPort-AV: E=Sophos;i="5.87,275,1631602800"; d="scan'208,217";a="260137175" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2021 01:43:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,275,1631602800"; d="scan'208,217";a="512108084" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga008.jf.intel.com with ESMTP; 30 Nov 2021 01:43:08 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 30 Nov 2021 01:43:08 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 30 Nov 2021 01:43:08 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 30 Nov 2021 01:43:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S/5836PmTNeQAH8I1a5bnTo/+n9T4etqXG85+iJp/qAxkzVFgtrGRMOE0PuYl9QS3EBDruuK/M1xd+C9QhZOL2TQcL7AdVRzrWT5bxFPdgHkMkHiMIiy7cMZbwRUsPbAdRhFX1WA48/T0MMI6K7SXBhU7/w1sOxXHhCpROh63G15ix+VfdpSPYZzoX2aPwakvF7oUEdhR3erfvwyCr7H45TM+IMDx3RsrjoHotgj1hKqhp8URtPUg6zxJ3YVrAsD2S4AeF30CEA1u4og8xpn7xC0WmfESXFfuqCphSII533uTX9wfb6J7UL1TgdZna0+/lQDiJMkb43r4FLgc0qFNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b/hzCe9y5GnS74rAZJVcX6Tah5IcaoFUjqw1e0/gvfc=; b=TbKGH0h83oIKWaD8w7ORiqpZZmBMThX56Bf28MuHBOr8P+qJemTOfnSpr2lMSsuwNNj53rYZIbCE/c1lW932iIF513nBlYfPZhS0nlf6txfmis06h0OIu3T9T/9voG8mjMQHg9gGzhrJX+qEa1C0Ls5SWLPm0tmBko3vyq9hteNb6TyMtoXWsM9yjJh152SQL5fBppyZt/sZZs5BUTUVS1Q6WB1H3ehFfKfThlhCXEb5qxQBjFT7v4i2NT+/mdUNFfre8fR5V1ee97y0z/pKL09dSLfZROpZ7IA1YC9oAB8P3UqKqmGwUWoIB2lS9SdiggaEqqxZY6nvv/rtC4e0mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b/hzCe9y5GnS74rAZJVcX6Tah5IcaoFUjqw1e0/gvfc=; b=YWit3ew9cduoT1yqL2Dgi111U0NUxy45cd0AvvTiIBatdJKBeLYegvEXZv4Dl5vnDn3xzhYwmszEsCafDZdm0YGSpNlza3dv1GeVMfUm7f8aCKpotTAXnzaFlted+TQuooK+p9H/bCQnYqMW58d8hyV3Kp6jM6FIF2qTkPjVQfc= Received: from PH0PR11MB5048.namprd11.prod.outlook.com (2603:10b6:510:3d::14) by PH0PR11MB5879.namprd11.prod.outlook.com (2603:10b6:510:142::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Tue, 30 Nov 2021 09:43:07 +0000 Received: from PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::7890:f8d1:fc4a:87f3]) by PH0PR11MB5048.namprd11.prod.outlook.com ([fe80::7890:f8d1:fc4a:87f3%4]) with mapi id 15.20.4755.011; Tue, 30 Nov 2021 09:43:07 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "Jiang, Guomin" CC: "Dong, Guo" , "Ni, Ray" , "Ma, Maurice" , "You, Benjamin" Subject: Re: [edk2-devel] [PATCH 1/1] UefiPayloadPkg: Update the Module Info rather than create new Info. Thread-Topic: [edk2-devel] [PATCH 1/1] UefiPayloadPkg: Update the Module Info rather than create new Info. Thread-Index: AQHX5aKC/U3xf8Yj3Ueic9aegc6nb6wbzdAB Date: Tue, 30 Nov 2021 09:43:06 +0000 Message-ID: References: <20211130042337.430-1-guomin.jiang@intel.com> In-Reply-To: <20211130042337.430-1-guomin.jiang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: 9450d4b6-3e63-3cc5-1f3f-fc212af0d4d4 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6ac43a3c-3f15-43c5-0aee-08d9b3e5d040 x-ms-traffictypediagnostic: PH0PR11MB5879: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CcbxKb+lJNvVdQ7wuZFasGAxLh36W0N76rUAGiAY7cXUwGaWqX+fRtDWFGnVWLBVTxlAP8drIRSlX8RJ6aYj4yBvSB8cdGHB8VIqe6EzCw4UKNokD2n3N8SGD7qL1+BZz4LFe4phvZLatMCeXVa0GIfGMEGiXjDYhOIRAwzshPLCUi+Lec7pv12OkEz04D6e2awWi0FvwcFF/A64B12s0uWHLha0C2e3NvmnrJJhSqQxUrKAdl7wIBCe6B35DEx2IWVC2IeBpbeRh0AV/RhY/ghnwxcNW7MxWxOa3dNXH3CBavt3dacsHDgx+Nz6L/7nGaZ6th0Vn71wBrkM9l8REzVg6+tOuIs3PbQtqFO0UKRF97lglkTp+4ONq5Nu8QnTFiP2Nd/jUGFgmR/5h4g7wE3WC9eKvXwHgynIXZBRcDfWZ3avkY8Noj0QY0fyPCIMr+vxMvySjb1DMBHKZ4bWF+7UxUZZY1MEE6toLMNcwJUpXYTbdz5Tx/YwjrH0H09etGBCH6+nUysnpkLW5IqfP/TiDGNSoyR+KttaBcWxIMKcCi21jt2PTAUDJptaz93GMCHhBp3uZ3IiGTe8pIusLcndQX/K+jbTVpW9eFmAgFPOZp1LK2jk7d0gRYznO4yfg45MgUjRMIEgJDbJAWOHkXnZPkgnJK+GWuZodOW8Ywsz8muDF24NwLI6+ffsKlVUxVxVZN/yJBtlsi7D2Mi+iOSolQ91FzXZZIbpjrNTzcdjPJBfNDyXOb794nId6vSY/3cdSDQcwUeCcmG2/DaV9+o3kfC5IuVeHqXGU1bWMizRdrSNbmULWPicuGBBaBol0MR7KqD7y1Flm3HIfMpklA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5048.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(6486002)(107886003)(9686003)(66556008)(66946007)(82960400001)(66446008)(38070700005)(966005)(52536014)(6506007)(66476007)(83380400001)(33656002)(8676002)(6636002)(64756008)(91956017)(53546011)(86362001)(76116006)(2906002)(38100700002)(122000001)(26005)(5660300002)(15650500001)(316002)(6512007)(54906003)(71200400001)(19627405001)(186003)(110136005)(4326008)(8936002)(166002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mbGbro7kxer32pTjws2JG171EuUEGgynmTYaXskxEydmH7iDA5FO87ss0/34?= =?us-ascii?Q?pWQNANtbaZylVNM9LzeU7y+8Na3f51ffMLx8cRB0FhBsvkQLSC5J15Cb5l93?= =?us-ascii?Q?yFchalAPWAL7h9zLkYuqAqT+mX+HyedWpmbEst51Q+AanPuQ8X/akJwf+IAY?= =?us-ascii?Q?fh1wCsnV7Ncbu/CTgwWSNFAuQtFULE1hL8viobUVlYlS1i6fVsN+Ytbvqyxy?= =?us-ascii?Q?sjwR/TZ2FTBH+s1r6TR7kByYOWuVLO381ztNpicOUeJjXu2Hn0Est3Y22S0R?= =?us-ascii?Q?lFAJo6wLrZtK7INm+zag4HEpzv4U4/FGfr6cMgW13rW1XkFVE36h9Rri0HlI?= =?us-ascii?Q?WKGpBVjGE0Xao07fccU3WKehDIErVNt0X65eQuCQOva2sTfgJdjreWfyFNTs?= =?us-ascii?Q?1kEbfVkMTrd+Vl2sOw/SY7WpnOsdDbaiyDFawa4PbJZZaTqxIuqefspvPdcv?= =?us-ascii?Q?1iaj9AwHZ78NLTOMHUI2XcihFnXa27MwlBd9UvNWBeypj2CqMZ7kJT962Wvy?= =?us-ascii?Q?HIUC0dpP2DXhthvC3eFu0GzN+DvQ08p2w/O/X32lLyflG5+QDxwp6KbTSWZc?= =?us-ascii?Q?oa64/T4loayngRj56rJQB10dBF1qt9eWOexB4Wwz9Qpxo+wUQ5gcsRRa8ovY?= =?us-ascii?Q?DqpglkHhO/L1xexf7vw9ZRzgYvKRRRX8vD8Rw/2nf95d1AhdquZYb9hLevVE?= =?us-ascii?Q?vwRZl7DElzC7QuquNDFCPqGnnUkiMcF/UGs6gvAGfUB0bm5LXP3JZOifONG3?= =?us-ascii?Q?I+IWmMsQJJtX1hzJnI9KwyeHSBgqISD2WihMnz36TffqMjisRcWNCwoXhIvB?= =?us-ascii?Q?f2DHP2Um8jH/N5Sz87iWHON5PnrhjbiA/iCfrG2mZjvOCiIpb5HN6UBIgbhB?= =?us-ascii?Q?471THSTIY1Tu3dBRz3IqZJVdCMZP3FErVa/vdELC8E+bxu0q0nVPbp8Xhfht?= =?us-ascii?Q?LPwD9xXjh3ttnswvDTzeABVKMIlq8deUNRs4f2qc5G4WL3r2Z2mVrQTl+frk?= =?us-ascii?Q?aafZkfjRs52MfqPulAIEQNAEi4QKWjF4Q4FELa7Fsvd3sLffkQbQSa5wH8Nr?= =?us-ascii?Q?xFMiEiZCGcu8TV/tuJ4DwNU9U2di4Ow6coy5ngQy2CyWBSgNjpk696/54Koa?= =?us-ascii?Q?iUKOumNh8hZQ/TL19BoXhbi6vLwTq5EiOfcmlVTUowNA3QAihxu59sGDSyJQ?= =?us-ascii?Q?smvhLj4+y4pzyV9+r+pOyZOrkhmbr5Me4doNHJqS828fP/WZh7mMvZiQSvLd?= =?us-ascii?Q?bCbpBhaz+3zjDVY1Z/Gp7mog151+MuZpzZMmLfMoH6JEkYzU28JsoHfyPVEQ?= =?us-ascii?Q?P26QHOv23p2LuTuRYaxS78TrouD2kBy9QRJLQ50JtAy5De3ePgGveXhvRBJ5?= =?us-ascii?Q?PuIDtqT47HuPD5Oxq9s5dpyPA6PyXSUiGqOV5DSvmLGazSrBcg5HYKpy/94n?= =?us-ascii?Q?GDxiAkqWzG+yjz4o9YExGzKnnF/7pX1gkF2Lgw7OFjQoGrMj4bb1Lea+2Kye?= =?us-ascii?Q?Nwz8zTsG/tXySYtFCRTCjg62pPs7jOycwpJZ3gC9p82G+l/JCowHduSmJpc6?= =?us-ascii?Q?kxpNQ/HqK1uxMyf9hWCUr3o4aL/zGwyDxEZQlXzHZNJfim913WNVPsOHawEg?= =?us-ascii?Q?0w=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5048.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ac43a3c-3f15-43c5-0aee-08d9b3e5d040 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2021 09:43:07.0554 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JGl6IzMDoXvTL2DYFx0XEvvd3YEWjw95zAT/KGJZh73ogUuYkTHopBIBGkRJkmudWBVjNpc88Kb09wbeKifiCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5879 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SJ0PR11MB50539A3622BCCEDE2B945CB890679SJ0PR11MB5053namp_" --_000_SJ0PR11MB50539A3622BCCEDE2B945CB890679SJ0PR11MB5053namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Guomin, Thanks for finding this issue. How do you find this issue? Does it cause any bugs? For the code change, I have some suggestions. I don't suggest changing HobLib because it will increase the difference bet= ween the payload entry HobLib and standard HobLib. I suggest changing the code which copies all hobs to new hob list in line 3= 41. For now, we only skip handoff hob, and you could add a function to determin= e whether to skip the Hob and let it skip handoff hob and ModuleInfo Hob. This will help a lot because I also plan to skip some other type hobs in th= e future to enable other feature. Thanks, Zhiguang ________________________________ From: devel@edk2.groups.io on behalf of Guomin Jiang= Sent: Tuesday, November 30, 2021 12:23 To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice= ; You, Benjamin Subject: [edk2-devel] [PATCH 1/1] UefiPayloadPkg: Update the Module Info ra= ther than create new Info. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3754 1. DxeCore will use ModuleInfo to install LoadedImage protocol for DxeCore. 2. DxeIpl will create the ModuleInfo of UniversalPayload. and UniversalPayload will create the ModuleInfo of DxeCore. 3. Only the first ModuleInfo will be used by DxeCore to install LoadedImage. 4. So it will create the mismatched ModuleInfo for DxeCore. Changes: 1. When found the ModuleInfo, update it with DxeCore Info only. 2. Create new ModuleInfo if found no ModuleInfo. Signed-off-by: Guomin Jiang Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You --- .../Library/PayloadEntryHobLib/Hob.c | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c b/UefiPayloadP= kg/Library/PayloadEntryHobLib/Hob.c index 61cd11ba0335..b840e7914f7a 100644 --- a/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c +++ b/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c @@ -331,6 +331,30 @@ BuildModuleHob ( ASSERT (((MemoryAllocationModule & (EFI_PAGE_SIZE - 1)) =3D=3D 0) && ((ModuleLength & (EFI_PAGE_SIZE - 1)) =3D=3D 0)); + Hob =3D GetFirstHob (EFI_HOB_TYPE_MEMORY_ALLOCATION); + ASSERT (Hob !=3D NULL); + while ((Hob =3D GetNextHob (EFI_HOB_TYPE_MEMORY_ALLOCATION, Hob)) !=3D N= ULL) { + if (CompareGuid (&Hob->MemoryAllocationHeader.Name, &gEfiHobMemoryAllo= cModuleGuid)) { + // + // Update Dxe Core HOB. + // + Hob->MemoryAllocationHeader.MemoryBaseAddress =3D MemoryAllocationMo= dule; + Hob->MemoryAllocationHeader.MemoryLength =3D ModuleLength; + Hob->MemoryAllocationHeader.MemoryType =3D EfiBootServicesCod= e; + + ZeroMem (Hob->MemoryAllocationHeader.Reserved, sizeof (Hob->MemoryAl= locationHeader.Reserved)); + + CopyGuid (&Hob->ModuleName, ModuleName); + Hob->EntryPoint =3D EntryPoint; + + // + // The Dxe Core HOB should only one. When find it, update and return + // + return; + } + Hob =3D GET_NEXT_HOB (Hob); + } + Hob =3D CreateHob (EFI_HOB_TYPE_MEMORY_ALLOCATION, sizeof (EFI_HOB_MEMOR= Y_ALLOCATION_MODULE)); CopyGuid (&(Hob->MemoryAllocationHeader.Name), &gEfiHobMemoryAllocModule= Guid); -- 2.30.0.windows.2 --_000_SJ0PR11MB50539A3622BCCEDE2B945CB890679SJ0PR11MB5053namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Guomin,

Thanks for finding this issue.
How do you find this issue? Does it cause any bugs?

For the code change, I have some suggestions.
I don't suggest changing HobLib because it will increase the difference bet= ween the payload entry HobLib and standard HobLib.
I suggest changing the code which copies all hobs to new hob list in line 3= 41.
For now, we only skip handoff hob, and you could add a function to determin= e whether to skip the Hob and let it sk= ip handoff hob and ModuleInfo Hob.
This will help a lot because I also plan to = skip some other type hobs in the future to enable other feature.

Thanks,
Zhiguang

From: devel@edk2.groups.io = <devel@edk2.groups.io> on behalf of Guomin Jiang <guomin.jiang@int= el.com>
Sent: Tuesday, November 30, 2021 12:23
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.c= om>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjami= n.you@intel.com>
Subject: [edk2-devel] [PATCH 1/1] UefiPayloadPkg: Update the Module = Info rather than create new Info.
 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3754

1. DxeCore will use ModuleInfo to install LoadedImage protocol for DxeCore.=
2. DxeIpl will create the ModuleInfo of UniversalPayload. and
   UniversalPayload will create the ModuleInfo of DxeCore.
3. Only the first ModuleInfo will be used by DxeCore to install
   LoadedImage.
4. So it will create the mismatched ModuleInfo for DxeCore.

Changes:
1. When found the ModuleInfo, update it with DxeCore Info only.
2. Create new ModuleInfo if found no ModuleInfo.

Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
---
 .../Library/PayloadEntryHobLib/Hob.c     &nb= sp;    | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c b/UefiPayloadP= kg/Library/PayloadEntryHobLib/Hob.c
index 61cd11ba0335..b840e7914f7a 100644
--- a/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c
+++ b/UefiPayloadPkg/Library/PayloadEntryHobLib/Hob.c
@@ -331,6 +331,30 @@ BuildModuleHob (
   ASSERT (((MemoryAllocationModule & (EFI_PAGE_SIZE - 1)) = =3D=3D 0) &&
           ((ModuleLength= & (EFI_PAGE_SIZE - 1)) =3D=3D 0));
 
+  Hob =3D GetFirstHob (EFI_HOB_TYPE_MEMORY_ALLOCATION);
+  ASSERT (Hob !=3D NULL);
+  while ((Hob =3D GetNextHob (EFI_HOB_TYPE_MEMORY_ALLOCATION, Hob)) != =3D NULL) {
+    if (CompareGuid (&Hob->MemoryAllocationHeader.Na= me, &gEfiHobMemoryAllocModuleGuid)) {
+      //
+      // Update Dxe Core HOB.
+      //
+      Hob->MemoryAllocationHeader.MemoryBaseAd= dress =3D MemoryAllocationModule;
+      Hob->MemoryAllocationHeader.MemoryLength=       =3D ModuleLength;
+      Hob->MemoryAllocationHeader.MemoryType&n= bsp;       =3D EfiBootServicesCode;
+
+      ZeroMem (Hob->MemoryAllocationHeader.Res= erved, sizeof (Hob->MemoryAllocationHeader.Reserved));
+
+      CopyGuid (&Hob->ModuleName, ModuleNa= me);
+      Hob->EntryPoint =3D EntryPoint;
+
+      //
+      // The Dxe Core HOB should only one. When f= ind it, update and return
+      //
+      return;
+    }
+    Hob =3D GET_NEXT_HOB (Hob);
+  }
+
   Hob =3D CreateHob (EFI_HOB_TYPE_MEMORY_ALLOCATION, sizeof (EFI= _HOB_MEMORY_ALLOCATION_MODULE));
 
   CopyGuid (&(Hob->MemoryAllocationHeader.Name), &gEf= iHobMemoryAllocModuleGuid);
--
2.30.0.windows.2






--_000_SJ0PR11MB50539A3622BCCEDE2B945CB890679SJ0PR11MB5053namp_--