From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.60527.1670889872078198860 for ; Mon, 12 Dec 2022 16:04:32 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=FirLBt43; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670889872; x=1702425872; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=GP9XvLU2Xy8Q7x96HGJUFUIfhbjnd/uNe8K8IOrhA04=; b=FirLBt43YxquoKXOQCHoDGFX0MwispuQLPP8yZme/XuorUuqQBOHAmu4 6n7L+hnTgr9mQD87Z/tKF2O1HwRgIf+lrgAu0QE3oCAFm0D8KVS43b2ly 5WyW9Q9MtC45CsLwjidGpMvvTHMDx0+DScScBkrboN1JRIiXjvDvKiPTl rPFzyNW4xzL876yCUFYqjYLO5KK3xMbptlKwLtDdqxUsdAB2hYIgC+tue /Ir36R/fQ0CJ9sUwvq0po6hqBiVZ11D5EHUt1HRIoc57MsyJ7FYY/Ys5F UBn4/vn6UYd5AuTiedHYh4XY97Zk9Rq1piBUDcZKRF95BNi0sN8sqXGFp g==; X-IronPort-AV: E=McAfee;i="6500,9779,10559"; a="315629898" X-IronPort-AV: E=Sophos;i="5.96,239,1665471600"; d="scan'208";a="315629898" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2022 16:04:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10559"; a="737173551" X-IronPort-AV: E=Sophos;i="5.96,239,1665471600"; d="scan'208";a="737173551" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 12 Dec 2022 16:04:31 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 12 Dec 2022 16:04:30 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 12 Dec 2022 16:04:30 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.49) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 12 Dec 2022 16:04:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cAa+X5aqTvfkOVcmOHaRA7xG2z/tWv2KQ9aZyQZFaqOpWYwcqG2GB8hYXIVFafD/IlBFV0RCs3NU7ApauEmFOhEdXiXK69OA0nRbm7tMWOFcZizzVL9wD4vbL+F2BArmzqfnO01J5db5L21+Dt9P5JlrHY7gIas3hvMx9aWmaw4tnRQsmaTqO0sSSkcvdt9rlxAUv9xLwpVcFKvXxRR5BmQShJXVcQAAUidVwMpD+6wKRpou1VVyEgY4Pl/heNkWmL/Jqv5Y+Nhen+RD//rDY6Ls/vczKry7g+VGPu3vsI8wS5SrokaRIAR/hCsmeSaa2iZiBh+FFhB1AwRcjP2X8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pD22azy3fLuBPMdTC2HNc0fHOf0DPP3AN9CqW93XL+A=; b=YaASHUF+XLTamTKpZ2DFtmBTcgdzTryFHVyd4QCx5w0He8nyIu6KWszqhcJPiER5AMrLDP8wktC3D4WYqDInnsNhGwQGotmssSKogoeE12dUY+ySpgmXjpYZhmPQhG0b6Se+Z5my1dyLmpamv2a+h1tRj2Pcn9/PmtFEKxaxA9e6NYLBk7J5vTHDBwsUawjSIA9sQolb02J8JfL4kX5TefJ6O0WZP1Lt9j8p8reByE3c/cXxkdNGx0wEnYEGOyzF7AhFTN2A7LUd1qOgxI7YDxDNh6a/2g+stPw/lrzsah7hhjJP57NjZ+eJkjC9FhSqK0D33jSEIw4UvtgJMfB36w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB5069.namprd11.prod.outlook.com (2603:10b6:a03:2ad::6) by PH0PR11MB5879.namprd11.prod.outlook.com (2603:10b6:510:142::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Tue, 13 Dec 2022 00:04:28 +0000 Received: from SJ0PR11MB5069.namprd11.prod.outlook.com ([fe80::10be:d81f:bb30:52d0]) by SJ0PR11MB5069.namprd11.prod.outlook.com ([fe80::10be:d81f:bb30:52d0%5]) with mapi id 15.20.5880.014; Tue, 13 Dec 2022 00:04:28 +0000 From: "Min Xu" To: "Boeuf, Sebastien" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "kraxel@redhat.com" Subject: Re: [PATCH 1/3] OvmfPkg/PlatformInitLib: Differentiate TDX case for Cloud Hypervisor Thread-Topic: [PATCH 1/3] OvmfPkg/PlatformInitLib: Differentiate TDX case for Cloud Hypervisor Thread-Index: AQHZDgix+62A4usUsEuo/KV3PGFYwq5q8KVA Date: Tue, 13 Dec 2022 00:04:28 +0000 Message-ID: References: <64b42b8bb9bbbafc6abb99c812baec57f1506990.1670835199.git.sebastien.boeuf@intel.com> In-Reply-To: <64b42b8bb9bbbafc6abb99c812baec57f1506990.1670835199.git.sebastien.boeuf@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5069:EE_|PH0PR11MB5879:EE_ x-ms-office365-filtering-correlation-id: 0fb8b1a7-606e-4ad6-450b-08dadc9d9a9a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q+oYHKpAMaDGC6UD8MVTh2uy1W5qJVzAiNCNx9Xz5tpAzvWh3GQzAg6ncVgti+GeRhIADWzMA+MYl52re6x3Eh6DhBvLdFF2+b7Aalfg2+NcN/O8OQ9UHvKgaA7K/uxucayFyWQHcVuBYdHrIRNNu8g+9g926cyhhRSkV0Ts34OLGW3Sgnjue46CKeEwucNVznQR6s3R0hEYCwHHTxDr07rgVMXA5er9OkJejPew2ReDFR/UUcCjs35dasCXx75OGNgE+Q8WdRXm4Aw2bdORwQg/nB9OMGOWfLBZVqlNP0/iN5yiRgt9Xt2ba7iyv7Z6U/vwBO+eiBtiLojTRVhdaWCni+uRN1j2HIx28ic297IPXPcC6VzPCkia6Cf1P0w1O0gGhhJsLanreBUQhU20t9k5z9QNXR+iYetIFJmkw5BZPRO1Ku7bVIAknFTrfBnS9dCfjU3cqVpzpd86fNnPItzOCRzgxpO6k0pD3zU1hatSo9bhIOxY9Ob12WB8SE8WvGuhCSL1JAeIQX6YziYURjoi3DyfBQWHYiJmpVjpk1j/uQd/49gOzo+FUAWLtF5MTruG5VEbvWugwVaQXj6pewow6SJQsV0DzQ5vQzr+RpsEbhhVeZ4gaETHmZHBYW7d8F8oGAD3WjrS+rcZWKPD/JHQRyx91gN2laLo29ZeyetKAXwdG9/OXsvlduYN/fB6zDyG2zz2G1I9kmnBh8VSMA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5069.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(346002)(366004)(136003)(451199015)(82960400001)(2906002)(55016003)(38100700002)(122000001)(52536014)(41300700001)(5660300002)(83380400001)(4326008)(66476007)(76116006)(66556008)(66946007)(8676002)(64756008)(66446008)(8936002)(316002)(86362001)(7696005)(38070700005)(6506007)(478600001)(54906003)(33656002)(9686003)(26005)(19627235002)(110136005)(71200400001)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0pjFnsDJAnQz40KcEy6b2S8tSs9YUghs8QUH8tgJ+sE9NLE1FCkjfn572XbI?= =?us-ascii?Q?Pzn5p/3nmq1+XZQO+nKy62GbyEbBFVVJe6ZYvXMnjZpdhJwQ0v+F6JnAEyh3?= =?us-ascii?Q?qOlFRmDIpHIqOVGqpZxRg3y02UACdDYu/GWSmU9poIkkA/gyHFH7O8dyU6iL?= =?us-ascii?Q?XpA91trNl6Io2TRxcyA3utOn1D3tetmuXoxbRdIKBRQcvGVOKKkGGNBYOxfS?= =?us-ascii?Q?Sv51UMi65K1i2EjNgCW3j6Osvm4tPSB35mHL97yr12WW3G/yKNRefTIJFFe9?= =?us-ascii?Q?3UvKtctU5dL6FSraakur/6nMeH9PBt8r8+5QyF4V366fMe36hlgbDPlqqq/5?= =?us-ascii?Q?JV1JSlhuJm/QbfcpgsqW5pHrqlpCyS9qKYY1eGaFeS7EUzqX9WL7/2Vfn+ZE?= =?us-ascii?Q?8sEdwWMyi0pwj3OOVW0v/Jj67lHm/wzOP1X4zB5LlypkHu3mVNHi6y/atD/G?= =?us-ascii?Q?m7WS3WFKnvlBWuCCBN1WZKhhvHnJIDIA1p5MtXCuIhP+w/uC/6YGMosw9taM?= =?us-ascii?Q?8YoI6rxuZZymIb2FzGoEiYXueuKTurte22WdTdcnZvzjkpZ2U47SB5yEFCeg?= =?us-ascii?Q?WwsWNMeB3HcnuCPFzAXW1a3hO/bID8ptolaJ7dxxoHAoAHzsM6DoMbfvIMyO?= =?us-ascii?Q?3lD+vmd7YLGUewikDM49d7uSnXu2zQKfEMdijB2bOcX4Vp1dN1aPrqTUkors?= =?us-ascii?Q?hxGUPED0Vr6aAM/pdTUh5g1w+FJKbXN56cHhANK0eAX4t92rMozd3mC03hZb?= =?us-ascii?Q?0I7Jyg5/AvL/UCorrW0ljVtsqUU9iSC5CQc/xYMQHWfU61RfXIW8cBQ/rP0M?= =?us-ascii?Q?4WoCGQnAiHKca9KWYRCUwoXLqMdN2RrAJba7kCj5oMbGmnNBwwkkwivyhgaC?= =?us-ascii?Q?0mpiuxaq11pNb2i9KezI1hCCwiM80UT9CArdmJte6SsUhBPzBwgaeM/qN4MT?= =?us-ascii?Q?NDLR7KZaVbBlYAxjznjXJCUWs8RX1ahOtD3MANtYArkUHHrFhSQ445Spmf4H?= =?us-ascii?Q?6AC1r5iM8BGsMgnAYNjO6OdUkMWj9k03tuhxt3ozjUh0JFj7kYhCN+1dstTd?= =?us-ascii?Q?2VHLG+d2tAu94+274VIq4zzhcpeEOXmpgWwrQaPZxbS7P+RYd1FWF6dZVqx9?= =?us-ascii?Q?HEydVY700BF+zwvXw7SxYz4BTtbMKg4tK13gB3ENiIsBc8M44Jp4qfzkWzB6?= =?us-ascii?Q?WP6XtjRteJacaq7ThBbNMu/ZiTPTvM9f0auZnkQB1wnaHfLEFx0bpxtggSVM?= =?us-ascii?Q?qcDl3JxLkaR9x4BYLHOVipgTTu0su238SsHTNob+WoAPwfTWlUJ3GRMUeSK8?= =?us-ascii?Q?ACv+kBUoTB+BTYSyzVYBK/5r/eFdP+Ld/kBHDmocnsDm5MCgcKLOth5XcMy3?= =?us-ascii?Q?lZAIAvpnd71gn0ZtHgVKlOISNFUB1zXhLpRrgjxF9frQazYreQDhe+9vIY3w?= =?us-ascii?Q?r6KPr3SNWpQBtJIdtfXyYV3mkoI0mOKcOPu3KMtUZtdpa9J6a6/4tRYEaAiN?= =?us-ascii?Q?KKLduICagn4wcfKHEgi0V2tmWmWLAmTqTVF5rnVyYQL/asSZW7z7IoMQiuss?= =?us-ascii?Q?m92ELCQCrBosa8Soax96DNAJwlGenglQCyp+H3gU?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5069.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0fb8b1a7-606e-4ad6-450b-08dadc9d9a9a X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2022 00:04:28.7655 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eApyUSj6no/mTMqY4eJWr4DZkdfa3C+M6ugOgLiHYDBn1/y38hN9zlevL/9+OGUpXan81g947nz5Ug0OmYQ/ng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5879 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On December 12, 2022 5:04 PM, Boeuf, Sebastien wrote: > Subject: [PATCH 1/3] OvmfPkg/PlatformInitLib: Differentiate TDX case for > Cloud Hypervisor >=20 > From: Sebastien Boeuf >=20 > Rely on the CcProbe() function to identify when running on TDX. This allo= ws > the firmware to follow a different codepath for Cloud Hypervisor, which > means it doesn't rely on PVH to find out about memory below 4GiB. > instead it falls back onto the CMOS to retrieve that information. >=20 > Signed-off-by: Sebastien Boeuf > --- > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/OvmfPkg/Library/PlatformInitLib/MemDetect.c > b/OvmfPkg/Library/PlatformInitLib/MemDetect.c > index b8feae4309..afee4b1e72 100644 > --- a/OvmfPkg/Library/PlatformInitLib/MemDetect.c > +++ b/OvmfPkg/Library/PlatformInitLib/MemDetect.c > @@ -26,6 +26,7 @@ Module Name: > // #include #include > +#include #include > #include #include > @@ -312,7 +313,8 @@ > PlatformGetSystemMemorySizeBelow4gb ( > UINT8 Cmos0x34; UINT8 Cmos0x35; - if (PlatformInfoHob- > >HostBridgeDevId =3D=3D CLOUDHV_DEVICE_ID) {+ if (PlatformInfoHob- > >HostBridgeDevId =3D=3D CLOUDHV_DEVICE_ID &&+ CcProbe () !=3D > CcGuestTypeIntelTdx) { // Get the information from PVH memmap > return (UINT32)GetHighestSystemMemoryAddressFromPvhMemmap > (TRUE); }-- > 2.34.1 Reviewed-by: Min Xu