From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.1551.1627454701220397323 for ; Tue, 27 Jul 2021 23:45:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=KXWTPSNK; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: digant.h.solanki@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10058"; a="199772909" X-IronPort-AV: E=Sophos;i="5.84,275,1620716400"; d="scan'208";a="199772909" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2021 23:44:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,275,1620716400"; d="scan'208";a="417661276" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 27 Jul 2021 23:44:54 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 27 Jul 2021 23:44:54 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 27 Jul 2021 23:44:53 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 27 Jul 2021 23:44:53 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 27 Jul 2021 23:44:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FJnMhQp9JznhkFk2m+2YXgs2hxDW1AP4EzEqqm+Pvq7K4istTJdKo2pAmTD1haUaPBdDuR/Xp+snc8lpR7YMcuPbPBB4FeagSSUN1wYmcN3zR2V2zqXSN11H2saCLkl4mlm+6PADTL2Q+BEXpQKrZXnLNlNev3sHc80ORZM17nYRGe/JB6/sjyKfEz+P0OER7FzvHyhGYNrgTP4bA+fm2K4QfS81TlUlD5piWbVYkVy9VwPEt84naC5eonVvNVA6sh63fQoZzjaRFAc592ZW6BS2CeRFU/qUVW1iWMeluGb4UOXhEoJuolNG+mauQ4GsdLhK+HTk5tI4toxKQ4pZYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nHUHoPCG+8SlzcHy1Z5SOZGix05Nrc3N+qIPOSIqtmw=; b=Wic10HiJW9b8hTEi6YP1iayJAaPuub6iqiKyYIgQo3jHcN1CbSQwVi/mNQZrOoDXcl3wKrMaWlhRGhp+Gny6Y2RqttXvwyIMSfInbFkDEZCvq70T+Qq2ju/6vsnL3ZC13j2+uSvqXsw8e+mR6HpZLqOyHVHoiE4MA7AMR3jbQFx5/VmOkYfqE1y+4eDgh0yYqxuhXpih+1ymt4hDy7TeXbQZ+W9pKPUMIdK69npLg6sfmrj9bpslLFQndKQTfVLBgjQPFPqruL1djGRNSB2iZjms9x+efHAYQOTV0LoiZBfI/W/gMVQi8Rkn3d3tUKFfEFfMKBflcKEamso6SLeGMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nHUHoPCG+8SlzcHy1Z5SOZGix05Nrc3N+qIPOSIqtmw=; b=KXWTPSNK7pLWasCAvO2BZpmgZ2rmH0uMBIAvik+Vv6CnFwYBEzWt7eHF9qIvDbqr206AK9NwEV6+/iZTp4+2FpzqBUGrHQLn+G0Ngg+HTtkDRuyT1tTSn1vAFoZuiVUrVisZVP7CJw7oJaMvTYOB9nz06kfSV505mPqVzfR2MwE= Received: from SJ0PR11MB5584.namprd11.prod.outlook.com (2603:10b6:a03:3ba::8) by SJ0PR11MB5677.namprd11.prod.outlook.com (2603:10b6:a03:37e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18; Wed, 28 Jul 2021 06:44:52 +0000 Received: from SJ0PR11MB5584.namprd11.prod.outlook.com ([fe80::b0b3:f1f5:9cbc:c268]) by SJ0PR11MB5584.namprd11.prod.outlook.com ([fe80::b0b3:f1f5:9cbc:c268%9]) with mapi id 15.20.4373.018; Wed, 28 Jul 2021 06:44:52 +0000 From: "Digant H Solanki" To: "devel@edk2.groups.io" CC: "Ni, Ray" , "Chaganty, Rangasai V" , "S, Ashraf Ali" Subject: Re: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0 Thread-Topic: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0 Thread-Index: AQHXfu9XJdmfbKht/Uin8vvjIz/WpatQlsywgAdjXKA= Date: Wed, 28 Jul 2021 06:44:52 +0000 Message-ID: References: <20210722114654.18447-1-digant.h.solanki@intel.com> In-Reply-To: Accept-Language: en-IN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7d1c23f2-05fd-4c09-0c15-08d95193343f x-ms-traffictypediagnostic: SJ0PR11MB5677: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:820; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dHtsLDpDiQJymr6OmD5akvlnHz+4vTDc1Z6QMjVMK8OdmTI58gyBHNRTdlfLXkIWzI8EWGTGwtR8QGXPcqYLNPWg3M4kgNjgQPBXwRjE9RkUZKBc5TY9jNU0CpT9NGa+UNRpEruf95jq70gMWSJ4D1HyjYNX/7MR3zNjNEtI5p0Qv+gn9krIHxtp45qfxVp7HHDJ1VH0QqE0+rui0vxJ4GcEpTYlOAMCeFKaCtZhldoRzmowMZq0id92mztmitdW5w9Q0PmdbEk1vFCH2FIR0BoQJZ179o4L5gSxR37ppUWFrl4/6ctw6H/I5OT7nADHuzM4wTegx2PmhAnFYBmjfUjUUpEYtmkwAjc5ZN1a1wod++W7f3Nw1LHo4I+/sVrz37sqElbstAfVLOlB58w7a0Komcc1paRiaeeoi/JDxpeBIDFw8J0xmZzNna8V4o0hkLU4wUn6lY7/0qKm2HVnrGqNTK6+n3WCIC8+bEN/rEGULIJVoR27U02kE4JowkCt5yoZEp61gvxh1sQ2uDH9VKSw3e0QkJMSvJWqcixvkyqKeWeCr8PeqiaqObMgId5FdbMx2EpgUJEveYwD1TIYiiBLR8PFSY9BV2MnYY/E4QHZ+H6AT875nHQApn9kbC//WoZzYRCdz3SwVu/RXfcNb0t9pCoFwNb9m8R5r2W/gSgbNYMgmhcnsICAEx+EQO9QUxAM2b24rrBjXTYe3K2gyEQ6k97y5BW5NrkfLiUyAUOo4AcQOXb65oUKPOkcMCFXnVZwoqbsY/2zYnghbXrn6eI6QMSvnTA1stWMahWL5Xs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5584.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(396003)(136003)(39860400002)(366004)(346002)(376002)(83380400001)(7696005)(107886003)(5660300002)(55016002)(38100700002)(9686003)(122000001)(186003)(76116006)(316002)(6506007)(26005)(66476007)(52536014)(66556008)(66446008)(64756008)(66946007)(53546011)(33656002)(2906002)(71200400001)(86362001)(478600001)(6916009)(8676002)(38070700005)(54906003)(8936002)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2rGBhn1PphvrXhTF+y7BzJDI8t/+g15FMdesSL/dc61NoAPKTWc2JVj9S1CY?= =?us-ascii?Q?eS+hF+q3J5tBjABjeSiTYFwyfRXxpcZf9S5lmzA+EL6VpLwcxWLjlZVAgKBI?= =?us-ascii?Q?4uVFmNGL/RQLkpThmOIo4UhzPiEDDHuOd/RGvb9194Blo1/EsRvfxnTjoEvS?= =?us-ascii?Q?cyszzHe+NKubxp/Mbf+8vdis89A8FcYMp4bxD/3IALkhHA3LCTsEQ+qAJePK?= =?us-ascii?Q?a0mW/tPn1i0veTeh9TMVXebeNfSswtC/payLOBSas9ts7RvIrVXimLdQTK3Y?= =?us-ascii?Q?Uzrb305zOZXURYEE33E5cZ/ERj7n1NafrLwQweoPRaB3MLtkgsbv7tAvOcN+?= =?us-ascii?Q?9oSBLNkG7mjKIHUVea0vpayuG4xPoz9wcVtq6jK9PniCSuVFhrvPo64DZINI?= =?us-ascii?Q?EJG7lE73tSiBoFrnNnI4GNSKYPySU8aKcPrZBUZ6j2clWWtJgqOGIilQUXXR?= =?us-ascii?Q?BoaWGs9nwm5xsr/+Cifcbj5K9wwq+Uud80ZR8xAqcp0k88FlukNfxEb2mjas?= =?us-ascii?Q?MMSphOiHddmIraH6STpXuf/KJAjgyH8Idcqz4ti9wmvcMlA9nsDkCfYwOakm?= =?us-ascii?Q?f+oGLQEK2TXCwCM9hStsz6sexGtTCoy8/JB+i3+I9XcCTpStatGV/L2FvskB?= =?us-ascii?Q?1wAEa1nchqoCnGH1E30/5SCJGnjb3ZsLEyhb74Wdu4zboIintI+3rSSE/ZMy?= =?us-ascii?Q?+6/AJit9Th5sxuvhAvSuEUZDUsxEqSOvm7AYrYb8EtE4MMICjPjZ7uYvs2BP?= =?us-ascii?Q?47YB19DIBF9hq4LxqLy5y6J7+pHFkwHL6Q4zgnQMk3ceENQYzSFV/rGZ1iKz?= =?us-ascii?Q?jL/aMoYwSdY7JSEfjNw4r7xgAw7Kt8w9H8E6k7w1zeA+WIbydRMkRMQqHEzL?= =?us-ascii?Q?fcAxInXETzE5lC8MIoLoSB+5ymcg7OroUfX54A6qu3ldj5hQOGsDhP55l3TZ?= =?us-ascii?Q?Ygm8sgiz8Ly729iY2lZUqCLxKU+5MIxTvahg65Qp+Bz11INGmV58LEvIllvq?= =?us-ascii?Q?CmR/2q/nDMVTo9veCeVH6eI7LbBwzkfvvOqrkwpy+voNIcUSdMM6nGMw4cwa?= =?us-ascii?Q?Ty5Ha+hW3oTgpVLXs8RkmUhKk+4o+6reJ36T82N+yZ6dV+8/bhqdmTjYfE+J?= =?us-ascii?Q?ZXM5py2v/6EbwMsWRSwh3SrqqX4fx/9ADM/g37dOU0oDeXMmqZN03Qx+dNEw?= =?us-ascii?Q?flUiAJNvoAPU4dOjMmV1SxF+Fb3Nb3obwFSyCr+bePc4BEeGWgMB+LSR+Gem?= =?us-ascii?Q?sxLmDbQN8kC3osSY1ub7ewim5c0nxrwe1EC9lcTKYSzntBhPTgbGUXu3OOrR?= =?us-ascii?Q?RLcUZggCEdNAsU8lyzxFUfm9?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5584.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d1c23f2-05fd-4c09-0c15-08d95193343f X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2021 06:44:52.6682 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Un1roOWN+X3GeEzBTQIWLZmLTsGM8t6ZEMCPHZii/oXB/Gd+laRAMYqaDkqXS3csXXJZ70jFHsqYzr8YT3EmPULduW3hl9MzgABnapiyXRc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5677 Return-Path: digant.h.solanki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please help review this patch to make it official soon. Thanks..!! -----Original Message----- From: Solanki, Digant H=20 Sent: Friday, July 23, 2021 7:25 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; S, Ashraf Ali Subject: RE: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IG= D OpRegion v3.0 Gentle reminder to review this patch pls. Thanks..!! -----Original Message----- From: Solanki, Digant H Sent: Thursday, July 22, 2021 5:17 PM To: devel@edk2.groups.io Cc: Solanki, Digant H ; Ni, Ray ; Chaganty, Rangasai V ; S, Ashraf Ali Subject: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD Op= Region v3.0 REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3426 - There are many OpRegion fields obsoleted in MBOX1 - MBOX2 is re-purposed for Backlight related fields for dual LFP. - Backlight related fields moved to MBOX2 from MBOX3 and some fields are ob= soleted in MBOX3. Signed-off-by: Digant H Solanki Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Ashraf Ali S --- Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion30.h | 1= 01 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++ 1 file changed, 101 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRe= gion30.h b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegi= on30.h new file mode 100644 index 0000000000..c9948ab55f --- /dev/null +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion +++ 30.h @@ -0,0 +1,101 @@ +/** @file + IGD OpRegion definition from Intel Integrated Graphics Device=20 +OpRegion + Specification based on version 3.0. + + Copyright (c) 2021, Intel Corporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ +#ifndef _IGD_OPREGION_3_0_H_ +#define _IGD_OPREGION_3_0_H_ + +#include "IgdOpRegion.h" + +#define IGD_OPREGION_HEADER_MBOX2_VER_3_0 BIT5 + +#pragma pack(1) +/// +/// OpRegion Mailbox 1 - Public ACPI Methods /// Offset 0x100, Size +0x100 /// typedef struct { + UINT32 DRDY; ///< Offset 0x100 Driver Readiness + UINT32 CSTS; ///< Offset 0x104 Status + UINT32 CEVT; ///< Offset 0x108 Current Event + UINT8 RM11[0x14]; ///< Offset 0x10C Reserved Must be Zero + UINT32 DIDL[8]; ///< Offset 0x120 Supported Display Devices ID Lis= t + UINT32 CPDL[8]; ///< Offset 0x140 obsolete + UINT32 CADL[8]; ///< Offset 0x160 obsolete + UINT32 NADL[8]; ///< Offset 0x180 obsolete + UINT32 ASLP; ///< Offset 0x1A0 ASL Sleep Time Out + UINT32 TIDX; ///< Offset 0x1A4 obsolete + UINT32 CHPD; ///< Offset 0x1A8 obsolete + UINT32 CLID; ///< Offset 0x1AC Current Lid State Indicator + UINT32 CDCK; ///< Offset 0x1B0 Current Docking State Indicator + UINT32 SXSW; ///< Offset 0x1B4 obsolete + UINT32 EVTS; ///< Offset 0x1B8 obsolete + UINT32 CNOT; ///< Offset 0x1BC obsolete + UINT32 NRDY; ///< Offset 0x1C0 Driver Status + UINT8 DID2[0x1C]; ///< Offset 0x1C4 Extended Supported Devices ID Li= st (DOD) + UINT8 CPD2[0x1C]; ///< Offset 0x1E0 obsolete + UINT8 RM12[4]; ///< Offset 0x1FC - 0x1FF Reserved Must be zero +} IGD_OPREGION_MBOX1_VER_3_0; + +/// +/// OpRegion Mailbox 2 - Backlight communication /// Offset 0x200, Size +0x100 /// typedef struct { + UINT32 BCL1; ///< Offset 0x200 Backlight Brightness for LFP1 + UINT32 BCL2; ///< Offset 0x204 Backlight Brightness for LFP2 + UINT32 CBL1; ///< Offset 0x208 Current User Brightness Level fo= r LFP1 + UINT32 CBL2; ///< Offset 0x20C Current User Brightness Level fo= r LFP2 + UINT32 BCM1[0x1E]; ///< Offset 0x210 Backlight Brightness Levels Duty= Cycle Mapping Table for LFP1 + UINT32 BCM2[0x1E]; ///< Offset 0x288 Backlight Brightness Levels Duty= Cycle Mapping Table for LFP2 +} IGD_OPREGION_MBOX2_VER_3_0; + +/// +/// OpRegion Mailbox 3 - BIOS/Driver Notification - ASLE Support ///=20 +Offset 0x300, Size 0x100 /// typedef struct { + UINT32 ARDY; ///< Offset 0x300 obsolete + UINT32 ASLC; ///< Offset 0x304 obsolete + UINT32 TCHE; ///< Offset 0x308 obsolete + UINT32 ALSI; ///< Offset 0x30C obsolete + UINT32 BCLP; ///< Offset 0x310 obsoleted in ver 3.0, moved to M= ailbox 2. + UINT32 PFIT; ///< Offset 0x314 obsolete + UINT32 CBLV; ///< Offset 0x318 obsoleted in ver 3.0, moved to M= ailbox 2. + UINT16 BCLM[0x14]; ///< Offset 0x31C obsoleted in ver 3.0, moved to M= ailbox 2. + UINT32 CPFM; ///< Offset 0x344 obsolete + UINT32 EPFM; ///< Offset 0x348 obsolete + UINT8 PLUT[0x4A]; ///< Offset 0x34C obsolete + UINT32 PFMB; ///< Offset 0x396 obsolete + UINT32 CCDV; ///< Offset 0x39A obsolete + UINT32 PCFT; ///< Offset 0x39E obsolete + UINT32 SROT; ///< Offset 0x3A2 obsolete + UINT32 IUER; ///< Offset 0x3A6 obsolete + UINT64 FDSS; ///< Offset 0x3AA obsolete + UINT32 FDSP; ///< Offset 0x3B2 obsolete + UINT32 STAT; ///< Offset 0x3B6 obsolete + UINT64 RVDA; ///< Offset 0x3BA Physical address of Raw VBT data= . Added from Spec Version 0.90 to support VBT greater than 6KB. + UINT32 RVDS; ///< Offset 0x3C2 Size of Raw VBT data. Added from= Spec Version 0.90 to support VBT greater than 6KB. + UINT8 VRSR; ///< Offset 0x3C6 Video RAM Self Refresh + UINT64 DLHP; ///< Offset 0x3C7 Dual LFP Hinge Alignment Paramet= ers + UINT8 RM32[0x31]; ///< Offset 0x3CF - 0x3FF Reserved Must be zero. +} IGD_OPREGION_MBOX3_VER_3_0; + +/// +/// IGD OpRegion Structure +/// +typedef struct { + IGD_OPREGION_HEADER Header; ///< OpRegion header (Offset 0x0, Si= ze 0x100) + IGD_OPREGION_MBOX1_VER_3_0 MBox1; ///< Mailbox 1: Public ACPI=20 +Methods (Offset 0x100, Size 0x100) + IGD_OPREGION_MBOX2_VER_3_0 MBox2; ///< Mailbox 2: Backlight=20 +communication (Offset 0x200, Size 0x100) + IGD_OPREGION_MBOX3_VER_3_0 MBox3; ///< Mailbox 3: BIOS to Driver Notif= ication (Offset 0x300, Size 0x100) + IGD_OPREGION_MBOX4 MBox4; ///< Mailbox 4: Video BIOS Table (VB= T) (Offset 0x400, Size 0x1800) + IGD_OPREGION_MBOX5 MBox5; ///< Mailbox 5: BIOS to Driver Notif= ication Extension (Offset 0x1C00, Size 0x400) +} IGD_OPREGION_STRUCTURE_VER_3_0; +#pragma pack() + +#endif -- 2.30.2.windows.1