From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.8534.1627048524700490154 for ; Fri, 23 Jul 2021 06:55:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=nqLsc5Wo; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: digant.h.solanki@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10053"; a="211939474" X-IronPort-AV: E=Sophos;i="5.84,264,1620716400"; d="scan'208";a="211939474" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2021 06:55:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,264,1620716400"; d="scan'208";a="660206527" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga006.fm.intel.com with ESMTP; 23 Jul 2021 06:55:22 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 23 Jul 2021 06:55:22 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 23 Jul 2021 06:55:22 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 23 Jul 2021 06:55:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PwSQu3x8N1T4aEyAtQFLgZJQ3dRiNMylK+Wg0uyi2n+K1Bv+LRclZcnQKauOAfKgR1B7pXarmAIm719x8+ypfpY2Bw5uh9HD/3crOzMQdrLW/pP5rgg2i07o4OuSwI4NqGNuvkYroh6XYEMNnVsAoBG+GYXVf/mB0fg+ijM29NrhJcHBPvUW9GkOizf3rhtaThbC480o3//sqk5K4SLWHgeVeeicoOePIhqVYfCq0SABdQzjok1l0KvYwK3i7j2CMgQRSju6OrG8g4RCFpwz7AiUH+zcIZOMrBRyN45mwSJkwwyCO+9Vf4ZR/FbtE19UDaD1c6eCzeBwVuRAa7y2PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z+l4exSct6FEcsDLxEzlMvqXkrMvMpwAaPg3kJSyp0k=; b=L7+UV6yPhp0BXMPW+3+MBSMZwHiz+CebjzDNSfqOB/kybN8bgoyImyGzapUWueu4U7XQkEQWx+DQ0M/NqBsv3OFYnCmdMuS9IUpf0uq+RAhYR91QXPZyWLbrQ0OFqsycGpmws+pkZdZWYecOFOkLolDMTZhSnvxWq1Bz0NThgVLjVFzz94tejzYHp+Wqwyve6ImNMprsGsiLnehkH8fXGK5Co3OkM1m8I+26cqqgAB+IwJTackyr/OfshGl4X3gWegMFtDo1Z1L2pdfrxMeW9Y6o66MJareg/AtIiyBjwF93FW7hqD9buQeDwTg/waUd3ulPXjMifwGx7xG2G+kR5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z+l4exSct6FEcsDLxEzlMvqXkrMvMpwAaPg3kJSyp0k=; b=nqLsc5WorlrVct+pVTWurOPgMx78//nwiHDD7DMX/Pv/QlXSMhlT2gQa//2KcUg4HiBMnwBA6AUbcw+Z9mdq4F237f3gzjANRT9yFuZ91DDgyooWlYFlLwuQV8taxZqIhBX1VnPqjhPqycZWTm0q5EhfZa8o6gKakqQknreszlk= Received: from SJ0PR11MB5584.namprd11.prod.outlook.com (2603:10b6:a03:3ba::8) by SJ0PR11MB5582.namprd11.prod.outlook.com (2603:10b6:a03:3aa::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24; Fri, 23 Jul 2021 13:55:20 +0000 Received: from SJ0PR11MB5584.namprd11.prod.outlook.com ([fe80::b0b3:f1f5:9cbc:c268]) by SJ0PR11MB5584.namprd11.prod.outlook.com ([fe80::b0b3:f1f5:9cbc:c268%9]) with mapi id 15.20.4352.029; Fri, 23 Jul 2021 13:55:20 +0000 From: "Digant H Solanki" To: "devel@edk2.groups.io" CC: "Ni, Ray" , "Chaganty, Rangasai V" , "S, Ashraf Ali" Subject: Re: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0 Thread-Topic: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0 Thread-Index: AQHXfu9XJdmfbKht/Uin8vvjIz/WpatQlsyw Date: Fri, 23 Jul 2021 13:55:20 +0000 Message-ID: References: <20210722114654.18447-1-digant.h.solanki@intel.com> In-Reply-To: <20210722114654.18447-1-digant.h.solanki@intel.com> Accept-Language: en-IN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a9720124-6fbc-4759-f664-08d94de182c6 x-ms-traffictypediagnostic: SJ0PR11MB5582: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:506; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dqvscbyVzDNX1FMDe0YgMp9+XOk4Qjyb1VanNorgUSwov5J5B8l3WP65RQXI7N7dQmgzbTCcYubgrvfOqcyaSywYTLvAqMi5mR1kHlw5vJGNu5myQtEJCZ9X0dN86NqFZMY65ktPjHcDy7YGne98/XTuvJeiyi+B99o56/8f2B6NsMblxWyIoedTe+iRTeizkG75L/GwWo5FXqzK86ikGQ788pZ3ZmAhAEF7VApX6Cowo/aqpHd0GykAwh+10jfb9W4f2esbMK7Qokpod9FFfhPv3HPiseEctvHYs+c+KXF01Csii9gQG6YgUbRYy/ZiFZKN9qnX+Ne76ljbfc/5Uv1JqDgB5r6WfW4hFx44brur2BDmz46f/1QXaDaRdzOJDAOS56QnLFvsloeODGVn/6C2AWavtn81stIpiCcyYo4njaOPYMQtjKnPcdtLZQqZDO+h6w/JHIpUbef3+FSLfuXzwxvBOB+y+65RotDNraAY9Cdl5MzXV5pPgT0OLgt07LZv752mIntAuZ99iXBsj9Djkf2m9pdgBCIXAX6OrR230Cky9kE5+DMTcr9K8V1YpBwIakT8HkMTQDBIV7tGXmcEEmplBdkZD8v4hgjCI8Q7V9c814D9CpWp4ZSbg9qZDnIPuznOGxi2Bin/ijcXPuPP/EhmwPFT9q4Z0KZJrxupCRhexDisP2bj7rLvutp/gX2Wd3Dj0V4P9dmPYvrEPYlgI+updTpoZfnVoXmA+hFdnFapnFqTuibTA+kcUUheWuyNF06v/EqjSY8yW3Yc5FrFcLfNnF+6j/6KMRRRb0Q= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5584.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(4326008)(2906002)(5660300002)(6506007)(8936002)(7696005)(86362001)(8676002)(26005)(186003)(53546011)(83380400001)(71200400001)(54906003)(6916009)(107886003)(316002)(64756008)(508600001)(66446008)(52536014)(66556008)(76116006)(9686003)(38100700002)(55016002)(33656002)(66946007)(66476007)(122000001)(38070700004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yHVaxJKAZP9PDq8pDXyxnrp0cuDr4XYYsD8bdcctSRmDS/Q3WW4YjGtpEGZz?= =?us-ascii?Q?ZiRfEPcyItX0h4z3gBoAbU/FOtb8H8j63V1UZGVq7w+O7NHxRYrlAORlYOIE?= =?us-ascii?Q?u5ILHFAzjpgl4qUh8i3usYduzMsfb3KNqlMAkAD0IacQ1ZZo/aMKDlqj50d6?= =?us-ascii?Q?4Lt9msKS9ZtmLUWsJT7vIRLv8VaYouOl/lMVDWtFx+8ChXprIr5ZDk7zRhxj?= =?us-ascii?Q?lewtBdvczqFFTERoeRuqQNPOKzIG9ZupOa1PrqjOyPqtrEbghF/uuDvUFTP4?= =?us-ascii?Q?wzRG8d2gd6aDWis3eNgjXGIFYS8/fFRAE9WoXhtAoqOsbd7GSlfxawZOWvMC?= =?us-ascii?Q?Tn6VkMl8rIpVNJcOSmV/VYqaIJvMLrh80+6zrueiLX786vdgtGSmtNHZrwDZ?= =?us-ascii?Q?sjFniP7Gl94KGreWVWQ0NMkxx41yj7+Cop8J+UH95s9qXh+Wg1MzcGl1lQ6u?= =?us-ascii?Q?MJJs2XZbuhxLJu/RKRlgyG/g0mal2WBp0E5CB6R+MMR2g9AlkgmWWPosSGiR?= =?us-ascii?Q?3vWsa48QLKNHYLRLLUHAgwHsQ471gtsOnLiXu1m6nFPVMOiMamZmGhjwoByx?= =?us-ascii?Q?ihn2OD785WAwKpb2mjiiKNIuFeHMMGEX/IeZIQ/6WiVJ1xK1sydgon2i/tei?= =?us-ascii?Q?r4z0n79GOPMLurQVn0/Ot+MgV2Pgnp/zmCqbGfEqMDBYmxjNudIUwLLRiN8i?= =?us-ascii?Q?sP/LrY4lvJGf21pqezlMBbrHnCnQ2vcfiXRURDzuDoVzzc+TjcmvmZlyiJLu?= =?us-ascii?Q?rW3Z2W1IzdTgF2ZsZsLxw7p3dWGnfUX2Z1F6pNSP7QZnskGHrXY95rQxiIkG?= =?us-ascii?Q?Ezo36v7pp65081mvGUxPBz5QGN43yZqIrTr3LQVaw8H4N83oVuriL63BxgMy?= =?us-ascii?Q?LQyKKWst5k2hdnc7yHnOw5+y1oYQNuKUkDdQrZnzeZpKgNoll7kAHDkIaF2L?= =?us-ascii?Q?agJ+r1KXs4Boi9ztCV0/Ab49prHNt+1dhq4xVNnOBK5tI7Oq2yMWdE8xlMFG?= =?us-ascii?Q?Mn95vZx15STybFgMYM+KG87PAYg9o2XTElks782EbfrPn5adfuGBAlst/nFL?= =?us-ascii?Q?WlNIhsMi8toAxjLNL8Zn6v0ZrgI1LUuM+0dtXwMV+sUjgbKw1pIMivLPHznB?= =?us-ascii?Q?N/Brvh+cybQeMgTVCbm8N9fd0KCjaPksZn9UfJxDLCG6WfDGVKOo0zi1QLEM?= =?us-ascii?Q?RZw77tVgCJ4jJKdRrLoizBo5M2F0ohiHS++b8TVrDX0P/Oi5V655+tSKKh8E?= =?us-ascii?Q?l1box21e/PgqOj/SibuWTSguwJ5doV8C9hS3uoqUIKFJPevcNvBGBS8Kqdne?= =?us-ascii?Q?n9n2Xki3kjtPkmrsOAgn2qpR?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5584.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9720124-6fbc-4759-f664-08d94de182c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2021 13:55:20.5180 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dPr4+EPp+oBCbyalz2cZPQHFvABLzfBtDsoMcmej9E7t7vYmO4c3K/tvPEwa8Tn/y59Ilg5SkR7C2ux7H+u0pfWih0bX2o7VutNBv2y1auI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5582 Return-Path: digant.h.solanki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Gentle reminder to review this patch pls. Thanks..!! -----Original Message----- From: Solanki, Digant H =20 Sent: Thursday, July 22, 2021 5:17 PM To: devel@edk2.groups.io Cc: Solanki, Digant H ; Ni, Ray ; Chaganty, Rangasai V ; S, Ashraf Ali Subject: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD Op= Region v3.0 REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3426 - There are many OpRegion fields obsoleted in MBOX1 - MBOX2 is re-purposed for Backlight related fields for dual LFP. - Backlight related fields moved to MBOX2 from MBOX3 and some fields are ob= soleted in MBOX3. Signed-off-by: Digant H Solanki Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Ashraf Ali S --- Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion30.h | 1= 01 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++ 1 file changed, 101 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRe= gion30.h b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegi= on30.h new file mode 100644 index 0000000000..c9948ab55f --- /dev/null +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion +++ 30.h @@ -0,0 +1,101 @@ +/** @file + IGD OpRegion definition from Intel Integrated Graphics Device=20 +OpRegion + Specification based on version 3.0. + + Copyright (c) 2021, Intel Corporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ +#ifndef _IGD_OPREGION_3_0_H_ +#define _IGD_OPREGION_3_0_H_ + +#include "IgdOpRegion.h" + +#define IGD_OPREGION_HEADER_MBOX2_VER_3_0 BIT5 + +#pragma pack(1) +/// +/// OpRegion Mailbox 1 - Public ACPI Methods /// Offset 0x100, Size=20 +0x100 /// typedef struct { + UINT32 DRDY; ///< Offset 0x100 Driver Readiness + UINT32 CSTS; ///< Offset 0x104 Status + UINT32 CEVT; ///< Offset 0x108 Current Event + UINT8 RM11[0x14]; ///< Offset 0x10C Reserved Must be Zero + UINT32 DIDL[8]; ///< Offset 0x120 Supported Display Devices ID Lis= t + UINT32 CPDL[8]; ///< Offset 0x140 obsolete + UINT32 CADL[8]; ///< Offset 0x160 obsolete + UINT32 NADL[8]; ///< Offset 0x180 obsolete + UINT32 ASLP; ///< Offset 0x1A0 ASL Sleep Time Out + UINT32 TIDX; ///< Offset 0x1A4 obsolete + UINT32 CHPD; ///< Offset 0x1A8 obsolete + UINT32 CLID; ///< Offset 0x1AC Current Lid State Indicator + UINT32 CDCK; ///< Offset 0x1B0 Current Docking State Indicator + UINT32 SXSW; ///< Offset 0x1B4 obsolete + UINT32 EVTS; ///< Offset 0x1B8 obsolete + UINT32 CNOT; ///< Offset 0x1BC obsolete + UINT32 NRDY; ///< Offset 0x1C0 Driver Status + UINT8 DID2[0x1C]; ///< Offset 0x1C4 Extended Supported Devices ID Li= st (DOD) + UINT8 CPD2[0x1C]; ///< Offset 0x1E0 obsolete + UINT8 RM12[4]; ///< Offset 0x1FC - 0x1FF Reserved Must be zero +} IGD_OPREGION_MBOX1_VER_3_0; + +/// +/// OpRegion Mailbox 2 - Backlight communication /// Offset 0x200, Size=20 +0x100 /// typedef struct { + UINT32 BCL1; ///< Offset 0x200 Backlight Brightness for LFP1 + UINT32 BCL2; ///< Offset 0x204 Backlight Brightness for LFP2 + UINT32 CBL1; ///< Offset 0x208 Current User Brightness Level fo= r LFP1 + UINT32 CBL2; ///< Offset 0x20C Current User Brightness Level fo= r LFP2 + UINT32 BCM1[0x1E]; ///< Offset 0x210 Backlight Brightness Levels Duty= Cycle Mapping Table for LFP1 + UINT32 BCM2[0x1E]; ///< Offset 0x288 Backlight Brightness Levels Duty= Cycle Mapping Table for LFP2 +} IGD_OPREGION_MBOX2_VER_3_0; + +/// +/// OpRegion Mailbox 3 - BIOS/Driver Notification - ASLE Support ///=20 +Offset 0x300, Size 0x100 /// typedef struct { + UINT32 ARDY; ///< Offset 0x300 obsolete + UINT32 ASLC; ///< Offset 0x304 obsolete + UINT32 TCHE; ///< Offset 0x308 obsolete + UINT32 ALSI; ///< Offset 0x30C obsolete + UINT32 BCLP; ///< Offset 0x310 obsoleted in ver 3.0, moved to M= ailbox 2. + UINT32 PFIT; ///< Offset 0x314 obsolete + UINT32 CBLV; ///< Offset 0x318 obsoleted in ver 3.0, moved to M= ailbox 2. + UINT16 BCLM[0x14]; ///< Offset 0x31C obsoleted in ver 3.0, moved to M= ailbox 2. + UINT32 CPFM; ///< Offset 0x344 obsolete + UINT32 EPFM; ///< Offset 0x348 obsolete + UINT8 PLUT[0x4A]; ///< Offset 0x34C obsolete + UINT32 PFMB; ///< Offset 0x396 obsolete + UINT32 CCDV; ///< Offset 0x39A obsolete + UINT32 PCFT; ///< Offset 0x39E obsolete + UINT32 SROT; ///< Offset 0x3A2 obsolete + UINT32 IUER; ///< Offset 0x3A6 obsolete + UINT64 FDSS; ///< Offset 0x3AA obsolete + UINT32 FDSP; ///< Offset 0x3B2 obsolete + UINT32 STAT; ///< Offset 0x3B6 obsolete + UINT64 RVDA; ///< Offset 0x3BA Physical address of Raw VBT data= . Added from Spec Version 0.90 to support VBT greater than 6KB. + UINT32 RVDS; ///< Offset 0x3C2 Size of Raw VBT data. Added from= Spec Version 0.90 to support VBT greater than 6KB. + UINT8 VRSR; ///< Offset 0x3C6 Video RAM Self Refresh + UINT64 DLHP; ///< Offset 0x3C7 Dual LFP Hinge Alignment Paramet= ers + UINT8 RM32[0x31]; ///< Offset 0x3CF - 0x3FF Reserved Must be zero. +} IGD_OPREGION_MBOX3_VER_3_0; + +/// +/// IGD OpRegion Structure +/// +typedef struct { + IGD_OPREGION_HEADER Header; ///< OpRegion header (Offset 0x0, Si= ze 0x100) + IGD_OPREGION_MBOX1_VER_3_0 MBox1; ///< Mailbox 1: Public ACPI=20 +Methods (Offset 0x100, Size 0x100) + IGD_OPREGION_MBOX2_VER_3_0 MBox2; ///< Mailbox 2: Backlight=20 +communication (Offset 0x200, Size 0x100) + IGD_OPREGION_MBOX3_VER_3_0 MBox3; ///< Mailbox 3: BIOS to Driver Notif= ication (Offset 0x300, Size 0x100) + IGD_OPREGION_MBOX4 MBox4; ///< Mailbox 4: Video BIOS Table (VB= T) (Offset 0x400, Size 0x1800) + IGD_OPREGION_MBOX5 MBox5; ///< Mailbox 5: BIOS to Driver Notif= ication Extension (Offset 0x1C00, Size 0x400) +} IGD_OPREGION_STRUCTURE_VER_3_0; +#pragma pack() + +#endif -- 2.30.2.windows.1