From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BDCDC7803D1 for ; Thu, 29 Feb 2024 03:31:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=4GR88igaisfrQ9NHqXwwN+H2dsTaOvAC5tWx4Pbdtu8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709177504; v=1; b=LmSGYsObXbH0PjOfJc2HyH00x6XLACJ/farp88/G+Aa0vDlgzz8nQKymDViackblh0ufWGi5 5JMBXdLMOOyaWReZFEjxZhhvTU+m+GAnd3bUdsHrtA5tsV/idD98IBVclxXaf6MVU3BFpIuCjxF attCToagwqxZch/SMYZXBa9Y= X-Received: by 127.0.0.2 with SMTP id vjhVYY7687511xEEDnVHXhcQ; Wed, 28 Feb 2024 19:31:44 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by mx.groups.io with SMTP id smtpd.web10.16481.1709177503780306584 for ; Wed, 28 Feb 2024 19:31:44 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="3741676" X-IronPort-AV: E=Sophos;i="6.06,192,1705392000"; d="scan'208";a="3741676" X-Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 19:31:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,192,1705392000"; d="scan'208";a="7886379" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Feb 2024 19:31:42 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 28 Feb 2024 19:31:42 -0800 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 28 Feb 2024 19:31:42 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 28 Feb 2024 19:31:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bX7Ttte4LReypvWC7dz/kXcw1WUTDwMO6A90A4UKSiaUXDmPPECD1Ht00JvNTJG6mP/pjMzhdReVktsaoegSQ1SzAZDhwa3qa9aA/5/sBYXEeQOARr3fMNTrRQl7EDhlZWxRRd0SMEXgoRRjEmHcmV9IkrxjsrjucHaXqd4siS6kqbGQXHPcp8rLL/z7USl0FEUc8vXzo7vTUAKEFcSwqgAvywaHFVFsRyk0TTGhclw1v5mDENpnMu+VdJRCJEyMzo+7ryWNLQ6wOL5jCQC2WeRXZg6mLs1deIFgYE6SA0q+h8pzv6OajQhhtQbaVvz3gGsXkNnnZSVmQktwNsoz1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bno0M4qO497RXvTirjD2WtbbezkcSk0YrV3WBA+jS/A=; b=WcSJ5OOWk3fUFesqmDNVuZfmA+yikFvDwUdqunBaReWtIWvF39Q4CRIn01cvAD+QgzRhYb61gqyXFjhydjRf648kUKeDqjHkTbMrfJceSvutxeLtAuTKQScDbqY0h8qBUFM5QbK5MyshcfrFfSheUAs5Ng/OmwDo9ngLLYpavHqpy/r+PWjWVIKVxh4nal286jgeoqHkmjYaTDBvHQDtcWKKJVGHFevE7i2NcRg4x1tx+BEVX0c9Q4Jxs5LXoyekHIihIOMq/rRIguponaVuE0/oFhOmsyHxqJgvmnVAV+veQy51I07gjKHNnRpJzjLKqEq07y3taUF6A0/Ss8hXmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from SJ0PR11MB5816.namprd11.prod.outlook.com (2603:10b6:a03:427::18) by LV8PR11MB8724.namprd11.prod.outlook.com (2603:10b6:408:1fd::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.25; Thu, 29 Feb 2024 03:31:39 +0000 X-Received: from SJ0PR11MB5816.namprd11.prod.outlook.com ([fe80::42de:e807:5a4a:a4a9]) by SJ0PR11MB5816.namprd11.prod.outlook.com ([fe80::42de:e807:5a4a:a4a9%3]) with mapi id 15.20.7339.022; Thu, 29 Feb 2024 03:31:39 +0000 From: "Tan, Ming" To: "Yao, Jiewen" , "devel@edk2.groups.io" , "Pingle, Sneha S" , "POLUDOV, FELIX" , "Bi, Dandan" CC: "Xu, Min M" Subject: Re: [edk2-devel] [PATCH v2] SecurityPkg/SecureBootConfigDxe: Update UI according to UEFI spec Thread-Topic: [PATCH v2] SecurityPkg/SecureBootConfigDxe: Update UI according to UEFI spec Thread-Index: AQHaaSj6ZO+NRhaLkkS3S1Tg1Th80bEfQoYggAFjg0A= Date: Thu, 29 Feb 2024 03:31:39 +0000 Message-ID: References: <20240227025909.10259-1-ming.tan@intel.com> In-Reply-To: Accept-Language: en-US X-Mentions: sneha.s.pingle@intel.com,felixp@ami.com,dandan.bi@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR11MB5816:EE_|LV8PR11MB8724:EE_ x-ms-office365-filtering-correlation-id: 1779ad2c-8990-4124-c6db-08dc38d6f0f6 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: SoeoCr3aotFZu3UuYwAJw+9y7Z9IXu/F89bIWrQRzm5j3XM90DnCOQZiBrCLqJGf+deF/UbS10p+4pVp/QdoCDEYXtG+p+OfXoK1QCVawtDiJXukHmg3VuNZf6ZQ9adEfcF2txmBwLqagT8BAAMpDMAcT3EqJ2XL14KKt1bHrMV4rwVbvW9AnG3Leka0Y53lpqovtE8rOKWMH9K2Fye9d8X8Id3sEuKzzQVziNQS2LnT1/Y5DYtWoWDZubI0lW+F/wc9cmSoY+Tu8+VdY+IPcym2oAgwfLYivbTb9VpfWiFKdqtX2fmXWVC6DUfEg4JkywKU0HUL8DMEIbGcQDaKPyAAoI5alAPw+qD01K7UFy4n0TLxQwKNGejgSNcbx2dCSopmvRrU6IszB0Xb/PVwcUCZwkpnIhDrF7CEcJ7b6zUuKTazaSjTnr/aoPz06/8JYDASgJajRhRE5MpF2GAoOuJuBsv/BraOyAe7lVv+Q4crj/BZsp1zuAUPIQue2xV5Dhg8ixaaov0+jqHJ3dSKfj34+HX/+zbOWIMO6ZZN6WgTqsqWzjmq2xfCseQk/Mlgaz6DU6Ua6ziRea8n/PYo47lVHVHRt8WI4zMhmF1zZN3UbBBu72o+nKr8P8aoFoYuWsE+rp4pvcqX1dB0UZjhUCjOgmTXQqSpr4k4S9pe1QU= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7gaR9BWkRDczPzVI8Ig1JXA5tQE8aq6RTiJtBYl51PSHsETukCk+KoxIqR86?= =?us-ascii?Q?dmbiKq3eZOYt76vl62Tgxwhec0iaDjmE0H+Zhi0kKAG0Tr8e4+pR3u6gaER+?= =?us-ascii?Q?QdmNko4Wgrr9TpPbMDMg3Ils2h6W/WnEeKl+0gGHY0h5jgUIMWUnbDBow5Tn?= =?us-ascii?Q?cB4SHcZmF5Mwc3rNnXi4YSSVFglQMg6PbP2qinH35cabSFmuOn10Jr0QbvB7?= =?us-ascii?Q?V6SU/smFLqLDk7MRdMqY3YthSd24hbtVCz2FsgWN2QdRc+nbbUfQwm4ORIBi?= =?us-ascii?Q?jTk/p3YAYkNK+EhYNGcZSCv7y40j1Z0bzMXOhF1TQdAJr6w2GJwg6+duFlWO?= =?us-ascii?Q?BAGj6oGFxFxpQp8x7a4lNwZ9UH46u4PtgqrAF1qFCwDHp0dIdN5sDw/mpnGn?= =?us-ascii?Q?eSd1SZJygABSRhSV6PYRnz0RGI1qzf8Uw5rXM9/h4uZVDFagt7dn9pPPvJrx?= =?us-ascii?Q?MIhZVSLz3r/2bDmsy6tVWFWiS54FThbBM7FX9crWZNlrLgbtXIh4C2yIARgI?= =?us-ascii?Q?N2GThfyMi+CslVK2dm2wBbWzp9XvdwVBkd6Q7cAWW6/xWHsH4J1cq2UJjvfa?= =?us-ascii?Q?fyVG+YjTSM9HOhgTSsLGYC9bdIHlHoIsngSzh2MfJxzZyCLCifVulIMVtovp?= =?us-ascii?Q?CQIBBN0fEiizvSWmLGvJ2+ydDnoVu2wg/Ua+4p2rFg4XK3yHGDb0SXL8clu6?= =?us-ascii?Q?MAmTh4rXN6dSFeTK0kOjkUJo5rgyMSJf8jZBnnBhHNjlt4MaQUGt9y5SdFzk?= =?us-ascii?Q?pG3Ly046OMehfZOICR4H4UP93aM77dHXBRK3BWRNTqxCWn/wRccSB8hxVk/K?= =?us-ascii?Q?6zGI46w9r9A+X69oVGAEw62LJI0VzQfSvk16t+y+sod713PS5iyBRgxchbKo?= =?us-ascii?Q?33C1y8DVCKnD6cbEBFIbDKeH6X1PY3BxKt0YfvRTLxxyFynV2gEmXrUKkPap?= =?us-ascii?Q?8jHqSa9RLDUabjgxSj2oQr2qkCHKg9ECzX4d0qZkpcfpMa80oYenVhvhtTmp?= =?us-ascii?Q?bfl2ij9QDoSqqd1AZ/j1D3HMw4D7XgYaBo+tpM1wz4KjXw6JUlrZcDKKMOhJ?= =?us-ascii?Q?LsYbFFaP3grDKVic4U0Cc6uNtmcYAg5pnyoUeZtmdzbck7vrEUERSm/wlZLY?= =?us-ascii?Q?FZxl28aYQooQ0N5RtYKmIgtCmH9rO8R6Zwa+ipLMQabEyj3ohXZeHPmSiJbL?= =?us-ascii?Q?wO85P8B/jEaDRwvlAPNQDoURrt4AWxULDkZFITIJUUi9Ojoh4dQo+7DOpaz+?= =?us-ascii?Q?eswaUWO7kAkjtZ24rO7d8Ifra9G6eEK9bKD2N+Q8zW21sXInPkx/JKbYLQV4?= =?us-ascii?Q?0Ds+FRQNybFZCJZNl/2xSksMoi55AMp0kcprq0k2bIiDpE4gi0U/WiluI67E?= =?us-ascii?Q?wj4D9qoyhghHuhK4dlyLutTicbsG168CJzoN+d+2epeg88JQ60lf6cL2uB1t?= =?us-ascii?Q?E2IK1NDIPl0mBGyez9uZyAGLTzUiSgVCvmjYYg8KjwPklyuMpeC1pmnHXTo6?= =?us-ascii?Q?muTCpJHqAYPmDmg3EF3VpaeBfoWqnlY6jRjzB6L1M3EpKb0zfRWhT9C0P7I1?= =?us-ascii?Q?4Ge9ZeN5jT67Xh4cNp8RRjHfCJwH/oMo0lueJO0Q?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5816.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1779ad2c-8990-4124-c6db-08dc38d6f0f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Feb 2024 03:31:39.6334 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cG3AdKA7bRPmlL9g7v0ftxzd+vtlfOvypAzttXd7C84+XArVJqqevXnP+YqmkCjyWNy20vNIyuIhWBCaA/M8bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8724 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ming.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: USv9pY7bCvejqDQbfAfhaMOOx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=LmSGYsOb; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Jiewen: This patch is only for UEFI spec mantis 1908 change in SecureBootConfigDx= e. This spec change just ask some drivers do some modification, it does not = ask the HII core to be modified, so this spec change will not cause compati= bility issue. For this patch, it only touch the UI setting, did not touch the modificat= ion of pk, kek, db, dbx, dbt EFI variable. I did the following unit test in EmulatorPkg WinHost.exe and Intel AlderL= ake RVP: 1. In PK Options, Enroll PK, check the "Attempt Secure Boot" is not gray = and enabled. 2. In RVP, Set "Attempt Secure Boot" to enable and disable, check it does= work, and device can boot to Windows. 3. In PK Options, delete PK, check the "Attempt Secure Boot" is gray and = disabled. 4. In DBX Options, Enroll Signature, check it does work, and the "Delete = All Signature List" is not gray. 5. In DBX Options, Delete all signature, check it does work, and the "Del= ete All Signature List" is gray after all signatures are deleted. 6. In KEK Options, Enroll KEK, check it does work. 7. In KEK Options, Delete KEK, check it does work. 8. In DB Options, Enroll Signature, check it does work. 9. In DB Options, Delete Signature, check it does work. 10. In DBT Options, Enroll Signature, check it does work. 11. In DBT Options, Delete Signature, check it does work. @Pingle, Sneha S Would you like to help to verify the secure boot functio= ns again in another Intel RVP? @Felix Polyudov Would you like to help to verify this patch with AMI brow= ser? Since AMI submitted this UEFI spec change, if verify pass, would you l= ike to add a "Reviewed-by' for this patch? @Bi, Dandan is HII expert and the reviewer of edk2 HII and UI modules, wo= uld you like to review this patch? And add a "Reviewed-by" for this patch? And I create a PR for this patch: https://github.com/tianocore/edk2/pull/= 5411, all CI checking are passed. Thank you. Tan Ming. -----Original Message----- From: Yao, Jiewen =20 Sent: Wednesday, February 28, 2024 1:56 PM To: Tan, Ming ; devel@edk2.groups.io Cc: Xu, Min M Subject: RE: [PATCH v2] SecurityPkg/SecureBootConfigDxe: Update UI accordin= g to UEFI spec Thanks for the update. First, would you please clarify which test you have done for this patch set= . Have you tested all previous function to ensure it still works? Second, would you please clarify if there is any compatibility issue to fol= low the new UEFI 2.10? For example, what if the core HII is still UEFI 2.9? would that still work? Third, because I am not HII expert, I would like to have HII expert to comm= ent the HII/Browser related change. Thank you Yao, Jiewen > -----Original Message----- > From: Tan, Ming > Sent: Tuesday, February 27, 2024 10:59 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Yao, Jiewen > Subject: [PATCH v2] SecurityPkg/SecureBootConfigDxe: Update UI=20 > according to UEFI spec >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4713 >=20 > In UEFI_Spec_2_10_Aug29.pdf page 1694 section 35.5.4 for > EFI_BROWSER_ACTION_FORM_OPEN: > NOTE: EFI_FORM_BROWSER2_PROTOCOL.BrowserCallback() cannot be used with=20 > this browser action because question values have not been retrieved yet. >=20 > So should not call HiiGetBrowserData() and HiiSetBrowserData() in=20 > FORM_OPEN call back function. >=20 > Now call SecureBootExtractConfigFromVariable() to save the change to=20 > EFI variable, then HII use EFI variable to control the UI. >=20 > Cc: Min Xu > Cc: Jiewen Yao > Signed-off-by: Ming Tan > --- > V2: Change code style to pass uncrustify check. >=20 > .../SecureBootConfigImpl.c | 37 ++++++++++--------- > 1 file changed, 20 insertions(+), 17 deletions(-) >=20 > diff --git > a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConf > igIm > pl.c > b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConf > igIm > pl.c > index 2c11129526..e2e61d1e07 100644 > --- > a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConf > igIm > pl.c > +++ > b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConf > igIm > pl.c > @@ -3366,6 +3366,8 @@ SecureBootExtractConfigFromVariable ( > ConfigData->FileEnrollType =3D UNKNOWN_FILE_TYPE; >=20 > } >=20 >=20 >=20 > + ConfigData->ListCount =3D Private->ListCount; >=20 > + >=20 > // >=20 > // If it is Physical Presence User, set the PhysicalPresent to true. >=20 > // >=20 > @@ -4541,12 +4543,13 @@ SecureBootCallback ( > EFI_HII_POPUP_PROTOCOL *HiiPopup; >=20 > EFI_HII_POPUP_SELECTION UserSelection; >=20 >=20 >=20 > - Status =3D EFI_SUCCESS; >=20 > - SecureBootEnable =3D NULL; >=20 > - SecureBootMode =3D NULL; >=20 > - SetupMode =3D NULL; >=20 > - File =3D NULL; >=20 > - EnrollKeyErrorCode =3D None_Error; >=20 > + Status =3D EFI_SUCCESS; >=20 > + SecureBootEnable =3D NULL; >=20 > + SecureBootMode =3D NULL; >=20 > + SetupMode =3D NULL; >=20 > + File =3D NULL; >=20 > + EnrollKeyErrorCode =3D None_Error; >=20 > + GetBrowserDataResult =3D FALSE; >=20 >=20 >=20 > if ((This =3D=3D NULL) || (Value =3D=3D NULL) || (ActionRequest =3D=3D= NULL)) { >=20 > return EFI_INVALID_PARAMETER; >=20 > @@ -4565,15 +4568,12 @@ SecureBootCallback ( > return EFI_OUT_OF_RESOURCES; >=20 > } >=20 >=20 >=20 > - GetBrowserDataResult =3D HiiGetBrowserData=20 > (&gSecureBootConfigFormSetGuid, mSecureBootStorageName, BufferSize, > (UINT8 *)IfrNvData); >=20 > - >=20 > if (Action =3D=3D EFI_BROWSER_ACTION_FORM_OPEN) { >=20 > if (QuestionId =3D=3D KEY_SECURE_BOOT_MODE) { >=20 > // >=20 > // Update secure boot strings when opening this form >=20 > // >=20 > - Status =3D UpdateSecureBootString (Private); >=20 > - SecureBootExtractConfigFromVariable (Private, IfrNvData); >=20 > + Status =3D UpdateSecureBootString (Private); >=20 > mIsEnterSecureBootForm =3D TRUE; >=20 > } else { >=20 > // >=20 > @@ -4587,23 +4587,22 @@ SecureBootCallback ( > (QuestionId =3D=3D KEY_SECURE_BOOT_DBT_OPTION)) >=20 > { >=20 > CloseEnrolledFile (Private->FileContext); >=20 > - } else if (QuestionId =3D=3D KEY_SECURE_BOOT_DELETE_ALL_LIST) { >=20 > - // >=20 > - // Update ListCount field in varstore >=20 > - // Button "Delete All Signature List" is >=20 > - // enable when ListCount is greater than 0. >=20 > - // >=20 > - IfrNvData->ListCount =3D Private->ListCount; >=20 > } >=20 > } >=20 >=20 >=20 > goto EXIT; >=20 > } >=20 >=20 >=20 > + GetBrowserDataResult =3D HiiGetBrowserData > (&gSecureBootConfigFormSetGuid, mSecureBootStorageName, BufferSize, > (UINT8 *)IfrNvData); >=20 > + >=20 > if (Action =3D=3D EFI_BROWSER_ACTION_RETRIEVE) { >=20 > Status =3D EFI_UNSUPPORTED; >=20 > if (QuestionId =3D=3D KEY_SECURE_BOOT_MODE) { >=20 > if (mIsEnterSecureBootForm) { >=20 > + if (GetBrowserDataResult) { >=20 > + SecureBootExtractConfigFromVariable (Private, IfrNvData); >=20 > + } >=20 > + >=20 > Value->u8 =3D SECURE_BOOT_MODE_STANDARD; >=20 > Status =3D EFI_SUCCESS; >=20 > } >=20 > @@ -5179,6 +5178,10 @@ SecureBootCallback ( > } >=20 > } >=20 >=20 >=20 > + if (GetBrowserDataResult) { >=20 > + SecureBootExtractConfigFromVariable (Private, IfrNvData); >=20 > + } >=20 > + >=20 > EXIT: >=20 >=20 >=20 > if (!EFI_ERROR (Status) && GetBrowserDataResult) { >=20 > -- > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116132): https://edk2.groups.io/g/devel/message/116132 Mute This Topic: https://groups.io/mt/104596915/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-