From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web08.23495.1647425735032603977 for ; Wed, 16 Mar 2022 03:15:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=I5HK9SU2; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=007458713f=nickle.wang@hpe.com) Received: from pps.filterd (m0150241.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 22GA4aVd028268; Wed, 16 Mar 2022 10:15:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pps0720; bh=v+Vz4nYZw1RlXktma6PlowfZ4GwWnuDsmSbSAv5aw8s=; b=I5HK9SU2J3nZSQtJFJHs7s0Qvq3bMy62Ft5rNyGkxQBmb0N6ElXEek6Xkm85s9VbO0k8 GlXUVYI9z/cvC4JQmiKd9hjvFTzz1wPxKciVMcI8CLqYBhImAfXCRpc0P96QYQhsyMIb SNhF6In+cFdxOu6nXyrLkESKqdA+rD15JJ79icMktrXpm8KjStHHuRmXDNyFgIztZLJc rrBzFltDGJ6HN3lVV1wTKHh4p8uDpScjLQmidNNuIvLI0wmMCYKVlFCFcmtnkyJ4LxHA 8Uo25psMSU2SFQvjeFkP+4EX8oAT0XLEx4RFvYwqhsgkzdbbghU5890h0VDoPscw+7xN wQ== Received: from g4t3425.houston.hpe.com (g4t3425.houston.hpe.com [15.241.140.78]) by mx0a-002e3701.pphosted.com (PPS) with ESMTPS id 3eudtd03j0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Mar 2022 10:15:33 +0000 Received: from G4W9119.americas.hpqcorp.net (g4w9119.houston.hp.com [16.210.20.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3425.houston.hpe.com (Postfix) with ESMTPS id 17BADA9; Wed, 16 Mar 2022 10:15:32 +0000 (UTC) Received: from G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) by G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Wed, 16 Mar 2022 10:15:31 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (15.241.52.13) by G9W8455.americas.hpqcorp.net (16.216.161.94) with Microsoft SMTP Server (TLS) id 15.0.1497.23 via Frontend Transport; Wed, 16 Mar 2022 10:15:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mYVX6PhJpHdS3mEx6oCEuuJarwVY4UyrORckS8wFnvWlgR6QLDdbWNxRp0qZH11EjD+L0RZ9/rD/OBYH4laL49B9EvDVPlBtucaUJ/dE6aaW1maamW+E0SpWa3y83GTHBe3nrjDtzqhsN79i4c8QTxKtJtYwfDV2negccbN22MVgPQ0rJyhaLSmKWGZpiMZ24vCT2tJgY3b8gj1TO93k6Bu86qDo/00oeYSY0DW1mKlQW38lyA6EVEqQEnclm9L3ufvnv8/O5BmjwN09tcsw1llVnndjT92iKBLdO3+92cFFz+GWc6DPh1eVww+oy/VBnshhQ/lup3ibXZAiYDqGSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v+Vz4nYZw1RlXktma6PlowfZ4GwWnuDsmSbSAv5aw8s=; b=iHwHt6eejPZJ+1XssjEsj8gMVaFdYYqNQ5+/jYZeDLhpiYufFi1XZ3huwxva4DGYoosoy88GBt+s7n+fRJTPqSPZEMtNrwy7WbqzkyYMTVwehD+RyTCHaKUBjpR0FJH877q5nDs0UjoFk5/YJ23U3O3+emO7xcPMNYTmFuNCgJnjimK3VHbve1RfPnx0AQomx1w0tannLWzBwP+PD+631EthcTx/NTbwZTlYPhqStByqy0/P7fG9B96e970hUehAfUMGAmjL4dkwmuXMUKfzZUipee7lN8KZWp2keKMge6nHUjYdwkV2pr/uZHsP10nCuo9JRKbCoxxKdbhPorLqAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from SJ0PR84MB1433.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:a03:381::17) by DM4PR84MB1423.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:8:4a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.15; Wed, 16 Mar 2022 10:15:30 +0000 Received: from SJ0PR84MB1433.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d5f:cd44:d334:3fdf]) by SJ0PR84MB1433.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d5f:cd44:d334:3fdf%3]) with mapi id 15.20.5081.015; Wed, 16 Mar 2022 10:15:30 +0000 From: "Nickle Wang" To: "Chang, Abner (HPS SW/FW Technologist)" , "devel@edk2.groups.io" CC: Andrew Fish , Ray Ni , "Wang, Nickle (Server BIOS)" Subject: Re: [PATCH] EmulatorPkg/RedfishPlatformCredentialLib: Don't stop Redfish service Thread-Topic: [PATCH] EmulatorPkg/RedfishPlatformCredentialLib: Don't stop Redfish service Thread-Index: AQHYORVi80GIyzlhrkCmtZWJ/mulcKzBysp/ Date: Wed, 16 Mar 2022 10:15:29 +0000 Message-ID: References: <20220316080433.3092-1-abner.chang@hpe.com> In-Reply-To: <20220316080433.3092-1-abner.chang@hpe.com> Accept-Language: en-US, zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: 04133356-2aa6-48a8-3186-d0502c92cb66 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bc350816-9aa7-4479-7407-08da0735e613 x-ms-traffictypediagnostic: DM4PR84MB1423:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OiTeOywurPonF1EYeE7kxisdMoYxKHxRy/Q7cGxwcn0AkTifXqjKpZPkzbucfj22Vf89HRW1UfCSTBBMGc3FECkCEBtIWcJ7tNWq6/D3D2konp382czENj5UNOK0GkgwxDGaKCQZ37UUVygPGe0DmBUDnMNDaHfZ6T4amklDpUe62DGmAUwfbjfzhr7AL4iQfldplO7yU5M4dhAroFe9uc4rtufPozFcWMhmNXaGOuaekU6hVvJivnjNdDhyGt43QOjw87tqFV8kfVIfbQGTY0JtC/oQ9nxYWyMbdWMwVNeVxS574R7G+qpVQULzHKH/SXs56n2x1uJOEGYyq+VzJGJxrjcor+TYJV1fxGGO2lKRtGpnPP2KY1xXG6pbP5Q6rMaqaFncB0e7WtYIoGs7YmJkeFYJq8Ke9IRq+Y8BbDU4NfD117P+u8Elf4Pa8vK/Mjh0KBmEJPdfhbz7lCQMBcUkljcMViKOTBNUKAMPKO2ybpFuclNRNZX4hnu/iaRzDQEPxwswBdr/M1ZCheZ8rVmR+xoQRj/R6WBn7D+2Od0orWUyNH6Lw4cm1VZ72Ekj7A/kz6RFgKIsf7O3sU1D33Oy4txIgv0X6Ru9Xn+hQ9CfnWQNVIdpkgd2AnmuaIl6ndFpcDoTJ45aE3sfT7zoETC17XWnbZ5cbYNA+V97MDEMFxHeNWZEZFR1zrnLw+1dEm5klRQEJ2AQb6nzmdiJE2H2I7azXweUHd3JczOhootY3fujjPXFPnJg0KEn9itG1Yv9ijTQrvH8M6lnxmDSsBlSUOsVgAhazZzDksK2qNk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR84MB1433.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(366004)(52536014)(5660300002)(2906002)(8936002)(4326008)(76116006)(8676002)(91956017)(64756008)(66446008)(66476007)(66556008)(66946007)(38100700002)(86362001)(33656002)(82960400001)(122000001)(55016003)(38070700005)(166002)(19627405001)(9686003)(508600001)(186003)(83380400001)(966005)(316002)(71200400001)(54906003)(53546011)(110136005)(7696005)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?0YqybJ3+/sXVKOWZHPusM6MiEoof+0OJacRIhCfA6snLNDKXGonDEyNu1c?= =?iso-8859-1?Q?vfI0+OI3tPal2K7R+5qXh+KyE4wLx3o7corH7o6vfqkIzC5zG1E3+Gv52y?= =?iso-8859-1?Q?PBHSA/gd6MS4yMzJ8m+PBMsB+g0nMC2WDngkgPW3Mw38A7lhEXva6AOpd+?= =?iso-8859-1?Q?6K6uBDJSoQcU5+rlHGFnE6qe2k+bTBPHubu0MQHzlx/kumK38ao1ubvXjC?= =?iso-8859-1?Q?W3OqDxSv6ofwLQ8FEd/UH30cY0bMjCE3WgSnV6yDso7XPSQ4ZmLVqy3DnN?= =?iso-8859-1?Q?Pax/s+CIfKsvNkaxaEk/y4ezysSYaenrU/rI2h6xV66IPddiYrabWdfryx?= =?iso-8859-1?Q?1vzyK4oxr/crWxqgYiNjnsRcsBgmi/vU8trY9mZFasZvy3ATBIbA9xAWns?= =?iso-8859-1?Q?/fv9KTcsvt6z1y4DMLFWotZW3JNPDOBvmRATwILHD7j05g/k+Ipq7ig4Su?= =?iso-8859-1?Q?0ACTVHOMDnMcjhO716vs38CPfJ5DGlklx8iWIUbfQ6vqtnqswQduQjFUmU?= =?iso-8859-1?Q?lksg4Bi2O++Ws27RHOz1uU1k4Yrtfarg+5Kkf5sd3KDdXiQzo118eUWkN5?= =?iso-8859-1?Q?v3m9WU8Rq/tmXobckhiMrWZKxUa/2a2pY/QvP1flN79S/nwGLYvMa4W9pO?= =?iso-8859-1?Q?CG5urUtq+zj+SkRrx4kIp19TQuxv8G3+ziATLiFw7b6z08xV5WMktTZMOH?= =?iso-8859-1?Q?p/XMmWHHfXQNPEXtqjTIpuDMMSX5Nn3IRWKV8JXVYQssbFKVVLK3ZTechx?= =?iso-8859-1?Q?MhRikMSOqFN1OqdGVf032T/bj0eyZC8v5BdyRG7JS4f2fqtrBsY9+4JOSp?= =?iso-8859-1?Q?8Tt8izmV1/eRObbd3s2DsWLSf/pff4eqJe7H9gL3Def7Zrej6H4evki0X7?= =?iso-8859-1?Q?2DfdCJbqbgUD7GJ51xeBvLnierExHVklDwgWCt61yqhSszc9ay5nH7Uqlu?= =?iso-8859-1?Q?+IVjQNwhWxJ+Pkdtqe3EM98JUUwI1RlhWXfOblGS3G46lugNEt83B+2AbK?= =?iso-8859-1?Q?/o8EhLgbikPoRY/gaTMhuynyZKQQCTXbnxKqTCNQPaQzLyLAzmzQV7qAbn?= =?iso-8859-1?Q?8fhyndngGQizIsyJfMi6VjjjC70dY86fFYG3HDhQP9Aj0vKmYTHR+Z7/VP?= =?iso-8859-1?Q?xejhbMbRbYIXMU5ViymNvAUQSHL7T7E44yUMyPxY+S62med/7QyMkvBhw/?= =?iso-8859-1?Q?ysiRtvtfeOK4824a5j23It8ksxs7ElVSWXFAXo6490ffJr78dCyWL9m5Yp?= =?iso-8859-1?Q?YalsKBg+eVbLBn+ygJ+tNWfc1LGGcz3c2LlEealKz/CNtLkMjR1bRhjKAW?= =?iso-8859-1?Q?CwKLgYdWGZzM1ogxKV5Ni8X4wIMKm6nd7s4+R5XHny23grxkbMbmiShzsU?= =?iso-8859-1?Q?53klr7BEftTB0q4aeuvaLdFSN6omRC9wYaEgn5SXaDQ0Qvwz8mw6iRqBKY?= =?iso-8859-1?Q?y55DwZOCXhi/SDL/Dw0YW8nkqXBl0TCP7IhnyFmi8JRmYsX0zeBLyRVmOW?= =?iso-8859-1?Q?R7HHgfcVFPFl+sI8A8Gh1SHSUwoufU2BiKL7vexdPiIrbVF4kWUDXPbgB0?= =?iso-8859-1?Q?RnlTzDC2SvGj+1Ui7d74ytOVWQ5q?= X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR84MB1433.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: bc350816-9aa7-4479-7407-08da0735e613 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2022 10:15:29.9479 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Wn0xZLsMKCJd3UCJAcDdwDGLitTq8BkRXAZxRQWPf36al93ezx5bzGVYwg2RkhBU8RQjW1TL7LxJxIaeaiMDcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR84MB1423 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: 39QRE2r-OVW6xs4Y0R5vyNSQGqCN0kym X-Proofpoint-GUID: 39QRE2r-OVW6xs4Y0R5vyNSQGqCN0kym X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-16_03,2022-03-15_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 impostorscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203160063 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SJ0PR84MB14339D076E63A37341ED6358FF119SJ0PR84MB1433NAMP_" --_000_SJ0PR84MB14339D076E63A37341ED6358FF119SJ0PR84MB1433NAMP_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Some typos. Platform Redfish credential library shouldn't stop the service at either En= dOfDXE or ExitBootService notification. RedfishConfigureHandler UEFI driver= is responsible to stop the Redfish service when EndOfDXE or ExitBootServic= e event is triggered. Reviewed-by: Nickle Wang Thanks, Nickle ________________________________ From: Chang, Abner (HPS SW/FW Technologist) Sent: Wednesday, March 16, 2022 16:04 To: devel@edk2.groups.io Cc: Wang, Nickle (Server BIOS) ; Andrew Fish ; Ray Ni Subject: [PATCH] EmulatorPkg/RedfishPlatformCredentialLib: Don't stop Redfi= sh service https://bugzilla.tianocore.org/show_bug.cgi?id=3D3859 Platform Redfish credential library shouldn't top the service at either End= OfDXE or ExitBootService notification. RedfishConfiguHandler UEFI driver is= responsible to stop the Redfish service when EndOfDXE or ExitBootService e= vent is triggered. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Andrew Fish Cc: Ray Ni --- .../RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatfo= rmCredentialLib.c b/EmulatorPkg/Library/RedfishPlatformCredentialLib/Redfis= hPlatformCredentialLib.c index a0233a984d..614eaebb0d 100644 --- a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.c +++ b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.c @@ -223,7 +223,6 @@ LibCredentialExitBootServicesNotify ( IN EDKII_REDFISH_CREDENTIAL_PROTOCOL *This ) { - LibStopRedfishService (This, ServiceStopTypeExitBootService); } /** @@ -237,5 +236,4 @@ LibCredentialEndOfDxeNotify ( IN EDKII_REDFISH_CREDENTIAL_PROTOCOL *This ) { - LibStopRedfishService (This, ServiceStopTypeSecureBootDisabled); } -- 2.17.1 --_000_SJ0PR84MB14339D076E63A37341ED6358FF119SJ0PR84MB1433NAMP_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

Some typos. 

Platform Redfish credential library shouldn't stop the service at either EndOfDXE or ExitBootService notification. RedfishCon= figureHandler UEFI driver is responsible to stop the Redfish service when EndOfDXE or Ex= itBootService event is triggered.

Reviewed-by: Nickle Wang &l= t;nickle.wang@hpe.com>

Thanks,
Nickle

From: Chang, Abner (HPS S= W/FW Technologist) <abner.chang@hpe.com>
Sent: Wednesday, March 16, 2022 16:04
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Wang, Nickle (Server BIOS) <nickle.wang@hpe.com>; Andrew F= ish <afish@apple.com>; Ray Ni <ray.ni@intel.com>
Subject: [PATCH] EmulatorPkg/RedfishPlatformCredentialLib: Don't sto= p Redfish service
 
https://bugzilla.tianocore.org/show_bug.cgi?id=3D3859
Platform Redfish credential library shouldn't top the service at either End= OfDXE or ExitBootService notification. RedfishConfiguHandler UEFI driver is= responsible to stop the Redfish service when EndOfDXE or ExitBootService e= vent is triggered.

Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
---
 .../RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c | 2 -= -
 1 file changed, 2 deletions(-)

diff --git a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatfo= rmCredentialLib.c b/EmulatorPkg/Library/RedfishPlatformCredentialLib/Redfis= hPlatformCredentialLib.c
index a0233a984d..614eaebb0d 100644
--- a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.c
+++ b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.c
@@ -223,7 +223,6 @@ LibCredentialExitBootServicesNotify (
   IN  EDKII_REDFISH_CREDENTIAL_PROTOCOL  *This
   )
 {
-  LibStopRedfishService (This, ServiceStopTypeExitBootService);
 }
 
 /**
@@ -237,5 +236,4 @@ LibCredentialEndOfDxeNotify (
   IN  EDKII_REDFISH_CREDENTIAL_PROTOCOL  *This
   )
 {
-  LibStopRedfishService (This, ServiceStopTypeSecureBootDisabled);  }
--
2.17.1

--_000_SJ0PR84MB14339D076E63A37341ED6358FF119SJ0PR84MB1433NAMP_--