From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4724E780091 for ; Thu, 16 May 2024 02:43:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=sjgUNd/PkuZZUxecE0W6M2ig3Y5Dbad8ysyhI2qrFbM=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715827381; v=1; b=ldoyvNrCO35K42cKfmgXMsmu8O/D3GtnXAoYdYPd36LmI8OYKjD6Yu4A3udxby47OZz1DE1j MUFV+9ijdMEfwVEWWH5C0RFhDl5M7wokQ78ogr547RzKwxBvnLaAz/whru8MkztgxCFPsS9eLYn 03E+lXeiQ0hlR42JXwX7UVkFmykh8d5xi4W54iVZRtr6i66nwQUhrPmOohU5u0V/Jnh1OX5I9UE d8uKCx7uczhaWw81O+dw/J0jDamwbP1eFNj+xPX37RklDlNmNVCSw6R1axSy7jphffjZ7/v5Msl qo1AaVPcOGCRwyY65GpBxLEuV046xtpn0IHtW4Co2hSKQ== X-Received: by 127.0.0.2 with SMTP id PyhQYY7687511xfwUxajwUJL; Wed, 15 May 2024 19:43:01 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mx.groups.io with SMTP id smtpd.web10.3989.1715827380781842302 for ; Wed, 15 May 2024 19:43:00 -0700 X-CSE-ConnectionGUID: scOdxdv+QVaOk/tfrqHmaA== X-CSE-MsgGUID: n6CdkLqfTJanXzqnQK3Acw== X-IronPort-AV: E=McAfee;i="6600,9927,11074"; a="11780670" X-IronPort-AV: E=Sophos;i="6.08,163,1712646000"; d="scan'208";a="11780670" X-Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 19:43:00 -0700 X-CSE-ConnectionGUID: QYx6hDxYSbO+laA8YALKqQ== X-CSE-MsgGUID: h1EcsSqJQLexVindk0mvOw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,163,1712646000"; d="scan'208";a="36054726" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 May 2024 19:43:01 -0700 X-Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 15 May 2024 19:42:59 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 15 May 2024 19:42:59 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 15 May 2024 19:42:59 -0700 X-Received: from SJ1PR11MB6227.namprd11.prod.outlook.com (2603:10b6:a03:45a::10) by MN6PR11MB8171.namprd11.prod.outlook.com (2603:10b6:208:471::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Thu, 16 May 2024 02:42:57 +0000 X-Received: from SJ1PR11MB6227.namprd11.prod.outlook.com ([fe80::c4da:83f1:f7be:e307]) by SJ1PR11MB6227.namprd11.prod.outlook.com ([fe80::c4da:83f1:f7be:e307%4]) with mapi id 15.20.7587.028; Thu, 16 May 2024 02:42:57 +0000 From: "Li, Yi" To: "Shang, Qingyu" , "devel@edk2.groups.io" CC: "Yao, Jiewen" Subject: Re: [edk2-devel] [PATCH V2 1/1] CryptoPkg: Remove outdated code related to deprecated SHA-1 Thread-Topic: [PATCH V2 1/1] CryptoPkg: Remove outdated code related to deprecated SHA-1 Thread-Index: AQHapzitPOILWJ7aZUOCMkbhvK4rNbGZJr0g Date: Thu, 16 May 2024 02:42:56 +0000 Message-ID: References: <47e37f157185c295cf70647d9f9926af38671dfb.1715826321.git.qingyu.shang@intel.com> In-Reply-To: <47e37f157185c295cf70647d9f9926af38671dfb.1715826321.git.qingyu.shang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ1PR11MB6227:EE_|MN6PR11MB8171:EE_ x-ms-office365-filtering-correlation-id: bccc9eec-fc36-415f-fe45-08dc7551e4ca x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?TPpNpms29I1uTgkAKytRpZwXERPcpl1i5aQj+RAIwQgHJwVxiuSiEXV94YBu?= =?us-ascii?Q?b4shkqI6iqZZ/LZ58Om6yMsR3/lFIefpdL557v50XHWShuJY91o0uYMZ0OYr?= =?us-ascii?Q?P4sLPexo1lOsVVYHQgTQZ4FpgkZMA7yNusf/ePasMErR48G0nayAsQIko0iQ?= =?us-ascii?Q?2jlBqRrBa41P6vNr5jBR+5scFngzNbU87ZQX7KIOc0XGCNcPrk2EiQKJRPzc?= =?us-ascii?Q?CF26Wqzm5qugNQkB81djUiefLIzrx9t3VZ+1Jahb7sZgi3c99EnCGJG4VFvz?= =?us-ascii?Q?LHKnTh9pka/9ScGWmAGzZHdDyGGlT9248cFAUbesMdj/vdri6uVdtmZBb/rb?= =?us-ascii?Q?nCf+PpsNGcDgQzWnjS0XEbT3m51LRb0RI3Ekba2bTG9LABMavMYRE/F+hrKO?= =?us-ascii?Q?o7HqsHugULGaO/YoQmdvdQNa3NPU6fQcMqeAKf4YysPMEWb62JiOJJtrnSf2?= =?us-ascii?Q?aPZ7kaiUH21/r26+t1tZehTpKSx38Shifyvd/u02AIhzxb1PWwy5Pi6L8G81?= =?us-ascii?Q?CFGh+ewxew5Uz1JjlzlkK+s1rlFiI83oHmNWdqC6U5UH+0tAzRFaKdTNpxfX?= =?us-ascii?Q?REnnKBx48GC8zFsu+UU4s5Veq/fv0obqNbT2cnkHlo0KdpiQR/xIQzM8BVxo?= =?us-ascii?Q?TZAk3mrmi9cfQqmwS3/2wrB1/h7w8fzOVSD6YLv4pxeU2I5LvqpAtcjmt25c?= =?us-ascii?Q?Os5IC0NNV6r4ByS0C4+uHT5AJO/qA0R9KilUZ8TDRQM2vh6EftKJRsizHtpW?= =?us-ascii?Q?H3uecB9se6FbUyzaRRglp6m3SDtHSkJA9MIST/j10hGx4rNoEw2Z00KFAz0h?= =?us-ascii?Q?csHkPQp8fqPpDd3SpCcrm/DREobZjWt4L8Q+R1WTokFh9nm9oAZ/xWV39m3V?= =?us-ascii?Q?OMVg0p3KvN+3oripYhR7DjwrQ+4xFD5i530e0owjY2YVL2oaPwOFHZcXN7aC?= =?us-ascii?Q?tIcjUoriEg2RiYSUunJNzVIoCRNRBUhJYiAMBkiTTAnS174icBjWXeW7jpEz?= =?us-ascii?Q?uwo9Ct3V/13OgLLNLL64dxAMkZt5tH429tsAfnGzyekpb6FSTx3FQokPo/Vb?= =?us-ascii?Q?q4U9nS1lsZKu76oMDT6sXFLSxkFkTF2O971hqUEbyfrvx22ICgdQ81HZ+AR3?= =?us-ascii?Q?4swDD6PZ+/erK6zezMmm4uj77q/0BnVwEa3D2nIFoHEUYXf9hGWYfFhxy+oD?= =?us-ascii?Q?8pSP5PxGk8GqShDoKSBfalVgDF8n3a/AA2ibMGeH7QqHuOwLz/837qbzDk0z?= =?us-ascii?Q?mKRHnX6ic4570GEu7xl4IPhpResJzNBdPM+nU36fwA=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ob241fmzDAZw92oZnosLVkm92mxe9WCELRMtmafkbUJP1qaUDiN7tGMFNimd?= =?us-ascii?Q?E/BEMI0j9WHVTJW1eFMVtTKO806raLo26+KoiorMxXMUvfUrlMeNyIXp6vfZ?= =?us-ascii?Q?wmglwByE7TIQ42KCzG8AXNchE6QnZCChXv8a4P+8pgkqmupK31/pgnlbHz2U?= =?us-ascii?Q?xBE0QMQ2oS/rwZoGFPzutyuaziGG03pscu0OfoN7Z1+cf2mNQD/e5CzezwjO?= =?us-ascii?Q?o1ro1/FnPKZvXcB2UxBZ+S3/HVK0iF+f9egk1p8UJmSJ/mQFkhAPlBu3sD5p?= =?us-ascii?Q?TeSV+4RgY+cQpIOstMMdu03bo2hgDGR3w76dm7VZw1eLLfHsZhd5mNh7q0YB?= =?us-ascii?Q?NcnNPQOkrI/w3DVORD+UdXh0s9YiJqamqqlp3AXhtNRuo68T3J+2eDdC7N18?= =?us-ascii?Q?jKx8rrbl/3E3VI9BpW85qohrnb6Cv2HEkV2FNbH6mAFET2p4SumVHTfASr35?= =?us-ascii?Q?S7pUO0gE3zx8jrJyrwzNDX4l4n8q0Gn0vQk0YlqsvxDEs1Gw3e9zVFXgkFJ6?= =?us-ascii?Q?2JewqWEl6DlHASl5R8TFJbwYOdO25ggW+rHoWzCNdAjCBd8yOTMvgEnsHMz2?= =?us-ascii?Q?7x8UBDuAZ9slHXEaXD1qw85edMrc6tYduYfMg2dK9HR9jHw/WL6FhaKFXZKd?= =?us-ascii?Q?zHDUtm7OlasJWbXPSCL8L9w0+JX+PiyrbxLxbrjQHC7uNJV2tRN/uUwBdNd7?= =?us-ascii?Q?U1uFA1k+G6q7S4MWj6jVKZDK+CVm4SFU2fr4rCOLjb15nhM9JCBuUD6XYkav?= =?us-ascii?Q?ACuEzZsBM7pXMVWcOFmagEkLOqgSOYRjsu0l3we9avWd6wqVyqIXZKUQWjOz?= =?us-ascii?Q?Z7rp2+DAGXcgpxk7uBP4lXXagyTVBSRVmfvAIS8P0izQOeJcuWZNJxNedw8m?= =?us-ascii?Q?PpfP+qTDssUoCqX1pc3jmYBs60Eogu9wC+JpkdZ3R5svyghfwTdfUHjzuqwy?= =?us-ascii?Q?ydrX2OLPCSASoBU48q2dVlQC2F+2emw1THxUiXpyJGbb/MmSQRFjFc1XM2SB?= =?us-ascii?Q?WxBajnGsi/JtM8RSYq+lzFhBZOIW+HygfTuNAzOASYu94Mvwq1cO8l4RyxKs?= =?us-ascii?Q?M8oxV6xjgjXd98bsTw70qGFUhmtVi4lYmyqEDSbi8DjoDkIFoStL20kZUVlp?= =?us-ascii?Q?nxbMOIYLfYS62FxZCOaGNpR9UKfHOCufd4xZBEkRE9b5PdbH63nNksQKfcvC?= =?us-ascii?Q?vl+u2Eekzo/2u5teNLTMp9tpIzUlVRla1yQVyfsFJ/5IXweLHBKYaau3QB7w?= =?us-ascii?Q?sH2OLX71UdZC3Xrs/Fi5M+aO84VHrW+CjtIExAW6OfJKAWCUQ+jx2fR3m2w3?= =?us-ascii?Q?4f1RWr9w/pWLXkoEYRV+ZZWzcXDOcd9S4w9hH/WNKJVVBjUOfXIKF8x/Gq9I?= =?us-ascii?Q?B0tbw3uz6vBRjvcYZeCSbULheZTY8DwTowPvO34IzcjAwYs0zBdjZoaUKeOS?= =?us-ascii?Q?T62XxbdC131I/icf9FlXiB72PN+BOncrD2tclLMg+gsyd5giXR6bfrPKRhvG?= =?us-ascii?Q?7J92eFhuIiQlCi7otmnTEvWVC67nVxHobMoW9C9YyOOpJAwsckngPBQKt215?= =?us-ascii?Q?TiorySw4KPypdTbEZLE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6227.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bccc9eec-fc36-415f-fe45-08dc7551e4ca X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2024 02:42:56.7986 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9BarfQCW36WwJMxNbbWoLK+8waPagQmypKJCDIND7xFxtrKmH70GybdsMx2UErHqZ0QcvTSZTdWpPt6wD4p19A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8171 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 15 May 2024 19:43:00 -0700 Resent-From: yi1.li@intel.com Reply-To: devel@edk2.groups.io,yi1.li@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AvXgRrQejiwQH2I86wwWSXzfx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ldoyvNrC; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, Qingyu I am still not see any codes related to CryptRand.c, are you missed 'git ad= d' for new change? Regards, Yi -----Original Message----- From: Shang, Qingyu =20 Sent: Thursday, May 16, 2024 10:28 AM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Li, Yi1 Subject: [PATCH V2 1/1] CryptoPkg: Remove outdated code related to deprecat= ed SHA-1 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4698 The default drbg type of randlib has been switched to aes_256_ctr in openss= l1.1.1, so sha1 is not really used in RandomSeed(). Remove related code whi= ch do SHA-1 support checking in CryptRand.c and CryptRandTsc.c to avoid pot= ential compatibility errors. Signed-off-by: Shang Qingyu Cc: Jiewen Yao Cc: Yi Li --- CryptoPkg/Library/BaseCryptLib/Rand/CryptRandTsc.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/Rand/CryptRandTsc.c b/CryptoPkg= /Library/BaseCryptLib/Rand/CryptRandTsc.c index 30454bf10f9b..b94c16de562d 100644 --- a/CryptoPkg/Library/BaseCryptLib/Rand/CryptRandTsc.c +++ b/CryptoPkg/Library/BaseCryptLib/Rand/CryptRandTsc.c @@ -40,14 +40,6 @@ RandomSeed ( return FALSE; } =20 - // - // The software PRNG implementation built in OpenSSL depends on message = digest algorithm. - // Make sure SHA-1 digest algorithm is available here. - // - if (EVP_add_digest (EVP_sha1 ()) =3D=3D 0) { - return FALSE; - } - // // Seed the pseudorandom number generator with user-supplied value. // NOTE: A cryptographic PRNG must be seeded with unpredictable data. -- 2.44.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118944): https://edk2.groups.io/g/devel/message/118944 Mute This Topic: https://groups.io/mt/106127679/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-