From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 589C1940EED for ; Thu, 16 May 2024 02:44:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=biuNPIu7UUEU9nyuD9nro/ww80uwTZwX86Z14sd43Tk=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715827447; v=1; b=RwXeD5//WJET9R2ZHPTFkRIwGposa7Avxm3dSa1rUL1b0a1end6LpHFHRvB5+aS+Wy6ljyRs INFTrQbDHNce5mqN46xq1iNCchYmZ56Y/XzoFHJ2oJslw34kvrKvkXtDcZNGwmUOfTAbDGlaYkv i2w3b6TJvMJmtAAxdJmA/v5J7poM1Ku+cf2xQ//8G3V4qDBVvZQuIAtQfxlDzja0MeS8vLYtv8C aBAPA+ZoWrWYxjbyOVPeFD2CmjoheqtxhGn1+MLflka31aOHOlquoq7vMlPSZDPHn7zpHzwHuEs py6AiOIIBzXX5VZ4fD4tAgxBOllUTP32zioeNmCcZleiw== X-Received: by 127.0.0.2 with SMTP id d1VLYY7687511xHqSUBBrHzf; Wed, 15 May 2024 19:44:07 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mx.groups.io with SMTP id smtpd.web10.4011.1715827447064509684 for ; Wed, 15 May 2024 19:44:07 -0700 X-CSE-ConnectionGUID: ylRGtm3pRs+0ZzX/GiOBIQ== X-CSE-MsgGUID: V71EX2YcQo678q9yIvCemg== X-IronPort-AV: E=McAfee;i="6600,9927,11074"; a="11780892" X-IronPort-AV: E=Sophos;i="6.08,163,1712646000"; d="scan'208";a="11780892" X-Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 19:44:07 -0700 X-CSE-ConnectionGUID: MnHL06Q4Tw6i2ul82UrvSw== X-CSE-MsgGUID: 53ge04oxQxi5z0+SMpCLMA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,163,1712646000"; d="scan'208";a="36054928" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 May 2024 19:44:07 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 15 May 2024 19:44:06 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 15 May 2024 19:44:06 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 15 May 2024 19:44:06 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 15 May 2024 19:44:05 -0700 X-Received: from SJ1PR11MB6227.namprd11.prod.outlook.com (2603:10b6:a03:45a::10) by CY5PR11MB6416.namprd11.prod.outlook.com (2603:10b6:930:34::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Thu, 16 May 2024 02:44:03 +0000 X-Received: from SJ1PR11MB6227.namprd11.prod.outlook.com ([fe80::c4da:83f1:f7be:e307]) by SJ1PR11MB6227.namprd11.prod.outlook.com ([fe80::c4da:83f1:f7be:e307%4]) with mapi id 15.20.7587.028; Thu, 16 May 2024 02:44:02 +0000 From: "Li, Yi" To: "Shang, Qingyu" , "devel@edk2.groups.io" CC: "Yao, Jiewen" Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Add support for aes128-sha256 and aes256-sha256 cipher Thread-Topic: [PATCH 1/1] CryptoPkg: Add support for aes128-sha256 and aes256-sha256 cipher Thread-Index: AQHapzQC4I38nEf4XUuR7e0VTvoHVbGZJzYw Date: Thu, 16 May 2024 02:44:02 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ1PR11MB6227:EE_|CY5PR11MB6416:EE_ x-ms-office365-filtering-correlation-id: 9d08067f-e277-4b07-fe64-08dc75520be2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?44ONFGzn5LOySaxlPWG2tv0gzJhVSGSwmN4J1Z7Yw45+8vrmrwPj95+43uXe?= =?us-ascii?Q?bCufmE5LWvIeNXtqAr5q3LEyB7agxDLdxCY8QEnrFC/cW+eIRpdbZKd4Nreq?= =?us-ascii?Q?H+pgA6iLxP5QA8OW/dNDw3rzKePKlfxSJnoNNdA0nhDZnmpXKPsTw6VE6WeJ?= =?us-ascii?Q?0IpuwfxhW2u30KYV085uofRzG2UKyy46/E4pDDzlOZBzvr3jMslgMjfbAO5p?= =?us-ascii?Q?bsGFvwnhs/mvUOeln/liYTziUydNXCokhUN1+fxMtDfF6NooPMZShv5iDjTq?= =?us-ascii?Q?xnnsLJVQDB5+dAIICOBUiUBmDegjfUT8GfUsF6WAxEg0dlYQ/8ytx0u+E/5H?= =?us-ascii?Q?TQ7+l45NwxBCNx+uf6Sg49ccP+Td6B/IG58oQZAXCm7GQDBLROSAxuOiGYa/?= =?us-ascii?Q?QQmhXc1grHhcaMwi9dmSTNno8SCfvmNbWg7SL1ATLOfSOs0Ux9jBQ67dEvJB?= =?us-ascii?Q?DOlhkzr5Wm1Ar9aDj4Nst9NVkEnqVNnSWV3KpBZK+hxvqrBT5xqnsjUvkNL1?= =?us-ascii?Q?9+AWWiDcrOP3tGlKbncGoaMO5uRDgKDc42Mczv4aennmvRB+W3Sm7EJQ9XBi?= =?us-ascii?Q?zRINbbQN93SwKAIZhO5GV6RQ8o1Hf2IiQXQ/OQCGTlQroMfiuv75mGxd3Atf?= =?us-ascii?Q?8DWYSN9ti4R6BtoykH3JM+DWjPp4Tp9sSdvk3CNN9YMGiMB6QMegnfL0bo0c?= =?us-ascii?Q?BjjsBmYgvTSz56AJNjpZOuWnBf4oWIvBljYEuiNOCgyIGnAtj2Gkyt/oHGJh?= =?us-ascii?Q?wriTCPj2rffeQ24l+cTWpE0H7Te85S6HTIsbgxYV2tTgv/nda7QG13kSjVR5?= =?us-ascii?Q?ayG7XLXv63JZlWWBulXQpSJ4GDKXjkXhxys7apFc5YJmcYCltEGmhBjZ1fGw?= =?us-ascii?Q?L3/BkIle7vaD8isHnvPpkPOJv3rJpAdtNbp0GuEWXArkmePuCZQh+xjjWy8G?= =?us-ascii?Q?OaEC3WmWIRqueoDnZQyvazehrdqc7YALGNuMvJqNZbU7rwBQBcJUy15AfMyz?= =?us-ascii?Q?wGHaJCqI08v1ltfyzwpxFh4qxfxyPS8hyX+V9Bq27txb9kDavwY1Rru1sXDG?= =?us-ascii?Q?BiLCVf1d6LvwGUMk4WIcpLgdY/dzJpeCP2v696XQGqLSQFxFlFdllaW3OqLs?= =?us-ascii?Q?hVd8UyXxiYGakmPIbBnCPoI+aRwS4Te9UgtnaPq6I2do7R7uQ5SDcNCr4wT1?= =?us-ascii?Q?Y4D/APyDaDsmtiElkJZR3qriz7Azbr5PbnL2xgyg1KsaIEi1q4f3zRMhQvhJ?= =?us-ascii?Q?N1vmVfSHD3NIFdofM3aWk/ES43d06R8vw90ct4Nz4Q=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RngCBjJBvvy2PBz33i9oVhsX8dA88EG8pPRQQeokRUeIG3+CGYJu2kThozMS?= =?us-ascii?Q?yFi9sm6dpz3mXYozp7gsjh8QDSQbTKxWeRB/JDTsdvtuu1AZvtdEJfWNm0g7?= =?us-ascii?Q?ST/ohLSBGDuMXQHD9Di7gchf6j67Tin7lRH27gdILWuEbWxneBRTaEjZF7mB?= =?us-ascii?Q?ttIx/Cup+u5iNmoAnCaI9T3ptiwxo442XKtJFphET+Z1nRqioarphFlOjebm?= =?us-ascii?Q?msREnoyPwIqfNomaeahtMUEMrtGbkslQswp+xYrrmdEc8utKhAXAZ9U2RnIT?= =?us-ascii?Q?yIC1uvi8vpVW1291A2eA520uR/OCu1kz3oEaKXYQBm07hlBbm7csx9U1Dcpk?= =?us-ascii?Q?+H8XRUJEifP5dNiXSV+0faWK3JIVQrK/woJt0JG09mO7chFYyPWppXqPNxpk?= =?us-ascii?Q?4jMoPekxJNRtm/0CAjU4jdx3Bvvd4Bj2ZPEqNQDui9XlKpCzyBOboRJLpi8j?= =?us-ascii?Q?A9VyiqgzE4nsT55O00CpOL73z7hJDztvoutkLg7K2mjm5e4h08RIL0cCa412?= =?us-ascii?Q?5QQ05MZdl5dTBHXNAZWYu2bzyoHxtvd19z/0KbWfvpQKiQ8PI0CVnfdfamOg?= =?us-ascii?Q?7pWOQaV/ldZcVUICOhpIIgSKaEEl2+ReYuYWslIDD9tWicbvo9fO8SxZS3/z?= =?us-ascii?Q?9J6K1qYHwbXHGwg4D4Vr+QJ51IIz2+Wmf0fKc+nrrRMOGSJy9xgeHK4kJ2CH?= =?us-ascii?Q?1dpw1JSOfJzMnhZCZOWiRl6oJgpoXGqOnqj0nWFBZ1JRydVuua2sC+si9Y5U?= =?us-ascii?Q?h9srJg0MP5ItKGlnjWhuN0hud4Ib4aqp2t91Ci4sb+eM1VWtaOsmHSaxiqs5?= =?us-ascii?Q?P0f5CLfOZk+ucRqtjh4KxCuDS+fp+X84KdPNh2CyfAyRUwjkVBY3bzcn0EVI?= =?us-ascii?Q?qNZXL5v99o9lOGM8ddZZhSb2/+4lVY3SCrC6yVtf25l7/lrm75OqAG3jS/qy?= =?us-ascii?Q?NxXAi98AGXj3hGulYu9nKPvz0JcUEU7ccCZAzbXXnf/BR1MxcT7XowK/u1jt?= =?us-ascii?Q?xTaxS8ZmP9iNvfyfwrrwMeMYdRseMMvVvyeteVyRWlhNEFYt7bBuNXwev3cA?= =?us-ascii?Q?0YT6633+5WRhVUPi/rvquWPvyMnOzIRe56g4R8/cKWH8BbNDBXKQ/zMIBHCb?= =?us-ascii?Q?LZxZPhGGYciNxg0EZUEdsWE7tmVfog8+Y/f6aCjDMz7OVbddY7MLhcwkEtFJ?= =?us-ascii?Q?e7jSVnUtRUsQrJkfOWM4UqsjEXpin2NXJco3AJR3spqCZ+XT0pQxiWsiVyZx?= =?us-ascii?Q?RHRgXF/dmwIsXzSWujFMMJ3s1JIjuf19QxXv+5KnenNEYM8vzY79oNTYinYc?= =?us-ascii?Q?N1d27Czum38XBR4qRE1+RQE2MBckh3oKGdR8lQTLfqsijW94FKMzAXLretJd?= =?us-ascii?Q?1Dg9qO2H5DJnCtqGYckMT0YOEBhMqY2irVuCFL4pLhX0nMsq1TjfEUlR2Ony?= =?us-ascii?Q?v73XbmqQbgWuuN0Us9D82Ov3yni6EwtMZF4Rf6BtYEOCTcXXPzsnHLmqS5UW?= =?us-ascii?Q?LHEcMnItio4kXdsyDoowdot8PtiFQrROsRkVe0YtL6vMIa1nOw5aGRdGsaRI?= =?us-ascii?Q?28T3ab9GyLqHaFLsDVo=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6227.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d08067f-e277-4b07-fe64-08dc75520be2 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2024 02:44:02.6931 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 87q5QmEG2lheug7buqmtcKhBLduW2BorQGqJU0cLEg1w58UULFf5Qv4mNi/1sc9ZIoay4xmbEahnnNeMiJSMpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6416 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 15 May 2024 19:44:07 -0700 Resent-From: yi1.li@intel.com Reply-To: devel@edk2.groups.io,yi1.li@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: n6texoxtEZqKH5WhepplsDEpx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="RwXeD5//"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Looks good to me. Reviewed-by: Yi Li We are in Hard Freeze phase, will push it after freeze. Thanks. -----Original Message----- From: Shang, Qingyu =20 Sent: Thursday, May 16, 2024 9:54 AM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Li, Yi1 Subject: [PATCH 1/1] CryptoPkg: Add support for aes128-sha256 and aes256-sh= a256 cipher REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4739 AES256-SHA256 is a Tls1.2 suite we need to support, add it to deflt_ciphers= in OpensslStub. Signed-off-by: Shang Qingyu Cc: Jiewen Yao Cc: Yi Li --- CryptoPkg/Library/OpensslLib/OpensslStub/uefiprov.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/CryptoPkg/Library/OpensslLib/OpensslStub/uefiprov.c b/CryptoPk= g/Library/OpensslLib/OpensslStub/uefiprov.c index 40ab7e937c69..f2af6a49d85e 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslStub/uefiprov.c +++ b/CryptoPkg/Library/OpensslLib/OpensslStub/uefiprov.c @@ -141,6 +141,17 @@ static const OSSL_ALGORITHM_CAPABLE deflt_ciphers[] = =3D { ALG(PROV_NAMES_AES_192_GCM, ossl_aes192gcm_functions), ALG(PROV_NAMES_AES_128_GCM, ossl_aes128gcm_functions), =20 + ALGC ( + PROV_NAMES_AES_128_CBC_HMAC_SHA256, + ossl_aes128cbc_hmac_sha256_functions, + ossl_cipher_capable_aes_cbc_hmac_sha256 + ), + ALGC ( + PROV_NAMES_AES_256_CBC_HMAC_SHA256, + ossl_aes256cbc_hmac_sha256_functions, + ossl_cipher_capable_aes_cbc_hmac_sha256 + ), + { { NULL, NULL, NULL }, NULL } }; static OSSL_ALGORITHM exported_ciphers[OSSL_NELEM(deflt_ciphers)]; -- 2.44.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118945): https://edk2.groups.io/g/devel/message/118945 Mute This Topic: https://groups.io/mt/106127156/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-