From: "Li, Yi" <yi1.li@intel.com>
To: "Hou, Wenxing" <wenxing.hou@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build
Date: Sun, 21 Jan 2024 07:57:23 +0000 [thread overview]
Message-ID: <SJ1PR11MB62272F42FCF8AEE2CFCCDDF2C5762@SJ1PR11MB6227.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240120134524.1669-1-wenxing.hou@intel.com>
Looks good to me.
Reviewed-by: Yi Li <yi1.li@intel.com>
-----Original Message-----
From: Hou, Wenxing <wenxing.hou@intel.com>
Sent: Saturday, January 20, 2024 9:45 PM
To: devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
Subject: [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4642
When use Mbedtls, there is a clang build error.
Add dummy inttypes header to fix clang build.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Yi Li <yi1.li@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Signed-off-by: Wenxing Hou <wenxing.hou@intel.com>
---
CryptoPkg/CryptoPkg.ci.yaml | 1 +
CryptoPkg/Library/Include/inttypes.h | 9 +++++++++
2 files changed, 10 insertions(+)
create mode 100644 CryptoPkg/Library/Include/inttypes.h
diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml index f961d85927..b601bcf85c 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -44,6 +44,7 @@
# This has Mbedtls interfaces that aren't UEFI spec compliant "Library/Include/stdint.h", "Library/Include/stubs-32.h",+ "Library/Include/inttypes.h", # These directories contain auto-generated OpenSSL content "Library/OpensslLib", "Library/IntrinsicLib",diff --git a/CryptoPkg/Library/Include/inttypes.h b/CryptoPkg/Library/Include/inttypes.h
new file mode 100644
index 0000000000..3d44d8201d
--- /dev/null
+++ b/CryptoPkg/Library/Include/inttypes.h
@@ -0,0 +1,9 @@
+/** @file+ Include file to support building the third-party
+cryptographic library.++Copyright (c) 2024, Intel Corporation. All
+rights reserved.<BR>+SPDX-License-Identifier:
+BSD-2-Clause-Patent++**/++#include <CrtLibSupport.h>--
2.26.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114123): https://edk2.groups.io/g/devel/message/114123
Mute This Topic: https://groups.io/mt/103849296/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-01-21 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 13:45 [edk2-devel] [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build Wenxing Hou
2024-01-21 7:57 ` Li, Yi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ1PR11MB62272F42FCF8AEE2CFCCDDF2C5762@SJ1PR11MB6227.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox