From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id CDF11780091 for ; Mon, 8 Jan 2024 08:26:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=h7wLp+wH6HDvQGBd/vM4PWKcErIIdgaQ9Dlupn/biqA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704702410; v=1; b=X/PahlvXECegQW1mbjMdeBaBXabr4pXbWmIr/tSkhJMSs3/LuvV8VTJZAneXfaRBa70KzSws pB1NuU95NS36UcEplHdKGaQ3OPFaiv2rZBwwQq9rLVi7z4qmxa0KOSeRr7Q/2c/tALQB0urJr1t qrHwA57wLxTqxrZI7pNRr53Y= X-Received: by 127.0.0.2 with SMTP id af4EYY7687511xHB27xkjz6P; Mon, 08 Jan 2024 00:26:50 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.2540.1704702409698109268 for ; Mon, 08 Jan 2024 00:26:49 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="397546246" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="397546246" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2024 00:26:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="29716129" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Jan 2024 00:26:49 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Jan 2024 00:26:48 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 8 Jan 2024 00:26:48 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Jan 2024 00:26:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ffWUDJ/QjSWpGArWwPocxDMmXORXQOzAFup86NO0ZDgxSIT2EgTDlZPRKQw7l9wS1UJBe87u30o17aIo6OLNJpmoUISxLCVYExR1Yo/H31lm4FTmbPecUABiLwZhSAAR18znfq0k5XgTFGomys/45I1v9u20hwQpK6nEH5f7xUvlaitZpxLz94v7C/ameBZhKDcp5ryrAT//pPY2ufzkOUDyrdH9dBXv06sNgbSWdYZiO6fb0aNLbjuzzuWehJIdxb6ECDAr/gA/TUOra1q5p5OC+/cQN4LExKLspRx4HDtwSRXm9NIXDLdPWpfLofq1uiC6d+EKrHtx3R8k3o2GzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZIQalVHygsIwltnq3BnEYB9+1MAriZdDO1Cb8gP0P/8=; b=I2ah9P6JPHl21w7bjjR32KIyykLBAWkQ6PqSZSkiR1ULXj5noKo9vQ883NxkhmrKrDomoVjuZnHfv70a+XLHZ9nJw0xeqdHZCmps7foGcA9F6N9zYk5SmAeimSBj1G+a6x/tmYJv2DycUFlSZIx+R4BFSnuZsmsrqYC8WtcRu5oMpBGvNXj1q3rVsyURTsQ1JObC3axTJ5fAQsnXaIY3eoCoftrpOD5tIhN3/USQPlq3HRt9gnpwlQARh/5xUWAoGk0GT9xkNxpNvwce9wAvFhHZU9nivA60YE7gox/lA//P4rKQg5kJomR+YwkWPMdK0thDHgFLss7+fuR++8lvpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from SJ1PR11MB6227.namprd11.prod.outlook.com (2603:10b6:a03:45a::10) by PH0PR11MB7614.namprd11.prod.outlook.com (2603:10b6:510:28f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Mon, 8 Jan 2024 08:26:46 +0000 X-Received: from SJ1PR11MB6227.namprd11.prod.outlook.com ([fe80::bee8:181:ff56:8bd]) by SJ1PR11MB6227.namprd11.prod.outlook.com ([fe80::bee8:181:ff56:8bd%6]) with mapi id 15.20.7159.018; Mon, 8 Jan 2024 08:26:46 +0000 From: "Li, Yi" To: "Hou, Wenxing" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Jiang, Guomin" Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls Thread-Topic: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls Thread-Index: AQHaPujZAcPn11RAO0q6Oo6Ik8nyLrDJWaCQgAY6yhCAAAY/sA== Date: Mon, 8 Jan 2024 08:26:46 +0000 Message-ID: References: <20240104083415.2967-1-wenxing.hou@intel.com> <20240104083415.2967-2-wenxing.hou@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ1PR11MB6227:EE_|PH0PR11MB7614:EE_ x-ms-office365-filtering-correlation-id: 422b80d3-34d1-474d-393b-08dc10238dc9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: ZXZs8EnS7T3aKWvet7s9upQ//NlPECkTaDq/5AKl4JYGH6UhGRhXNzlEfOwZ+wnCC7OXw9+Uy26ceo/rJmMh0hx4FYOzRVI9Xq4YajWoWUT9XIwjNm/1G6N8Qn9hTjkijX11p8bW3pjP++ltiN+vDmQRzKaZtQcNkzk3WvuxeJG56TD9fgxtcv/iS9h8pcVMarZQ2aKt4HKAIKn+jFIXvHEqIC4qOGnrIGftIFA1B+3E9MqFdTZbOHRaeqMeGhf68gLF702sh0p8ZIPI5b3M8k2/UxEKmkuGsZl4Zzt+0awP3OTzCGwSJ5pCi0tfygjNsS8Skqt8NIXznaduU9qqoeGwYpMyZSq8/YmrSTe4Qje+Yr9aS3HZpy83Gx0KqXHJ+RSG353ld4NSsF/bOKkV3P6id/adHly563GhWYVJFGVJVB88tfDOtUiPbqnHV/KFvhXKCgiS147dnNq3yuJix0WzJaVN2uuo5N32bcvJdOkahuiTjlPQJGRCZmIm2bJWbOKDQpf/qSJDAWJDJ5zD2/5IicrEKM/h624MY1jrHsnPpsMafsJkq3hC8PYdhqUFhKhOJadhNCzEFa1DRwp/WtlG2HBRkgqz/ei1+vkeJoM= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x+jSS9yWw1I48v+lrYC1agVsW8+xjXPX81z8xSItQ7K9/TUcIsqTWJAlZw1D?= =?us-ascii?Q?bjt53/fXXTBMsXQgWJMI0zr+S8y6PU0gRUfzvRKO5xIfq5d+nrnFkZca3XI7?= =?us-ascii?Q?wCjq5Dnj0VLmLcbtt9x1WVsk0ctnz4sTI2SLOYRm6V4UlwIdXkthOsw4cLDG?= =?us-ascii?Q?X8I1YmKfSNzF+ve516VZCF6a9KQuDMicBVN46rp+9C++6MUyRFcW0mhBWcLn?= =?us-ascii?Q?JOcIG9VtYFl5F5ip4yZoOLCw+ZagqeoCDu9m3X5QNSbIp9pksXzSvW4HdFoe?= =?us-ascii?Q?TSHMXPZv8iQu5ocYhQq2LlAiOAYDNeur4NVGuOUH/36P1Gz3+gbE459WVS+N?= =?us-ascii?Q?4h1RScVt5+Tifw1GcpAfZH/HRgdOXga16/yaMJpWR6H4Itye6DheiefV+mgB?= =?us-ascii?Q?x7KazgXBQCF07DrlLz7j3wt+kHzficcTX2oip2ItKMb22QkGk1p8uh0iMB5e?= =?us-ascii?Q?luix4bfUJmTLLb9LfZy+uJkbdatLURBv94MKbuy0zPuxi6/NG4L6TXQvHn02?= =?us-ascii?Q?4BGdO3miYdxAbqRvvYcQh6RAxbriFK7tXDvsdP1a5xQdsd8BDaUREua/Yzwh?= =?us-ascii?Q?5JNE+59NoTU44oQ0FWqThMLnuUzk/yZ13iMqnu40dlOK5qw7pLGcodLaQUb9?= =?us-ascii?Q?b6RVUsX4EfhK3JEPseXCwc9lHfinADflYVbnhyAvxGQ8xyr6ubKqd1RvzAZr?= =?us-ascii?Q?1NS+b4hsXl6ibZJ0wakuHrETK0UzeFRR+i8MPjoIxNbLgaSXYPXRplcS4zD2?= =?us-ascii?Q?51abWQdHWfEveb2Gksn3UqFdGenOOe/DEVoyA6fz5nCI6dR1MmwXkjwERR6m?= =?us-ascii?Q?K/plZaPIhh1+cLy+voQ0aFB9SaBNQoY3S/zMfuOghjqUHAM55jSFR92IEBrV?= =?us-ascii?Q?t482PR20mpCNIZ+SzE7AJ3thWGicH4ErXBrVtAg4wKrXnuf4ojyc9sQE5DO/?= =?us-ascii?Q?EXyNckXYqR8qGggmuxS9Ibrn8gcpwZEzokf79uGdjOC9uFa7PCeTIdrAMnvj?= =?us-ascii?Q?ItEuGWsZnnAgWzx6HbcUSUCN3zyxgYJFP+6KJC+PgI1zgbQVKxFnY80ueFm5?= =?us-ascii?Q?6YenYiONs5RDGbTmi3G/nf3U2ejBG8BJ9/2eH0l4Unf9ten2IBXZPuOZcYcU?= =?us-ascii?Q?c5AfK51rHi9xhw0lV4X20iRCb5TcJA8B/1hPwF+PbwyJI2gJLlEucMzmxmaS?= =?us-ascii?Q?qBcVmkLPhPXhk2HTpmTSBVtJP4mqhDPDc2Wb+F47MQgpLZyF7hGSI4z+BNkg?= =?us-ascii?Q?YgpYFqhPcFgddwGUzIsT5g8BCy5IDcfIwk27fxsoIuFGGAe0C7bvJ6JQibZe?= =?us-ascii?Q?47ZHpRI8tRZaULlGUcjK72uLHn1m37WE812Rq8s+6SVkHLVNwpTvS1ac1GKo?= =?us-ascii?Q?+Y5pS+xawnYLq7L6OEp2IW2yNKtUT7/inVmdIt+I24QZwmUfm+I8a/gB8Z/p?= =?us-ascii?Q?k3G7bi+vQCKjx1T6zuWEShs1wavnLf8KZG2uHmaRbAajtoX+62mxUkoPdFmI?= =?us-ascii?Q?6pqIzvqILbfghJ+xmDAcFRA9kkl0wSaO4CmAA0ZoBmndb+wzOUX8xtS/Soi/?= =?us-ascii?Q?i6y1/KP1tHEMANP1Q00=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6227.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 422b80d3-34d1-474d-393b-08dc10238dc9 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2024 08:26:46.8245 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lGhZyXgy+fJCxNI0dt7xgz07Wn79e/0KVfWgRB0FKXHXgnG/4EvQB+bPki7TdH4YEQu1Aw4X3taCRrWX2ZWySA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7614 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yi1.li@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0dLwx9sIJe6Y8VhD13lHham3x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="X/PahlvX"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Sounds good, thank you. Reviewed-by: Yi Li -----Original Message----- From: Hou, Wenxing =20 Sent: Monday, January 8, 2024 4:23 PM To: Li, Yi1 ; devel@edk2.groups.io Cc: Yao, Jiewen ; Jiang, Guomin Subject: RE: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls Hi, For VS build, the size is same for enable or disable MBEDTLS_NO_UDBL_DIVISI= ON, because the previous code only had GCC build failure. This MACRO doesn'= t affect the VS build. For GCC build, the previous code didn`t have the size because of the build = failure. To compare the size ,I add the dummy API for previous code: tu_int __udivti3 (tu_int a, tu_int b) { return 0;} And the size has very s= mall change(<1kb) for enable or disable MBEDTLS_NO_UDBL_DIVISION. Thanks Wenxing -----Original Message----- From: Li, Yi1 Sent: Thursday, January 4, 2024 4:59 PM To: Hou, Wenxing ; devel@edk2.groups.io Cc: Yao, Jiewen ; Jiang, Guomin Subject: RE: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls Hi, > disabling it can reduce code size in some embedded targets. Could you provide size change after/before this define enabled? Thanks, Yi -----Original Message----- From: Hou, Wenxing Sent: Thursday, January 4, 2024 4:34 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Li, Yi1 ; Jiang, = Guomin Subject: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4630 Enable MBEDTLS_NO_UDBL_DIVISION to fix GCC x64 build failure. Cc: Jiewen Yao Cc: Yi Li Cc: Guomin Jiang Signed-off-by: Wenxing Hou --- CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h = b/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h index ae9ef3a1b380..3068612c0815 100644 --- a/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h +++ b/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h @@ -67,7 +67,7 @@ * example, if double-width division is implemented in software, disabling * it can reduce code size in some embedded targets. */ -// #define MBEDTLS_NO_UDBL_DIVISION +#define MBEDTLS_NO_UDBL_DIVISION =20 /** * \def MBEDTLS_NO_64BIT_MULTIPLICATION -- 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113371): https://edk2.groups.io/g/devel/message/113371 Mute This Topic: https://groups.io/mt/103519146/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-