* [edk2-devel] [PATCH 0/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls @ 2024-01-04 8:34 Wenxing Hou 2024-01-04 8:34 ` [edk2-devel] [PATCH 1/1] " Wenxing Hou 0 siblings, 1 reply; 5+ messages in thread From: Wenxing Hou @ 2024-01-04 8:34 UTC (permalink / raw) To: devel; +Cc: Jiewen Yao, Yi Li, Guomin Jiang REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4630 Enable MBEDTLS_NO_UDBL_DIVISION to fix GCC x64 build failure. Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Yi Li <yi1.li@intel.com> Cc: Guomin Jiang <guomin.jiang@intel.com> Signed-off-by: Wenxing Hou <wenxing.hou@intel.com> Wenxing Hou (1): CryptoPkg: fix gcc build fail for CryptoPkgMbedtls CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113150): https://edk2.groups.io/g/devel/message/113150 Mute This Topic: https://groups.io/mt/103519145/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 5+ messages in thread
* [edk2-devel] [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls 2024-01-04 8:34 [edk2-devel] [PATCH 0/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls Wenxing Hou @ 2024-01-04 8:34 ` Wenxing Hou 2024-01-04 8:58 ` Li, Yi 0 siblings, 1 reply; 5+ messages in thread From: Wenxing Hou @ 2024-01-04 8:34 UTC (permalink / raw) To: devel; +Cc: Jiewen Yao, Yi Li, Guomin Jiang REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4630 Enable MBEDTLS_NO_UDBL_DIVISION to fix GCC x64 build failure. Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Yi Li <yi1.li@intel.com> Cc: Guomin Jiang <guomin.jiang@intel.com> Signed-off-by: Wenxing Hou <wenxing.hou@intel.com> --- CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h b/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h index ae9ef3a1b380..3068612c0815 100644 --- a/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h +++ b/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h @@ -67,7 +67,7 @@ * example, if double-width division is implemented in software, disabling * it can reduce code size in some embedded targets. */ -// #define MBEDTLS_NO_UDBL_DIVISION +#define MBEDTLS_NO_UDBL_DIVISION /** * \def MBEDTLS_NO_64BIT_MULTIPLICATION -- 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113151): https://edk2.groups.io/g/devel/message/113151 Mute This Topic: https://groups.io/mt/103519146/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls 2024-01-04 8:34 ` [edk2-devel] [PATCH 1/1] " Wenxing Hou @ 2024-01-04 8:58 ` Li, Yi 2024-01-08 8:22 ` Wenxing Hou 0 siblings, 1 reply; 5+ messages in thread From: Li, Yi @ 2024-01-04 8:58 UTC (permalink / raw) To: Hou, Wenxing, devel@edk2.groups.io; +Cc: Yao, Jiewen, Jiang, Guomin Hi, > disabling it can reduce code size in some embedded targets. Could you provide size change after/before this define enabled? Thanks, Yi -----Original Message----- From: Hou, Wenxing <wenxing.hou@intel.com> Sent: Thursday, January 4, 2024 4:34 PM To: devel@edk2.groups.io Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>; Jiang, Guomin <guomin.jiang@intel.com> Subject: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4630 Enable MBEDTLS_NO_UDBL_DIVISION to fix GCC x64 build failure. Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Yi Li <yi1.li@intel.com> Cc: Guomin Jiang <guomin.jiang@intel.com> Signed-off-by: Wenxing Hou <wenxing.hou@intel.com> --- CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h b/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h index ae9ef3a1b380..3068612c0815 100644 --- a/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h +++ b/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h @@ -67,7 +67,7 @@ * example, if double-width division is implemented in software, disabling * it can reduce code size in some embedded targets. */ -// #define MBEDTLS_NO_UDBL_DIVISION +#define MBEDTLS_NO_UDBL_DIVISION /** * \def MBEDTLS_NO_64BIT_MULTIPLICATION -- 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113154): https://edk2.groups.io/g/devel/message/113154 Mute This Topic: https://groups.io/mt/103519146/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls 2024-01-04 8:58 ` Li, Yi @ 2024-01-08 8:22 ` Wenxing Hou 2024-01-08 8:26 ` Li, Yi 0 siblings, 1 reply; 5+ messages in thread From: Wenxing Hou @ 2024-01-08 8:22 UTC (permalink / raw) To: Li, Yi1, devel@edk2.groups.io; +Cc: Yao, Jiewen, Jiang, Guomin Hi, For VS build, the size is same for enable or disable MBEDTLS_NO_UDBL_DIVISION, because the previous code only had GCC build failure. This MACRO doesn't affect the VS build. For GCC build, the previous code didn`t have the size because of the build failure. To compare the size ,I add the dummy API for previous code: tu_int __udivti3 (tu_int a, tu_int b) { return 0;} And the size has very small change(<1kb) for enable or disable MBEDTLS_NO_UDBL_DIVISION. Thanks Wenxing -----Original Message----- From: Li, Yi1 <yi1.li@intel.com> Sent: Thursday, January 4, 2024 4:59 PM To: Hou, Wenxing <wenxing.hou@intel.com>; devel@edk2.groups.io Cc: Yao, Jiewen <jiewen.yao@intel.com>; Jiang, Guomin <guomin.jiang@intel.com> Subject: RE: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls Hi, > disabling it can reduce code size in some embedded targets. Could you provide size change after/before this define enabled? Thanks, Yi -----Original Message----- From: Hou, Wenxing <wenxing.hou@intel.com> Sent: Thursday, January 4, 2024 4:34 PM To: devel@edk2.groups.io Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>; Jiang, Guomin <guomin.jiang@intel.com> Subject: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4630 Enable MBEDTLS_NO_UDBL_DIVISION to fix GCC x64 build failure. Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Yi Li <yi1.li@intel.com> Cc: Guomin Jiang <guomin.jiang@intel.com> Signed-off-by: Wenxing Hou <wenxing.hou@intel.com> --- CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h b/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h index ae9ef3a1b380..3068612c0815 100644 --- a/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h +++ b/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h @@ -67,7 +67,7 @@ * example, if double-width division is implemented in software, disabling * it can reduce code size in some embedded targets. */ -// #define MBEDTLS_NO_UDBL_DIVISION +#define MBEDTLS_NO_UDBL_DIVISION /** * \def MBEDTLS_NO_64BIT_MULTIPLICATION -- 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113370): https://edk2.groups.io/g/devel/message/113370 Mute This Topic: https://groups.io/mt/103519146/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls 2024-01-08 8:22 ` Wenxing Hou @ 2024-01-08 8:26 ` Li, Yi 0 siblings, 0 replies; 5+ messages in thread From: Li, Yi @ 2024-01-08 8:26 UTC (permalink / raw) To: Hou, Wenxing, devel@edk2.groups.io; +Cc: Yao, Jiewen, Jiang, Guomin Sounds good, thank you. Reviewed-by: Yi Li <yi1.li@intel.com> -----Original Message----- From: Hou, Wenxing <wenxing.hou@intel.com> Sent: Monday, January 8, 2024 4:23 PM To: Li, Yi1 <yi1.li@intel.com>; devel@edk2.groups.io Cc: Yao, Jiewen <jiewen.yao@intel.com>; Jiang, Guomin <guomin.jiang@intel.com> Subject: RE: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls Hi, For VS build, the size is same for enable or disable MBEDTLS_NO_UDBL_DIVISION, because the previous code only had GCC build failure. This MACRO doesn't affect the VS build. For GCC build, the previous code didn`t have the size because of the build failure. To compare the size ,I add the dummy API for previous code: tu_int __udivti3 (tu_int a, tu_int b) { return 0;} And the size has very small change(<1kb) for enable or disable MBEDTLS_NO_UDBL_DIVISION. Thanks Wenxing -----Original Message----- From: Li, Yi1 <yi1.li@intel.com> Sent: Thursday, January 4, 2024 4:59 PM To: Hou, Wenxing <wenxing.hou@intel.com>; devel@edk2.groups.io Cc: Yao, Jiewen <jiewen.yao@intel.com>; Jiang, Guomin <guomin.jiang@intel.com> Subject: RE: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls Hi, > disabling it can reduce code size in some embedded targets. Could you provide size change after/before this define enabled? Thanks, Yi -----Original Message----- From: Hou, Wenxing <wenxing.hou@intel.com> Sent: Thursday, January 4, 2024 4:34 PM To: devel@edk2.groups.io Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>; Jiang, Guomin <guomin.jiang@intel.com> Subject: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4630 Enable MBEDTLS_NO_UDBL_DIVISION to fix GCC x64 build failure. Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Yi Li <yi1.li@intel.com> Cc: Guomin Jiang <guomin.jiang@intel.com> Signed-off-by: Wenxing Hou <wenxing.hou@intel.com> --- CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h b/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h index ae9ef3a1b380..3068612c0815 100644 --- a/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h +++ b/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h @@ -67,7 +67,7 @@ * example, if double-width division is implemented in software, disabling * it can reduce code size in some embedded targets. */ -// #define MBEDTLS_NO_UDBL_DIVISION +#define MBEDTLS_NO_UDBL_DIVISION /** * \def MBEDTLS_NO_64BIT_MULTIPLICATION -- 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113371): https://edk2.groups.io/g/devel/message/113371 Mute This Topic: https://groups.io/mt/103519146/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-08 8:26 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-01-04 8:34 [edk2-devel] [PATCH 0/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls Wenxing Hou 2024-01-04 8:34 ` [edk2-devel] [PATCH 1/1] " Wenxing Hou 2024-01-04 8:58 ` Li, Yi 2024-01-08 8:22 ` Wenxing Hou 2024-01-08 8:26 ` Li, Yi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox