From: "Li, Yi" <yi1.li@intel.com>
To: "Hou, Wenxing" <wenxing.hou@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 09/10] CryptoPkg: Add Mbedtls submodule in CI
Date: Mon, 4 Sep 2023 08:46:29 +0000 [thread overview]
Message-ID: <SJ1PR11MB622774D6F414E339F3FA432DC5E9A@SJ1PR11MB6227.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230902141627.3178-10-wenxing.hou@intel.com>
Skip those files in DscCompleteCheck is workaround IMO, I think we can add all mbedtls libraries and components to CryptoPkg.dsc with new CRYPTO_SERVICES.
-----Original Message-----
From: Hou, Wenxing <wenxing.hou@intel.com>
Sent: Saturday, September 2, 2023 10:16 PM
To: devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
Subject: [PATCH v2 09/10] CryptoPkg: Add Mbedtls submodule in CI
Change CI for new Mbedtls submodule.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Yi Li <yi1.li@intel.com>
Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Signed-off-by: Wenxing Hou <wenxing.hou@intel.com>
---
.pytool/CISettings.py | 2 ++
CryptoPkg/CryptoPkg.ci.yaml | 66 +++++++++++++++++++++++++++++++++++--
2 files changed, 65 insertions(+), 3 deletions(-)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index 6fb7342f81..c5803a877c 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -199,6 +199,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
"MdePkg/Library/BaseFdtLib/libfdt", False)) rs.append(RequiredSubmodule( "MdePkg/Library/MipiSysTLib/mipisyst", False))+ rs.append(RequiredSubmodule(+ "CryptoPkg/Library/MbedTlsLib/mbedtls", False)) return rs def GetName(self):diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
index 59ba56d41e..204b97f470 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -41,7 +41,14 @@
# These directories contain auto-generated OpenSSL content "Library/OpensslLib", "Library/IntrinsicLib",- "Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c"+ "Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c",+ # mbedtls+ "Library/MbedTlsLib/mbedtls",+ # This has mbedtls interfaces that aren't UEFI spec compliant+ "Library/MbedTlsLib/EcSm2Null.c",+ "Library/MbedTlsLib/CrtWrapper.c",+ "Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h",+ "Library/BaseCryptLibMbedTls/SysCall" ] }, "CompilerPlugin": {@@ -68,7 +75,16 @@
}, "DscCompleteCheck": { "DscPath": "CryptoPkg.dsc",- "IgnoreInf": []+ "IgnoreInf": [+ "CryptoPkg/Library/BaseCryptLibMbedTls/BaseCryptLib.inf",+ "CryptoPkg/Library/BaseCryptLibMbedTls/PeiCryptLib.inf",+ "CryptoPkg/Library/BaseCryptLibMbedTls/RuntimeCryptLib.inf",+ "CryptoPkg/Library/BaseCryptLibMbedTls/SecCryptLib.inf",+ "CryptoPkg/Library/BaseCryptLibMbedTls/SmmCryptLib.inf",+ "CryptoPkg/Library/BaseCryptLibMbedTls/TestBaseCryptLib.inf",+ "CryptoPkg/Library/MbedTlsLib/MbedTlsLib.inf",+ "CryptoPkg/Library/MbedTlsLib/MbedTlsLibFull.inf"+ ] }, "GuidCheck": { "IgnoreGuidName": [],@@ -76,7 +92,51 @@
"IgnoreFoldersAndFiles": [] }, "LibraryClassCheck": {- "IgnoreHeaderFile": []+ "IgnoreHeaderFile": [+ "Library/MbedTlsLib/mbedtls/Library/aesni.h",+ "Library/MbedTlsLib/mbedtls/Library/bignum_core.h",+ "Library/MbedTlsLib/mbedtls/Library/bignum_mod.h",+ "Library/MbedTlsLib/mbedtls/Library/bignum_mod_raw.h",+ "Library/MbedTlsLib/mbedtls/Library/bn_mul.h",+ "Library/MbedTlsLib/mbedtls/Library/check_crypto_config.h",+ "Library/MbedTlsLib/mbedtls/Library/cipher_wrap.h",+ "Library/MbedTlsLib/mbedtls/Library/common.h",+ "Library/MbedTlsLib/mbedtls/Library/constant_time_internal.h",+ "Library/MbedTlsLib/mbedtls/Library/constant_time_invasive.h",+ "Library/MbedTlsLib/mbedtls/Library/ecp_internal_alt.h",+ "Library/MbedTlsLib/mbedtls/Library/ecp_invasive.h",+ "Library/MbedTlsLib/mbedtls/Library/entropy_poll.h",+ "Library/MbedTlsLib/mbedtls/Library/hash_info.h",+ "Library/MbedTlsLib/mbedtls/Library/lmots.h",+ "Library/MbedTlsLib/mbedtls/Library/md_wrap.h",+ "Library/MbedTlsLib/mbedtls/Library/mps_common.h",+ "Library/MbedTlsLib/mbedtls/Library/mps_error.h",+ "Library/MbedTlsLib/mbedtls/Library/mps_reader.h",+ "Library/MbedTlsLib/mbedtls/Library/mps_trace.h",+ "Library/MbedTlsLib/mbedtls/Library/padlock.h",+ "Library/MbedTlsLib/mbedtls/Library/pkwrite.h",+ "Library/MbedTlsLib/mbedtls/Library/pk_wrap.h",+ "Library/MbedTlsLib/mbedtls/Library/psa_crypto_aead.h",+ "Library/MbedTlsLib/mbedtls/Library/psa_crypto_cipher.h",+ "Library/MbedTlsLib/mbedtls/Library/psa_crypto_driver_wrappers.h",+ "Library/MbedTlsLib/mbedtls/Library/psa_crypto_ecp.h",+ "Library/MbedTlsLib/mbedtls/Library/psa_crypto_hash.h",+ "Library/MbedTlsLib/mbedtls/Library/psa_crypto_invasive.h",+ "Library/MbedTlsLib/mbedtls/Library/psa_crypto_its.h",+ "Library/MbedTlsLib/mbedtls/Library/psa_crypto_mac.h",+ "Library/MbedTlsLib/mbedtls/Library/psa_crypto_random_impl.h",+ "Library/MbedTlsLib/mbedtls/Library/psa_crypto_core.h",+ "Library/MbedTlsLib/mbedtls/Library/psa_crypto_rsa.h",+ "Library/MbedTlsLib/mbedtls/Library/psa_crypto_se.h",+ "Library/MbedTlsLib/mbedtls/Library/psa_crypto_slot_management.h",+ "Library/MbedTlsLib/mbedtls/Library/psa_crypto_storage.h",+ "Library/MbedTlsLib/mbedtls/Library/rsa_alt_helpers.h",+ "Library/MbedTlsLib/mbedtls/Library/ssl_client.h",+ "Library/MbedTlsLib/mbedtls/Library/ssl_debug_helpers.h",+ "Library/MbedTlsLib/mbedtls/Library/ssl_misc.h",+ "Library/MbedTlsLib/mbedtls/Library/ssl_tls13_invasive.h",+ "Library/MbedTlsLib/mbedtls/Library/ssl_tls13_keys.h"+ ] }, ## options defined ci/Plugin/SpellCheck--
2.26.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108255): https://edk2.groups.io/g/devel/message/108255
Mute This Topic: https://groups.io/mt/101114034/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-09-04 8:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 14:16 [edk2-devel] [PATCH v2 00/10] Add HMAC/HKDF/RSA/HASH features based on Mbedtls Wenxing Hou
2023-09-02 14:16 ` [edk2-devel] [PATCH v2 01/10] CryptoPkg: Add mbedtls submodule for EDKII Wenxing Hou
2023-09-02 14:16 ` [edk2-devel] [PATCH v2 02/10] CryptoPkg: Add mbedtls_config and MbedTlsLib.inf Wenxing Hou
2023-09-02 14:16 ` [edk2-devel] [PATCH v2 03/10] CryptoPkg: Add HMAC functions based on Mbedtls Wenxing Hou
2023-09-02 14:16 ` [edk2-devel] [PATCH v2 04/10] CryptoPkg: Add HKDF " Wenxing Hou
2023-09-02 14:16 ` [edk2-devel] [PATCH v2 05/10] CryptoPkg: Add RSA " Wenxing Hou
2023-09-04 8:43 ` Li, Yi
2023-09-02 14:16 ` [edk2-devel] [PATCH v2 06/10] CryptoPkg: Add all .inf files for BaseCryptLibMbedTls Wenxing Hou
2023-09-02 14:16 ` [edk2-devel] [PATCH v2 07/10] CryptoPkg: Add Null functions for building pass Wenxing Hou
2023-09-02 14:16 ` [edk2-devel] [PATCH v2 08/10] CryptoPkg: Add MD5/SHA1/SHA2 functions based on Mbedtls Wenxing Hou
2023-09-02 14:16 ` [edk2-devel] [PATCH v2 09/10] CryptoPkg: Add Mbedtls submodule in CI Wenxing Hou
2023-09-04 8:46 ` Li, Yi [this message]
2023-09-02 14:16 ` [edk2-devel] [PATCH v2 10/10] CryptoPkg: Add basic Readme for BaseCryptLibMbedTls Wenxing Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ1PR11MB622774D6F414E339F3FA432DC5E9A@SJ1PR11MB6227.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox