From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id D44FEAC0E1A for ; Mon, 22 Apr 2024 07:53:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=aNR3OCyuAH8vobJi2Dwhu5CP3TiyRggcJqbJKLdvNiU=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713772413; v=1; b=gUZTm2ahYAENgR53irAKHJXZHgMqTXQYdlquJf/DrcbzIHKvrN+ecBY5r/lYi55ltoEF6gpw YZ2mTEcymD+rt3fJIs/s2Rn4iTzE0CkTH3rXoY5PnksufwLK7cn39cg5svZVA863wBBwh/eQDlo 4MEPjT0asLZ8m5ccUzbgEACqguPkVZAnMIuyjUCFugyyO1C1GKI40NFKpWj/OuNMOU/Kq5kYdxk Wk6FZ3fdNZjReMLbWmmj8iYg6JH3apbRw2uT81pRPxU1yKUumYtU3BgF87yKIRX4AFPzPJ5YLQR TEM2vYLg4LxAnO05xKAfFT2S0JU5Dw/qRPxePo/syTxGw== X-Received: by 127.0.0.2 with SMTP id ZOMFYY7687511xRpVpX7xki9; Mon, 22 Apr 2024 00:53:33 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mx.groups.io with SMTP id smtpd.web10.13135.1713772412651432487 for ; Mon, 22 Apr 2024 00:53:32 -0700 X-CSE-ConnectionGUID: Dj/y4QwBQJCOFsjXvnVZTg== X-CSE-MsgGUID: PEC75rmjR/eiPHBamhTYbg== X-IronPort-AV: E=McAfee;i="6600,9927,11051"; a="19850320" X-IronPort-AV: E=Sophos;i="6.07,220,1708416000"; d="scan'208";a="19850320" X-Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 00:53:32 -0700 X-CSE-ConnectionGUID: oB7++dXyQNKI4x4j8zCkdQ== X-CSE-MsgGUID: fMswXC3jSIqqC8oDyywXcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,220,1708416000"; d="scan'208";a="28605327" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Apr 2024 00:53:32 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 22 Apr 2024 00:53:31 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 22 Apr 2024 00:53:31 -0700 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 22 Apr 2024 00:53:30 -0700 X-Received: from SJ1PR11MB6227.namprd11.prod.outlook.com (2603:10b6:a03:45a::10) by SA1PR11MB5780.namprd11.prod.outlook.com (2603:10b6:806:233::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.19; Mon, 22 Apr 2024 07:53:28 +0000 X-Received: from SJ1PR11MB6227.namprd11.prod.outlook.com ([fe80::301:5dbd:207b:5578]) by SJ1PR11MB6227.namprd11.prod.outlook.com ([fe80::301:5dbd:207b:5578%4]) with mapi id 15.20.7519.018; Mon, 22 Apr 2024 07:53:28 +0000 From: "Li, Yi" To: "Hou, Wenxing" , "devel@edk2.groups.io" CC: "Yao, Jiewen" Subject: Re: [edk2-devel] [PATCH 0/9] Add more crypt APIs based on Mbedtls Thread-Topic: [PATCH 0/9] Add more crypt APIs based on Mbedtls Thread-Index: AQHaj9LqLzqztbja+kOOxF4mZvrpe7Fz9IIg Date: Mon, 22 Apr 2024 07:53:28 +0000 Message-ID: References: <20240416075118.4799-1-wenxing.hou@intel.com> In-Reply-To: <20240416075118.4799-1-wenxing.hou@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ1PR11MB6227:EE_|SA1PR11MB5780:EE_ x-ms-office365-filtering-correlation-id: 32ea48d5-4e03-435c-149a-08dc62a14c16 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?LEF8Tt3xAHWlJenvJJnVj4PvF0VmsVofHKK7j6XXtezrvbiwf3+Q4NlKji8K?= =?us-ascii?Q?rMbGG4O2smRmATz2awBZRu+PC11xfR3jEENpoSc2b+U22iO5H4uIKViEgPcK?= =?us-ascii?Q?yj1jOMai7PHuu9OzS5u5Q+lbFix/Q/+rwkVh0N+QyJW893pXk/KMJcPHgOMI?= =?us-ascii?Q?sK+rMybiPDc8DPIeX+UXl9gQpff51z5zFVIXUEL1BzRqaZHJYasRfJr01/2B?= =?us-ascii?Q?+y8UEmmVTeBw2tZXISmCBF2ErZoYP0xO6Wtsq1J32CXGMwRsVoBkZuI58Zty?= =?us-ascii?Q?EQ7pbKXeQYzFNUBNegTpwfCaRhHhE4a6ULEXgRYlZV7qp3Os4A3utC8ovEGY?= =?us-ascii?Q?eSriorpIpv/B07D+UppOdIWM3ITX5BnuXi5MOj0sRpzpaLkiQGSBwNaveFwH?= =?us-ascii?Q?dHsnyfoJ5fP1phJ7z5elMUXoG+2Ia4Om8XoMmq+7RaC+hztHVdECBrVhEG19?= =?us-ascii?Q?2Ok1vvaYNZxJF8gHRwoVpe8B68VexYuwMPsFsBK3J/XB6+Hly3M2veeWVmQG?= =?us-ascii?Q?V18i/9HdJ87NeCRMxaJjryHiVoC0Tpx4eTUcc4ebH1mLIDAZCQTHlKoDuj93?= =?us-ascii?Q?yqg6/cPOmPVNfMtaeYRdEB7WqCwfTz2MVJuF5YFuSjTvN9A64hEgXgtWTNCu?= =?us-ascii?Q?0faZrcE3X0Kz+UKasZ/ueLWb5L16deGanmb5tlXDW28QuJ2n1+daLqIfpYg8?= =?us-ascii?Q?DMV2r/xxFtoG9FwN6Py9PiZ3iS9WVTihPk6sN/6Je1uSUBVzyfTA03qExRXS?= =?us-ascii?Q?Cm97hMLuSDRb3VH5d969k7T5ygxFUxKbpEbBh77VTNvMD1mwUZYs5hECwOu0?= =?us-ascii?Q?Mb1QzJxIieCVsHq+yC4ZY86J3eA15sDedW9kA1y50nYzeWqtUJ4m1amIh8XZ?= =?us-ascii?Q?6wVCKfgox2bVlkfKfEfL37k6ExN19BF9HvIFYGfTSkJj1U88BIY3xxCFPjuG?= =?us-ascii?Q?TfcE0CUvkbnrnfRyt3cPPHGcpF4RpmMjYhruJcHXQVbyLOViIz4ss4XKZ87E?= =?us-ascii?Q?+nZWk5SpQ+3p5AdMhDts5zMIxFDdJ2sl6QndoJOzCXra693+e6tQXOs8wUhD?= =?us-ascii?Q?XHfrFmqHtgrcoeWbQFdXLJ07dhN3xPfXDbinQq4NzerCbEL8GAvUxh9RKloq?= =?us-ascii?Q?C7fkw3QJsLL6r26XpJHMhf5lWykvMn5dQzBnJZBPWK3x8l4HG70oyd8vuWex?= =?us-ascii?Q?OjD1ilEjAIB+C5/H0tiuPq9o50ybPP9vsoNulhIV/arTXbHaSdYCyqDb/2Lq?= =?us-ascii?Q?iEOIf5w8Ch/GfAWJtlazaoR+rfbIYwVzxtQt9pA1Bg=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MrvcV6EQYuFJTT2oySF2sUMKW6H6u2+4oFWNB7EzVWqxgj/8tVO+HaaEdjmF?= =?us-ascii?Q?7DhU8eP5mlqhtKpCg1EOYjTmQehIEv0UKGSoGSJWliLOX4ML6pW2CEmfmMoc?= =?us-ascii?Q?13vKpPlfaNXSy8wgIKqU4FAxKm3wBtYp5ydLrCQEa+iFEvanFfUUv9GOYF+a?= =?us-ascii?Q?PLmXM+bpbGadj8jxMAUuLf6UV9y3pW0g8+TGjyz+CxMvDFh4hkGTeCrSchDJ?= =?us-ascii?Q?uGc++NWN3zIQy0BS2jCnMLdHXcmk75fqxESuT8ffxRn2psPTGMQ8qvyXOMJx?= =?us-ascii?Q?MUO0qPeWwl0gk3tZLrpwhXZ5x5Vm7dsDbOuD6SRIl8ZwTUQXAUxAbDVtgfbR?= =?us-ascii?Q?aZOtN0gjdLDTeqC0yOPhd6nqlM5UAW1+jLnIJkO87Ik4L81RCYBX6jefFOxn?= =?us-ascii?Q?VEty5O+Xvkpv48lp8hAroYwHsKijD7zZlzIWA7UqXjYwCnIpUk2RAW2D3yRY?= =?us-ascii?Q?g3xVl0DOH5SxT6inm+YktUjJqHOhDSu4m5MBvOPRZvG5CaivMVI5ann2hOrE?= =?us-ascii?Q?RJXB+efk9GNLdsAQRhwi7b7E75CmcvTPbJvRFSQKRHF0rEPbO0aHLglJlj3Z?= =?us-ascii?Q?iSH1AavPeefCr9gylrNk5mxD7WR+yPk4k/DwicZngW/bou+FXZwBUZu9bZEc?= =?us-ascii?Q?mbKcysQLBYzDEJXUraGdUA1H3QTpaEzJ9hgb0r2hmC0rxVw1Cfjox0WQkugN?= =?us-ascii?Q?Zv+QaQMHIKyaBD588boYW/DRb1VGi4gVysa/nlDNcAI/yhNS2UgUKRHR4WmI?= =?us-ascii?Q?9j+OF/pNunFzfsEvuTXLZChJ2wJEDe3Cn2iw9PuevXEKaUi/coaXqkDz08XQ?= =?us-ascii?Q?ecebeaKjmVvrlcBjZrXYV3TvxZUxeGgNVQfAqXxtzEyzLaY3dQJLI6QhYv9v?= =?us-ascii?Q?n/mt9Kxqd2vheAXWeXYRpPpygWT7VliaUi0BYHr3ruvV4aDoMZ55qzd610Gx?= =?us-ascii?Q?MxlVzKbjg1+Zg0zycPl9qmTRZHAtVasaZSmZvKGThC6brGVxyYfffav+s1j+?= =?us-ascii?Q?Got9Qj4Oht9oeuWy3PSiICC+v6qNP5x3v+qYKuGJjSfWdPTRA6fZYyjBmZyw?= =?us-ascii?Q?FONcICy9cbf/ENBdJm5eq7M702fLpb/4xAojkjpKA6SIMFf+LrNHcuaCCgtq?= =?us-ascii?Q?F8jyF7PHSW05rzY6HMPxDLyIBRhyY8F3nsz36Guh7KjSYSmLKAQBdnsgnA2J?= =?us-ascii?Q?4P17k4RdWuUnaEOcpVwnuvfNenpd1lFHrtfBPPWyIrA3+anFtNZ5GXR3ncII?= =?us-ascii?Q?REa4t8mEHbj1EkIOpXBCB/FgH3jXxr7rNO9i9BRWqnfUyynKXXFeyhpd9tjl?= =?us-ascii?Q?vPMcXGmruvg1K7jNRa8a+uaJK7Ynp/fGeUR1+mw12IAR5d/EVbyAz2kOpZWl?= =?us-ascii?Q?B//PqhkzFEAIWZtGuPqLMKdJl93x26Pl6q19EJJiAWah7NMnWuid+CWWs/hf?= =?us-ascii?Q?B5AY08Q+paCh8rbFvbSSHn68Z0C0RmQPAVpUtxiG2U9ZX/FJiwmZlSCR2xeJ?= =?us-ascii?Q?KNSXQvbzMsDHsHcFbL2iIOUdKWZLMj9zFl81WWSr6ywIz0JWOcXjj7NNF8Uu?= =?us-ascii?Q?sc+8euEaRr5qI/j8BQI=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6227.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32ea48d5-4e03-435c-149a-08dc62a14c16 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2024 07:53:28.5168 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xgPHj6QdIhbIoXFQjRMYfPiYA5lvxLz4PLq/S/dmh5s5n3IFp/qgBwA52+svgqCmA3FTj11dzFmshvvZUwVF9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5780 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 22 Apr 2024 00:53:32 -0700 Resent-From: yi1.li@intel.com Reply-To: devel@edk2.groups.io,yi1.li@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lIURJXUP1P2jRjbV4q0UpFvpx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=gUZTm2ah; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io I found some magic number and format issues, please check comments in your = PR. Regards, Yi -----Original Message----- From: Hou, Wenxing =20 Sent: Tuesday, April 16, 2024 3:51 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Li, Yi1 Subject: [PATCH 0/9] Add more crypt APIs based on Mbedtls REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4177 Add AeadAesGcm/Pem(only RSA)/X509(only RSA)/More RSA/PKCS5 /pKCS7/Authentic= ode/Timestamp implementation based on Mbedtls. The patch has passed the EDKII CI check: https://github.com/tianocore/edk2/pull/5552 And the patch has passed unit_test in EDKII and integration test for platfo= rm. And the patch hass passed the fuzz test: https://github.com/tianocore/edk2-staging/commit/4f19398053c92e4f7791d468a1= 84530b6ab89128 Cc: Jiewen Yao Cc: Yi Li Signed-off-by: Wenxing Hou Wenxing Hou (9): CryptoPkg: Add AeadAesGcm based on Mbedtls CryptoPkg: Add rand function for BaseCryptLibMbedTls CryptoPkg: Add Pem APIs based on Mbedtls CryptoPkg: Add X509 functions based on Mbedtls CryptoPkg: Add Pkcs7 related functions based on Mbedtls CryptoPkg: Add Pkcs5 functions based on Mbedtls CryptoPkg: Add more RSA related functions based on Mbedtls CryptoPkg: Add AuthenticodeVerify based on Mbedtls CryptoPkg: Add ImageTimestampVerify based on Mbedtls CryptoPkg/CryptoPkg.ci.yaml | 1 + .../Cipher/CryptAeadAesGcm.c | 227 ++ .../BaseCryptLibMbedTls/InternalCryptLib.h | 49 + .../BaseCryptLibMbedTls/Pem/CryptPem.c | 138 ++ .../Pk/CryptAuthenticode.c | 214 ++ .../BaseCryptLibMbedTls/Pk/CryptPkcs1Oaep.c | 278 +++ .../BaseCryptLibMbedTls/Pk/CryptPkcs5Pbkdf2.c | 100 + .../Pk/CryptPkcs7Internal.h | 20 +- .../BaseCryptLibMbedTls/Pk/CryptPkcs7Sign.c | 615 ++++++ .../Pk/CryptPkcs7VerifyBase.c | 113 + .../Pk/CryptPkcs7VerifyCommon.c | 1315 +++++++++++ .../Pk/CryptPkcs7VerifyEku.c | 689 ++++++ .../BaseCryptLibMbedTls/Pk/CryptRsaExt.c | 346 +++ .../BaseCryptLibMbedTls/Pk/CryptRsaPssSign.c | 137 ++ .../Library/BaseC= ryptLibMbedTls/Pk/CryptTs.c | 381 ++++ .../BaseCryptLibMbedTls/Pk/CryptX509.c | 1924 +++++++++++++++++ .../BaseCryptLibMbedTls/Rand/CryptRand.c | 105 + .../BaseCryptLibMbedTls/Rand/CryptRandTsc.c | 105 + 18 files changed, 6745 insertions(+), 12 deletions(-) create mode 100644 = CryptoPkg/Library/BaseCryptLibMbedTls/Cipher/CryptAeadAesGcm.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pem/CryptPem.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptAuthentic= ode.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs1Oaep= .c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs5Pbkd= f2.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs7Sign= .c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs7Veri= fyBase.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs7Veri= fyCommon.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptPkcs7Veri= fyEku.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaExt.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaPssSig= n.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptTs.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptX509.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Rand/CryptRand.c create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Rand/CryptRandTsc= .c -- 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118073): https://edk2.groups.io/g/devel/message/118073 Mute This Topic: https://groups.io/mt/105552830/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-