From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.77.43]) by mx.groups.io with SMTP id smtpd.web10.3887.1592960690110079019 for ; Tue, 23 Jun 2020 18:04:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=l2eW2E5r; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.77.43, mailfrom: garrett.kirkendall@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cuU8kz87+/Z2LOCBVguwOY5ctP/awum/1xoTY9Sk0wbi75QMsJ/yFfpdK+sNiRS+zzTpZE6CdQz+djWQpbL37eRcH6sfj+YjI9jaG+r6V7Nk9gbq4L1tDgIfofIAvRGHIJbnrTplQC75+pZt/2sNt/sJCM+tFzzHJDgeGAyfgw1OcTiFmrGYTeOM3Ry2IotAiutNa19ueYR+Xbz1nyeB8aRJ+TLCvo7yKXWB6URlrNTbvl8NSmFrYqKtAQNBeLGwGMMzYYX/Tri7kUC2c8p53uI6/n9TAJn+HvTjs6gl1b0c5nrJeCIGwCdjHxeCBNp4BwQVW0gTv90f3PKcDQ09Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mpyEQAilNReQrSJkiBXrYytqkyQ3agC/Mn/aYBkY1Og=; b=honQyZNWSnUWtVR9VRRUH1Hoi5mTiVsfXqbQAzNo1XlknUFJWjsLYpQWXVaWyaJxhaqSzbSBeAIA79hpTFHgueapILaWmdQisn8X1Ftxg7BO73Yoi3JdShBygg6c2++fw7m+ijKaVyFDPo7Oc9+UeJa+UcAcVrDMFsqsy5fYxos4TNldWBgl8gRDQ1uJrb+BMtfYwr002gE0mX614r1VytsmvpKhdJ+ENc1IT0+6zvhAW4pCHq1Qn59AIjoJ2O7Pyae8L4eGNqBYvfCnI16RUw7/y3fQFcTNkMSQOqGZnn+MtxlyCoYlos94yMT0q3rTGelQ+7rm/ynLIjYYBNkcow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mpyEQAilNReQrSJkiBXrYytqkyQ3agC/Mn/aYBkY1Og=; b=l2eW2E5rn20g0jEX60Vo+uJ+aOvZeyXcSs4jeowIfjanTQhiV6NrFqc8q5pd3ZjmVVdhMkDHz4+kbSRYBOfC2MaP6XlqBmcIa95v0557+yyobBAdWjb01jbfmxLiKoFj2cd02HA5FQqohQOS4Qa1/vy8qAxnMqTfhyy9j6w2yR8= Received: from SN1PR12MB2352.namprd12.prod.outlook.com (2603:10b6:802:25::13) by SN6PR12MB2848.namprd12.prod.outlook.com (2603:10b6:805:77::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Wed, 24 Jun 2020 01:04:48 +0000 Received: from SN1PR12MB2352.namprd12.prod.outlook.com ([fe80::156e:ce6d:a148:274e]) by SN1PR12MB2352.namprd12.prod.outlook.com ([fe80::156e:ce6d:a148:274e%7]) with mapi id 15.20.3109.027; Wed, 24 Jun 2020 01:04:48 +0000 From: "Kirkendall, Garrett" To: "devel@edk2.groups.io" , "Kirkendall, Garrett" CC: Eric Dong , Ray Ni , Laszlo Ersek , Hao A Wu Subject: Re: [edk2-devel] [PATCH v6 0/4] AMD processor MSR_IA32_MISC_ENABLE Thread-Topic: [edk2-devel] [PATCH v6 0/4] AMD processor MSR_IA32_MISC_ENABLE Thread-Index: AQHWSJekxMdsygvTLkyLWCPP4pSk2ajm9bcg Date: Wed, 24 Jun 2020 01:04:48 +0000 Message-ID: References: <20200622131825.1352-1-Garrett.Kirkendall@amd.com> In-Reply-To: <20200622131825.1352-1-Garrett.Kirkendall@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2020-06-24T01:04:44Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=f62bc193-dbba-472b-bb01-315cb3884c9c; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; x-originating-ip: [76.164.77.151] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4ccf514d-8d2a-4553-5d59-08d817da97a4 x-ms-traffictypediagnostic: SN6PR12MB2848: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0444EB1997 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iFEDwv4melr+IY8rvbH7ZB0U4ye7a81l73Mc5SPrj0FULrTLAltBD3h/YTNUR4xyIerJWXykyZVqD/CnsiqdRmvVIquL1X+OFnxWGSuVz5crQp/m2ARVHe5rDJSikvip2QCaHqc0iOhT3c0XepWKwXtZnmXSl3pErl2rpcE2uvoe0TKRWoTLSLuA8XGvJ8wDSnJQSqyDy5zCrgpHkS2qzD6Xhsxbjm73CpGsmm06WbqjfRxA53iQBytF/Hny4fa8d/501gb0IWrGv6GCDdpOP9UljAhz0Bbxi+THzg/eGTFH6lTOx1N2sCZKJLU07zxKs0JqH2C11eT3PgRlVbVXc4PqAnZ7rUvLG1pYFZk19tuPkdgVylfGleE9nB5aY9yA6EVeV0wvH9mM0cdLWGggHA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN1PR12MB2352.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(376002)(366004)(346002)(39850400004)(8936002)(8676002)(9686003)(55016002)(2906002)(4326008)(5660300002)(86362001)(52536014)(33656002)(83380400001)(71200400001)(6506007)(966005)(54906003)(186003)(26005)(53546011)(66476007)(45080400002)(66946007)(76116006)(316002)(64756008)(66446008)(478600001)(7696005)(66556008)(19627235002)(110136005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: EpYlqSSGwhPqBdjYJY+aiReiws/H0Dj+0lUmqYcsZkXXWngGo7iS/5PmOQONkUbqWeYalxz0hke4GBT5I6shzIsOQ3rL0HohwJG7e2GQe8i+cBGltbXgRMfeFBZGizMdI8+wG7EPQKhTncnkR4dOtj5D/CE0Mwr9BTPZCKYNQCdUpJVRyIigt/53vn48qEkb3GnsV75wfqBqTq5a8dJ+9FWCYlAS5lH66WwrH43rlFAWhLy85sRuilMW3XIweDicXEt8zuvJa5mXLK/IfopiO1PfE2T2hCs/T5mYBUCx5vciOPPinrQQy3/d+80mR1Pgewza8L4Wd/irPtNVIEDnaRjVxLOueoMT6x2PIeNZfdotXgKb+VxqZdJGTSC+Tli/8RE7/lOVjckJ9/stuDT6gtptKIUUjtTmmh4VtHUm+hkH2FiCKvT1gHfu5nMYMLNOAi9LLQVws7KAwuZq1poGMcoEOEVt/IJR1NJTSNQbzyo= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ccf514d-8d2a-4553-5d59-08d817da97a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2020 01:04:48.6296 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r8hChlWXvToIrek51MgCYCYNmR7sMiECgPPthbKiDzFmCjzZvO/V1obIGycpayP+VOJ/wkpTGDJadnaDuFvBcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2848 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable [AMD Public Use] Is there anything else needed from me for this patch at this time? GARRETT KIRKENDALL SMTS Firmware Engineer | CTE 7171 Southwest Parkway, Austin, TX 78735 USA=20 AMD=A0=A0 facebook=A0 |=A0 amd.com -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kirkendall,= Garrett via groups.io Sent: Monday, June 22, 2020 8:18 AM To: devel@edk2.groups.io Cc: Eric Dong ; Ray Ni ; Laszlo Ers= ek ; Hao A Wu Subject: [edk2-devel] [PATCH v6 0/4] AMD processor MSR_IA32_MISC_ENABLE [CAUTION: External Email] AMD processor does not support MSR_IA32_MISC_ENABLE register. Accessing t= his register on AMD causes an unhandled exception in SmmEntry.nasm and a su= bsequent failure to boot since this is too early in SMM path for the except= ion handler to be loaded. 1. Prepare PcAtChipsetPkg/PcAtChipsetPkg.dsc to move StandardSignatureIsAu= thenticAMD into UefiCpuLib LibraryClass BaseUefiCpuLib in UefiCpuPkg. 2. To distinguish between AMD and other processors, refactor StandardSigna= tureIsAuthenticAMD into BaseUefiCpuLib. So there is only one copy in the s= ource. 3. Skip manipulation of MSR_IA32_MISC_ENABLE register if running on an AMD= processor. Tested on AMD X64 hardware. OvmfIa32 and OvmfIa32X64 on Intel hardware. v1: Move StandardSignatureIsAuthenticAMD. Handle MSR_IA32_MISC_ENABLE v2: Incorporate Laszlo's feedback v3: Typo, not sent v4: Patch in to add UefiCpuLib to PcAtChipsetPkg.dsc v5: Patch in to add UefiCpuLib to SourceLevelDebugPkg.dsc v6: Hopefully reformat patch when sending???? Garrett Kirkendall (4): PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass SourceLevelDebugPkg: SourceLevelDebugPkg.dsc add UefiCpuLib LibraryClass UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD PcAtChipsetPkg/PcAtChipsetPkg.dsc | 2 ++ SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 2 ++ UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf | 7 ++++ UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf | 2 ++ UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf | 2 ++ UefiCpuPkg/Include/Library/UefiCpuLib.h | 14 +++++++= + UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h | 3 ++ UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c | 38 +++++++= +++++++++++++ UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 25 ++-----= ------ UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 25 ++-----= ------ UefiCpuPkg/Library/MpInitLib/MpLib.c | 23 -------= ----- UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 9 ++++- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 19 +++++++= +-- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 20 +++++++= ++-- 14 files changed, 117 insertions(+), 74 deletions(-) create mode 100644 = UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c Changes at: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub= .com%2Fgkirkendall-amd%2Fedk2%2Ftree%2Fsmmentry_nasm_skip_msr_xd_bit_on_amd= _v6&data=3D02%7C01%7Cgarrett.kirkendall%40amd.com%7C5b2918ff7a2345a5ce7= f08d816af8e23%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6372842905535488= 04&sdata=3DF9ktro2rmOouJYui4jqTFK25TK6l1HBl317RW41QDM4%3D&reserved= =3D0 Pull Request: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub= .com%2Ftianocore%2Fedk2%2Fpull%2F716&data=3D02%7C01%7Cgarrett.kirkendal= l%40amd.com%7C5b2918ff7a2345a5ce7f08d816af8e23%7C3dd8961fe4884e608e11a82d99= 4e183d%7C0%7C0%7C637284290553548804&sdata=3DFcHQc%2BzJHMAJfSWc9z%2FZ4Bx= h5Ur4EnM%2BaIurKJ0iNYU%3D&reserved=3D0 Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Hao A Wu Signed-off-by: Garrett Kirkendall -- 2.27.0