From: "Kirkendall, Garrett" <garrett.kirkendall@amd.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Eric Dong <eric.dong@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib
Date: Wed, 10 Jun 2020 14:17:40 +0000 [thread overview]
Message-ID: <SN1PR12MB2352CABC4895DA115F4B56D785830@SN1PR12MB2352.namprd12.prod.outlook.com> (raw)
[AMD Public Use]
There are currently three instances of StandardSignatureIsAuthenticAMD Function in the below locations. I need to propose another change that will require the same function in PiSmmCpuDxeSmm. I would like to see this function move to a single "LibraryClass" location. I think no one knew where to propose the function, so we ended up with three instances so far. The best place I can find would be UefiCpuPkg/BaseUefiCpuLib/. Thoughts? Is there a better function name such that a similar Intel identifier function could be created when needed in the future?
I'm thinking this will be 3 patches
1. Add StandardSignatureIsAuthenticAMD to BaseUefiCpuLib
2. Move current instances to Library function
3. Propose code change in PiSmmCpuDxeSmm
UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c: StandardSignatureIsAuthenticAMD (
UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c: StandardSignatureIsAuthenticAMD (
UefiCpuPkg/Library/MpInitLib/MpLib.c: StandardSignatureIsAuthenticAMD (
GARRETT KIRKENDALL
SMTS Firmware Engineer | CTE
7171 Southwest Parkway, Austin, TX 78735 USA
AMD facebook | amd.com
next reply other threads:[~2020-06-10 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 14:17 Kirkendall, Garrett [this message]
2020-06-11 1:11 ` UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib Ni, Ray
2020-06-11 1:29 ` Dong, Eric
2020-06-11 4:56 ` Ni, Ray
2020-06-11 7:07 ` Dong, Eric
2020-06-11 14:16 ` Laszlo Ersek
2020-06-12 7:59 ` Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN1PR12MB2352CABC4895DA115F4B56D785830@SN1PR12MB2352.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox