From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.75]) by mx.groups.io with SMTP id smtpd.web12.11902.1591798662480599001 for ; Wed, 10 Jun 2020 07:17:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=UIKmf95y; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.243.75, mailfrom: garrett.kirkendall@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XsjeQCqrzUY6AXj4/j0DgrSrOPGj4jWI/X+xweWVs12IOMjN/xmhGdLRGnIVqXE5Usnw05M3mN6hpjC4XiqYcaVYdPzzMi/UzxsKMwzagg0P3nVso6kvc6Elsc1awbocsrDuqhX/hRWpiMoaslmSbRYTLog1PQPSSGYlQ9wlxJqZutWS/22cxYZ+Z6MXnTlbjrmppZoFcJjmg2wDQ1KvMXksSaj/vDEQ1ngvu0vAp+DEsNynz7OIPf8qnNzqwgRi4Mec6MB+890I/+r++trU4tKiqwOat6zFykJ2TSVzpht5vgxnKy8WBOB+J7iQyVbhbKKe8KfUWEZJf5MIzzbI4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=owufR0E/0gODrlWX3vG0g4xNpQSFHFyym/S8fltWQXw=; b=Yg+13abnGpkRVnPplxw6iTApa8o5R98noKNK7g0r49e7XKE0WlIV0BSs5OWNDWaEf9MjVjVdcBEDVV5lwQlRZFAit1VJ9TTzTvtzWPE3cKLr0r1VQDma16lL5RkphQfq1oYFvYwLMFOe1kN3/2kBR9/4t8qKdFexFSEsN9nApw4Nl90b+AxJhJuSupMgA34hzpytBxQjIxlP+Bbdnd5sodrJ1AGz0X/zIvPM0QwVv1NWLsgSmHVLS627A2JDHWKKh8NmpvVPJlT7qcTnchhFa0a4YKRyMAkMjeOje4AiuZ9IIi4N39fq7G5XMyrrWkkukegX6Z03Wguqugn+8G0TSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=owufR0E/0gODrlWX3vG0g4xNpQSFHFyym/S8fltWQXw=; b=UIKmf95yFT05jso/y8dsewLPVNI9db/hByfrtnwP75SJl5byHa26mTvDmnPuOrzytVi/iBb0KrXpzxWSy+EkikjjVu+4Z9kiiK0KU5W7LaflcW2syT6qr7VW2Df07/3J74XVRO9qwvSch2yl/yAjLOInDFPFuSOpqKLi0ldHlLM= Received: from SN1PR12MB2352.namprd12.prod.outlook.com (2603:10b6:802:25::13) by SN1PR12MB2496.namprd12.prod.outlook.com (2603:10b6:802:2f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.22; Wed, 10 Jun 2020 14:17:40 +0000 Received: from SN1PR12MB2352.namprd12.prod.outlook.com ([fe80::156e:ce6d:a148:274e]) by SN1PR12MB2352.namprd12.prod.outlook.com ([fe80::156e:ce6d:a148:274e%7]) with mapi id 15.20.3066.023; Wed, 10 Jun 2020 14:17:40 +0000 From: "Kirkendall, Garrett" To: "devel@edk2.groups.io" CC: Eric Dong , "Ni, Ray" , Laszlo Ersek Subject: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib Thread-Topic: UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib Thread-Index: AdY/LxrU4UeZwuEKT3qg1oH+0DYgTw== Date: Wed, 10 Jun 2020 14:17:40 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2020-06-10T13:48:24Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=a0aba147-89af-413a-9a26-cb37e91c8949; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; x-originating-ip: [165.204.77.11] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5de1d48b-5d60-46cb-ef77-08d80d4908e3 x-ms-traffictypediagnostic: SN1PR12MB2496: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0430FA5CB7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 23UZn7KeOdXy/7ff0tBIvmphScfK3lqC1M3j4gnXr9HO4W+hBsRmGCiOwtPXB57Ov5YeEqIYwVqvfLftNNKjqKYXfnKWKk76x3q2YtuSbPMS/WmZlG3Gb0FlcvA42XgkMkBsyYNlbd5mxc4JCSBquv34G5bo8FroDL7BStwMlvYcYRi9VR0yASxhOULf12huejLlxXnV3Wk+Mfwcg9pFeSTRWQqubVPKrZiTRDYTWye5FNWE0Y7Q1GCIs/88zh8qAyk2Go186ywkvrEloiEnabi79dhcsT14tE1lcIQE333Gr/vd57VBxdVdkWFYhreoZ6b5ZyFK2pUxoyiy57wlCg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN1PR12MB2352.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(4636009)(376002)(346002)(366004)(396003)(39860400002)(136003)(76116006)(66476007)(7696005)(71200400001)(66556008)(2906002)(86362001)(33656002)(64756008)(54906003)(6506007)(66946007)(186003)(9686003)(52536014)(478600001)(26005)(5660300002)(66446008)(4326008)(316002)(8936002)(6916009)(8676002)(55016002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: wOrFx5O3DM0fLFoK6x9UtX1gnG/1ZO4CI/1fQyfwFUiErGUkst5MXlCecHksNhMrictj2/ppMmmLOP9J+0Y41E42mxffA4zAa0aIksj3ht7pwDK0c7LTTrm7ZVkg6Orpg15W8rJF76tXCDCO2z7y9zOjLTsOv7h7ni9OYs1Rk3qVOmzuY/Cpk/+KxCZK7LJl3qLuC8MGhTMqgFvBsDyPziLnTeoHVym8/mAO78zfqlEiVzGonHzrxFsBM2XdTgDt4Ce/wmQZ/NFlxBaYw4ROkUPnPf4r64DHHpnmnxAbiL44Lr8WOt+P6rDAN/UFtxphz083ESJ9wfPpd8Iw2MuKwQifmUbk0c5G8faxoOhotnWMug2mfMqayA5GLWzSoRcFvmgm46vTLrnloYATUq1A/HMzS6OKUGnDbnsUaSsb6IKlYWXb+SfImv66gjFjopsB3mj3dnTm3bAN3ANkUSBrxVzCq+n9Na7nKYyYA1ueaHG8lYCYFWEN6QXzsCfqpSIE x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5de1d48b-5d60-46cb-ef77-08d80d4908e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2020 14:17:40.4875 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rsYEA3oduWNc9B5SSBrAGXXXIpSku/HabkbHZ95oMYhvPOx9hcvmsf7BPstg9NZ080NpOhoAd9WDdgWoenJtHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2496 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable [AMD Public Use] There are currently three instances of StandardSignatureIsAuthenticAMD Func= tion in the below locations. I need to propose another change that will re= quire the same function in PiSmmCpuDxeSmm. I would like to see this functi= on move to a single "LibraryClass" location. I think no one knew where to = propose the function, so we ended up with three instances so far. The best= place I can find would be UefiCpuPkg/BaseUefiCpuLib/. Thoughts? Is there= a better function name such that a similar Intel identifier function could= be created when needed in the future? I'm thinking this will be 3 patches 1. Add StandardSignatureIsAuthenticAMD to BaseUefiCpuLib 2. Move current instances to Library function 3. Propose code change in PiSmmCpuDxeSmm UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c: StandardSignatureIsAuthenti= cAMD ( UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c: StandardSignatu= reIsAuthenticAMD ( UefiCpuPkg/Library/MpInitLib/MpLib.c: StandardSignatureIsAuthenticAMD ( GARRETT KIRKENDALL SMTS Firmware Engineer | CTE 7171 Southwest Parkway, Austin, TX 78735 USA=20 AMD=A0=A0 facebook=A0 |=A0 amd.com