public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Quan Nguyen" <quan@os.amperecomputing.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>,
	Leif Lindholm <leif@nuviainc.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Open Source Review <OpenSourceReview@amperecomputing.com>,
	Victor Gallardo OS <Victor@os.amperecomputing.com>
Subject: Re: [PATCH v1 1/1] ArmPkg/ArmGicDxe: fix writes to GICD_IPRIORITYR<n> when ARE enable
Date: Sat, 28 Nov 2020 01:43:11 +0000	[thread overview]
Message-ID: <SN6PR0102MB34872CB87B4650EABEB9579DF2F70@SN6PR0102MB3487.prod.exchangelabs.com> (raw)
In-Reply-To: <a8835396-9349-b392-f5ee-c1faae4cb560@arm.com>

No, Ard,
ArmGicDisableInterrupt() does not access these registers (IPRIORITYR)

-Quan

From: Ard Biesheuvel <ard.biesheuvel@arm.com>
Date: Friday, November 27, 2020 at 14:17
To: Quan Nguyen OS <quan@os.amperecomputing.com>, Leif Lindholm <leif@nuviainc.com>, devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Open Source Review <OpenSourceReview@amperecomputing.com>, Victor Gallardo OS <Victor@os.amperecomputing.com>
Subject: Re: [PATCH v1 1/1] ArmPkg/ArmGicDxe: fix writes to GICD_IPRIORITYR<n> when ARE enable
On 10/28/20 2:21 AM, Quan Nguyen wrote:
> According to ARM doc IHI 0069F, section 11.9.18, "Accessing the
> GICD_IPRIORITYR<n>:", "These registers are always used when affinity
> routing is not enabled. When affinity routing is enabled for the
> Security state of an interrupt:
>   * GICR_IPRIORITYR<n> is used instead of GICD_IPRIORITYR<n> where n = 0
> to 7 (that is, for SGIs and PPIs)."
> 
> The current ArmGicV3 code tries to initialize all the IPRIORITYR
> registers to a default state via the Distributor (GICD), so skip
> writes to the first eight IPRIORITYR registers when Affinity Routing
> is Enabled.
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Victor Gallardo <Victor@os.amperecomputing.com>
> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>

Isn't this already being taken into account in ArmGicDisableInterrupt()?

> ---
>   ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c b/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c
> index d7da1f198d9e..bc543502481b 100644
> --- a/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c
> +++ b/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c
> @@ -378,6 +378,7 @@ GicV3DxeInitialize (
>     UINTN                   RegShift;
>     UINT64                  CpuTarget;
>     UINT64                  MpId;
> +  BOOLEAN                 AffinityRoutingEnabled = FALSE;
>   
>     // Make sure the Interrupt Controller Protocol is not already installed in
>     // the system.
> @@ -391,11 +392,21 @@ GicV3DxeInitialize (
>     // Routing enabled. So ensure that the ARE bit is set.
>     if (!FeaturePcdGet (PcdArmGicV3WithV2Legacy)) {
>       MmioOr32 (mGicDistributorBase + ARM_GIC_ICDDCR, ARM_GIC_ICDDCR_ARE);
> +    // If Affinity Routing is Enabled, the first 32 interrupts (SGI and PPI)
> +    // can be programmed only through Redistributor interface (GICR).
> +    // Initializing the GICD_IPRIORITYR registers for these interrupts can be
> +    // skipped as the Redistributor will be powered up and initialized
> +    // at the appropriate time (e.g. in EL3 by trusted firmware).
> +    AffinityRoutingEnabled = TRUE;
>     }
>   
>     for (Index = 0; Index < mGicNumInterrupts; Index++) {
>       GicV3DisableInterruptSource (&gHardwareInterruptV3Protocol, Index);
>   
> +    if (AffinityRoutingEnabled && Index < 32) {
> +      continue;
> +    }
> +
>       // Set Priority
>       RegOffset = Index / 4;
>       RegShift = (Index % 4) * 8;
> 

  reply	other threads:[~2020-11-28  1:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28  1:21 [PATCH v1 1/1] ArmPkg/ArmGicDxe: fix writes to GICD_IPRIORITYR<n> when ARE enable quan
2020-11-26 13:09 ` Quan Nguyen
2020-11-27  7:17 ` Ard Biesheuvel
2020-11-28  1:43   ` Quan Nguyen [this message]
2020-11-30  9:09     ` Ard Biesheuvel
2020-12-01  3:46       ` Quan Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR0102MB34872CB87B4650EABEB9579DF2F70@SN6PR0102MB3487.prod.exchangelabs.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox