public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Heng Luo" <heng.luo@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
	"Sinha, Ankit" <ankit.sinha@intel.com>,
	"Kubacki, Michael" <michael.kubacki@microsoft.com>
Subject: Re: [edk2-platforms] [PATCH V1 4/4] TigerlakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT
Date: Tue, 7 Jun 2022 01:07:19 +0000	[thread overview]
Message-ID: <SN6PR11MB27520EC36BFAE8D0C4B8564F93A59@SN6PR11MB2752.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220606225030.3403-5-nathaniel.l.desimone@intel.com>

Reviewed-by: Heng Luo <heng.luo@intel.com>

> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Tuesday, June 7, 2022 6:51 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Sinha, Ankit
> <ankit.sinha@intel.com>; Kubacki, Michael <michael.kubacki@microsoft.com>;
> Luo, Heng <heng.luo@intel.com>
> Subject: [edk2-platforms] [PATCH V1 4/4] TigerlakeOpenBoardPkg: Indicate
> width of CLK duty cycle in FADT
> 
> Set the location of the DUTY_CYCLE field in the P_CNT register and indicate the
> width of the clock duty cycle to OS power management
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Cc: Heng Luo <heng.luo@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../TigerlakeURvp/OpenBoardPkgPcd.dsc                  | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git
> a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
> b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
> index ebbbc7b9f9..aba3c8d6d0 100644
> ---
> a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
> +++
> b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd
> +++ .dsc
> @@ -1,7 +1,7 @@
>  ## @file
>  #  PCD configuration build description file for the TigerlakeURvp board.
>  #
> -#  Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
> +#  Copyright (c) 2021 - 2022, Intel Corporation. All rights
> +reserved.<BR>
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent  #  ## @@ -118,6 +118,14 @@
>    gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000
>  #!endif
>    gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeiStackSize|0x40000
> +
> +  #
> +  # Set the location of the DUTY_CYCLE field in the P_CNT register  #
> + and indicate the width of the clock duty cycle to OS power management
> + #
> +  gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset|0x1
> +  gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth|0x3
> +
>  [PcdsFeatureFlag.common]
>    ######################################
>    # Edk2 Configuration
> --
> 2.27.0.windows.1


  parent reply	other threads:[~2022-06-07  1:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06 22:50 [edk2-platforms] [PATCH V1 0/4] Enable CPU pwr mgmt in FADT for Intel client boards Nate DeSimone
2022-06-06 22:50 ` [edk2-platforms] [PATCH V1 1/4] KabylakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT Nate DeSimone
2022-06-06 22:56   ` [edk2-devel] " Michael Kubacki
2022-06-06 23:17     ` Nate DeSimone
2022-06-06 22:50 ` [edk2-platforms] [PATCH V1 2/4] WhiskeylakeOpenBoardPkg: " Nate DeSimone
2022-06-06 22:56   ` [edk2-devel] " Michael Kubacki
2022-06-06 23:12   ` Sinha, Ankit
2022-06-06 22:50 ` [edk2-platforms] [PATCH V1 3/4] CometlakeOpenBoardPkg: " Nate DeSimone
2022-06-06 22:58   ` [edk2-devel] " Michael Kubacki
2022-06-06 23:13   ` Sinha, Ankit
2022-06-06 22:50 ` [edk2-platforms] [PATCH V1 4/4] TigerlakeOpenBoardPkg: " Nate DeSimone
2022-06-06 22:59   ` [edk2-devel] " Michael Kubacki
2022-06-06 23:14   ` Sinha, Ankit
2022-06-07  1:07   ` Heng Luo [this message]
2022-06-08 22:00     ` [edk2-devel] " Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB27520EC36BFAE8D0C4B8564F93A59@SN6PR11MB2752.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox