From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web08.580.1635476605088260423 for ; Thu, 28 Oct 2021 20:03:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=YfbRztn5; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: heng.luo@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10151"; a="230435729" X-IronPort-AV: E=Sophos;i="5.87,191,1631602800"; d="scan'208";a="230435729" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2021 20:03:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,191,1631602800"; d="scan'208";a="665668953" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 28 Oct 2021 20:03:24 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 20:03:24 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 20:03:23 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 28 Oct 2021 20:03:23 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.45) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 28 Oct 2021 20:03:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gi50lXB6aRKERyasBEbvOIsY1N+ejVbEh4yrSq0YX+numr5FDCL5AaJuUDOihrS0mMbJEuAloSpmgcNNW/pR/6LIoLWr++HxTCFt+Lir7VkvhvyCnS5Q5+M1yPcas3BWzHJ2p5wfclpVUGo6KBd7PTM4A3Th4WyxAx6ZVy4CVHAnsnq4RB3knC/sBZov0fS3P2vGpyvOvSXJjVJPsSdA8HUlb+wBsDKvshyC/HnwjOsIOyj284MRVJ4XD81oCcSER4fbQG3mELbeVrCXv8Nn2xsRr1gpD+x/n1dj89+6HnasAm9PjGFVHQcMf/aOvfUG8mhOgiwqbkp1hpHOjNZbjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gUQQ5vwD/EcDDwe2vs2pkVAeo1TGZO46iNmh0uiqNT8=; b=doxXbghqIKclngCATpjSI2d5S4N46eJpkytBc/A215N7nAtfP7zTEclzx5Um8bUStlLeaLimoU6m0rrpabVd3/JpBHKPIPIcGZmjGyDMBJnA3thQfhIGV8Y6SJf5hTF6JmzQ14uy6O0Irkt9LvabWhPGxmaUOonGs93HdBH3b8i81YLtfzQYsVGfcvEsIEKG5OjuvJqEevyLlGzNmiAeIEKmvfQrUCGjJOLF7atHLkov4zvTkOS+dvu+OY1JfgydRjjGr3t5uljdo45M7lSnmy7F1I38ZPtdqlf4valynJubj5bpm/Vu86RQ5IudsVv1Cv7vGJ8T7FtQ2o8UXZCNkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gUQQ5vwD/EcDDwe2vs2pkVAeo1TGZO46iNmh0uiqNT8=; b=YfbRztn5Ehw2YJzXWB+IR6SBiAwjgmsGUyZreUGOWMtABiRKvhn4cfNEdUn6R2mmP6RYcv3I39CFK4qXkNUsYFALSC6vFslCf+30RQWJM+LhyoVoKxOCC6JBN/LRA5+wwW7S6Vb8OG6gMauEXhzSwqUvU4PIClOybFo/jba9oAI= Received: from SN6PR11MB2752.namprd11.prod.outlook.com (2603:10b6:805:59::31) by SN6PR11MB2974.namprd11.prod.outlook.com (2603:10b6:805:d7::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Fri, 29 Oct 2021 03:03:22 +0000 Received: from SN6PR11MB2752.namprd11.prod.outlook.com ([fe80::797d:13bd:e7dc:3918]) by SN6PR11MB2752.namprd11.prod.outlook.com ([fe80::797d:13bd:e7dc:3918%4]) with mapi id 15.20.4628.020; Fri, 29 Oct 2021 03:03:22 +0000 From: "Heng Luo" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" Subject: Re: [PATCH v6 23/52] TigerlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib Thread-Topic: [PATCH v6 23/52] TigerlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib Thread-Index: AQHXzDzFVf4s5s4mI0SM7ose1uQ2aqvpSpEg Date: Fri, 29 Oct 2021 03:03:22 +0000 Message-ID: References: <20211028204326.645-1-mikuback@linux.microsoft.com> <20211028204326.645-24-mikuback@linux.microsoft.com> In-Reply-To: <20211028204326.645-24-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 37cd9197-195d-4cd0-ba93-08d99a88ab2d x-ms-traffictypediagnostic: SN6PR11MB2974: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2089; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BTK4nK8FUAkJYvWf5mziKuu4awzuc6bB9EEvd2hiQZljd/jmRnuIxlbnhFonV1WE7YBCNCswI1tIvP8av184NqCHWVcbEirufM88jjzRMC4p94P5XgwM1mDycn1bf4GPpD4FkOXjO4nZxacM81Vy65xmo0b/Zx5ctCE6k89wSenmNLun6OktrJjbgUjCeNUKY4Yi7W7AjOD/kUjl/TsXbnrKbz/vNn+WqwpR32p4PChxfYynmqvtPRA17cSO8rTObM9kgWoIi13eQOBA31eVJ9DOE70/M9Y5H7q1Rq/LC8w8fZl/oEncSmSyu4OivbdwZOx8Jj45ZnMo7mCkbGLAybhHSY+NNGmj5BSaWuK1vWPQvJKc/jjL4fspH0LOvhZHOBMnwZi59nXTFmAM9oDcVxl51t0IjnvzIYeK0KfsQnJFphP7HZTSnc0B33iA5yilXMn3JnxyyvH0/H8l4++82y6G/3YoN0uRIW+i9hc5bJlW+mgMurBDJ+L22OxzNaQ2DRPwbBVKdP8k08H2VFdTSGW6437HBVMoGkwAFu0du55jA0ItzK/gFXPWOSatbJjaal4VrprsAj9wEbMkGMEd8xQAkKnZ50GOcaDjUzEevQf+62I5i9fcW3tXGrgpTsyELG90c4hVOrgqh9nlwusDMcfWxsP6YbgoONPMvrfrbhBkL6bv4kOtCl8Ht6BXPqnMVVO5IFbatxR4JqiSKIyNtkop7IhvIJ2B9TrKZPsfB455y7auZ8uXHPSP2vUQShqBQohJGbAIAS4gAUEL/B41NFrpc9O7y1wmNZNMTMVovVY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2752.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(122000001)(38100700002)(38070700005)(33656002)(82960400001)(86362001)(107886003)(66946007)(186003)(4326008)(7696005)(9686003)(26005)(55016002)(5660300002)(53546011)(6506007)(66476007)(66556008)(64756008)(66446008)(508600001)(83380400001)(8676002)(8936002)(71200400001)(54906003)(110136005)(316002)(2906002)(76116006)(15650500001)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z4iG0Zyxj4Jxj3GyhZrpeFbTnzXddNpQsTW8BOXtnqst6xqPm4m6zHOOKiIh?= =?us-ascii?Q?I4mTmvnqZCLnciqkgO9n4xAz8XQsn80ESgKpLvgOQrY0wpp0e6oIWzmg7+N9?= =?us-ascii?Q?su44fnfCFMUD9QwgTR8ZPqifogY8n7JownppD8MHE1S3OTH/pcv/xrmjqGxM?= =?us-ascii?Q?2azKVEGzLwxaEezpseYtsLdZSYvKWQpKAqVaR1usZsD8zh16jPvLMhCPopQK?= =?us-ascii?Q?d4dvqzL2HZgH9oTvzVC1fpi4hwnWM782IlBA2vAEEddIzTL/ZaYhh3iGbDbm?= =?us-ascii?Q?yFX2nXn1F1ftu83OJO3pGeTOdS/K2sw/esJ4ynIlPP3Q9Ib7oOTcbdBoLIm4?= =?us-ascii?Q?8+e58FwNDce4DG3BKrejsZUoEAc/1U3pswrol3iTzd1bqZJT4seBeGx9KdUK?= =?us-ascii?Q?Js2EooPxK/cUulfBk3A5V5N1u3FULV0RGTPpwCR6vU/mF5yt82jKDHCV3X7j?= =?us-ascii?Q?KxDubUv8EZAiPE3k3B+war10FZ9ayOhUY+YZTS23YcIBVtbGh8zxoPiSAY7j?= =?us-ascii?Q?ii4/I77scESVL0ErPBTiqCFhqgubli4ZONUW7ZWUqVLDa+miuhUj/Hjt1PMU?= =?us-ascii?Q?x+2gPagOkfgrcJqkannlrcX3P3zYjMTYx6phkDSR6ha6froI2DEJI2A2gDCS?= =?us-ascii?Q?IQxBNj8jOTf9iZ2t5yCXwpd3B6Vn+m4yf305q3uQ9C0ePBYobxnGmL/8rBwz?= =?us-ascii?Q?a0DT2YzjEkx9VaIb9dF/KC6c0C5pk/E7rpBLoQ6oHDjYNktwoe9JOihoIPqN?= =?us-ascii?Q?nJdKLQn5dQwg+ugM3BeXf0DkNzK1PpGAeeZd7nqM1u9oyKhKsao2SmAv4Z7a?= =?us-ascii?Q?4cOqXrxI7pbPJUMxtPojLQzqxNIHazG5ANdtyU0IgJffwhq0rWTPzizxPQl0?= =?us-ascii?Q?Zh5YlJzmDQrL5sqfyU2cpLq43st4n8EfeLcHQ1cMA4uUPCoNswEdUg96BGy1?= =?us-ascii?Q?md5Z7d7mTOhm/2ZhUi9+ASDLI0mnlUZYMesdkhWYsLDHfY275/UVXERtzIA6?= =?us-ascii?Q?xLIJTiOYoBuY9cd0mmAc8PlALCjSgHjMCNnE3/YfI7+5acm/pjzceUeF0lmg?= =?us-ascii?Q?9A8r1NO6pUJr6mXm511snvYhz7KRseDQes28ZIcZkmV2YxumxOUGZBc9ChX3?= =?us-ascii?Q?UUArEGTaRaUDC05rPuwDZJ3s0zmyv4W8bsS18FIEcp3Ca4BTvjqh1DG5UC5K?= =?us-ascii?Q?e8RYeBXb5H2ghUM0LAh1opVmCVemmQ6cH8yeTGc4a0hNw5quq1bK/x4ywZQw?= =?us-ascii?Q?bSn2v8ewytR0zXjY52tWXM0K/RYnA1JJOgjX/ly9JfPeAf9yThoJliw6QidH?= =?us-ascii?Q?qVdR4I9DqGzhFvvuUgC3aRxbeXKSNH1mFwCVQTjYtZsePOUxpVVT2ppLLYky?= =?us-ascii?Q?SwYOOTfwBQabbjCwj1kE/n2l39ZuusvfdhedQKDtrQXgCjEG/sEP5NnTymqh?= =?us-ascii?Q?8YwvA2CjT+mjzsVMdEdn2LXstWhoO7NN1PMy52eMO8+xnbFTFTCq8grMD2nD?= =?us-ascii?Q?YTl0fmq4rYbz8JW0RGwbUBSiuXDGJon0FEs9/Vfu0PTD9M9gJI1kMyj8zBTy?= =?us-ascii?Q?5EsOlwYRUFjbPvbGUZdzOxCmIO/+h4V0zY7TY7UUdygd1YBcYZ2hwKSXlbcW?= =?us-ascii?Q?zA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2752.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37cd9197-195d-4cd0-ba93-08d99a88ab2d X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2021 03:03:22.6477 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uI6+VhFTuIjSIq+r9CidRaFnj9IfwAWoXdkAwW6ufhgjHRodpKWLgebsIr+mfUaoGOxVl9qfbBd09JBbF0SLSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2974 Return-Path: heng.luo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Heng Luo > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Friday, October 29, 2021 4:43 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L ; Luo, Heng > Subject: [PATCH v6 23/52] TigerlakeOpenBoardPkg: Update SpiFvbService & > SpiFlashCommonLib >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 >=20 > Updates TigerlakeOpenBoardPkg to use the SmmSpiFlashCommonLib instance in > IntelSiliconPkg and the SpiFvbServiceSmm driver in IntelSiliconPkg. >=20 > Cc: Sai Chaganty > Cc: Nate DeSimone > Cc: Heng Luo > Signed-off-by: Michael Kubacki > Reviewed-by: Nate DeSimone > Reviewed-by: Sai Chaganty > --- > Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc | 7 > +++++-- > Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf | 2 += - > 2 files changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git > a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc > b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc > index 1adf63403450..758b966fee81 100644 > --- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc > +++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.ds > +++ c > @@ -173,7 +173,7 @@ [LibraryClasses.X64] > !include $(PLATFORM_SI_PACKAGE)/SiPkgDxeLib.dsc >=20 > [LibraryClasses.X64.DXE_SMM_DRIVER] > - > SpiFlashCommonLib|$(PLATFORM_BOARD_PACKAGE)/Library/SmmSpiFlashCom > monLib/SmmSpiFlashCommonLib.inf > + > + > SpiFlashCommonLib|IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiF > + lashCommonLib.inf > !if $(TARGET) =3D=3D DEBUG >=20 > TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/Sm > mTestPointCheckLib.inf > !endif > @@ -297,6 +297,10 @@ [Components.X64] > !include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc > $(PLATFORM_SI_BIN_PACKAGE)/Microcode/MicrocodeUpdates.inf >=20 > +!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE > + IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf > +!endif > + > # > # SmmAccess > # > @@ -326,7 +330,6 @@ [Components.X64] > NULL|$(PROJECT)/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.i= nf > } >=20 > - $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf > $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf >=20 > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf { diff --git > a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf > b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf > index e3b2f048524c..b802c2167d06 100644 > --- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf > +++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fd > +++ f > @@ -434,7 +434,7 @@ [FV.FvOsBootUncompact] !if > gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE INF > $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyDxe/SiliconPolicyDxe.inf > INF > $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf > -INF $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf > +INF IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf >=20 > INF UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > INF $(PLATFORM_PACKAGE)/Acpi/AcpiTables/AcpiPlatform.inf > -- > 2.28.0.windows.1