From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.3621.1649210531704618506 for ; Tue, 05 Apr 2022 19:02:12 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=AhXvZOZe; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: heng.luo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649210531; x=1680746531; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AKKj92SQLN9RvGv2Q/6ja1hKyy3aY4B3wr5dVR4jBOY=; b=AhXvZOZe2V9dNGeUBihPwT+lEqTQ9TkXsjVrUL7LKSHFZ9QFLVHSJgbt zXZbxeW/4ICQ18961aBF31KDERcuT3whaYHkRa1MQr/lt6cXabso5AKhz rP3NeAy9iGCEBG4fwAaczuzNnEXc/6aquB1x1hb8iB7bqZ3bZGUygVT/H SqidArOR3jLM5zLpo46/UC/Rggsso63Id6KCNfesMcoxt/RoQjqHs6BlN b3bPmEQKzj96Na3gugVaL6UJqythZcf+H3YLFHo9oA4SwYyHL5+HqAdM9 V5vukWD9l6ZRBeEfFSEK1KrlcS91ShO+bnhXQrFbdREJ0fvDWBqRtvIP4 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10308"; a="241509631" X-IronPort-AV: E=Sophos;i="5.90,238,1643702400"; d="scan'208";a="241509631" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2022 19:02:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,238,1643702400"; d="scan'208";a="570284637" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga008.jf.intel.com with ESMTP; 05 Apr 2022 19:02:10 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 5 Apr 2022 19:02:10 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 5 Apr 2022 19:02:10 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 5 Apr 2022 19:02:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fSZEQPlyPiIe9tlv20w5dgqPaSrJHJtoKBmA/m4TN9mSpRfq9V/bvGIa7q+VlBZ61BqOlKrjiWIjrbG/3O8NFPdPx+h+Ym1k6MwODQHTVC9HkHSXyYUrRCMLRZQ0lseJp3LPVkn4kK3QW0rl485RBCb+QXP4Omjm3/oOD0rP2/Qor9j7hmIi/fe+78zA/9gx9V+fpW+ihDtAEynnnObVNjm530ZEeMluXmSKrozDx275cQMZuD2sXRk4YZbPipVAILxcbzOILfbCVKeBceLpkAKPDtF6n7KhyaGJteQu/f8bfGfagqGau06+reyeEPla+OyVVKzzGlV6DQrFWE+QJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rlY3nTs/Y7mN/etcAM3X1aTqLFQ4eBPR6JahgFYtQBA=; b=UNwJ8NJ7GdK7CtEs4l6PNL0Dx9GFTEPx9Etq7T8tF1mzBlltrhrzUiwxGK+TAv3Qv3xVs/i5eJNSTLePRCCn6PqXgQRfgKHHX8xdIbB0jiO1BenbBAivpfp3usDPOgDsUXmcpzOHFP5S9Rqu5Z/1PJ8bGz5AXsDuKLefBKO5IYEOdk/15NMOFDc8cvvc3jfO8y6Al3qqGPZfCjkRjsTvjIhlIZHzZDcp3ohj7WGcez+NOurEiAybjogZQ17dSSWpSzVVERsjFjr0FqPZMDd0NMaenjDvTBUGmkt6pl7Xc2WcEoz3mPdhAwtuQZ0QEfhPNmy+3MRw/awR/kt5/mGpJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB2752.namprd11.prod.outlook.com (2603:10b6:805:59::31) by CH0PR11MB5377.namprd11.prod.outlook.com (2603:10b6:610:b8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr 2022 02:02:08 +0000 Received: from SN6PR11MB2752.namprd11.prod.outlook.com ([fe80::8cb7:c628:e329:a31b]) by SN6PR11MB2752.namprd11.prod.outlook.com ([fe80::8cb7:c628:e329:a31b%7]) with mapi id 15.20.5123.031; Wed, 6 Apr 2022 02:02:08 +0000 From: "Heng Luo" To: "devel@edk2.groups.io" , "Luo, Heng" CC: Maciej Rabeda , "Fu, Siyuan" , "Wu, Jiaxin" , "Rabeda, Maciej" Subject: Re: [edk2-devel] [Patch V4] NetworkPkg: Add PCDs for HTTP DNS RetryCount and RetryInterval Thread-Topic: [edk2-devel] [Patch V4] NetworkPkg: Add PCDs for HTTP DNS RetryCount and RetryInterval Thread-Index: AQHYRyIWogpAZ3mcYUKgnPmX2WRlJKziJKhw Date: Wed, 6 Apr 2022 02:02:08 +0000 Message-ID: References: <16E24E429C73DB68.15950@groups.io> In-Reply-To: <16E24E429C73DB68.15950@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6644ef95-3ef7-4314-cf64-08da177174ce x-ms-traffictypediagnostic: CH0PR11MB5377:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ajBaktC/fgeoOQsX/DtCpG4WnkPnqrLRFMYo5qISGpumhsRH0M6jMb+jvu8xu8lodW4l/oof7Wl8EZMmevAx6km+n0QyuxCu8ZsI53Jkqqv5Jkg0OJbDVRGdTURwhG8MAhkMtsZkOdjQ6GiOKFARGZeaBZ2y0tVcb/5GBqYkeJfM8dV5j8WOnrMUfKyFnaablTiX8O84aWslgLoHpjWSbn7whwpGMXgSnDW7W8yBqMMLh9MgwbR84Ku8iDMHpaH9oKHJ23t7+VyODpkef0LVYHXOVu7TIeOlhpBJRayOHzQsQY7m1PfN1vkh+2fE5+XDu9wwF3097IoGB2EMjzlhYpgOmIhL7M4j2aKsSvQb+OTwSks5rk4AzIgJ+Q8LRkyo1EBpWeYvFD6q3i1Bged7Rm4d3+sxyyPSlgZoF79LTZZBmGN5FMxqivzGop1IiX2wB2P6SB3fMlx/G7nHxgnc593VxBanwoNOE11hs+Io01h8LAoehHSbkw4t+v8QX2WsFJcpJfp+FdBsQ0L3gcMoxRcvcJER+PurDRTV2Ea8Kk9p+IlDj0qR+NYfDH/un0rpptiUN3p/kXilMygSSSWWKWblxgHb23l4Lri/jSrYxtkvAV9FIddQbq1mrq44w7cnLB18lALVbwy68ZA4eFQvqrcofy0d5DTITMAasy8EdlFldx2BezJNvCARV8u3g3XtjT0hxTT6+qbGge12U6GWKDYEyiyP03BF1F0IoeajCe9ADJSdqu0cTFBPas6ilSn7Zc8BR+MO7TxhgkdhULqPE7/bBRLuHa3b/ETRyGDqPQMWLvpZcZcc9VlJFqOawxBoFeicl+XJEgJB8m4HBqoG3A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2752.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(110136005)(54906003)(38070700005)(53546011)(76116006)(508600001)(66476007)(316002)(19627235002)(4326008)(6506007)(7696005)(86362001)(8676002)(9686003)(83380400001)(966005)(66556008)(66446008)(64756008)(66946007)(186003)(71200400001)(26005)(122000001)(82960400001)(2906002)(38100700002)(8936002)(33656002)(5660300002)(55016003)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wgG9HyHkF1NPG3bVzi6Ii2LmpLksi5IM6ou5hEqrZGJzIgyAHr6iD5StBfpt?= =?us-ascii?Q?XFPfVUYsqwNje6LZzSE1SgM1pW2qW264im4WxQlXYXR/W99tvaC7WRZBC501?= =?us-ascii?Q?Vyejh7SuTfeFP0xqVm4coJVjGydqjDgfEuZR7g4W853PaDaQlRGMemFjXWh+?= =?us-ascii?Q?2mrBzlB0Iy2/U5hkXzdOhhMcfU253yGbx3XBHrKF7JJhXgRqfiHqN4HTjJMn?= =?us-ascii?Q?wD9go12vN4kW/6aNIRSVlbJ76xbyZzQBNX7RSPDXR8zKf/HfElgxyoVQKxOh?= =?us-ascii?Q?FS2VLLQNgbs6Adn9S9ismr55G13ELRwEZKx1ZoWre3YprnWOaj9Nj3+PvIse?= =?us-ascii?Q?OYrMmcCQz1ooSPJ/Tjgy+ub7T2cnHS+j3Z8770nIA5/EKkNb9VQS2YFt7krZ?= =?us-ascii?Q?8WIWjSdB3fy+RIWOVT9PzTnPbrpfJT4SFdMOx+BICNe6qDyzYrRgjQyC06vR?= =?us-ascii?Q?NFKiz0J8nXzU6McO837p5RWn2mR2/Jn+jaMNJ1VS+Nk+6C0ukOgq5atqoiWm?= =?us-ascii?Q?kwFJRSnrMKxssumPxhO7Akc3fsynHuiCAH4me2+eOqV84c43XxBpnU5WDUk+?= =?us-ascii?Q?rec27rQY7QDWk8R5xVmNohDVhFhVj1Fj8eZHICg4FSjsPAN0PfaQ6g4BIBev?= =?us-ascii?Q?nUOwXHZtmb/fZEw6bbvbuqrQMzsRGIGS4JRwXRIH3eKoxcM55HkxP9TM86ZK?= =?us-ascii?Q?2tKE6K6r+NCnkherVy/WLHo8STRY9urV/4KOHxhr1RzXu3gQ2Lrjq4HbKfZ2?= =?us-ascii?Q?3FoWV/7bGyZGZRgFUc8iS7VCAi38U0UGNbZqfY2ISRHbDA6nBiqT5rr6+jkC?= =?us-ascii?Q?IoyzTYQd21sU3/OuVGRNHsO46boGyNV/1Ny6/q/1jug2sii5qTSaliJK4Wbp?= =?us-ascii?Q?DsADsRfjGZ/mgRFkE2ysiXTvoGBUxrEQB/f6iM0YM2r1ueg/BdkEnUaEC59z?= =?us-ascii?Q?axo9v2eMN0ZxdyOR/yUmEsC3H+ppciTR0/6cXR0rXwWLAqhtJn3sb50MVzj2?= =?us-ascii?Q?I/fcejNy8y5DMS2CKQZnCZQkz7eoBr/HCCR1wqAzevEujaJmIzHkl9VTWdAk?= =?us-ascii?Q?144AsGAHkB2A8LI/COr8UQ5JjRWGdmKxd1ynEoFJxaFP9yK8sI0DUR765sCB?= =?us-ascii?Q?OERaqxOydOC0FF6C2E7VDqK7CRDf439T1aHxpQk8W9sdI/Gzxzkhej9AKQTh?= =?us-ascii?Q?HZTeQLkVWzMobFGdqbr7mLvWc2SuOwJPBUHdmrFD6PnoZmXI6HYULmYRVgF2?= =?us-ascii?Q?HNHSn94rpzYfxNKkFWqJcZu1USrMB3KWmjZUtjNo7ljXS0fvuwE1qR6BwPJk?= =?us-ascii?Q?XE1Zcikq5NCnSgZ752XKMK7eS7dyo5X/clZ4btWdzycYU5ZlrIB7qzd/H6Pp?= =?us-ascii?Q?kCqfznlqQprRBDR625V8AjnSm+X0AUOYzcIUVqORObkS79ouI0Dd2V8GXAou?= =?us-ascii?Q?Q7pMb5yfdSJkjfSJmh6SIPOsYqqynXP6G6THNcWI+K/qzcT6aKJQ1zNTdsW5?= =?us-ascii?Q?eC0Lc86m1MZHjw7fIWxv9aFIE3zqkrHeknMsOykYkcNfMEW5Txi0HIhSxN/q?= =?us-ascii?Q?KqGk+qQx3OljWvoCNXtnN8GVIDWclIJY24fopTLKzd62zHQ+15tfjnHNqd24?= =?us-ascii?Q?UnDICm6pMZAh0nsfc0K1vT96jilJD6HcOEmIorjZsDdy+T91wU7zUP0k9byE?= =?us-ascii?Q?UPShNZvQxlkxYRxBflICB0ilYx3Xt3FunHHZo/FZK/tW7phPgWp2V2iWOjUm?= =?us-ascii?Q?9klxIpkwuw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2752.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6644ef95-3ef7-4314-cf64-08da177174ce X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2022 02:02:08.3862 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FGt4lsvdLxl0eHgLAiON0VwC9SxRSgr4FEcIX7ctkteLDdRXt9NnKW+6NSlUzheFQhoMx/lOhbWJsQ8Vs5wNPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5377 Return-Path: heng.luo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Dear Maintainers, Could you review the patch? All checks have passed the EDK2 CI build. https://github.com/tianocore/edk2/pull/2717 Thanks, Heng > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Heng Luo > Sent: Sunday, April 3, 2022 2:14 PM > To: devel@edk2.groups.io > Cc: Maciej Rabeda ; Fu, Siyuan > ; Wu, Jiaxin > Subject: [edk2-devel] [Patch V4] NetworkPkg: Add PCDs for HTTP DNS > RetryCount and RetryInterval >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3889 >=20 > Currently the HTTP DNS Retry Interval is 2 second and no retry attempt. > If DNS response can't arrive in 2 second, the DNS request is failed, and = then > HTTP boot is failed. > In order to resolve this issue, Add PCDs to support RetryCount and RetryI= nterval > configured in Platform. >=20 > Cc: Maciej Rabeda > Cc: Fu Siyuan > Cc: Wu Jiaxin > Signed-off-by: Heng Luo > --- > NetworkPkg/HttpDxe/HttpDns.c | 4 ++++ > NetworkPkg/HttpDxe/HttpDxe.inf | 2 ++ > NetworkPkg/NetworkPkg.dec | 9 +++++++++ > NetworkPkg/NetworkPkg.uni | 11 +++++++++++ > 4 files changed, 26 insertions(+) >=20 > diff --git a/NetworkPkg/HttpDxe/HttpDns.c b/NetworkPkg/HttpDxe/HttpDns.c > index 59a2784e6a..13cbde0f34 100644 > --- a/NetworkPkg/HttpDxe/HttpDns.c > +++ b/NetworkPkg/HttpDxe/HttpDns.c > @@ -108,6 +108,8 @@ HttpDns4 ( > Dns4CfgData.DnsServerListCount =3D DnsServerListCount; > Dns4CfgData.DnsServerList =3D DnsServerList; > Dns4CfgData.UseDefaultSetting =3D HttpInstance- > >IPv4Node.UseDefaultAddress; > + Dns4CfgData.RetryInterval =3D PcdGet32 (PcdHttpDnsRetryInterval); > + Dns4CfgData.RetryCount =3D PcdGet32 (PcdHttpDnsRetryCount); > if (!Dns4CfgData.UseDefaultSetting) { > IP4_COPY_ADDRESS (&Dns4CfgData.StationIp, &HttpInstance- > >IPv4Node.LocalAddress); > IP4_COPY_ADDRESS (&Dns4CfgData.SubnetMask, &HttpInstance- > >IPv4Node.LocalSubnet); > @@ -315,6 +317,8 @@ HttpDns6 ( > Dns6ConfigData.DnsServerList =3D DnsServerList; > Dns6ConfigData.EnableDnsCache =3D TRUE; > Dns6ConfigData.Protocol =3D EFI_IP_PROTO_UDP; > + Dns6ConfigData.RetryInterval =3D PcdGet32 (PcdHttpDnsRetryInterval); > + Dns6ConfigData.RetryCount =3D PcdGet32 (PcdHttpDnsRetryCount); > IP6_COPY_ADDRESS (&Dns6ConfigData.StationIp, &HttpInstance- > >Ipv6Node.LocalAddress); > Status =3D Dns6->Configure ( > Dns6, > diff --git a/NetworkPkg/HttpDxe/HttpDxe.inf > b/NetworkPkg/HttpDxe/HttpDxe.inf index af681c0184..c9502d0bb6 100644 > --- a/NetworkPkg/HttpDxe/HttpDxe.inf > +++ b/NetworkPkg/HttpDxe/HttpDxe.inf > @@ -75,6 +75,8 @@ > [Pcd] > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections ## CONSUMES > gEfiNetworkPkgTokenSpaceGuid.PcdHttpIoTimeout ## CONSUMES > + gEfiNetworkPkgTokenSpaceGuid.PcdHttpDnsRetryInterval ## CONSUMES > + gEfiNetworkPkgTokenSpaceGuid.PcdHttpDnsRetryCount ## CONSUMES >=20 > [UserExtensions.TianoCore."ExtraFiles"] > HttpDxeExtra.uni > diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec index > 928e84fec4..5e43ebf8c5 100644 > --- a/NetworkPkg/NetworkPkg.dec > +++ b/NetworkPkg/NetworkPkg.dec > @@ -163,5 +163,14 @@ > # @Prompt The Timeout value of HTTP Io. Default value is 5000. >=20 > gEfiNetworkPkgTokenSpaceGuid.PcdHttpIoTimeout|5000|UINT32|0x0000000F >=20 > + ## The Retry Interval of HTTP DNS in seconds. If the Retry Interval > + is less than # DNS_DEFAULT_TIMEOUT, then use the > DNS_DEFAULT_TIMEOUT. > + # @Prompt The value of Retry Interval. Default value is 0 > + > + > gEfiNetworkPkgTokenSpaceGuid.PcdHttpDnsRetryInterval|0|UINT32|0x000000 > + 10 > + > + ## The Retry Count of HTTP DNS if no DNS response received after Retry > Interval. > + # @Prompt The value of Retry Count, Default value is 0. > + > gEfiNetworkPkgTokenSpaceGuid.PcdHttpDnsRetryCount|0|UINT32|0x0000001 > 1 > + > [UserExtensions.TianoCore."ExtraFiles"] > NetworkPkgExtra.uni > diff --git a/NetworkPkg/NetworkPkg.uni b/NetworkPkg/NetworkPkg.uni index > 6d0fa67c6f..c0bbbd3ee1 100644 > --- a/NetworkPkg/NetworkPkg.uni > +++ b/NetworkPkg/NetworkPkg.uni > @@ -111,3 +111,14 @@ > #string STR_gEfiNetworkPkgTokenSpaceGuid_PcdHttpIoTimeout_HELP > #language en-US "This value is used to configure the request and response > timeout when getting " > = "the recovery image from the > remote source during an HTTP recovery boot." > = "The default value set is 5 seconds." > + > +#string > STR_gEfiNetworkPkgTokenSpaceGuid_PcdHttpDnsRetryInterval_PROMPT > #language en-US "Retry Interval of HTTP DNS" > + > +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdHttpDnsRetryInterval_HELP > #language en-US "This value is used to configure the retry Interval of HT= TP > DNS." > + = "The default value set is 0 second. > If the value is less than" > + = "DNS_DEFAULT_TIMEOUT, then > use the DNS_DEFAULT_TIMEOUT." > + > +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdHttpDnsRetryCount_PROMPT > #language en-US "Retry Count of HTTP DNS" > + > +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdHttpDnsRetryCount_HELP > #language en-US "This value is used to configure the Retry Count of HTTP = DNS if > " > + = "no DNS response received after > Retry Interval. The default value set is 0." > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20