From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.565.1635476742224238875 for ; Thu, 28 Oct 2021 20:05:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=CBTeV0u3; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: heng.luo@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10151"; a="230841009" X-IronPort-AV: E=Sophos;i="5.87,191,1631602800"; d="scan'208";a="230841009" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2021 20:05:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,191,1631602800"; d="scan'208";a="530254892" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga001.jf.intel.com with ESMTP; 28 Oct 2021 20:05:33 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 20:05:33 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 20:05:32 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 28 Oct 2021 20:05:32 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 28 Oct 2021 20:05:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O151C6hsEc+EBBNf6hWqvmtN9NySmt2+UNJAwSIDcgdwr0ySuG98IFFmYjTVWSwz1JOPYGRWivht0+i0hrt1IBs4OetYDGBiLyDrcSa//+CGmHj0DfQRzomWZ5o9TxNHdxieIfugXrskBHlis/EkgSLFwmSeKa9OunixY/fK3iaNyoAmXjENAzCHhlcXWtS4stENz2uwKIKoMifuTFkXZ9LORJNO5tBjfWEANfbmp3nSTP8OXtH/dAMhg3jk0FfGgiWxEHKG9OsRdp3Q8HnqxlUa1VuGo2JkW5DU/5ap5HIS2vjpvXc9xmsFoRi1bR3R2bF1gRnG6prZI84droIp3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E9ar5EQ92pv74oTRvfhhMMGwj386Mc8IHKwBavuMjWM=; b=XKBW3b+oLHu7fIEuTN8ZixbtAaTz+OGUpr8L2XG0+gxcQZsuNnTC4PmXLOZw4k2eWabXorju8ucMiMi83RPllETIhOaW+FK2FnAPMeDJ3e8XcyFehZIg3zLZQ++otDmrMCYm2bFXgAMNLUMjo60rzl4iE7rKGIBwDtGSWA/oAgbVj9C31F4tsGAxCWPyScEtHaUNa7OB0meTJQwCilwC3J7QU4F8KX5lznQv3HRzNuk/CfghOR36hhbUaPT3S+zgDGxqaZZATUqSGozOuqgCE72n4onbizcHqLC1OR27pLEAz6Qy9rLPKe1g+bLnamleLNQyq9u5QfpdwWGfIwclTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E9ar5EQ92pv74oTRvfhhMMGwj386Mc8IHKwBavuMjWM=; b=CBTeV0u3p4Ba2y2cf0WKsArfQfajNE1HJYFMGKsbVOhgCWzhAqNJV0HOGGbJUKmut3DQCCosgcJ26ha4mmz0yt4rwj6oR/dyJxZ2hOtC9wNVfCfY7feP+vAGEplTMNuoh2i69SzGdDQ5dl9wkbC5gX6Oux5NE/MWa/m/QbgIK7I= Received: from SN6PR11MB2752.namprd11.prod.outlook.com (2603:10b6:805:59::31) by SN6PR11MB2974.namprd11.prod.outlook.com (2603:10b6:805:d7::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Fri, 29 Oct 2021 03:05:31 +0000 Received: from SN6PR11MB2752.namprd11.prod.outlook.com ([fe80::797d:13bd:e7dc:3918]) by SN6PR11MB2752.namprd11.prod.outlook.com ([fe80::797d:13bd:e7dc:3918%4]) with mapi id 15.20.4628.020; Fri, 29 Oct 2021 03:05:31 +0000 From: "Heng Luo" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" Subject: Re: [edk2-devel] [PATCH v6 51/52] TigerlakeSiliconPkg/SpiSmm: Update for SPI2 Protocol Thread-Topic: [edk2-devel] [PATCH v6 51/52] TigerlakeSiliconPkg/SpiSmm: Update for SPI2 Protocol Thread-Index: AQHXzEi+/j/FcxlOCk2NBMOSUbw3yavpSvKg Date: Fri, 29 Oct 2021 03:05:30 +0000 Message-ID: References: <20211028220846.753-1-mikuback@linux.microsoft.com> <20211028220846.753-16-mikuback@linux.microsoft.com> In-Reply-To: <20211028220846.753-16-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 92d4235a-3cd0-43a8-3846-08d99a88f7a8 x-ms-traffictypediagnostic: SN6PR11MB2974: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vRX+24KbdXpPRSs47tYCDk4vCArSolXILsIdPYFhN1cyd/30A/4vKBcghRctE8zy9yXqHTohMT082P40pB0yirE5jbngvjz3UtPemGb5sbKuKumUjgNrBCyMtGb234H1crKP/bbdpOiQ235MtbGaW0Q+2h/d31jrEvdDEXUDpi6yIEHNVkziwZ4KYh362MQ/tpHU5YRzcl7IqtXzr3COQEoYy3G8UfPfghq7N9dVq9L04VoGXuF7NqDcJj4Hb6dPIc8mZjUuqYDJRgnVAULPRf4DxE4cRVw/9c+lp4Q3j/gEgu3KTSf50OFSU9zDM1DfGx0kQW2RXcN0J8SczXoL9XBc7awObITkG1TxNx/2eI9zAmtbR/c89X1Qc5Lqhi/NmAendS1tUPPcgS5Urlx56GbSoL44etAmI5zB0tBkMAOiIhQDcOQE3qZ6aA/Y+YBMAGjL+m7DViAjM5wsysIIhK5iqIdhWdBSlkaGGBGOnntRFOQoreo3aKdMY7WPhF9I5HukyoHWFFDs/53nPG6kAWv2E+WArEOzWIcnWKk5e3hLH1YesvSswf/aYesAL/FquUd203ScBZ6sEMUTQxJAOHj1yGinxOZFDmMzW9/Zathoeg8ikFgUh//Mw1JPd0V7sp2yVp/xUYjYefD75CXj6LkmVgwpC04HKKWdLRVjcnQ/ZZWKIVPVgXaL5U7bO/YIbzoprGn+11Rwq4UuL6m863gc6eOxwydTm7XcyR4sqbiQepRjDlk28zS+iepqdKKSQcVetrRSfx8Uji89wQ2KWKcoIw/S8kBZpNO2IVjlmGlsyJBam+bj8KW9300YkPqqRDtBlJxSaFhYU+EaapS4RA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2752.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(122000001)(38100700002)(38070700005)(33656002)(966005)(82960400001)(86362001)(107886003)(66946007)(186003)(4326008)(7696005)(9686003)(26005)(55016002)(5660300002)(53546011)(19627235002)(6506007)(66476007)(66556008)(64756008)(66446008)(508600001)(83380400001)(8676002)(8936002)(71200400001)(54906003)(110136005)(316002)(2906002)(76116006)(15650500001)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pS0bQbXgJ8+pNrOsYfq295TqnUrlsaiFA/vI0zlScNii0hfWQiaKo0YAUPEM?= =?us-ascii?Q?T+b7+q7ZxLMIie1WdK/R2DsZbCTJMJNDGUVyA9rL12x7A/RKa6VriaJdVRuF?= =?us-ascii?Q?Us8GPo3nA3lhgnifEPluzD9OHmEK1lCZVkmCiFwysjRmvgYCroKKm6QOnXMU?= =?us-ascii?Q?lqZUKk7M66i5P+jHTW2AuCgejRXcxsNk8ztVX/F2ToX+UboJxE4vRJewDoen?= =?us-ascii?Q?LTuUYsnoO0RiwT10tmC+nGidQqJJrprgH4ZfxJpuMBCDyua3A/x++3kk/9vV?= =?us-ascii?Q?sIcez/SAq/J2DHb+NCumAu8fuZXDekmAuPEcdLCJQp+d8rH6vVGIbgXxeP4c?= =?us-ascii?Q?t2ppjjUKKyn/0FesHBty7OdsO4iIiez4t3QuqA/u/F+fW3FVXhLgYLkTrIRQ?= =?us-ascii?Q?aAQ6WMCuJGyWhzSI0wFkKtnCSKd/cgfsvA1Wov57v9VGCa+0kpwSR3N7F/cf?= =?us-ascii?Q?9BqLzxH7gLjOBT3zdJOpT7tSHr4vtHkQ0GUdCLITaRJPvkbPNrC1WMI5Yt6J?= =?us-ascii?Q?XuCAUUBXxL4VWs15H23uSNtKQicQ8/zSg+8ZWaap8NeyVdUSTyiFje/ag2n2?= =?us-ascii?Q?gvdh5jsVD+3AkB1+5BU1vGNAcdZQY5RTWS7w6pd9WU20zOGYJS8HANTSbUZz?= =?us-ascii?Q?EBw9MTCvbF0H7PtIQtOERTVOE34+psdnCOITneoyTuwiD9wOA8NRdI+od/fn?= =?us-ascii?Q?58eaO3HNsErv3OKdYjwwYnjGjpktelULsGsYR6sLUeQH0wMKHP8GyVP7QrgP?= =?us-ascii?Q?Uou2FfXOjZAc6ozyYNVQQC8w5q9jEi5zgWb3biGnMSde/NwurCaElJ9oDwa5?= =?us-ascii?Q?QNaAxeUKVk69VCCt9xjqyPyHZ10E5d1wxkgLo1laeZQH7eeps8SuebdK7Oo8?= =?us-ascii?Q?0yWCxpJ1LSk/dCGlNm72AujMSQiAWZJcnc0u4Jp+ZSf/AVeRu9KbclkM5Oiw?= =?us-ascii?Q?f4+8Yh6bXIogfo0igrE6KG2zy/XXAQQz0UDlytoZQp4/XW96TB3aJIYf+D2D?= =?us-ascii?Q?gyu1Li47BImk2i6sBFnUildutJheYqMwYhiAxfBnDF1rYJpHhjtlePO1aZfE?= =?us-ascii?Q?tqxAPTuy1yoAs/JKUBf6BE/DH2fhlJb//S5R6lrTA9PTV4VeKYezrnnf9msC?= =?us-ascii?Q?gdyTpYo23NcUaFLqwZ74oowb5wZR+Wd4l8TfTmNkXL1g1QYdPP4IxM3GN1rf?= =?us-ascii?Q?nD+qrUWM6qFaNGgpkA8BPR3FvLj0OqWkTPc+KV83nvkUeI1nD7U25ovAL3kW?= =?us-ascii?Q?o311rvaPuHRh4xFt721WPTtMZwVraPKrIPqcSTpRVrdO0xz49bnQ7y9XnFxR?= =?us-ascii?Q?hrWXio5SMYZOZu6vmvq709izLG6W/tonl/i7t8hywmtbjs4W80eOMjAGC0Cq?= =?us-ascii?Q?mR7sd7x7lwm2pC45rWpHd/+Fd7ScoUXA/8b+UMjByojtNxEezLNBrxBpoCGQ?= =?us-ascii?Q?0rzL5CGuHQ/3pDT0rEqtOfD0DuTEH7MYiKpWmvvXW8drnZKy3RJRKvRVcoYp?= =?us-ascii?Q?gXc7B7x2tbZvbIBslz/MbwbiOFDLUnwR96k7LgptZo6Cb/kMd7a5OISfWW5k?= =?us-ascii?Q?c/hKqgfPOMtAcuR/fxgmYisyUosZomBd37iRy6blETZwQUvkapqP266m2EIz?= =?us-ascii?Q?Cw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2752.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92d4235a-3cd0-43a8-3846-08d99a88f7a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2021 03:05:30.4675 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0MwiQoDY9jDE8FFidmrWEvLrE5wBflCcYf9Ky9MjWKFEzdCa3j7pCfATYanS/O8orIyikhwjQRQsF1+g4Inz8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2974 Return-Path: heng.luo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Heng Luo > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, October 29, 2021 6:09 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L ; Luo, Heng > Subject: [edk2-devel] [PATCH v6 51/52] TigerlakeSiliconPkg/SpiSmm: Update= for > SPI2 Protocol >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 >=20 > Updates references to the "PCH_SPI_PROTOCOL" to instead refer to > "PCH_SPI2_PROTOCOL". >=20 > Cc: Rangasai V Chaganty > Cc: Nate DeSimone > Cc: Heng Luo > Signed-off-by: Michael Kubacki > --- > Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/Spi.c | 10 +++++-= ---- > Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/Spi.c > b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/Spi.c > index 419eddaff38d..a55cb37c4faa 100644 > --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/Spi.c > +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/Spi.c > @@ -13,7 +13,7 @@ > #include > #include #include > -#include > +#include > #include > #include > #include > @@ -45,8 +45,8 @@ GLOBAL_REMOVE_IF_UNREFERENCED UINT32 > mSpiResvMmioAddr; > - Documented in System Management Mode Core Interface Specificatio= n . >=20 > - @result > - The SPI SMM driver produces @link _PCH_SPI_PROTOCOL > PCH_SPI_PROTOCOL @endlink with GUID > - gPchSmmSpiProtocolGuid which is different from SPI RUNTIME driver. > + The SPI SMM driver produces @link _PCH_SPI2_PROTOCOL > PCH_SPI2_PROTOCOL @endlink with GUID > + gPchSmmSpi2ProtocolGuid which is different from SPI RUNTIME driver. >=20 > - Integration Check List\n > - This driver supports Descriptor Mode only. > @@ -108,11 +108,11 @@ InstallPchSpi ( > return Status; > } > /// > - /// Install the SMM PCH_SPI_PROTOCOL interface > + /// Install the SMM PCH_SPI2_PROTOCOL interface > /// > Status =3D gSmst->SmmInstallProtocolInterface ( > &(mSpiInstance->Handle), > - &gPchSmmSpiProtocolGuid, > + &gPchSmmSpi2ProtocolGuid, > EFI_NATIVE_INTERFACE, > &(mSpiInstance->SpiProtocol) > ); > diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf > b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf > index f64b84880b31..40feab02d3ef 100644 > --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf > +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf > @@ -39,7 +39,7 @@ [Sources] >=20 >=20 > [Protocols] > -gPchSmmSpiProtocolGuid ## PRODUCES > +gPchSmmSpi2ProtocolGuid ## PRODUCES > gEfiSmmCpuProtocolGuid ## CONSUMES >=20 >=20 > -- > 2.28.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#82871): https://edk2.groups.io/g/devel/message/82871 > Mute This Topic: https://groups.io/mt/86664084/3906523 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [heng.luo@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20