public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Heng Luo" <heng.luo@intel.com>
To: "mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"Oram, Isaac W" <isaac.w.oram@intel.com>
Subject: Re: [edk2-platforms][PATCH v1 2/3] TigerLakeOpenBoardPkg: Remove unnecessary debug macro argument
Date: Thu, 6 Oct 2022 12:19:32 +0000	[thread overview]
Message-ID: <SN6PR11MB2752D014113932B4ACC93BF8935C9@SN6PR11MB2752.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221005033531.3994-3-mikuback@linux.microsoft.com>

Reviewed-by: Heng Luo <heng.luo@intel.com>

> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Wednesday, October 5, 2022 11:36 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone,
> Nathaniel L <nathaniel.l.desimone@intel.com>; Luo, Heng
> <heng.luo@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>
> Subject: [edk2-platforms][PATCH v1 2/3] TigerLakeOpenBoardPkg: Remove
> unnecessary debug macro argument
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4094
> 
> Removes an argument passed to a debug macro without a print specifier.
> The argument appears to be useless.
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> 
> Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiSiPreMemDe
> faultPolicyInitLib/PeiSiPreMemDefaultPolicyInitLib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiSiPreMem
> DefaultPolicyInitLib/PeiSiPreMemDefaultPolicyInitLib.c
> b/Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiSiPreMem
> DefaultPolicyInitLib/PeiSiPreMemDefaultPolicyInitLib.c
> index f0eb3f3f141f..f31cec231e8c 100644
> ---
> a/Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiSiPreMem
> DefaultPolicyInitLib/PeiSiPreMemDefaultPolicyInitLib.c
> +++
> b/Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiSiPreMe
> +++ mDefaultPolicyInitLib/PeiSiPreMemDefaultPolicyInitLib.c
> @@ -32,7 +32,7 @@ PeiSiPreMemDefaultPolicyInitLibConstructor (
>    if (PeiPreMemSiDefaultPolicyInitPpi == NULL) {
>      return Status;
>    }
> -  DEBUG ((DEBUG_INFO, "PeiPreMemSiDefaultPolicyInitPpi-
> >PeiPreMemPolicyInit ()\n", Status));
> +  DEBUG ((DEBUG_INFO,
> + "PeiPreMemSiDefaultPolicyInitPpi->PeiPreMemPolicyInit ()\n"));
>    Status = PeiPreMemSiDefaultPolicyInitPpi->PeiPreMemPolicyInit ();
>    ASSERT_EFI_ERROR (Status);
> 
> --
> 2.28.0.windows.1


  reply	other threads:[~2022-10-06 12:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05  3:35 [edk2-platforms][PATCH v1 0/3] Platform/Intel: Fix invalid DEBUG() macros Michael Kubacki
2022-10-05  3:35 ` [edk2-platforms][PATCH v1 1/3] MinPlatformPkg: Fix invalid debug macros Michael Kubacki
2022-10-05  3:35 ` [edk2-platforms][PATCH v1 2/3] TigerLakeOpenBoardPkg: Remove unnecessary debug macro argument Michael Kubacki
2022-10-06 12:19   ` Heng Luo [this message]
2022-10-06 23:59   ` Chaganty, Rangasai V
2022-10-05  3:35 ` [edk2-platforms][PATCH v1 3/3] WhitleyOpenBoardPkg: Fix invalid debug macros Michael Kubacki
2022-10-10 21:11 ` [edk2-platforms][PATCH v1 0/3] Platform/Intel: Fix invalid DEBUG() macros Isaac Oram
     [not found] ` <171CD17D6C79385E.7991@groups.io>
2022-10-10 21:17   ` [edk2-devel] " Isaac Oram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB2752D014113932B4ACC93BF8935C9@SN6PR11MB2752.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox