From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.37652.1598596827641618537 for ; Thu, 27 Aug 2020 23:40:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=rPKzFVHL; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: qi1.zhang@intel.com) IronPort-SDR: /TiYZ9SfIQdj7/OSa9ucrJKLweTEY43tOqVGrFXCXhVmRTLQwPiinKzMD45jW7vtuiWVZWrppQ mGg6RJw0EC/w== X-IronPort-AV: E=McAfee;i="6000,8403,9726"; a="218170646" X-IronPort-AV: E=Sophos;i="5.76,362,1592895600"; d="scan'208";a="218170646" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2020 23:40:26 -0700 IronPort-SDR: Kn9uMaZld4Gsy2JcfAncnw0fNhW4HiDwGw3Sa1hAendDOADCmzx5EJl+ugtzsqx+p4ExM4i5y0 CzpjldEWnnIQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,362,1592895600"; d="scan'208";a="329865319" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga008.jf.intel.com with ESMTP; 27 Aug 2020 23:40:26 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 27 Aug 2020 23:40:23 -0700 Received: from orsmsx115.amr.corp.intel.com (10.22.240.11) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 27 Aug 2020 23:40:23 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX115.amr.corp.intel.com (10.22.240.11) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Aug 2020 23:40:23 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Aug 2020 23:40:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k8pIkMeidsGhJZpCIdbwDgt8U6D4sko7wHaQybQ3+al2bdOausYx1//aykOPCm2pPBmP4EbjC7p5RELZFgBVBlMliT5mPKYa9Lh/7SnAOT8l0xlbmlvcSLi2HnSsexfu+36PBH1VvDBJuEiSV0vjIwHzEirthGUaxpP6e5Wc5tYBatk8yxIbDDi8CfxARS/+/0ugdvOr5C/2rorDZAu0Z/VXwcfkWB4qt9RWtZGApOWPUWyE5ktepYY3eFblGG8Jx8wVAK0g34RiJ4u1gKDi7V/AtqdAlt/hg8Cm/7GuyTMh6rU3pb7LykXGQiCNAaZa065zJMJCYZmogQsX/91YEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P6FJStn0BymSSyVRgbr2muZseXS2wjJVGLqPZMRx8bs=; b=OHWSlZmll5q3w8axY5vwMRJgEjwh+1mhEFguf8wFyOMFsXwV6HeHoJFUu2oKJboQYNQ1ech4BqCt+q1UC649lX6ZKl+DF6q8CQa6LbQ/TsXdrCdCKi4U5Atxy/p1B9rmzHjkJaebbOh6e5flQpfSwkOPQYq/oEwYbPyo80RoiUjuZS+2Pb+t2yPRc5OfCOY7e3csYqY8y8LS7tpUU8cWdEe6HUC+numFPyNtDNQukE4rBjzh9PJx2vyjMvoV4JlwtGsMIifTD9/AicScWVbY/K6GcoWrO30JNmXJI0PYMGGHakz5gyce3u7I9sKB2hZ6hKAuAjjMd/0XrFzmThfTng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P6FJStn0BymSSyVRgbr2muZseXS2wjJVGLqPZMRx8bs=; b=rPKzFVHLMZN5+VrRULaL7vBHhMgWEh0Jjo8RaQJpF1b7hP3fg8E3/Rt5Tq+cpB6uBDEF/TQhpmz0HciiCHfo72H5AdsU3ByVl6U7FB/xD2vAq2pQD/sZCWapyuXXQ9nWLJFZlNYgvWKw2EyoNdG/yElmOZkQTsxtlk3SbbbiZfA= Received: from SN6PR11MB2797.namprd11.prod.outlook.com (2603:10b6:805:5a::32) by SN6PR11MB3136.namprd11.prod.outlook.com (2603:10b6:805:da::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24; Fri, 28 Aug 2020 06:40:22 +0000 Received: from SN6PR11MB2797.namprd11.prod.outlook.com ([fe80::d9a2:f50e:8cd8:7933]) by SN6PR11MB2797.namprd11.prod.outlook.com ([fe80::d9a2:f50e:8cd8:7933%6]) with mapi id 15.20.3326.021; Fri, 28 Aug 2020 06:40:22 +0000 From: "Qi Zhang" To: "Wang, Jian J" , "Wu, Hao A" , "devel@edk2.groups.io" CC: "Yao, Jiewen" Subject: Re: [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library. Thread-Topic: [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library. Thread-Index: AQHWfQKeqzxoEtbM6E+snK9hsSG96KlNC7yAgAAGIRA= Date: Fri, 28 Aug 2020 06:40:22 +0000 Message-ID: References: <20200828061506.8068-1-qi1.zhang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.221] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5c2c2859-26b5-4638-e4be-08d84b1d3d12 x-ms-traffictypediagnostic: SN6PR11MB3136: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /EG3f3TU6WDK8IMht7Q2JIBtMYU3nh6LSq2Bgy/e3ChM9BXkfnm+FvFDQQGBuofWzm3+Q8ZR/aWfpl0ErnKfP8G7oPe0fsqWA5eDB9dAxV3DxHBigylgv0xmoLZqYot3EZhUqfu3iTGBtQH+XedfduvnrX28oNizEYN7jdEHBwODstoq3WV3gqSi9lPfNOQI8yKSCA7scosA/IgIbpymGpo9nij0i//Vj/11qcPXLVKJX983IbUFflQgZYYxbxwFrvzGj4ro9X89KkCjuGmX7v5FkGblT/faYXdBOZGCe/rxQb47OQQYbDx0HCrGiqhAaVCCEQwOLFi8+l9VHXaKsIZh0Qdxe6KMMD5aIZXkBAO0SLndGn6wxuGl4hhEoqk+/LOhx3rFgQEE64u1yt/jGg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2797.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(346002)(396003)(376002)(366004)(4326008)(76116006)(71200400001)(66556008)(33656002)(26005)(86362001)(966005)(66946007)(66476007)(5660300002)(316002)(7696005)(53546011)(6506007)(186003)(110136005)(52536014)(66446008)(64756008)(83380400001)(2906002)(478600001)(9686003)(107886003)(55016002)(8936002)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: i780OamNUOtFaUDREDQtAaWx2PtyHCtmjSihGGFAvRG+p5FKz/mOHF5Uf1NrAGcVYsrFBRGFH3M8+mGci01Zlx8EVyTRzG9VkAL+VnpTnorupWE6CxSjr8oubiMeT53AwdemrnZJhjfHCPZSBxBmRYLUAHXsVXHLBcDyiuXsyoYR2ulZOKJzMpe0kUWfDuXMU3gTJPi8c4znQAOz+YGKxtD/1I2VL5YHcq46g2s+3terQ4CCaLmjZdsI9DNskmrVamwkBUDhaqmhnBK9MeYnP+9lq4nlml73fQmk+cQnbvV21VjrHSh6i7PK9ujp7Xy9yb29tgGvbaN4tkb3aCowvdyGyMP95yfnT9ndt7tgqqwbCBzsuLLa8UH2mHoWHTWUwM6DA1p/JXusGMPkpSpAP9Bdh4YcLTyKs5xbJaF7DiQTXePms4oENIAgul7sX6vVJBx8gUfFHt8RT2dLoMw8VoryI5u7IrdBvwqJoRcvzAB7zCJxVbI2tPx1TbA5bOrSJD6BIvlskj6L1Wr3tnZR6N9ZHchmR1NtBzVGj2erdtEA7KfzQIb+Qlhx6b1C0eFCHkYyZCtymTb2phiLZhXCSMkx9iESq3c87juCXtIjCHDi03qqBuaOKLyM+9CFkntKx94kRUUH50wp0921wnwUPw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2797.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c2c2859-26b5-4638-e4be-08d84b1d3d12 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Aug 2020 06:40:22.2389 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q1tPSJUtUprFYxp8vkuzrvwyXsmkcNHQ6IWCzFdDl80oJsvAeLvbZXCr3vQbH0GVDDbVJAh6SwECOwT6DftXuQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3136 Return-Path: qi1.zhang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Jian & Hao Could you please review this change as well? Thanks! Qi Zhang > -----Original Message----- > From: Yao, Jiewen > Sent: Friday, August 28, 2020 2:17 PM > To: Zhang, Qi1 ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: RE: [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull > to BASE library. >=20 > Reviewed-by: Jiewen Yao >=20 > > -----Original Message----- > > From: Zhang, Qi1 > > Sent: Friday, August 28, 2020 2:15 PM > > To: devel@edk2.groups.io > > Cc: Zhang, Qi1 ; Wang, Jian J > > ; Wu, Hao A ; Yao, Jiewen > > > > Subject: [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull > to > > BASE library. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2940 > > > > TpmMeasurementLib includes DxeTpmMeasurementLib and > > PeiTpmMeasurementLib. > > So need to change TpmMeasurementLibNull to BASE library to avoid build > > error in some platform. > > > > Signed-off-by: Qi Zhang > > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Jiewen Yao > > --- > > .../Library/TpmMeasurementLibNull/TpmMeasurementLibNull.c | 4 +++- > > .../Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf | 6 > > +++--- > > 2 files changed, 6 insertions(+), 4 deletions(-) > > > > diff --git > > > a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull. > c > > > b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull. > c > > index b9c5b68de8..ee3be62fc6 100644 > > --- > > > a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull. > c > > +++ > > > b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull. > c > > @@ -1,11 +1,13 @@ > > /** @file > > > > This library is used by other modules to measure data to TPM. > > > > > > > > -Copyright (c) 2015, Intel Corporation. All rights reserved.
> > > > +Copyright (c) 2015-2020, Intel Corporation. All rights reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > > > **/ > > > > > > > > +#include > > > > + > > > > /** > > > > Tpm measure and log data, and extend the measurement result into a > > specific PCR. > > > > > > > > diff --git > > > a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.i > n > > f > > > b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.i > n > > f > > index 61abcfa2ec..1db2c0d6a7 100644 > > --- > > > a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.i > n > > f > > +++ > > > b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.i > n > > f > > @@ -1,7 +1,7 @@ > > ## @file > > > > # Provides NULL TPM measurement function. > > > > # > > > > -# Copyright (c) 2015 - 2018, Intel Corporation. All rights > > reserved.
> > > > +# Copyright (c) 2015 - 2020, Intel Corporation. All rights > > +reserved.
> > > > # SPDX-License-Identifier: BSD-2-Clause-Patent > > > > # > > > > ## > > > > @@ -10,9 +10,9 @@ > > INF_VERSION =3D 0x00010005 > > > > BASE_NAME =3D TpmMeasurementLibNull > > > > FILE_GUID =3D 6DFD6E9F-9278-48D8-8F45-B6CFF2C2B= 69C > > > > - MODULE_TYPE =3D UEFI_DRIVER > > > > + MODULE_TYPE =3D BASE > > > > VERSION_STRING =3D 1.0 > > > > - LIBRARY_CLASS =3D TpmMeasurementLib|DXE_DRIVER > > DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER > > > > + LIBRARY_CLASS =3D TpmMeasurementLib > > > > MODULE_UNI_FILE =3D TpmMeasurementLibNull.uni > > > > > > > > # > > > > -- > > 2.26.2.windows.1