From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.6478.1589244567505354055 for ; Mon, 11 May 2020 17:49:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Q57wMHax; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: chasel.chiu@intel.com) IronPort-SDR: 4k44J3nfr5zuZ71DKxyxLl5qBYP7ar9kjtrZ3X3POQmIxRy+18VKtDHkWqL9fTIBnGW7bmzOXE bIwp6rj5pzsw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 17:49:26 -0700 IronPort-SDR: HSMcj4GnPBSDq+2iKHcFsf7K/+vnjUXk2Mgtd14QL5yKe7Hbvi4OP/9xh2cxOMdTAcSizQOrcb fmlYyqVg6x3A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,381,1583222400"; d="scan'208";a="250721450" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 11 May 2020 17:49:26 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 17:49:26 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 11 May 2020 17:49:25 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 11 May 2020 17:49:25 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.52) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 17:49:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f9isNAgHWs8ostT8nZDKfVC2dPXNGmBX/kSE779hWIHlGyCH5Bz0nNyTc12EICZGj/TWqBUUAEwBc3lBPZ9kI13q9z0NjuOGnRdhZ9kl1KGjLfY93NBbH9vO+yuagcJz2FFvV8qacN7mbPbR51S06wSV10CwLuZRnSgEcNy3EC8y3AASDBOfXRE8U1f490muayltGCKfwoNYnKmuEboaj2+h8OCl91kAqunOtGXTYZIuee/23AVJv5IhFx3NEfNqpXMRGjj//Zv+iS7I4qkZGNtzG0w3HTszD3p5sJIKzaCDgQCY2bS89JlzHVPt5cDOy3GTSAqAlDGvqWGCAYeTDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lqpVHD/pKMAY0JT8Rtp6bi9GnJ6o6wV8tpW5Kjk1Irw=; b=nQQYfMyWjusMtufVmuSSa/CtcZx2FFKvMlyyASYsFK6TbtrWjXrBDgbKuLvBl4bjaWQ5xd8xuwUOKBYHNxB+pFyfUf6Qi7zgWzyGLcZLdaSwCwO39nPtfDNX1gOyI4NlNOMNGdCjGPfL+5N+M88FRIA1eIMf6RrCONlOGcg0iNOmL3+DAgu7wiYtkuNLUzcSZc33U3U9Nz4cVp1cXnEEg86g9Sz6UGrcKRK2a0d1wBkEYpWr1Z9sptEbjg8nPxOFZ0MWpuHscwqRFuOGNJNyzDNV9ws5GNuFKYgWYjyLlOvU73a+e8H/W1m/iMwbCvckKpE3F0q2c9zo+DpconaWeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lqpVHD/pKMAY0JT8Rtp6bi9GnJ6o6wV8tpW5Kjk1Irw=; b=Q57wMHaxGidYus4y/FabJjaYmytF9zMRh3I5z7Ac6eVDGOtp01p6U3shPBV1gl7LFk4B4eH3kOak2EGNu8D9FGXRADzBe3erDuwi+ipp32BksYLOKpvbKOit7T1CljQA3Y3Chfh74/y/EwLzZrdsTHI52plizfM1FmxZZp1f2pA= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB2895.namprd11.prod.outlook.com (2603:10b6:805:cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Tue, 12 May 2020 00:49:11 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584%4]) with mapi id 15.20.2979.033; Tue, 12 May 2020 00:49:11 +0000 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "cheptsov@ispras.ru" Subject: Re: [edk2-devel] [PATCH V4 14/27] IntelFsp2Pkg: Add support for DebugCommonLib Thread-Topic: [edk2-devel] [PATCH V4 14/27] IntelFsp2Pkg: Add support for DebugCommonLib Thread-Index: AQHWJ6rXpW83MJulwEq48iYee0fv6aijnu8g Date: Tue, 12 May 2020 00:49:11 +0000 Message-ID: References: <20200511154121.3878-1-cheptsov@ispras.ru> <20200511154121.3878-15-cheptsov@ispras.ru> In-Reply-To: <20200511154121.3878-15-cheptsov@ispras.ru> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 39e115ee-c6d7-4c67-8b0e-08d7f60e4979 x-ms-traffictypediagnostic: SN6PR11MB2895: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0401647B7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +CfL+pwbJUvCV+XdpWyAgsNx3MHrF/zrQsOLRSrwyGstTtKLMj1F8S60h3+CzhKvAK1HVOr9tncNpDSa6CYPHK35iqT+4H5GlZIylRseEs3GACpwf/WQTTZXtMBdNL9qnjhtIVu3pTvN9DicpCVs9BnSknZTfW22ho2Z1UBy328LKvidDDK6fuQaPbgZ1W8f0IK+raUKOejeYszvSCR1z8W95r5h4GMGu0LNx/7Ibc8TKZEuQ6ffCw6419/Uhy6FHmBdu2Zk1v5LRwO+zkuXrIId7uzM7aSMpNmRbi5vSWfKcw+F5CL5vviI3NhFTZ4TSeI1/w61MqScZJViCFxcAliO8I63Zn0j4p0NSDawTyFgHNsJjdDQIZpdOQiVNTxxjsD4gxTPvEySPHxi/Jkk+JFMXFXCG6KfT9tHvYkrAj7ZZqUNI3vNJa2zPFJh2urnwbtn0fvoRXHx/k2O8t4GrPlpjaHzu6vPx/+HneFmmqnhV57rdCYd8B5HfwEWPBWdStrXp+zJWSzKv80CfJ3F//eOOW6EOpZ+1OAXkMpqlG+aJl7gjYEfmuXImi1kascAr6MDx1kbD7SbCX76Cqtn+OZxPDPgGqdYlDfS+yIJlEs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(136003)(376002)(39860400002)(346002)(366004)(33430700001)(71200400001)(478600001)(966005)(2906002)(86362001)(110136005)(76116006)(186003)(8676002)(8936002)(53546011)(7696005)(26005)(6506007)(9686003)(66946007)(66556008)(66476007)(66446008)(64756008)(55016002)(316002)(33656002)(52536014)(5660300002)(19627235002)(33440700001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: BEY66doHJgzNRS+xUdM1RItNdruL9RMciRRL52z/syrH36GSqn9QKqHNBe4X0UGQp+ZJ+bcRdfzcuK7MpQ3dyqfwcIOBwGrphlY3zaBhH+tG8tUfX8ckLXWcjmlmgHXodtNq5hVeLvyqWjubYHc0QZvY9J2Od9jiEJLNOQKOATDDsWj2T4hS1bnaBIrSx235lcWkkioeedaClHXLoJC+1hDoGB6TNYNea/E3rEO+HXPFaPp4sA0szybk546FP9rs3qf9HGgHm7n81hjJvscjMm91TSEd4kuEzCHjf6lZ+GntwkwVB56L4/2UxnG1jm/DOm+ZHdLmue09y+/PVEnATvZJa/Cqn3V3thkHuRypwMf+3wtCblw8n/YNEkVjoPy7JXgmOuU9kgMaFr8UOBQ0vyWSNlNhA09+BIGtEwSsMJRZe9doUgeks9AYW8fIkMkDx6oeDl4RpIHTwUGj9RRRrIxoV+fAW62U16B4xR2Lo9GylUv/Bvr41Ij2Xuxme7su x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 39e115ee-c6d7-4c67-8b0e-08d7f60e4979 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2020 00:49:11.7232 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zJDxUT/iOKkVgEHvdiwqwjlG3YMoUy9ZJrnbX1sqVSzZ/kvvU3VOw4hngeFh5diZpzFLJMaH/dlb5llFuHJN9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2895 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Vitaly > Cheptsov > Sent: Monday, May 11, 2020 11:41 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH V4 14/27] IntelFsp2Pkg: Add support for > DebugCommonLib >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2054 >=20 > Signed-off-by: Vitaly Cheptsov > --- > IntelFsp2Pkg/IntelFsp2Pkg.dsc > | 1 + >=20 > IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort. > inf | 1 + > IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > | 97 -------------------- > 3 files changed, 2 insertions(+), 97 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.dsc b/IntelFsp2Pkg/IntelFsp2Pkg.ds= c > index 02fe9cb188..3b2d2a5b8a 100644 > --- a/IntelFsp2Pkg/IntelFsp2Pkg.dsc > +++ b/IntelFsp2Pkg/IntelFsp2Pkg.dsc > @@ -21,6 +21,7 @@ [LibraryClasses] > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf+ > DebugCommonLib|MdePkg/Library/BaseDebugCommonLib/BaseDebugCom > monLib.inf > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Base > DebugPrintErrorLevelLib.inf > PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf > IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.infdiff --git > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPo > rt.inf > b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPo > rt.inf > index 14b1899e6c..c708386677 100644 > --- > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPo > rt.inf > +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSeri > +++ alPort.inf > @@ -35,6 +35,7 @@ [LibraryClasses] > PcdLib PrintLib BaseLib+ DebugCommonLib DebugDeviceLib > DebugPrintErrorLevelLib diff --git > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > index b34905365d..f2e1de8822 100644 > --- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > @@ -316,100 +316,3 @@ DebugClearMemory ( > { return Buffer; }---/**- Returns TRUE if ASSERT() macros are enabled= .-- > This function returns TRUE if the > DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of- > PcdDebugPropertyMask is set. Otherwise FALSE is returned.-- @retval > TRUE The DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of > PcdDebugPropertyMask is set.- @retval FALSE The > DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of PcdDebugPropertyMask > is clear.--**/-BOOLEAN-EFIAPI-DebugAssertEnabled (- VOID- )-{- return > (BOOLEAN) ((PcdGet8(PcdDebugPropertyMask) & > DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED) !=3D 0);-}---/**- Returns TRUE > if DEBUG() macros are enabled.-- This function returns TRUE if the > DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of- > PcdDebugPropertyMask is set. Otherwise FALSE is returned.-- @retval > TRUE The DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of > PcdDebugPropertyMask is set.- @retval FALSE The > DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of PcdDebugPropertyMask is > clear.--**/-BOOLEAN-EFIAPI-DebugPrintEnabled (- VOID- )-{- return > (BOOLEAN) ((PcdGet8(PcdDebugPropertyMask) & > DEBUG_PROPERTY_DEBUG_PRINT_ENABLED) !=3D 0);-}--/**- Returns TRUE if > DEBUG_CODE() macros are enabled.-- This function returns TRUE if the > DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of- PcdDebugPropertyMask > is set. Otherwise FALSE is returned.-- @retval TRUE The > DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of PcdDebugPropertyMask is > set.- @retval FALSE The DEBUG_PROPERTY_DEBUG_CODE_ENABLED > bit of PcdDebugPropertyMask is > clear.--**/-BOOLEAN-EFIAPI-DebugCodeEnabled (- VOID- )-{- return > (BOOLEAN) ((PcdGet8(PcdDebugPropertyMask) & > DEBUG_PROPERTY_DEBUG_CODE_ENABLED) !=3D 0);-}---/**- Returns TRUE if > DEBUG_CLEAR_MEMORY() macro is enabled.-- This function returns TRUE > if the DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of- > PcdDebugPropertyMask is set. Otherwise FALSE is returned.-- @retval > TRUE The DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of > PcdDebugPropertyMask is set.- @retval FALSE The > DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of > PcdDebugPropertyMask is > clear.--**/-BOOLEAN-EFIAPI-DebugClearMemoryEnabled (- VOID- )-{- > return (BOOLEAN) ((PcdGet8(PcdDebugPropertyMask) & > DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED) !=3D 0);-}--/**- Returns TRUE > if any one of the bit is set both in ErrorLevel and > PcdFixedDebugPrintErrorLevel.-- This function compares the bit mask of > ErrorLevel and PcdFixedDebugPrintErrorLevel.-- @retval TRUE > Current ErrorLevel is supported.- @retval FALSE Current ErrorLevel is > not supported.--**/-BOOLEAN-EFIAPI-DebugPrintLevelEnabled (- IN > CONST UINTN ErrorLevel- )-{- return (BOOLEAN) ((ErrorLevel & > PcdGet32(PcdFixedDebugPrintErrorLevel)) !=3D 0);-}-- > 2.24.2 (Apple Git-127) >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#59113): https://edk2.groups.io/g/devel/message/59113 > Mute This Topic: https://groups.io/mt/74138546/1777047 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com= ] > -=3D-=3D-=3D-=3D-=3D-=3D