* [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit
@ 2020-05-12 17:25 Kathappan Esakkithevar
2020-05-12 23:58 ` Chiu, Chasel
2020-05-13 0:11 ` Chaganty, Rangasai V
0 siblings, 2 replies; 5+ messages in thread
From: Kathappan Esakkithevar @ 2020-05-12 17:25 UTC (permalink / raw)
To: devel; +Cc: Sai Chaganty, Chasel Chiu, Nate DeSimone, Deepika Kethi Reddy
The Ddr4MixedUDimm2DpcLimit FSP-M Upd has been renamed as
Ddr4Mixed2DpcLimit at CometLakeFspBinPkg\CometLake1.
FSP wrapper driver need to use FSP-M Upd name Ddr4Mixed2DpcLimit
from CometLake1 FSP at CometlakeOpenBoardPkg.
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2714
Signed-off-by: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
---
.../FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c
index 45d76ad5e4..53f26d824f 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c
+++ b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c
@@ -344,7 +344,7 @@ PeiFspSaPolicyInitPreMem (
FspmUpd->FspmConfig.GdxcIotSize = MemConfig->GdxcIotSize;
FspmUpd->FspmConfig.GdxcMotSize = MemConfig->GdxcMotSize;
FspmUpd->FspmConfig.DualDimmPerChannelBoardType =(UINT8) MemConfig->DualDimmPerChannelBoardType;
- FspmUpd->FspmConfig.Ddr4MixedUDimm2DpcLimit =(UINT8) MemConfig->Ddr4MixedUDimm2DpcLimit;
+ FspmUpd->FspmConfig.Ddr4Mixed2DpcLimit =(UINT8) MemConfig->Ddr4MixedUDimm2DpcLimit;
//
// Update UPD:CaVrefConfig
//
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit
2020-05-12 17:25 [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit Kathappan Esakkithevar
@ 2020-05-12 23:58 ` Chiu, Chasel
2020-05-13 0:11 ` Chaganty, Rangasai V
1 sibling, 0 replies; 5+ messages in thread
From: Chiu, Chasel @ 2020-05-12 23:58 UTC (permalink / raw)
To: Esakkithevar, Kathappan, devel@edk2.groups.io
Cc: Chaganty, Rangasai V, Desimone, Nathaniel L, Kethi Reddy, Deepika
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com>
> Sent: Wednesday, May 13, 2020 1:26 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kethi Reddy, Deepika
> <deepika.kethi.reddy@intel.com>
> Subject: [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to
> Ddr4MixedUDimm2DpcLimit
>
> The Ddr4MixedUDimm2DpcLimit FSP-M Upd has been renamed as
> Ddr4Mixed2DpcLimit at CometLakeFspBinPkg\CometLake1.
> FSP wrapper driver need to use FSP-M Upd name Ddr4Mixed2DpcLimit from
> CometLake1 FSP at CometlakeOpenBoardPkg.
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2714
>
> Signed-off-by: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> ---
> .../FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c | 2
> +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyI
> nitLib/PeiFspSaPolicyInitLib.c
> b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicy
> InitLib/PeiFspSaPolicyInitLib.c
> index 45d76ad5e4..53f26d824f 100644
> ---
> a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyI
> nitLib/PeiFspSaPolicyInitLib.c
> +++
> b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPoli
> +++ cyInitLib/PeiFspSaPolicyInitLib.c
> @@ -344,7 +344,7 @@ PeiFspSaPolicyInitPreMem (
> FspmUpd->FspmConfig.GdxcIotSize =
> MemConfig->GdxcIotSize;
> FspmUpd->FspmConfig.GdxcMotSize =
> MemConfig->GdxcMotSize;
> FspmUpd->FspmConfig.DualDimmPerChannelBoardType =(UINT8)
> MemConfig->DualDimmPerChannelBoardType;
> - FspmUpd->FspmConfig.Ddr4MixedUDimm2DpcLimit =(UINT8)
> MemConfig->Ddr4MixedUDimm2DpcLimit;
> + FspmUpd->FspmConfig.Ddr4Mixed2DpcLimit =(UINT8)
> MemConfig->Ddr4MixedUDimm2DpcLimit;
> //
> // Update UPD:CaVrefConfig
> //
> --
> 2.16.2.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit
2020-05-12 17:25 [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit Kathappan Esakkithevar
2020-05-12 23:58 ` Chiu, Chasel
@ 2020-05-13 0:11 ` Chaganty, Rangasai V
2020-05-14 1:24 ` [edk2-devel] " Dong, Eric
1 sibling, 1 reply; 5+ messages in thread
From: Chaganty, Rangasai V @ 2020-05-13 0:11 UTC (permalink / raw)
To: Esakkithevar, Kathappan, devel@edk2.groups.io
Cc: Chiu, Chasel, Desimone, Nathaniel L, Kethi Reddy, Deepika
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com>
Sent: Tuesday, May 12, 2020 10:26 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kethi Reddy, Deepika <deepika.kethi.reddy@intel.com>
Subject: [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit
The Ddr4MixedUDimm2DpcLimit FSP-M Upd has been renamed as Ddr4Mixed2DpcLimit at CometLakeFspBinPkg\CometLake1.
FSP wrapper driver need to use FSP-M Upd name Ddr4Mixed2DpcLimit from CometLake1 FSP at CometlakeOpenBoardPkg.
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2714
Signed-off-by: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
---
.../FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c
index 45d76ad5e4..53f26d824f 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c
+++ b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPoli
+++ cyInitLib/PeiFspSaPolicyInitLib.c
@@ -344,7 +344,7 @@ PeiFspSaPolicyInitPreMem (
FspmUpd->FspmConfig.GdxcIotSize = MemConfig->GdxcIotSize;
FspmUpd->FspmConfig.GdxcMotSize = MemConfig->GdxcMotSize;
FspmUpd->FspmConfig.DualDimmPerChannelBoardType =(UINT8) MemConfig->DualDimmPerChannelBoardType;
- FspmUpd->FspmConfig.Ddr4MixedUDimm2DpcLimit =(UINT8) MemConfig->Ddr4MixedUDimm2DpcLimit;
+ FspmUpd->FspmConfig.Ddr4Mixed2DpcLimit =(UINT8) MemConfig->Ddr4MixedUDimm2DpcLimit;
//
// Update UPD:CaVrefConfig
//
--
2.16.2.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit
2020-05-13 0:11 ` Chaganty, Rangasai V
@ 2020-05-14 1:24 ` Dong, Eric
2020-05-14 3:16 ` Kathappan Esakkithevar
0 siblings, 1 reply; 5+ messages in thread
From: Dong, Eric @ 2020-05-14 1:24 UTC (permalink / raw)
To: devel@edk2.groups.io, Chaganty, Rangasai V,
Esakkithevar, Kathappan
Cc: Chiu, Chasel, Desimone, Nathaniel L, Kethi Reddy, Deepika
Hi all,
Seems this patch has passed code review.
Also, it used to fix a platform build failure, and other patches will be blocked if this platform build failure, so I help to push the code change.
Pushed: SHA-1: c2cb5a4d1b54e8fe79fe1c1132034989597fee10
Thanks,
Eric
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Chaganty, Rangasai V
> Sent: Wednesday, May 13, 2020 8:11 AM
> To: Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com>;
> devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kethi Reddy, Deepika
> <deepika.kethi.reddy@intel.com>
> Subject: Re: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build
> error due to Ddr4MixedUDimm2DpcLimit
>
> Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
>
> -----Original Message-----
> From: Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com>
> Sent: Tuesday, May 12, 2020 10:26 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kethi Reddy, Deepika
> <deepika.kethi.reddy@intel.com>
> Subject: [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to
> Ddr4MixedUDimm2DpcLimit
>
> The Ddr4MixedUDimm2DpcLimit FSP-M Upd has been renamed as
> Ddr4Mixed2DpcLimit at CometLakeFspBinPkg\CometLake1.
> FSP wrapper driver need to use FSP-M Upd name Ddr4Mixed2DpcLimit from
> CometLake1 FSP at CometlakeOpenBoardPkg.
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2714
>
> Signed-off-by: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> ---
> .../FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic
> yInitLib/PeiFspSaPolicyInitLib.c
> b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic
> yInitLib/PeiFspSaPolicyInitLib.c
> index 45d76ad5e4..53f26d824f 100644
> ---
> a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic
> yInitLib/PeiFspSaPolicyInitLib.c
> +++
> b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPoli
> +++ cyInitLib/PeiFspSaPolicyInitLib.c
> @@ -344,7 +344,7 @@ PeiFspSaPolicyInitPreMem (
> FspmUpd->FspmConfig.GdxcIotSize = MemConfig->GdxcIotSize;
> FspmUpd->FspmConfig.GdxcMotSize = MemConfig->GdxcMotSize;
> FspmUpd->FspmConfig.DualDimmPerChannelBoardType =(UINT8)
> MemConfig->DualDimmPerChannelBoardType;
> - FspmUpd->FspmConfig.Ddr4MixedUDimm2DpcLimit =(UINT8)
> MemConfig->Ddr4MixedUDimm2DpcLimit;
> + FspmUpd->FspmConfig.Ddr4Mixed2DpcLimit =(UINT8) MemConfig-
> >Ddr4MixedUDimm2DpcLimit;
> //
> // Update UPD:CaVrefConfig
> //
> --
> 2.16.2.windows.1
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit
2020-05-14 1:24 ` [edk2-devel] " Dong, Eric
@ 2020-05-14 3:16 ` Kathappan Esakkithevar
0 siblings, 0 replies; 5+ messages in thread
From: Kathappan Esakkithevar @ 2020-05-14 3:16 UTC (permalink / raw)
To: Dong, Eric, devel@edk2.groups.io, Chaganty, Rangasai V
Cc: Chiu, Chasel, Desimone, Nathaniel L, Kethi Reddy, Deepika
Thanks Eric!!
> -----Original Message-----
> From: Dong, Eric <eric.dong@intel.com>
> Sent: Thursday, May 14, 2020 6:54 AM
> To: devel@edk2.groups.io; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Esakkithevar, Kathappan
> <kathappan.esakkithevar@intel.com>
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kethi Reddy, Deepika
> <deepika.kethi.reddy@intel.com>
> Subject: RE: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build
> error due to Ddr4MixedUDimm2DpcLimit
>
> Hi all,
>
> Seems this patch has passed code review.
> Also, it used to fix a platform build failure, and other patches will be blocked
> if this platform build failure, so I help to push the code change.
>
> Pushed: SHA-1: c2cb5a4d1b54e8fe79fe1c1132034989597fee10
>
>
> Thanks,
> Eric
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Chaganty, Rangasai V
> > Sent: Wednesday, May 13, 2020 8:11 AM
> > To: Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com>;
> > devel@edk2.groups.io
> > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Kethi Reddy, Deepika
> > <deepika.kethi.reddy@intel.com>
> > Subject: Re: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix
> > build error due to Ddr4MixedUDimm2DpcLimit
> >
> > Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
> >
> > -----Original Message-----
> > From: Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com>
> > Sent: Tuesday, May 12, 2020 10:26 AM
> > To: devel@edk2.groups.io
> > Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Chiu, Chasel
> > <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Kethi Reddy, Deepika
> > <deepika.kethi.reddy@intel.com>
> > Subject: [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to
> > Ddr4MixedUDimm2DpcLimit
> >
> > The Ddr4MixedUDimm2DpcLimit FSP-M Upd has been renamed as
> > Ddr4Mixed2DpcLimit at CometLakeFspBinPkg\CometLake1.
> > FSP wrapper driver need to use FSP-M Upd name Ddr4Mixed2DpcLimit
> from
> > CometLake1 FSP at CometlakeOpenBoardPkg.
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2714
> >
> > Signed-off-by: Kathappan Esakkithevar
> > <kathappan.esakkithevar@intel.com>
> > Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> > ---
> > .../FspWrapper/Library/PeiFspPolicyInitLib/PeiFspSaPolicyInitLib.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> >
> a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic
> > yInitLib/PeiFspSaPolicyInitLib.c
> >
> b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic
> > yInitLib/PeiFspSaPolicyInitLib.c
> > index 45d76ad5e4..53f26d824f 100644
> > ---
> >
> a/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolic
> > yInitLib/PeiFspSaPolicyInitLib.c
> > +++
> > b/Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiFspPoli
> > +++ cyInitLib/PeiFspSaPolicyInitLib.c
> > @@ -344,7 +344,7 @@ PeiFspSaPolicyInitPreMem (
> > FspmUpd->FspmConfig.GdxcIotSize = MemConfig->GdxcIotSize;
> > FspmUpd->FspmConfig.GdxcMotSize = MemConfig->GdxcMotSize;
> > FspmUpd->FspmConfig.DualDimmPerChannelBoardType =(UINT8)
> > MemConfig->DualDimmPerChannelBoardType;
> > - FspmUpd->FspmConfig.Ddr4MixedUDimm2DpcLimit =(UINT8)
> > MemConfig->Ddr4MixedUDimm2DpcLimit;
> > + FspmUpd->FspmConfig.Ddr4Mixed2DpcLimit =(UINT8) MemConfig-
> > >Ddr4MixedUDimm2DpcLimit;
> > //
> > // Update UPD:CaVrefConfig
> > //
> > --
> > 2.16.2.windows.1
> >
> >
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-14 3:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-12 17:25 [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit Kathappan Esakkithevar
2020-05-12 23:58 ` Chiu, Chasel
2020-05-13 0:11 ` Chaganty, Rangasai V
2020-05-14 1:24 ` [edk2-devel] " Dong, Eric
2020-05-14 3:16 ` Kathappan Esakkithevar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox