From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web08.3720.1618471562765001671 for ; Thu, 15 Apr 2021 00:26:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=lfvg+WaB; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: chasel.chiu@intel.com) IronPort-SDR: PQGkhX2qzMOrFtL3ZpsAKMLjQLwm5+QYzWih8NzRdgH+bxL3kJVJKiNrs9lZ8cqQInmkBc1wY9 wTCb3VGOU7xg== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="256121731" X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="256121731" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 00:26:01 -0700 IronPort-SDR: 2F50PK9ch7Y/zxU9LEPlphB6f932kLEQiWK08C9jU6mFEhE+iYRn0M4lkz/O6umX52G4AUdMMh ieDY/wY1NMAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="461521379" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 15 Apr 2021 00:26:01 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 15 Apr 2021 00:26:00 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 15 Apr 2021 00:26:00 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 15 Apr 2021 00:26:00 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 15 Apr 2021 00:25:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EO374tW9xCZRr+dhzhbFzR8DnrPqc/lQewbgUHIlbgQMf/p0GROZ1iSAlIZfu0sCfqrTwbOgUkeAim6cLDMM5QGf4ufkdGby4HYQMsAQeYR8BBaS/QrAip6qijmuJlTPhNr+ICA0vOCTmKP6+KUqd6ZGuPE/HBKPBictBgfLiDFYUMTNzyV+/0X4lTlzefhDqNBwV+ryLIDFltuxpj9C++314NYmiGOH2NqKpMztzDDyohTDxlxEb2qejpkMlytuVSvlPlEJSN3kFYnwBOc693qq9AYP3BlpmOszf/AMr33VSDb/uvE34hnAjNwlpy4kaJ9Gdt7lwMATII78XCRohA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W8/n4ZjR28bZ4IezF1A94JiyN+Uv9Y6hRUCA+jSBuWU=; b=KlQ+ukVMrGDPe7VVsvgdEU271A01NvX4ZPekp7c3E2mr1Ip5NC6uaZOMGKirFkIEMpj9fxYkHvE7UJ7PT8ezhKQTOCXl4ANdAS9sP1cQhxlOk7diL6WKG4yp1Q09ryR4fMEAsWisEt0GD4kOELKEtJwVLKV/mMspn+jRxMZcpT8VomWmiMoB/5hcWdctEk2QNwgQAxfCOzN2USfxjBzmDkadAmFoXBwO7O1cMPxouzIZKslaOICGGJZtezhTj0JplWBNWs1dK19byRiky6zCaWktCeQcKkb9791RH6XjFKPNjODzo6WR+H0vWc0V7GlR+d4Hsc2UDi1Lf3VEz0RM+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W8/n4ZjR28bZ4IezF1A94JiyN+Uv9Y6hRUCA+jSBuWU=; b=lfvg+WaB3IW8SYI61K+gL3yJRMYUh5kfBoLIIGd7BngG2uw98ockcg0N37aIka4O+zXR1o6vqMeRG5SKPeq0Pkqbj7yhhXcy+lgT65FiepVjLHAKc0ziiFn8Kz3DIbVn4TViURzJF79a+hZVJSBldIIIhdIk9jaQCLTdwuwoGLo= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB2607.namprd11.prod.outlook.com (2603:10b6:805:56::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.22; Thu, 15 Apr 2021 07:25:57 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::3101:f483:8348:816]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::3101:f483:8348:816%7]) with mapi id 15.20.4042.016; Thu, 15 Apr 2021 07:25:57 +0000 From: "Chiu, Chasel" To: "Lou, Yun" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Zeng, Star" , "Ni, Ray" Subject: Re: [PATCH v2] IntelFsp2WrapperPkg: Remove microcode related PCDs Thread-Topic: [PATCH v2] IntelFsp2WrapperPkg: Remove microcode related PCDs Thread-Index: AQHXMcNpYTRev++6Ik249r1+3rez76q1LRiQ Date: Thu, 15 Apr 2021 07:25:57 +0000 Message-ID: References: <20210415064847.15537-1-yun.lou@intel.com> In-Reply-To: <20210415064847.15537-1-yun.lou@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a08a2b1-59aa-4761-f026-08d8ffdfb665 x-ms-traffictypediagnostic: SN6PR11MB2607: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0KyOH2O/GGFIP0on9HhjfYyVJnxb+eV6hMH6Wb8O9gcCF9qugjasfNbPi+8nLhgkDgRhXoTNepHhC4TleO6RLemWDJUUVRQifEOWtLFhlJqtnPGlUXoNwIkMgBibTfe1eqt53NBYA8KR20jE4NswdNQYzK/urnJE+3iVlh7aGebC4FRelbtqaRD/ZE1ksHbfLYMlNoxO6RQ8knegTe+FXTXtSlouUfOr90HDDOLPpAhudGHecVd0n2NQeu1h0zOgDPcXzk7dehKGEKVSbCIibnFT6D+octT9Ald2J41ycfFAtLl/Tu502G0d1Xzq5Ik01Pddouw/AYNDM8bwoSoWbcMw+YjIPmf5wgWdSC9jlgVAw0MNpdv5PhF7hj61aKTtb44g3TBdKf8nupmoZJTri+uWsFrCYadSTPBxAgZfSuMQVFTWlLt5SjWWR3S4+HBtpdfyZBsGuD3qMXzhqqL0tRZf2+z2ix/Sbr6X7Knm76CdEAeIuGOBFDQzzEcFeBzhkqRTK+hz6cuS+oy1rL/7CV0bD3D3WKAJTcovLL4AgQIrKNtpb9CkRNKAcHspZ6iso7BviT1KnMeaKXzzIW+Q7DcGOt7I/oFlQEBbS/RydVdP9HVjktYkr6/XAowiuRoeRIYZ+YligWWoYccouU7MrlJlpRsVpc1KCbZBuIkrHdfN4OFIYgS8sFcIudkiLWdw x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(39860400002)(366004)(396003)(346002)(71200400001)(64756008)(5660300002)(186003)(76116006)(2906002)(26005)(66476007)(38100700002)(53546011)(4326008)(83380400001)(66446008)(7696005)(110136005)(66556008)(316002)(66946007)(33656002)(52536014)(8676002)(107886003)(19627235002)(86362001)(54906003)(478600001)(9686003)(122000001)(6506007)(8936002)(966005)(55016002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?WnCI2jVR0hsoIyzohC/jDgWBilgYRJpibw19TLMP+jIENFAFxxxDCQrCB03E?= =?us-ascii?Q?w1ks2NLVWEsYkJwKuNktFrDeX8Zj2nYkPNMp5zk57HaHPllfgZQtG73I0s03?= =?us-ascii?Q?gTL6WGX7NvN6dL2zoUayQBTEc7h8VoMM/PfWYIdcF6W2yRbddsUhqEB88f3v?= =?us-ascii?Q?YlG0n0efUT4qqQoRoQaMZW37pz/qLnz1uP3ptLn4SOe80aw/ppHKfK7tAey5?= =?us-ascii?Q?RHsJJ4ngAPaWzYXtTZ3Uus/JqSv/TN1VaqEoxjwJ73KcJOFTH0h8gTN6PFXk?= =?us-ascii?Q?rM2Hc18/zjzsfX9gHHZYiPW1dbRJ7U/xi94d4BI7QuH9I7gogRLH9qwbKvoI?= =?us-ascii?Q?bSTW4oZaUk/bw71uwOZIPcn2uxqdRr0/byAiHRV0FuEciyvRvDPlz6KriHtj?= =?us-ascii?Q?zTUOTqKw6rebHe1qrmftP3eevzMoEkROlYF++Wfb4SJvKAtD2BCvgVeWxO1L?= =?us-ascii?Q?mcRGlev9p5vvXjs0SdO+v27pXjs67561Lv3lTb6vP3TQ5GESyF/M1j/as8YR?= =?us-ascii?Q?X47SwExRpGdY5kenHgskpO2+klm0fMFoPGHtBF5oOjHZlxKxi75HlDr/U/JK?= =?us-ascii?Q?0HOA8xQ/kPVL8MHyUP5DvANSa5ePsb1xlcXSOx0uRXD1fDlFEXydBpOoN6EG?= =?us-ascii?Q?gwaCgl9TFC2mBqMIfWa71mZSnWP8UiQG4dhEmKspF1S9X6WSX+kA7qdKQBpC?= =?us-ascii?Q?Olw2fYrTB25SvniaKHq/ax14W6+SaBrWTcT3PW+4/182G38o2uE40Lkb1bMl?= =?us-ascii?Q?D1Xmq5srExBFWxRZrs9Lrdq5tAe60aBSOii0vZqO1Nl5iA5RtoNubK3G9nQ3?= =?us-ascii?Q?1hG1v50raX3GOwlFwyV5L9bMGPPw4f4qQ2TRKRPaYn88zLhuqO4pCsqfWKPq?= =?us-ascii?Q?Y8d2g3Ahr0U+xRLo+AwoUD/TaWL/gpoOYDk9rJ6qUdCa8bhW09VACumP1MjA?= =?us-ascii?Q?JPcWW5JMlY487WdvMJITNf593iA1LXsgc/Me261DkbPUoEzBx/jv2YW1JwKw?= =?us-ascii?Q?koQ9XobXMpSDL8DALvnwBdEqF643j8QDQPuvSbM5TBoiQvN868bMiicr5zBT?= =?us-ascii?Q?bQsbmA0kG+Uyofrvl9pNygRm9wFx57Sv8foR4z8FwXSBpdmOrhVQFztojyRb?= =?us-ascii?Q?wwypT/dRTjyPUe+gnFAUOLH/BFapTkX0WhqX+0xiOC6JQkYwTX7606HzzdIk?= =?us-ascii?Q?4FYHb0r70wbE+Fl6j0aD9q6IhvOTWl4f/r0Nhx2bmSnsGmZ8wtVjB6H6waIq?= =?us-ascii?Q?2erK1PtOV7IdfnkbE0S/kWemb9yUbRaaWiE+U0poXFLry8OMLZ20nyeZOD7n?= =?us-ascii?Q?qmbzFdlDsI5/QOcmKRqJqbv3?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a08a2b1-59aa-4761-f026-08d8ffdfb665 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2021 07:25:57.4529 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fZ6q75GExmHF3Mufs/c3GgmiAECR5uEgqJqXK/f6hszwVB0gSSIF8ptru0SCYJ7K1bu6cr3lQt4pZlb1qrEd2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2607 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Yun, I would recommend that we split this patch and remove PCD from DEC as last = step after all involved platforms not consuming them, what do you think? Thanks, Chasel > -----Original Message----- > From: Lou, Yun > Sent: Thursday, April 15, 2021 2:49 PM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Chiu, Chasel ; > Desimone, Nathaniel L ; Zeng, Star > ; Ni, Ray > Subject: [PATCH v2] IntelFsp2WrapperPkg: Remove microcode related PCDs >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3334 >=20 > IntelFsp2WrapperPkg defines following PCDs: > PcdCpuMicrocodePatchAddress > PcdCpuMicrocodePatchRegionSize > PcdFlashMicrocodeOffset >=20 > But the PCD name caused confusion because UefiCpuPkg defines: > PcdCpuMicrocodePatchAddress > PcdCpuMicrocodePatchRegionSize >=20 > PcdCpuMicrocodePatchAddress in IntelFsp2WrapperPkg means the base address > of the FV that holds the microcode. > PcdCpuMicrocodePatchAddress in UefiCpuPkg means the address of the > microcode. >=20 > The relationship between the PCDs is: > IntelFsp2WrapperPkg.PcdCpuMicrocodePatchAddress > + IntelFsp2WrapperPkg.PcdFlashMicrocodeOffset > =3D=3D UefiCpuPkg.PcdCpuMicrocodePatchAddress >=20 > IntelFsp2WrapperPkg.PcdCpuMicrocodePatchRegionSize > - IntelFsp2WrapperPkg.PcdFlashMicrocodeOffset > =3D=3D UefiCpuPkg.PcdCpuMicrocodePatchRegionSize >=20 > To avoid confusion and actually the PCDs in IntelFsp2WrapperPkg are only = used > by a sample FSP-T wrapper, this patch removes the 3 PCDs defined in > IntelFsp2WrapperPkg. >=20 > The FSP-T wrapper is updated to directly use the ones in UefiCpuPkg. >=20 > Signed-off-by: Jason Lou > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Ray Ni > --- >=20 > IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamInit > Data.c | 6 +++--- > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > | 8 +------- >=20 > IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecFspWra > pperPlatformSecLibSample.inf | 7 +++---- > 3 files changed, 7 insertions(+), 14 deletions(-) >=20 > diff --git > a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI > nitData.c > b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI > nitData.c > index 96b47e23da..e57b5b57be 100644 > --- > a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI > nitData.c > +++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecR > +++ amInitData.c > @@ -1,7 +1,7 @@ > /** @file Sample to provide TempRamInitParams data. - Copyright (c) 2= 014 - > 2020, Intel Corporation. All rights reserved.
+ Copyright (c) 2014 - = 2021, > Intel Corporation. All rights reserved.
SPDX-License-Identifier: BS= D-2- > Clause-Patent **/@@ -52,8 +52,8 @@ GLOBAL_REMOVE_IF_UNREFERENCED > CONST FSPT_UPD_CORE_DATA FsptUpdDataPtr =3D { > } }, {- ((UINT32)FixedPcdGet64 (PcdCpuMicrocodePatchAddress) = + > FixedPcdGet32 (PcdFlashMicrocodeOffset)),- ((UINT32)FixedPcdGet64 > (PcdCpuMicrocodePatchRegionSize) - FixedPcdGet32 > (PcdFlashMicrocodeOffset)),+ FixedPcdGet32 > (PcdCpuMicrocodePatchAddress),+ FixedPcdGet32 > (PcdCpuMicrocodePatchRegionSize), FixedPcdGet32 > (PcdFlashCodeCacheAddress), FixedPcdGet32 (PcdFlashCodeCacheSize), = }diff > --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > index 6852bf1271..a3b9363779 100644 > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > @@ -1,7 +1,7 @@ > ## @file # Provides drivers and definitions to support fsp in EDKII bios= . #-# > Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.
+# > Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.
# = SPDX- > License-Identifier: BSD-2-Clause-Patent # ##@@ -56,12 +56,6 @@ > ## Provides the size of the BIOS Flash Device. > gIntelFsp2WrapperTokenSpaceGuid.PcdFlashCodeCacheSize|0x00200000|UINT > 32|0x10000002 - ## Indicates the base address of the first Microcode Pat= ch in > the Microcode Region- > gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchAddress|0x0|UINT6 > 4|0x10000005- > gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize|0x0|UI > NT64|0x10000006- ## Indicates the offset of the Cpu Microcode.- > gIntelFsp2WrapperTokenSpaceGuid.PcdFlashMicrocodeOffset|0x90|UINT32|0x > 10000007- ## Indicate the PEI memory size platform want to report > gIntelFsp2WrapperTokenSpaceGuid.PcdPeiMinMemSize|0x1800000|UINT32|0x > 40000004 ## Indicate the PEI memory size platform want to reportdiff --= git > a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecFspW > rapperPlatformSecLibSample.inf > b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecFspW > rapperPlatformSecLibSample.inf > index d7f8301bef..027b127724 100644 > --- > a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecFspW > rapperPlatformSecLibSample.inf > +++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecF > +++ spWrapperPlatformSecLibSample.inf > @@ -1,7 +1,7 @@ > ## @file # Sample to provide FSP wrapper platform sec related function.= #-# > Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.
+# > Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.
# = # SPDX- > License-Identifier: BSD-2-Clause-Patent #@@ -76,8 +76,7 @@ > gIntelFsp2WrapperTokenSpaceGuid.PcdFspmBaseAddress ## > CONSUMES [FixedPcd]- > gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchAddress ## > CONSUMES- > gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize ## > CONSUMES- gIntelFsp2WrapperTokenSpaceGuid.PcdFlashMicrocodeOffset > ## CONSUMES+ gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress > ## CONSUMES+ > gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize ## > CONSUMES gIntelFsp2WrapperTokenSpaceGuid.PcdFlashCodeCacheAddress > ## CONSUMES gIntelFsp2WrapperTokenSpaceGuid.PcdFlashCodeCacheSize > ## CONSUMES-- > 2.28.0.windows.1