From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.428.1588215295286572495 for ; Wed, 29 Apr 2020 19:54:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=WP+PnJTy; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: chasel.chiu@intel.com) IronPort-SDR: 8MPZzZJDSj9/MdnM1frXUdfiJuTPWgMtPUJwDb4ZSodtitZLi+ON1JC6wVwDO9dChIcZgC88M3 TDMXtCxWor/Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 19:54:53 -0700 IronPort-SDR: cd0AZeBWNOQn7G5/EQbpbTWyyFroy4lSx6N4AQAFE8XLa/9fHQiAe0iK+dvdXYW51zcJ6tv3L+ v2lfYjIJgpTA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,333,1583222400"; d="scan'208";a="282706365" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga004.fm.intel.com with ESMTP; 29 Apr 2020 19:54:53 -0700 Received: from orsmsx158.amr.corp.intel.com (10.22.240.20) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 19:54:53 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX158.amr.corp.intel.com (10.22.240.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 19:54:53 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 19:54:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yv5dSz5ngMTRFs4d3+3aG0v8N9wOcyl2mau1rRaxKI/fgClGn9ttcDIIzuP2bCjESQo0T9qm2otjbH7DDHbg2dmCzv4rroJC0KjR0m+Al4gvbNwj9ffmwzyn9gL/HG5B1vnQ1t4G7kTnXA5YLckzjDzlSSrY6e2ZHU0rwU3Pzey+qP+6lMP+Jn3SVjN/YGVAHLjp75G//jGaAdy41/QpXwUrZ8KARgN513njE/to+nEaEQLCZJWgcRIjGQgEI+KWK8oNRwW1KWppBrDwjr+eYQWh3BaaSCPF6hmkreaAt/JBoo3nSptRwNEsySa+PW+hx+32OIr0V3RuSzQNK4rCfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IhE4rU0Rtj3x8jhMwfnV9UeF6rrN44qzJYKKUHziCOg=; b=gmFpi/edCg8VZk5i9Ju9xbONkprfMsj7lh5SCphlxVMuEJZDeSCyFPrJn3uReEJ461TC5OVjuErGr0QyALAJhzx17Yu2zKIz1cR7CMx+6EyHd5DNKkFtUv51wyjjjXVa9zOstkpCnudDEDHQwPrmMhWowiz7ubPNcISPLQ1PYvQ4NmqaeIBsG9n1UDyTwU9G36DInxEfAO2ZnQ7wlJjCn/eI87WMZ2VygOJIhJvlZwHomdcBNvIL38uZgNjQHMGa8+lPAQUl0maveCSP7/UinhqgsJouet9WOxiO/mqVSJb0at8WnabA+eZXZOI29mPv2GmTGOrb9gMMOMJMjuN42A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IhE4rU0Rtj3x8jhMwfnV9UeF6rrN44qzJYKKUHziCOg=; b=WP+PnJTyTnlKmuDaLzKIQe0xfYHPFDkqy01ZtrpkmrRkVrHJgF14tgkmQ2cfFgzWBJj50+JL+5LBFovSgZwYkW2EdrtFwQddjoafwqXCG9akT8UjctqQQJZTXN/3PKcint8N2EfQc5ni4O+DckeC0juSRKO2w4o+qpM3YtIVC/Y= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB2991.namprd11.prod.outlook.com (2603:10b6:805:db::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Thu, 30 Apr 2020 02:54:51 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584%4]) with mapi id 15.20.2937.023; Thu, 30 Apr 2020 02:54:51 +0000 From: "Chiu, Chasel" To: "Shindo, Miki" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" , "Agyeman, Prince" , "Ni, Ray" Subject: Re: [edk2-platforms:PATCH v4 1/7] WhiskeylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Topic: [edk2-platforms:PATCH v4 1/7] WhiskeylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Index: AQHWHc57fgrBXWePeUe/cLitPTVit6iQ+bYg Date: Thu, 30 Apr 2020 02:54:51 +0000 Message-ID: References: <20200429023203.37544-1-miki.shindo@intel.com> <20200429023203.37544-2-miki.shindo@intel.com> In-Reply-To: <20200429023203.37544-2-miki.shindo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 43916f1e-e173-4bb8-5567-08d7ecb1da6a x-ms-traffictypediagnostic: SN6PR11MB2991: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:83; x-forefront-prvs: 0389EDA07F x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(366004)(346002)(136003)(376002)(39860400002)(66446008)(966005)(7696005)(107886003)(86362001)(33656002)(4326008)(66476007)(76116006)(52536014)(8676002)(66946007)(71200400001)(2906002)(5660300002)(55016002)(316002)(9686003)(8936002)(186003)(478600001)(66556008)(64756008)(26005)(110136005)(54906003)(6506007)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: stxL21uZDKE7V3Ia++uJsObS99nzc0nqin3RELIpIftu9ctp/vqFXxWrw0+t9CK9OeJsWnXXJzgjl074IceywmyOLkFZdjEpqsKFPeInf0vAHU415+10cWW3mS60J72ezbyIexi7jFPD722gikS+PPVYR62cHNzdFLqtjE7c1ZHQO42X5B4hr6fYqR1Yhuw6mNmTT74lVy1aewXK3PUPDFwdtkfKYVPiSMQaKpID2exel8VDQI6C4GGhLT38YNnoeVctjmflecQIm3/o5iWZ0fbqhAQnUgASQWYCskDCkaHpUdp38PsKIqiuyt4sMpvrBdVEuSaIkWJfNWELVSxdv3+sqBBWUs5nzsu+X/9b4fPUt23T8Fr436KtblVkStZe93zQO4OsLyvOSuT4qv5y+OIQpJIDAeJI/CXWpR9N/c6nb9RDTuaBqySgvrRfI9xZ/uOsNhQg1ZUIUDNB7GPkUcJe7rrikD/3Iah4RQ0w52TUajDGDc7daHz3M3yXwZ6rSiyEIziR3q20ojbhBkn40Q== x-ms-exchange-antispam-messagedata: uczsH4R3ThmU5wx3zX6XNQXN5GJ5nBJFqJpRkB/Zsi3S9erw/cuDipPFgrdyDIz8mf0+Ozp7cXCTzK+wS8Jcri0AqW2t4oaRYCB1hPghkCwCurWdF6bLigRG/b77KU4v+jFuxvTkcMuQYG/pb7e+1nZcRSi072CwWeb7AF8dWdRDANi88vqkhVNtMcYRXgE++SIsJTcm/HLxoVA3/E3V6FuIBoffNgA4P57gv2y92Q/rjDP9qwkPPItmYEkXbC7HrHhIZbZsSd/j8zEvV3nqSh66ESM1zvrBpcRKjLzWjqX4zshYrqg30LXHZ5GCjyVrJ2EbJPyxPCt016VLtM/S9MxZtzww6nHRFQrhNi47y8BxviTwnUhNLUnT1xkS/G0ufDJR8k3vzBbXRnHMP8QzXX1GarDWf3mLaAixkK94LEPI3KdXUzVRadyTm2hazRDRCq5+JG+mf6imIkihUvZw56ax+8+Cwc8xPE/2uBMX0EScKKDgBARkeHKk6+sof4b9W9rnLPcOOiB5Tc/tK/eBrIMdpf2cSex2iA8zwEw0JJvgPqn5lnVSjyNr+ctCkSNvOc74s1M2Jm+49sayiFUutNKKWHiu/9NMhJB4+F4nEAK4Fio59F3M0A8Cy/Ld/hAhJs7zIXHV4tnvRtAEygFJTF+ub96Rw5wJkbsoMU27tLXj9s6ac9FoAngi3UY+KyeJ1yfD0PEuvQvs96woOnCHlK5sRzW+LAJughBFWN5JT0cYZKkCapd/0TFI+F3/ypI/EU0Yd+hfUF7yZxIQ+mV/2xC/ZucdayTHTnUrGIayqK7YI1AqL+kI1Zrws0Juk6UE MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 43916f1e-e173-4bb8-5567-08d7ecb1da6a X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2020 02:54:51.2823 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0luy1xxgEZ9I14+7OdB7dLpPelY5aeD5wtlzVjpmrvo9dvMzYVu9rVe2y/PoKkFKzoPu4ntUb1YhTVc+J5a+5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2991 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Shindo, Miki > Sent: Wednesday, April 29, 2020 10:32 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Agyeman, Prince > ; Ni, Ray > Subject: [edk2-platforms:PATCH v4 1/7] WhiskeylakeOpenBoardPkg/TbtDxe: > Removes redundant InitializeAslUpdateLib >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2536 >=20 > This commit removes redundant InitializeAslUpdateLib call as > DxeAslUpdateLib itself calls it internally. >=20 > Signed-off-by: Miki Shindo > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Prince Agyeman > Cc: Ray Ni > --- >=20 > Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe. > c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDx > e.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDx > e.c > index c670f23320..991edfc2c6 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDx > e.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/Tb > +++ tDxe.c > @@ -1,6 +1,6 @@ > /** @file >=20 > - Copyright (c) 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2019 - 2020, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent **/ >=20 > @@ -125,9 +125,6 @@ TbtAcpiEndOfDxeCallback ( > UINT16 Length; > UINT32 Signature; >=20 > - Status =3D InitializeAslUpdateLib (); > - ASSERT_EFI_ERROR (Status); > - > Address =3D (UINT32) (UINTN) mTbtNvsAreaProtocol.Area; > Length =3D (UINT16) sizeof (TBT_NVS_AREA); > DEBUG ((DEBUG_INFO, "Patch TBT NvsAreaAddress: TBT NVS Address %x > Length %x\n", Address, Length)); > -- > 2.16.2.windows.1