From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Lai, Cosmo" <cosmo.lai@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Lai, Cosmo" <cosmo.lai@intel.com>,
"Ma, Maurice" <maurice.ma@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH] IntelFsp2Pkg/FspSecCore: LoadMicrocodeDefault() failed with padding in FV.
Date: Tue, 27 Oct 2020 06:09:42 +0000 [thread overview]
Message-ID: <SN6PR11MB28141358DBC8430B6C79D284E6160@SN6PR11MB2814.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201022025127.1136-1-cosmo.lai@intel.com>
Change pushed: 31e97bdae2c66e28c5c7df1340757304e1b76d41
> -----Original Message-----
> From: Cosmo Lai <cosmo.lai@intel.com>
> Sent: Thursday, October 22, 2020 10:51 AM
> To: devel@edk2.groups.io
> Cc: Lai, Cosmo <cosmo.lai@intel.com>; Ma, Maurice <maurice.ma@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [PATCH] IntelFsp2Pkg/FspSecCore: LoadMicrocodeDefault() failed with
> padding in FV.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3017
>
> Platform microcode FV may have padding between each version of microcode
> binary, and current FSP-T/LoadMicrocodeDefault() cannot handle this case and
> return not_found unexpectedly.
>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Signed-off-by: Cosmo Lai <cosmo.lai@intel.com>
> ---
> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm
> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm
> index 7934eab6d7..7fd3d6d843 100644
> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm
> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm
> @@ -307,10 +307,6 @@ AdvanceFixedSize:
> add esi, dword 1024
>
> CheckAddress:
> - ; Is valid Microcode start point ?
> - cmp dword [esi + MicrocodeHdr.MicrocodeHdrVersion], 0ffffffffh
> - jz Done
> -
> ; Check UPD header revision
> cmp byte [esp + LoadMicrocodeParamsFsp22.FspUpdHeaderRevision], 2
> jae Fsp22UpdHeader1
> @@ -341,6 +337,10 @@ Fsp22UpdHeader1:
> jmp CheckMainHeader
>
> LoadMicrocodeDefault4:
> + ; Is valid Microcode start point ?
> + cmp dword [esi + MicrocodeHdr.MicrocodeHdrVersion], 0ffffffffh
> + jz Done
> +
> LoadCheck:
> ; Get the revision of the current microcode update loaded
> mov ecx, MSR_IA32_BIOS_SIGN_ID
> --
> 2.16.2.windows.1
prev parent reply other threads:[~2020-10-27 6:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 2:51 [PATCH] IntelFsp2Pkg/FspSecCore: LoadMicrocodeDefault() failed with padding in FV Cosmo Lai
2020-10-22 3:28 ` Chiu, Chasel
2020-10-26 17:59 ` Nate DeSimone
2020-10-27 6:09 ` Chiu, Chasel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB28141358DBC8430B6C79D284E6160@SN6PR11MB2814.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox