From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.10029.1603778987533822640 for ; Mon, 26 Oct 2020 23:09:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=KGK7Ywx6; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: chasel.chiu@intel.com) IronPort-SDR: hlnTc3EZNlJ7tHpTSo1s3BQmMUMqBBu/xJyk2i0y2xNRuu9pjTpKUTV05C+Df/HX5drVpUma0D RtGlyTIrxL2w== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="168132147" X-IronPort-AV: E=Sophos;i="5.77,422,1596524400"; d="scan'208";a="168132147" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 23:09:46 -0700 IronPort-SDR: o2vAAENilQUG247EzftsRLSAZjzElUbEhI2VrwVJQAvUNOkxOxcYXl69f8fNt3CqRRS/ary/HR R7CtW4V6uDww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,422,1596524400"; d="scan'208";a="524566813" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 26 Oct 2020 23:09:46 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 26 Oct 2020 23:09:45 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 26 Oct 2020 23:09:45 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 26 Oct 2020 23:09:45 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 26 Oct 2020 23:09:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mKlClXrT0NF4xZ0XU37m7ACiDnx8ha5co4o1cGX2DD0so9kzLPNlqfQFhrMMLK8ngpnVv4LtKkkX1eAwGtBldIguVCcqbizz3tIxL0e5prQd+QsJPgKNHAalvxYK8kb+WzhSoaLcn2kXz6su2EHfTfqdnhGX33Qu3qEy0n6zjn4NVoueHwIyfeo/6amFp82Et8rvTgUxoxDMKWO2xekXoxzULKiW4O6DaQ9f3AvkHZjfNSvwz6vLHOeLaWJGEemOkYYOvknIXlcRcqi0bsQOrVMt3jaqrp7Nbls3Meln3BtfcVxhB2hqvZQPWqxh0jNwndkIs2Lwqc4kmnhHOmHsNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wI2dNtu6fUqtcfvDwRbaWA3VmgxfeXMukE/m0/DJmDA=; b=DKMVtpEj7xoZ3AksuxrKuHXD2fYncpmK+gQV0PzGDpsnpIk75v6TmdsrSxS1NtcHNEkLSneOb+p7MI3GtxLdPZXLC/8KkvXEyYgLcGziLPESuHmhvsz5jzOFNlVWB4yUx8jMZSI9awU+sIAldrhFJZWu7V+uSOuLZMBpSAZoQUVqpBEiGomxlSC0UVMquLMQK+TfpYZKtQBN+wRDZ35f2qJ4Tj6OXL5H3kE9QstYRvMwCdaq+ezcztaNgr5fZ8uPPXUxDrxZGT4cHf9kQeRmX5KDtzM5SiWoDz6uSezyybDV91yz5+qzgDMSBTFthoN6l2XM7CLIT2xnb5XWmJrR4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wI2dNtu6fUqtcfvDwRbaWA3VmgxfeXMukE/m0/DJmDA=; b=KGK7Ywx6hq2vGJzVM5fXD/13Ml5zwJCXreovear1Pb/OL629vMMrXLgdmZ8RS+4uVVEmrWwdNzjTKEa92DowMTxUWJX/pRuPlhkxkMIMJwk0uO+JM5g4dc1f3hoohuSJle5XNeF4NHW/ROWXEBBQsgTfEY/FVjjBd2EDYLgo3JI= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB2912.namprd11.prod.outlook.com (2603:10b6:805:cb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.24; Tue, 27 Oct 2020 06:09:42 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::4540:a6b5:b0bc:9d82]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::4540:a6b5:b0bc:9d82%4]) with mapi id 15.20.3477.028; Tue, 27 Oct 2020 06:09:42 +0000 From: "Chiu, Chasel" To: "Lai, Cosmo" , "devel@edk2.groups.io" CC: "Lai, Cosmo" , "Ma, Maurice" , "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [PATCH] IntelFsp2Pkg/FspSecCore: LoadMicrocodeDefault() failed with padding in FV. Thread-Topic: [PATCH] IntelFsp2Pkg/FspSecCore: LoadMicrocodeDefault() failed with padding in FV. Thread-Index: AQHWqB5Mheh+HqZjUkubbSb5DBmU5Kmq/yAw Date: Tue, 27 Oct 2020 06:09:42 +0000 Message-ID: References: <20201022025127.1136-1-cosmo.lai@intel.com> In-Reply-To: <20201022025127.1136-1-cosmo.lai@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [220.136.32.137] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fe5923f7-25eb-4201-2374-08d87a3ee533 x-ms-traffictypediagnostic: SN6PR11MB2912: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:403; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FlanYcdXCACoVxhLQMQng58CrE3+Q1CbZVevjsbpjQFEXuvpTk5eFOnO87u2jMaXd4XbkmkpzyU7dduDcLH41wE2Oj7HwQk64mvXAzge2q1EM1IyhepTBHW3hC1nzMI5bn9X/b4OlUpVto83y+pQZDY9uA685tke0cb1dEhDlo2fqiPZw5b+i9bGxLCj7lCCMhDxwiXnntlppnDJvMrw5RJM8Hj/ZHuu6tc9XGYijCuXya8eEkvPQLWxlG1US+KTROooDrY3Hw11ZbKo3vszZGXBGge2E4k7VRODcPzvoMmNckHg3O//NCOVNZmaRX73G2DVEAERr6Y2QNe3luEmvE+AoQ73MFKRmmFEUv0PIOOFVJensM/8UT/++cMc9Uzr8sk10gYKImKhJtIqFI+1zg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(396003)(366004)(136003)(376002)(346002)(110136005)(316002)(86362001)(186003)(2906002)(71200400001)(8676002)(9686003)(107886003)(8936002)(33656002)(26005)(478600001)(4326008)(52536014)(53546011)(54906003)(7696005)(66476007)(66556008)(76116006)(66946007)(966005)(64756008)(19627235002)(6506007)(66446008)(83380400001)(55016002)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: dI40sH968xaHPLVcpg+7deJF2TxBEIXGdCJbaNOpmd7a5BkWtdkG5FzuuLkDf+ObsnBy5wgTAj2rahwOoT1lwW8AEFQytU/oxDsQ4xsbBEx8GlOtUpHzKiWUeImy/R3vwp662vbV44q5VMMSbqKsqWSDNNs3UCfT9eenLavR02mF5+VnsT2+Rm0DCKetzRsmUuegpdqBZTJJgkFL/zk2tvcngHiw6cCWkSD9bHSAHm1rgyjhvWc7PXKa8Yn5Y3MvokNBklgzFkazUHFibGufvXCbLElFQvWH0HrlyIrV+7i03tx4FZZ+X7gHLDPC1BjwtHiFGD6V0N+Frij3+JTBQbSAVeFfRKrouzVs/+8JHzaLE/Oz9v9itEq8LZREPQB3kfn+SrziRVgCB3nfwWMBRjgWsTf3Bc+HIo3M0vhh45hv4QYGvPonrFZoutsOaUoO+M7a+vVzjF3v5QTSKil26MeYagOFkezYU/0XjIbKXaNBwF928AA6WD2UU6dIebBq2SOwYrHlPuk7Vz/2uAyfZuL2dsKW7/4vVN8YfLF83AN+KhclnrPyOcRd/XuVp2Aec894QEawCkTRBJRAf1hWiv9TNbY7MKz9LTw2dc5gpYx/gUal+D/NVS6muvB3UdRpqWddCUMVYH5sIglTkkYhYQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe5923f7-25eb-4201-2374-08d87a3ee533 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 06:09:42.3440 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W/yoE4UynCkeb5NhknSbLWSkqbFCM0B1et34KrF2EX0rELA1uuz24C67f0uFvVh9DBWMTwL3fdtZA2Dq8dPu2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2912 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Change pushed: 31e97bdae2c66e28c5c7df1340757304e1b76d41 > -----Original Message----- > From: Cosmo Lai > Sent: Thursday, October 22, 2020 10:51 AM > To: devel@edk2.groups.io > Cc: Lai, Cosmo ; Ma, Maurice ; > Desimone, Nathaniel L ; Zeng, Star > ; Chiu, Chasel > Subject: [PATCH] IntelFsp2Pkg/FspSecCore: LoadMicrocodeDefault() failed w= ith > padding in FV. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3017 >=20 > Platform microcode FV may have padding between each version of microcode > binary, and current FSP-T/LoadMicrocodeDefault() cannot handle this case = and > return not_found unexpectedly. >=20 > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Chasel Chiu > Signed-off-by: Cosmo Lai > --- > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm > index 7934eab6d7..7fd3d6d843 100644 > --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm > @@ -307,10 +307,6 @@ AdvanceFixedSize: > add esi, dword 1024 >=20 > CheckAddress: > - ; Is valid Microcode start point ? > - cmp dword [esi + MicrocodeHdr.MicrocodeHdrVersion], 0ffffffffh > - jz Done > - > ; Check UPD header revision > cmp byte [esp + LoadMicrocodeParamsFsp22.FspUpdHeaderRevision], 2 > jae Fsp22UpdHeader1 > @@ -341,6 +337,10 @@ Fsp22UpdHeader1: > jmp CheckMainHeader >=20 > LoadMicrocodeDefault4: > + ; Is valid Microcode start point ? > + cmp dword [esi + MicrocodeHdr.MicrocodeHdrVersion], 0ffffffffh > + jz Done > + > LoadCheck: > ; Get the revision of the current microcode update loaded > mov ecx, MSR_IA32_BIOS_SIGN_ID > -- > 2.16.2.windows.1