From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.7633.1594976231054300287 for ; Fri, 17 Jul 2020 01:57:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=spGw+X+d; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: chasel.chiu@intel.com) IronPort-SDR: 0N/67FnvDd0NeYGy++3Wpy18uEtcZrA8pIQ3Lpbm+i/RR9Hb0OmBI7fBRMb2xIMFyOAbH4sATz OCi6Tc7BzFJQ== X-IronPort-AV: E=McAfee;i="6000,8403,9684"; a="211098553" X-IronPort-AV: E=Sophos;i="5.75,362,1589266800"; d="scan'208";a="211098553" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2020 01:57:10 -0700 IronPort-SDR: GCZ0u2PvkxnpaBSj6WFH+QTSwiZMHSe3uzjee0FPlzysVnNsMJusYEo/NM5VxnVHXU3g5/GzYw kFmj7uykQ5ww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,362,1589266800"; d="scan'208";a="317291813" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga008.jf.intel.com with ESMTP; 17 Jul 2020 01:57:10 -0700 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jul 2020 01:57:09 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX161.amr.corp.intel.com (10.22.240.84) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jul 2020 01:57:09 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.51) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jul 2020 01:57:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ql49f1o3lG9/Potcr7LuCFTaXiB3gO0YKo2nOtH6dbR2YLs0QArirFmOvC82SB/cP8fXyyVmsc2nTTvPn9qcKZ0hO8JR6s0kkyp5C7LMyTJ1bLXvn+RExCmCLq6T+MH7o6DvVrpgpq043Ws0xWTGGGn+QD3PcdpdI/HMHPMizcrZfjhjXHynj3Bl1aOb6lTFWI54CWjLUZo3k+FPz0R864Y/ZRV2LM/zAc/nVEzbXyM7u4o7fTqamHY2TkvQzguCGCoiwxNfLxfJzVWwaEjufmBXK+1i4vYDQkmeG7HB9WYt6wYot7JSSvDN3fjA83H8m0/0D7wDLFOCsmhx6uI4lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q2JukiANeQLmL0DJbQ9yYFYTLk6itq3338xZ2wwbfTA=; b=EaGW/9NTFhZQPSOwXvk9c15gB5zVItg1pyMLIBlWpK+cD+GF1MdjD0TPxkVY2da3WjV1P9Hra7jpJpWWLvKEv3ibO8yEAf06B+OFTc5P5QpAaon2RKZ0hWEmhVGfLGh2zvMutODinUU8AXt5hzmxnmV2uFWtX6hLkU8jumwKbp5UH87KnURvBzdvHpPi9z2J2ziRqtohi8gUZIBb5EyQKtD71Xmd53LvIH4ofCurjaoNt/BTShuzMK1ZWDvzN2e03BBeoWGr+imrLaAlYWUTYKfzNiH1Z12yhnTV1kV8eJuqIaPCnPiyrlsnX9Y47EN6GFKYYjrggLLGN0egfOajBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q2JukiANeQLmL0DJbQ9yYFYTLk6itq3338xZ2wwbfTA=; b=spGw+X+d6lkZgpyvYbjZwpv+nbFTF5eXmScOjPriUN4u574/WumlC57TvJGLFKs12wv9epCW5WcMoafNvujzl2hsS3CGW54067yaFj4jrx/ObRxlTB5ljkh8aXmVCH/eq0VkcbTDhUvI2WRExRgv/QUGCYarBXyM0Cvs5O5pqms= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB3039.namprd11.prod.outlook.com (2603:10b6:805:d3::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Fri, 17 Jul 2020 08:57:06 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::4843:7aba:799b:326]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::4843:7aba:799b:326%5]) with mapi id 15.20.3174.026; Fri, 17 Jul 2020 08:57:05 +0000 From: "Chiu, Chasel" To: "Kumar, Chandana C" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms: PATCH V1] MinPlatformPkg/PlatformInitPei: Thread-Topic: [edk2-platforms: PATCH V1] MinPlatformPkg/PlatformInitPei: Thread-Index: AQHWWpWVBDahvAz+M0uVfRaKQl/Lv6kLelNg Date: Fri, 17 Jul 2020 08:57:05 +0000 Message-ID: References: <20200715104900.27552-1-chandana.c.kumar@intel.com> In-Reply-To: <20200715104900.27552-1-chandana.c.kumar@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [61.60.205.141] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5661ef5f-45dd-45fd-5f55-08d82a2f6172 x-ms-traffictypediagnostic: SN6PR11MB3039: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r5QXZypUWcXpfmsLECteX7xui7/oj5lhUvi0NR7ImRPsYt5F7/YwyfRRgvZiuU5E9Hi8oPBXueMnXS6WN32oStd/1IajV0C4GY1Fq/gVIOOuMXnSCDGC54yjyaDUquu/U9ODEnvyd46bRUr0Rbks/ez4DYOvIINHXEDPN6qWdMpL6voYoX+Yq6ffl+nDYLbdWU8EnRDppEXwWbUL1XYlKnDQbbMFE2UuCRYia8OtVKRWBZLN2X/+xMY2M4ft3tdPiaUZXajUETaaO+ukDR96BHcIKIM9YO+/W0VoPumNvkK7Y7LQFEYlx1izfg9lb5C+at3pAcTsNTa6kLvwRJI9Yy3l01pbi4iNguifmdBvOaQZUvIQ1ZVnl56B3pO405p3nRxjXXMvMT3Fqar7hlAuRA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(366004)(396003)(376002)(39860400002)(136003)(9686003)(76116006)(33656002)(66476007)(53546011)(64756008)(66446008)(52536014)(6506007)(7696005)(8676002)(66556008)(107886003)(4326008)(83380400001)(66946007)(110136005)(186003)(26005)(5660300002)(71200400001)(8936002)(86362001)(478600001)(55016002)(966005)(316002)(54906003)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: fNcKuV1tibJZium5xPNF12GgnZsuFVsetkNPJ2VRk+mVQXhnbl6l+73VBj0ydC/A7oN0YhrBBm55S11vMRnG98rTH/lookHTLEq2ySn1UXgsp2Knx3ylbUXhR8uBliSYnvNil8OKvYVIm8J6v23My7zatfsIHuuQf+S428Kka29t+pXoK/YpozoJmW4R8fLSGSzfHsSE+nljcvWmJfW/XdBJlHgk3W7+fzBmorBYAhkrX9h6JlXPiDxvab1bEl6/7eP1O90gH4rE2uof9Q6PXHimp1O7L444BaWu8E2vy0qMsFn8ZV/gRUcmiEFTdJsjMYia6xfK8xP/1uRmyzf0vKC0dLEjFuUjuNu2IM6b16BtBzXVbaETXw/qPkBAWnaDeqiu61OVY4bo5mDvKOR4N9jCQt76nNFTIy8hkbUNtriCyhiUrpIWi70PNpKim9mI3Y9mSK7wORaBi/+oyJW/mL8EIDmNZzm2WY6B2JePnrY= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5661ef5f-45dd-45fd-5f55-08d82a2f6172 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2020 08:57:05.8071 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 45jPAtnk0WOj3CUjVEnPZrnYbzVoQgFvfsx11lUOuURUDajJTYwUc2ZHq2nTBQh1Jiw6ITN9Jc69hO/iODehUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3039 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Chandana, Please see my question below. Thanks, Chasel > -----Original Message----- > From: Kumar, Chandana C > Sent: Wednesday, July 15, 2020 6:49 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms: PATCH V1] MinPlatformPkg/PlatformInitPei: >=20 > Create an Library instance of ReportCpuHobLib from PlatformInitPei driver= . > PA bits reported can be overriden using Library instance in Platform. >=20 > Update ReportCpuHobLib to PlatformInitPreMem driver and dec file. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2674 >=20 > Change-Id: Iad1be2612e0748d5c9a2a766cd2256dd9845ec13 > Signed-off-by: Chandana Kumar > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Nate DeSimone > --- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > | 5 +++-- >=20 > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPr= e > Mem.inf | 3 ++- > 2 files changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index 7f74ac93..da312c86 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -6,7 +6,7 @@ > # INF files to generate AutoGen.c and AutoGen.h files # for the build > infrastructure. > # > -# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2020, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -68,7 +68,8 @@ > TestPointLib|Include/Library/TestPointLib.h > TestPointCheckLib|Include/Library/TestPointCheckLib.h >=20 > -SetCacheMtrrLib|Include/Library/SetCacheMtrrLib.h > + SetCacheMtrrLib|Include/Library/SetCacheMtrrLib.h > + ReportCpuHobLib|Include/Library/ReportCpuHobLib.h >=20 > [PcdsFixedAtBuild, PcdsPatchableInModule] >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInit= Pr > eMem.inf > b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInit= Pr > eMem.inf > index 7ee18eb6..8e828ff2 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInit= Pr > eMem.inf > +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/Platfor > +++ mInitPreMem.inf > @@ -1,7 +1,7 @@ > ### @file > # Component information file for the Platform Init Pre-Memory PEI module= . > # > -# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2020, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -28,6 +28,7 @@ > TestPointCheckLib > TimerLib > SetCacheMtrrLib > + ReportCpuHobLib You are adding library class here but still local function ReportCpuHob () = defined in PlatformInitPreMem.c, I think we should remove that local functi= on. >=20 > [Packages] > MinPlatformPkg/MinPlatformPkg.dec > -- > 2.16.2.windows.1