From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web08.39741.1622431583192610292 for ; Sun, 30 May 2021 20:26:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=s5dggoD2; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: chasel.chiu@intel.com) IronPort-SDR: EPDyOeRuLQSGdWcQq7d2RJ/PqXIIi7RPbUOuI4jYbjHiJ6urbY+qyptf9PjKj/KZgd/V8FNiYm j86ixCTJ4OaQ== X-IronPort-AV: E=McAfee;i="6200,9189,10000"; a="183638357" X-IronPort-AV: E=Sophos;i="5.83,236,1616482800"; d="scan'208";a="183638357" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2021 20:26:20 -0700 IronPort-SDR: Otu1HgXXDvz447Av1cMWOxs1IAhBiMC/8RaEmFAt8OQaSlpFV1TUZACaLRuQvOPutIKiJB+oNN 4k0dQiZIfN5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,236,1616482800"; d="scan'208";a="466573640" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 30 May 2021 20:26:20 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Sun, 30 May 2021 20:26:20 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Sun, 30 May 2021 20:26:20 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Sun, 30 May 2021 20:26:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eo5OQPP6zoQVjDoDscf/YMEkcAPmndPOxfdRQrZBfEVW6FkmoH5F1nrzLQqrwL2YIe3hw9nD9xP3fIYVCodrtNMUyhufYd22fCJgJ+iGXzi91yIRtNQ+K4bMviBZEvdJJkbkZLq8xvMopH7U5PjtZBLiokYVer3fr56IsGdch503zYmmWcxUwc1Y270Eu5MAhz3YL4uYN4YLOafYv+9tQnmf3vhp/ypZymx/N2JeG6PCehsQP+vtE1kuY2+iwbAAGsYoCeEWJRa6NHdnmaxLn+zIUNZexjKeXT5EIR/UwJwmtf1QzFztOPDeNg/OBND8CSfGqJ6eAwGKGtV7/poqiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2IffICZ96PWguzCdsrpGQEOliz63MO/2uHIIa5EHF1g=; b=mJkShoRInRW8XwkHp0VwwBgUChYMYVHGcXUHaO30M3zSfz+BG9ozCf/lNUgwP5cAqD4Ijry2HX1dvmKTfU6ILmAHQG/YGy55f4EbXCTAfxAFgpRwItlIG3PmVMynCtmHAZM592AErr9ogWH9LboVCreH/t+vBkmspGIL2plYOJRj5dnKwLJq9R20s4vdwb1AdRprYoVosevORqYcYaxOP16eVLUXQ6yoJb1wSKt/yHap8r55rKrCP81piMrQji1q2Fbewnr9m7ElAcvVMhOM8XUuqyleKllAPF0XjSbUhDgsxkTcsYSDyZeWwTF8Raoul1txlU+LDCIM0mvkBqEcAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2IffICZ96PWguzCdsrpGQEOliz63MO/2uHIIa5EHF1g=; b=s5dggoD2KgqvGM30zudI5rwlhP5hC83GrdZwVQHdtFnumJAr9obR83YJ8NEujpgHor4RJSE26cEoIwUaWdlLaLgHDtQCr+fM59wto3ioBbPTZohUusAB33nID7qXfnH0uSwPUH5aKIBFb6aPfEqeagnDKQCpSZQe/ZHCUAxZPAw= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SA0PR11MB4734.namprd11.prod.outlook.com (2603:10b6:806:99::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.21; Mon, 31 May 2021 03:26:17 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::6157:b65c:53b6:a320]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::6157:b65c:53b6:a320%6]) with mapi id 15.20.4173.029; Mon, 31 May 2021 03:26:17 +0000 From: "Chiu, Chasel" To: "Lou, Yun" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Zeng, Star" , "Ni, Ray" Subject: Re: [PATCH v2] IntelFsp2WrapperPkg: Remove microcode related PCDs Thread-Topic: [PATCH v2] IntelFsp2WrapperPkg: Remove microcode related PCDs Thread-Index: AQHXMcNpYTRev++6Ik249r1+3rez76r9Na2A Date: Mon, 31 May 2021 03:26:16 +0000 Message-ID: References: <20210415064847.15537-1-yun.lou@intel.com> In-Reply-To: <20210415064847.15537-1-yun.lou@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [118.161.140.175] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c19b3a59-cfdf-4f31-dd5e-08d923e3d9f4 x-ms-traffictypediagnostic: SA0PR11MB4734: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r6dDQGIJ81Zk8tkjyecgvTOu9/niX5WNxNxYZSnf0IKJLU3A1EHJwtU6QqvCm3kGugs9I6eGmS+i4GXkAThCHtQt2+mGi2v1ggP995Nu4k54Iht6UcY1gJaOBfxcjh8sP3rN3pdleWVdrR71pWZGlJI0aco4lMZdII8mxbccDaEaeIR+e1JVQ8Y//Vz/XrU7NhYqG1xOSrn5tevTu82dElOnNJIA7nOXOUTKvqEPNnmugJbwx7/VGXKodenhxNGozhcPfv0MwyUhRBJReBN/HVC42V9Ce4Yr6tVJFeiX6aGxdDCg507ZSgRqmTCk2epjIFPKvLMLtuMY67/M/8FlcCkYRq/OgbRG2c2iINJx3vh5yidqVVE28WnOc0WGqJ3ZnCkzpjAlBagVZax8D2ImR3ju4D8cgV+Vd0/6UDVKpQCWR8bjiKArm2pU0l2gSN+1/QLmSC69/9x9UiK/EfM8Aa+e3QuH6035AInkyyy5Iaj+nyyuM/il+0qgAq/zJBFOgl9o6YNeZWoBJ1A3uBNQiqFq5/RxB8oY8U1TC4ePzxiVYiA4gQ/+379kxQ3xP2wp3I9URy39dsoa5MRq4EB/q/Tu7ZQAVv6cyp8Zidh+/0FWV/nt8LpSdgHaNj17WJE8M+uQBkvCG4paZQoa6ujI7elGlHr27znVe/ozCT5HqzHg5GPwAudT1QYzf+gc01dPGf0R3oCdKMYpt2rtndRDc7MlYz7+MduQE6p/Uruszzo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(366004)(396003)(39860400002)(346002)(4326008)(6506007)(53546011)(52536014)(26005)(55236004)(478600001)(966005)(5660300002)(7696005)(66946007)(66476007)(66446008)(66556008)(64756008)(107886003)(2906002)(76116006)(9686003)(19627235002)(122000001)(38100700002)(8936002)(186003)(86362001)(83380400001)(8676002)(71200400001)(55016002)(54906003)(33656002)(316002)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?3i2E6bnIyN4GBMmiXzmECEVeJlnARj1l5YaqdbB5brE/NPtOoKA6PexYbQB/?= =?us-ascii?Q?iqzPrd+wMyhxmHxCyQnQ77h3Idgep+e6Srv86v2H029TyE4lpkw6Ozki5ZpW?= =?us-ascii?Q?FTkufYyN6MRK6arE+zuAvmKQgnSYv5/wF62B79YL6+oaiUFCIhjh9Eze2mbw?= =?us-ascii?Q?3XJX20PwLlUN7ZP/24m4ewUQFSHTXFWtWb/EO4pdTXfMHY5AQNSsWOI88RRi?= =?us-ascii?Q?lHkuwJ3te0W8rg7BXwpiD3O7MiIP+xOdz+dX/8AUtcJjxaYorV8bd2xE9V26?= =?us-ascii?Q?BeEey5orXnZisy0WpY7h6zX60AbB6s4jYiHwbUhRPCP1rRzybfnX9Oa+9wsn?= =?us-ascii?Q?ZmIZo86Hia0RGwrfJGFuZc1LXrZ4gepMr1d4O8xbdo2yKD8pxrLsAUMW+SqT?= =?us-ascii?Q?HiVZz5nhKLMFVqOD6oTb1ZM4TOvyLow70oxoHDZNiUn+L0cD0egjvchiR9jf?= =?us-ascii?Q?Xqq6CfgmEJ8T9jRO3V1IBn729fe2lHZvPi6TwU68GiMRvZjFEOALCXZfxl8c?= =?us-ascii?Q?X/B5fE9xnbNwoUdY0EA5RuYz3CHyJ/iy+U2Ti3GpyUO05d5YI9YacMJDarLe?= =?us-ascii?Q?nzw7sIr7386HSp5zVV5tU1lnqwH2h6/ofV0etskTwryLfqkqkh77GHMrPqR9?= =?us-ascii?Q?nj3fMEUcq7PzhqwUR1V9kBnMR3mlM0fSbIHE22puX9bTHAMUYJQh8sqIAsts?= =?us-ascii?Q?X8zjrNfrUuoKEXewSixFj6+0ppXUqSTsMIJg7d0KmNAy7WJueFqWfFMLiVbK?= =?us-ascii?Q?0QGxwK09r+tBHZ4tzaM28f5W1hyuEfGeQNh+yi1f9QSxfOOpPFxl7H1QLzXE?= =?us-ascii?Q?FjhkUUvnTCmha0CzH+OiorRdVgKaH+UoqT2zg4NWGG4111OT4lc/2NvYMex+?= =?us-ascii?Q?CK/GHRycMvQiV1OvVojlEgFWvjVOLGNFsuK9NgJycomqiwOonD3Gl9p0SxYl?= =?us-ascii?Q?EHKJuZNh63JDf+YJhnUNDKGhXXX7ilb0CcLKEQ2lRuHwsSuUUi2r9aFwCoLJ?= =?us-ascii?Q?EJITexscvUbTSaePcH8IpT1QVTp/yZDcNXC/BzSxl9U+33Jk60OaVWl/DRXo?= =?us-ascii?Q?FiMORN2QAJ/wN61llWDpS/0e2/cWPFzQLrp9dL6ov7DhU/Up2lmQ+Id1VgQd?= =?us-ascii?Q?x49DcmEOBHuA7UW3eY0XqqrWiRuLL5LPeiaG52oog7ml1iYfRk5TMATGRpNK?= =?us-ascii?Q?zAHyxsWOzeEoL6FjXIy3by0eCYis5yclxOR9Iicc+0GYSZ1ixDIWNCokslDO?= =?us-ascii?Q?jRS5xiTMein6YWxml77/7/GUMKK4UqRKzdB086zoiBmed9/2DSkzUgxDld2d?= =?us-ascii?Q?pvhab9ePz8zbPcBRQkPAd1zh?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c19b3a59-cfdf-4f31-dd5e-08d923e3d9f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2021 03:26:16.9208 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +69CUYnu7ZzCj7LtYlH3UDk5qcPHfeVPD/Q59cESs+p1oijm59+FusrU3xwlCoJXeSvMB2m3aMcLzuxbBa5ZUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4734 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch pushed: fe5da0927aad98f3c005088197fa30c1b8f9d3e8 > -----Original Message----- > From: Lou, Yun > Sent: Thursday, April 15, 2021 2:49 PM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Chiu, Chasel ; > Desimone, Nathaniel L ; Zeng, Star > ; Ni, Ray > Subject: [PATCH v2] IntelFsp2WrapperPkg: Remove microcode related PCDs >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3334 >=20 > IntelFsp2WrapperPkg defines following PCDs: > PcdCpuMicrocodePatchAddress > PcdCpuMicrocodePatchRegionSize > PcdFlashMicrocodeOffset >=20 > But the PCD name caused confusion because UefiCpuPkg defines: > PcdCpuMicrocodePatchAddress > PcdCpuMicrocodePatchRegionSize >=20 > PcdCpuMicrocodePatchAddress in IntelFsp2WrapperPkg means the base address > of the FV that holds the microcode. > PcdCpuMicrocodePatchAddress in UefiCpuPkg means the address of the > microcode. >=20 > The relationship between the PCDs is: > IntelFsp2WrapperPkg.PcdCpuMicrocodePatchAddress > + IntelFsp2WrapperPkg.PcdFlashMicrocodeOffset > =3D=3D UefiCpuPkg.PcdCpuMicrocodePatchAddress >=20 > IntelFsp2WrapperPkg.PcdCpuMicrocodePatchRegionSize > - IntelFsp2WrapperPkg.PcdFlashMicrocodeOffset > =3D=3D UefiCpuPkg.PcdCpuMicrocodePatchRegionSize >=20 > To avoid confusion and actually the PCDs in IntelFsp2WrapperPkg are only = used > by a sample FSP-T wrapper, this patch removes the 3 PCDs defined in > IntelFsp2WrapperPkg. >=20 > The FSP-T wrapper is updated to directly use the ones in UefiCpuPkg. >=20 > Signed-off-by: Jason Lou > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Ray Ni > --- >=20 > IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamInit > Data.c | 6 +++--- > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > | 8 +------- >=20 > IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecFspWra > pperPlatformSecLibSample.inf | 7 +++---- > 3 files changed, 7 insertions(+), 14 deletions(-) >=20 > diff --git > a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI > nitData.c > b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI > nitData.c > index 96b47e23da..e57b5b57be 100644 > --- > a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecRamI > nitData.c > +++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecR > +++ amInitData.c > @@ -1,7 +1,7 @@ > /** @file Sample to provide TempRamInitParams data. - Copyright (c) 2= 014 - > 2020, Intel Corporation. All rights reserved.
+ Copyright (c) 2014 - = 2021, > Intel Corporation. All rights reserved.
SPDX-License-Identifier: BS= D-2- > Clause-Patent **/@@ -52,8 +52,8 @@ GLOBAL_REMOVE_IF_UNREFERENCED > CONST FSPT_UPD_CORE_DATA FsptUpdDataPtr =3D { > } }, {- ((UINT32)FixedPcdGet64 (PcdCpuMicrocodePatchAddress) = + > FixedPcdGet32 (PcdFlashMicrocodeOffset)),- ((UINT32)FixedPcdGet64 > (PcdCpuMicrocodePatchRegionSize) - FixedPcdGet32 > (PcdFlashMicrocodeOffset)),+ FixedPcdGet32 > (PcdCpuMicrocodePatchAddress),+ FixedPcdGet32 > (PcdCpuMicrocodePatchRegionSize), FixedPcdGet32 > (PcdFlashCodeCacheAddress), FixedPcdGet32 (PcdFlashCodeCacheSize), = }diff > --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > index 6852bf1271..a3b9363779 100644 > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > @@ -1,7 +1,7 @@ > ## @file # Provides drivers and definitions to support fsp in EDKII bios= . #-# > Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.
+# > Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.
# = SPDX- > License-Identifier: BSD-2-Clause-Patent # ##@@ -56,12 +56,6 @@ > ## Provides the size of the BIOS Flash Device. > gIntelFsp2WrapperTokenSpaceGuid.PcdFlashCodeCacheSize|0x00200000|UINT > 32|0x10000002 - ## Indicates the base address of the first Microcode Pat= ch in > the Microcode Region- > gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchAddress|0x0|UINT6 > 4|0x10000005- > gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize|0x0|UI > NT64|0x10000006- ## Indicates the offset of the Cpu Microcode.- > gIntelFsp2WrapperTokenSpaceGuid.PcdFlashMicrocodeOffset|0x90|UINT32|0x > 10000007- ## Indicate the PEI memory size platform want to report > gIntelFsp2WrapperTokenSpaceGuid.PcdPeiMinMemSize|0x1800000|UINT32|0x > 40000004 ## Indicate the PEI memory size platform want to reportdiff --= git > a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecFspW > rapperPlatformSecLibSample.inf > b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecFspW > rapperPlatformSecLibSample.inf > index d7f8301bef..027b127724 100644 > --- > a/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecFspW > rapperPlatformSecLibSample.inf > +++ b/IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecF > +++ spWrapperPlatformSecLibSample.inf > @@ -1,7 +1,7 @@ > ## @file # Sample to provide FSP wrapper platform sec related function.= #-# > Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.
+# > Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.
# = # SPDX- > License-Identifier: BSD-2-Clause-Patent #@@ -76,8 +76,7 @@ > gIntelFsp2WrapperTokenSpaceGuid.PcdFspmBaseAddress ## > CONSUMES [FixedPcd]- > gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchAddress ## > CONSUMES- > gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize ## > CONSUMES- gIntelFsp2WrapperTokenSpaceGuid.PcdFlashMicrocodeOffset > ## CONSUMES+ gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress > ## CONSUMES+ > gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize ## > CONSUMES gIntelFsp2WrapperTokenSpaceGuid.PcdFlashCodeCacheAddress > ## CONSUMES gIntelFsp2WrapperTokenSpaceGuid.PcdFlashCodeCacheSize > ## CONSUMES-- > 2.28.0.windows.1