Re: [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg: Change some PCDs type

["Chiu, Chasel" <chasel.chiu@intel.com>]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Tan, Ming <ming.tan@intel.com>
> Sent: Tuesday, June 9, 2020 7:24 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg: Change some
> PCDs type
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2791
> 
> Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in
> MdeModulePkg.dec are changed, so change them from PcdsFeatureFlag to
> PcdsFixedAtBuild in dsc files.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Ming Tan <ming.tan@intel.com>
> ---
>  .../CometlakeURvp/OpenBoardPkgPcd.dsc                | 12
> ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgP
> cd.dsc
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgP
> cd.dsc
> index 1ccdb28f12..d611e99fc1 100644
> ---
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgP
> cd.dsc
> +++
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkgP
> cd
> +++ .dsc
> @@ -75,12 +75,6 @@
>    # Edk2 Configuration   ######################################
> gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreImageLoaderSearchTeSection
> First|FALSE-
> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE-!if
> $(TARGET) == RELEASE-
> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE-!else-
> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE-!endif
> gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmEnableBspElection|FALSE
> gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmProfileEnable|FALSE
> gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE@@
> -207,6 +201,12 @@
>  !if $(TARGET) == DEBUG
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl|FALS
> E !endif+
> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE+!if
> $(TARGET) == RELEASE+
> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE+!else+
> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE+!endif
> gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIoBarEnableMask|0x80
> gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIoPciBarRegisterOffset|0x00--
> 2.24.0.windows.2