From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.65766.1597756202195464389 for ; Tue, 18 Aug 2020 06:10:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=WKA6F9lj; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: chasel.chiu@intel.com) IronPort-SDR: e4hHJBK0PhozZzs6s1YmRMCBoTTHhw50r5us0GeSDnFLnQ8OU5nqOHg4+79WL08SJ+2wkIC8hA DPQh8CKqd2Fw== X-IronPort-AV: E=McAfee;i="6000,8403,9716"; a="152303370" X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="152303370" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 06:10:01 -0700 IronPort-SDR: xK+TCOevLa8PnvZFmM/EwbwFdandLjxzjyhZxTIInL78lTfWmy3D/S8AhQSGKQWp9jD5oqYhRK 8mZwUc8fWGYQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,327,1592895600"; d="scan'208";a="296837037" Received: from orsmsx605-2.jf.intel.com (HELO ORSMSX605.amr.corp.intel.com) ([10.22.229.85]) by orsmga006.jf.intel.com with ESMTP; 18 Aug 2020 06:10:01 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 18 Aug 2020 06:10:00 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 18 Aug 2020 06:10:00 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 18 Aug 2020 06:10:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i7it2sSwlCTqiQUOl/DZSeF/aaaJzIykG3k+lEnnQZMaMISw0JR4yQmoTgKIbUJE21YNioK2qvUlxLktI6k93bk2jV1Iuye9zSDTHQB6xyNI6Tc8Fewo+6bHbev2VbkyhqLDpvVQui+oJCQ0Wb12c8ncNK5oROtZVJreXqg4UlNd620YMfQqahjdddvMxxQ+AH4CeN2zzmjBAGnM/1WadjVpU1o8AgEDi7uuKqJDBbcoTrBopknhDfunbVaA53KkR2JASqdLOC23i9jbqhc/AbEWC/l5Z0N7U8xcfeHXqFoAt12Ur93anvuUHA3K75IDGjsuNjs6Jo3AqBMI0T+npg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l+GnYdKnaYXnilUXv+sWoZKLT2cp/f7A7Vl7w/zyY9E=; b=V6pPv1H0f7Ij5ignZzfpzQsHSmOw7zuf6kg9BODxBD33KFtwbrI+kUXt44iiQ+shHDw+CemwNkK7+OjRxdiYyhtmXYaEZOFgKXhM7ZXGVdicadasJzl+0hdKGcVmU37auQ/MgQQfksNOKU5m0MMuyoAPwS2s0EErfxlIe8q6smbIx2WaKK4vbILFoiQLBym85rNHORbk/x+1jwpYpdtcIhXjwWdSoPJ0MbU56l5Gzgsv5dW14jrPg3p942Tn3JrfLIHMDpoLvTuDoJrYujZ9WK8LLCm3xrcBmNlwS3gX8EGBf2xVpQl4a9u87yIiE/zq6OUlACVzZrMWZ+ILqjMqdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l+GnYdKnaYXnilUXv+sWoZKLT2cp/f7A7Vl7w/zyY9E=; b=WKA6F9lj9Eih44KB12HT+LVjC2H7kHVkoi5TuedLbwaRmrotNB610JiYHyUvtxEaxhbeF2Bdl8zTjAboJmX6suUayrS8/HRAvLQjhMEMoIA1BFh8hfCIhNDV54dseVOexc+RGIPlYfL7iOGayZ2fnwzSObgChwlt+Yxc6WUc1xw= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB2559.namprd11.prod.outlook.com (2603:10b6:805:57::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.25; Tue, 18 Aug 2020 13:09:59 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::4843:7aba:799b:326]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::4843:7aba:799b:326%5]) with mapi id 15.20.3305.024; Tue, 18 Aug 2020 13:09:59 +0000 From: "Chiu, Chasel" To: "Zhang, Qi1" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [PATCH v4 6/8] IntelFsp2Wrapper/dsc: Add FspTpmMeasurementLib and PcdFspMeasurementConfig. Thread-Topic: [PATCH v4 6/8] IntelFsp2Wrapper/dsc: Add FspTpmMeasurementLib and PcdFspMeasurementConfig. Thread-Index: AQHWdSiQFdi2CIrM+UGXu/+WcPkCOak91zdw Date: Tue, 18 Aug 2020 13:09:59 +0000 Message-ID: References: <20200818062618.3698-1-qi1.zhang@intel.com> <20200818062618.3698-7-qi1.zhang@intel.com> In-Reply-To: <20200818062618.3698-7-qi1.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [220.129.108.102] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3010cc5f-72ba-4e0b-7def-08d8437802b9 x-ms-traffictypediagnostic: SN6PR11MB2559: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hQLQVLe7yiVY640huftE7c2h9OME+BXLT4GN4oPwIkOgap6Mr26EafFaVIzZN9NmrNPPxgEY/6MUrDGr2RDq6Z4YOJUfIWhoSbuTeo+Vywwwrm80hYchGY6LKkTGkG1NCuTFWFtHgqme80Et9JR7/C5h+kuQrjZ/4TK3ntuW9N+XoP9txkSUFOtRdc1ze+dcjKcAqbof2RWf1euKTKq5zcX6ic4WJSs1PI0LU4q3f2lZXJW6QfBz9+jsDeeONSbzSZD5W72Ei4QNsKkTG9BiQ8f0gbXOJWZd8uRjBxspBCJS2EubIj4tsC1EXPflanbFcZppjx1ieCBN3AUK9kTIGmbqshm+RnfdwdXqZiHPxgPnwKD3CrxOTOdrdL7fHy9WlivCXk4HhJ6AxRXrbZe0nw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(396003)(39860400002)(366004)(376002)(966005)(4326008)(186003)(8936002)(478600001)(26005)(64756008)(83380400001)(33656002)(19627235002)(66946007)(66476007)(71200400001)(76116006)(66556008)(66446008)(107886003)(86362001)(5660300002)(9686003)(54906003)(53546011)(8676002)(7696005)(6506007)(110136005)(55016002)(52536014)(316002)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 0BBaU+bEBeFt4L2iOQx8ABYphB1XxpBEOyi273UvsoTslY0sj6OL0NN86QWkpY3MtZA0391t6zUxUwLvFsOEic51sXUlpFdiQa4UINYuQn8QGI9EIFgCkiS+1qIGSvPteaqg5kwLed15ljfwz3csGUx2DlL7TC1EQFwPQohxkRvytzrYo16pp8qeCYpBgHwbd1F9QkWh32LX81FdM8gvjwSbIR4kDNr1T9IIDCkwtJM14jRu0poO2zj8yWdU2Fo71AY2/GD2I9JA7qSMnXOANAFxo2EzX0yC7vmTUoV7ev8VZjDe/L8+jPCVm5l+1zVWGowXxN+Xjcp7pVVF7pP01Jl0ONsZUlUpJlwV2p65QDao4HFarIwVrysExSQDjLriYUHPFYsk1HLbCWMCBeC98iV6ksn34pBgJYGtOR+QjyWBmQyCqenrhHfL6Gih4ay7oTdBy97yhaIR4EjFchURAGy1v9JKOQgAdh5rKntH8QYhDfFWbml12OYxdmUIcHZMYVhOvGNRiQrbk4pdapVvvooVKyHVjTeqmcrQZrjrl7ma81UpihKK5XHiZqEyAyl4uBo//7wSAq6hJfHNfrOsUGWFlqrB+bKS+e7IQQdNvmDbmKBQRJxifG8MjSt1Ba+MjFttU9/qAXdV50bOo4TQhw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3010cc5f-72ba-4e0b-7def-08d8437802b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2020 13:09:59.1773 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eHv2b2ax4acrOo9eCGOKDFmEfBWGGBCvxAORxIS8g0KTCcj4ir25aDrBWLra3Kw6wuC73OrLHTtnRgxRNYIyig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2559 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Copyright year of IntelFsp2WrapperPkg.dec can be extend to 2020 when pushin= g. Reviewed-by: Chasel Chiu > -----Original Message----- > From: Zhang, Qi1 > Sent: Tuesday, August 18, 2020 2:26 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Zhang= , > Qi1 > Subject: [PATCH v4 6/8] IntelFsp2Wrapper/dsc: Add FspTpmMeasurementLib > and PcdFspMeasurementConfig. >=20 > From: Jiewen Yao >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2376 >=20 > Cc: Jiewen Yao > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Qi Zhang > Signed-off-by: Jiewen Yao > --- > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 17 +++++++++++++++++ > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 6 +++++- > 2 files changed, 22 insertions(+), 1 deletion(-) >=20 > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > index faf2be621c..cb41ca9807 100644 > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > @@ -92,6 +92,23 @@ > # > gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x00000001|UINT > 8|0x4000000A + ## This PCD decides how FSP is measured+ # 1) The > BootGuard ACM may already measured the FSP component, such as > FSPT/FSPM.+ # We need a flag (PCD) to indicate if there is need to do su= ch > FSP measurement or NOT.+ # 2) The FSP binary includes FSP code and FSP > UPD region. The UPD region is considered+ # as configuration block, and = it > may be updated by OEM by design.+ # This flag (PCD) is to indicate if we > need isolate the the UPD region from the FSP code region.+ # BIT0: Need > measure FSP. (for FSP1.x) - reserved in FSP2.+ # BIT1: Need measure FSPT= . > (for FSP 2.x)+ # BIT2: Need measure FSPM. (for FSP 2.x)+ # BIT3: Need > measure FSPS. (for FSP 2.x)+ # BIT4~30: reserved.+ # BIT31: Need isolat= e > UPD region measurement.+ #0: measure FSP[T|M|S] as one binary in > one record (PCR0).+ #1: measure FSP UPD region in one record (PCR1), > the FSP code without UPD in another record (PCR0).+ #+ > gIntelFsp2WrapperTokenSpaceGuid.PcdFspMeasurementConfig|0x00000000| > UINT32|0x4000000B+ [PcdsFixedAtBuild, > PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx] # ## These are > the base address of FSP-M/Sdiff --git > a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc > index cb4f69285d..aa2eb26c33 100644 > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc > @@ -1,7 +1,7 @@ > ## @file # Provides drivers and definitions to support fsp in EDKII bios= . #-# > Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.
+# > Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.
# > SPDX-License-Identifier: BSD-2-Clause-Patent # ##@@ -45,6 +45,7 @@ > # FSP Wrapper Lib > FspWrapperApiLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/Bas > eFspWrapperApiLib.inf > FspWrapperApiTestLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperApiTes > tLibNull/BaseFspWrapperApiTestLibNull.inf+ > FspMeasurementLib|IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/ > BaseFspMeasurementLib.inf # FSP platform sample > FspWrapperPlatformLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatf > ormLibSample/BaseFspWrapperPlatformLibSample.inf@@ -57,6 +58,8 @@ > PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemory > AllocationLib.inf HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf+ > TpmMeasurementLib|SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmM > easurementLib.inf+ > TcgEventLogRecordLib|SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLo > gRecordLib.inf [LibraryClasses.common.DXE_DRIVER] > UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryP > oint.inf@@ -73,6 +76,7 @@ >=20 > IntelFsp2WrapperPkg/Library/SecFspWrapperPlatformSecLibSample/SecFspW > rapperPlatformSecLibSample.inf > IntelFsp2WrapperPkg/Library/PeiFspWrapperHobProcessLibSample/PeiFspWr > apperHobProcessLibSample.inf > IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTestLib/PeiFspWrapperApiTe > stLib.inf+ > IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasuremen > tLib.inf IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf > IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.inf-- > 2.26.2.windows.1