From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.969.1587710743878967802 for ; Thu, 23 Apr 2020 23:45:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=VpIjNZ0t; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: chasel.chiu@intel.com) IronPort-SDR: pmp7RpCztJFEGRNzwBx2ZvWji9i1bmPaIK1XC+19sVBUGeCSXThxzImGbUtE4LH6f02wQJTl6E Z27AZI8DYnnw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 23:45:42 -0700 IronPort-SDR: 5VovhBNdu7BEtU5lxWpJ6W8UcL6tBAnXkfUIzSQVhHgbJekGuGtYNvSr6bBkvgeTnstpIXQdQP oRxR+wpuBQ6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,310,1583222400"; d="scan'208,217";a="246510435" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 23 Apr 2020 23:45:42 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 23:44:13 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 23 Apr 2020 23:44:12 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 23 Apr 2020 23:44:12 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 23:44:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RH7VQ8qAl6y41tfuZWyX2ZcGyzNxRXqVlJ/JrMdbyPOi22qIy+TuffkzoBcEpyBnhQls/03pvfByCuoGExqGQ16L/p2iYQYXY4YnOmBKotpUPAjmf8QYGhfY6AAWhGQy6MSGMpLrFxwkVl5+TAkui2i5TTfQfqURh4t7Ox5+3AY2v6DBB5w2xc7Bv2pR6PI+Sql32Gg+Xn6tKG+Y92q4TKdQU+033PMUV0g+AdNc/6LfjgvcAtseqiJz3SC0zoHLv9U1FRnd6eB+38DRlQWgrpdOF5a6MIcWlYbwThjI/RJU84EbqvdbM2JlBhTzsMze6PA0HpsYHX13P1lPYSoo6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aJ8vlEgLpwAhKpLzI8ySWDYMXzP34+TDyx8+/iwdiwk=; b=H2fuj+aqm1yamZ4d9xTkNNTzhNu4Jjpulahyh/ml72xpIqgS+sU+SiQ5wYsrQEAHP8Gj4zWpt5vSEr8XT82+PXzzEenWumilFth5XIE+KN92akuqoqh17ulb3uXfvU9cWt6OEI7syh0rTlgJMQM+p99YGs19aqtxF+8ZqjicfDLbKmZB0jztRa6UTDTuaRd+EAcVwfgxZAYAjeteJSzBh1OwGveRRIc1DZd3Va9UNIvbZz/1bqER5wsFeagihEItb5hDDDkqT1W4llSc6FNpbMxlQOKeeYTHQYcIzO0QEQiM6Zfq6RbUIsrvc3Tpa59CKuwOZ7Lqey6pckFuIsfDrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aJ8vlEgLpwAhKpLzI8ySWDYMXzP34+TDyx8+/iwdiwk=; b=VpIjNZ0t+GDPoz31PnnXjhf9oUpm5yuFdKtQ3ID+Y53AuF+zKtUj2ZDxT0Tvx36tSwwwOKNKnwWjXz9Txo47oUlvlSN2ChiyCkGUBvvoK4LoiqU1HDb0RUSjFJR2pxcsxVIwq1tet6gna+s6l9sqw9JJPbgkMtk3xbDfI85ePdI= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB2590.namprd11.prod.outlook.com (2603:10b6:805:54::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Fri, 24 Apr 2020 06:44:10 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584%4]) with mapi id 15.20.2937.020; Fri, 24 Apr 2020 06:44:10 +0000 From: "Chiu, Chasel" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Kethi Reddy, Deepika" , "Esakkithevar, Kathappan" , "Agyeman, Prince" , Michael Kubacki Subject: Re: [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS Hook Dxe Driver Thread-Topic: [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS Hook Dxe Driver Thread-Index: AQHWGB0yOCULhNb8X0utXZ3vTfUMF6iH1zCl Date: Fri, 24 Apr 2020 06:44:10 +0000 Message-ID: References: <20200421204028.10410-1-nathaniel.l.desimone@intel.com>,<20200421204028.10410-2-nathaniel.l.desimone@intel.com> In-Reply-To: <20200421204028.10410-2-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=chasel.chiu@intel.com; x-originating-ip: [134.134.139.72] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e05d6e2f-8c1e-40c7-2eab-08d7e81ae518 x-ms-traffictypediagnostic: SN6PR11MB2590: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-forefront-prvs: 03838E948C x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(346002)(396003)(366004)(136003)(376002)(39860400002)(478600001)(110136005)(6506007)(19627405001)(86362001)(45080400002)(5660300002)(966005)(55016002)(66476007)(64756008)(53546011)(26005)(71200400001)(66446008)(66556008)(7696005)(66946007)(9686003)(316002)(8936002)(76116006)(4326008)(8676002)(2906002)(186003)(81156014)(54906003)(52536014)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BuqwBNqwVEbIDVg3tIZiK/UTeNEzhnRTzV+OD3pAkPP/1l8MwvP86kuxBEvKLVNTxA2nHKhE/bagwM5ZAHDYRW3SGfgt5wbzb1jluyCi0HjTGkfTHN6CfIdXcxSGjRzvOYW6HVZiP4eRgGGDKXPHtSUoZLBHgyu4XcLWv3bN8TwEJ618F6QRdDd1BGC3aIH2AsP1uRqyja6arGc0ax5XgmceNbrrTt0J2iCwVqWRUY7nA88+0jtvtmJ5zxOBICXHtrQd6fsjlSrTpImQUgU/sZM0ynmY6cz/+90cFp2eq5M6Pwo0qwHXWFtZs2ltLKsaCtRp6cuYuXrHExkyhPA3lWNyfrrTDoVdbh1eexWpOGnUxd6dcE9PaJamT9hYLvRHfUMyVJQZE3jM0J1nGGua1KZ2tr8sdIu3A7yiULVss+JAW90HaB91yK+SzCuh3tLHXJxbWlmsNZFul64F36ezsl9OVhpKG8Y4Nlj9dnaNwhMxODYDmUq8mAoZxKNmDEcTSwxgW1UE9p+SNM41H/D03w== x-ms-exchange-antispam-messagedata: qxORA9/vOutOditSnIUOb5LO4scWZDSPXnQ//nccwtBdnCKZresBa4p8WFYi3MD3VJiqA0HEbnlfgIf+M2fO+nwgXl4jGB5XbWrMhEatXhuQW5Q0NemvxQMUXBVxR4dn32W+qNL0Nz7OBxXTL5Ts6A== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e05d6e2f-8c1e-40c7-2eab-08d7e81ae518 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2020 06:44:10.4836 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VWnBlaaR3vUZYHywEyVDZAFinFAKlaLFnHnKpZWAQwCzwmo70bjPbj6ZJwgzh4jVLcE9JR3wX5VHfKu1HL8q9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2590 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SN6PR11MB2814458049E1892CE48195D4E6D00SN6PR11MB2814namp_" --_000_SN6PR11MB2814458049E1892CE48195D4E6D00SN6PR11MB2814namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > ________________________________ From: Desimone, Nathaniel L Sent: Wednesday, April 22, 2020 4:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Kethi Reddy, Deepika ; = Esakkithevar, Kathappan ; Agyeman, Prince= ; Michael Kubacki Subject: [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS Hoo= k Dxe Driver REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 Added a DXE driver that registers the minimum platform BDS hook points, to WhiskeylakeURvp board. These hooks are triggered on the BDS hook events What was done: * Included an instance of BdsHookLib and BoardBootManagerLib from BoardModulePkg * Included BdsHookDxe to register the callbacks implemented in BdsHookLib Signed-off-by: Nate DeSimone Cc: Chasel Chiu Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Cc: Prince Agyeman Cc: Michael Kubacki --- .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 4 ++++ .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf | 1 + 2 files changed, 5 insertions(+) diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPk= g.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc index 14e82ba34d..958a2d0c50 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc @@ -224,6 +224,8 @@ ####################################### DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/DxePolicyUpd= ateLib/DxePolicyUpdateLib.inf DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library/DxeTbtPol= icyLib/DxeTbtPolicyLib.inf + BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.i= nf + BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/BoardBoot= ManagerLib.inf ####################################### # Board-specific @@ -452,3 +454,5 @@ $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf !endif BoardModulePkg/LegacySioDxe/LegacySioDxe.inf + BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf + diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPk= g.fdf b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf index e2d40bcbb6..31f4d22311 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf @@ -346,6 +346,7 @@ INF MdeModulePkg/Universal/Console/GraphicsOutputDxe/G= raphicsOutputDxe.inf INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf +INF BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf INF ShellPkg/Application/Shell/Shell.inf -- 2.26.0.windows.1 --_000_SN6PR11MB2814458049E1892CE48195D4E6D00SN6PR11MB2814namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable


Reviewed-by: Chase= l Chiu <chasel.chiu@intel.com>


From: Desimone, Nathaniel L= <nathaniel.l.desimone@intel.com>
Sent: Wednesday, April 22, 2020 4:40 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V= <rangasai.v.chaganty@intel.com>; Kethi Reddy, Deepika <deepika.ke= thi.reddy@intel.com>; Esakkithevar, Kathappan <kathappan.esakkithevar= @intel.com>; Agyeman, Prince <prince.agyeman@intel.com>; Michael Kubacki <Michael.Kubacki@microsoft.com>
Subject: [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add = BDS Hook Dxe Driver
 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336

Added a DXE driver that registers the minimum platform
BDS hook points, to WhiskeylakeURvp board.
These hooks are triggered on the BDS hook events

What was done:

* Included an instance of BdsHookLib and BoardBootManagerLib
from BoardModulePkg

* Included BdsHookDxe to register the callbacks implemented
in BdsHookLib

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Michael Kubacki <Michael.Kubacki@microsoft.com>
---
 .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc  &= nbsp;   | 4 ++++
 .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf  &= nbsp;   | 1 +
 2 files changed, 5 insertions(+)

diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPk= g.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc=
index 14e82ba34d..958a2d0c50 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBo= ardPkg.dsc
@@ -224,6 +224,8 @@
   #######################################
   DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/Dx= ePolicyUpdateLib/DxePolicyUpdateLib.inf
   DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library= /DxeTbtPolicyLib/DxeTbtPolicyLib.inf
+  BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBds= HookLib.inf
+  BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/= BoardBootManagerLib.inf
 
   #######################################
   # Board-specific
@@ -452,3 +454,5 @@
   $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf  !endif
   BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
+  BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
+
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPk= g.fdf b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf=
index e2d40bcbb6..31f4d22311 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBo= ardPkg.fdf
@@ -346,6 +346,7 @@ INF  MdeModulePkg/Universal/Console/GraphicsOu= tputDxe/GraphicsOutputDxe.inf
 INF  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
 INF  BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
 INF  MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf
+INF  BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
 
 INF  ShellPkg/Application/Shell/Shell.inf
 
--
2.26.0.windows.1

--_000_SN6PR11MB2814458049E1892CE48195D4E6D00SN6PR11MB2814namp_--