From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.8865.1621414722305501129 for ; Wed, 19 May 2021 01:58:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=wI1Z4R2A; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: chasel.chiu@intel.com) IronPort-SDR: mN9jVCsgGA0CIuJ1mKxFWccmcqf9fQw9hmIZs00Q30e2+aACLarWesBixbna5rIeOAtMo7ec79 kMp3M2gCVp7Q== X-IronPort-AV: E=McAfee;i="6200,9189,9988"; a="264843937" X-IronPort-AV: E=Sophos;i="5.82,312,1613462400"; d="scan'208";a="264843937" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2021 01:58:32 -0700 IronPort-SDR: io9XKrafy0e3i5Y4xJdPDfH8dqQ1YRhwra7LQAGghv4QrVRpMyCGBvG9I4vvCDtpUnqDf0QxQ2 ijO9HDLOux4g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,312,1613462400"; d="scan'208";a="439883099" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 19 May 2021 01:58:32 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 19 May 2021 01:58:31 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Wed, 19 May 2021 01:58:31 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Wed, 19 May 2021 01:58:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fAw+4PdLm0pilXC23VVDbActwq13P+8CZVm/RoFzpZi7erpXe1/riWXcf2Cm6TyqHJzwg/33IqD6nqOITGI5Wr4OEov5KG5P49c1nyL+ilwZO0N4AR4gCD2LzErRIET4r2r/Ye5/1z1g9xbRkoorpItR+twFUMaPXwSH19d8EywrKDDsv8ioH7lMOsPHvjdi+1mh7t0IzklWLtYuTXt5MUCMTqJeK5k3OldKzTU6B6ykhg5aviDWhn7TdjhGE9RlCYkTxU35k7xIJixwnFbC1hdFnsqGkpH1LAg9eiRWeVeBOr2PGBgCre58j2nSR+Dm/Pzo09AxLeBka03HTVp4bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lr1Q/s6JarZbC4nJ7vzbuwdgujMONfimGTZ+XNWpBNo=; b=gFLvv+7lD9PoLB/7IuxHenD19zTWkha54E2YBDSxobUMbNYoFlWcbzp3OKYiYWH8/boqwY2yC3d3PaIo3TBxVo3vXzHNa189x6VI1QznYgd2ciS1qM+9RKzJ/0ODvf1sVHteQY/iFkWZs/hY7l9hzN56TOYNuWBhzPm0+tEXFXJNL24swhnaGSH9bS/RjHx2Ver85m3z+fZ4fYQXho5wYnHAq+9LFr3BzKLJw5GNONij/zuLcbsMqvFLzPd5fAS799fLaDiUOAvWLXjW+IjoTfJA4DnDlBHSmoqiNuL4cc9lcqOa+53ZhLgb5LJlw2qNJVZwIVZJtYsVhZ4sPziqYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lr1Q/s6JarZbC4nJ7vzbuwdgujMONfimGTZ+XNWpBNo=; b=wI1Z4R2AvEOs+GLa4owIWejFJqb9zZgyh6YE8OcMtV5Sv2Jb2CDregEPBv+Y5isDRSvmLLj73FIifpSJHMvFGOxIwDfbdRDajmjHzwlcNnDlCmBuFv5NpUsBL0X9d05A5jcnxx6s57NR67/z3U80dtcDhYzRmwS1Jd1rgY69jYA= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SA2PR11MB5193.namprd11.prod.outlook.com (2603:10b6:806:fa::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.28; Wed, 19 May 2021 08:58:27 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::6157:b65c:53b6:a320]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::6157:b65c:53b6:a320%6]) with mapi id 15.20.4129.033; Wed, 19 May 2021 08:58:27 +0000 From: "Chiu, Chasel" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Chaganty, Rangasai V" , "Kethi Reddy, Deepika" , "Esakkithevar, Kathappan" Subject: Re: [edk2-platforms][PATCH v2 20/35] CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib Thread-Topic: [edk2-platforms][PATCH v2 20/35] CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib Thread-Index: AQHXTGOUwyt1cVN9WU6vaR+yv1i0farqgXQQ Date: Wed, 19 May 2021 08:58:27 +0000 Message-ID: References: <20210519035947.1234-1-mikuback@linux.microsoft.com> <20210519035947.1234-21-mikuback@linux.microsoft.com> In-Reply-To: <20210519035947.1234-21-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [114.43.45.8] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 82d3dc2e-f95f-496b-ff56-08d91aa44481 x-ms-traffictypediagnostic: SA2PR11MB5193: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F3cdZ9lyc9mKcfYFPZ1mekR9tU6VYFF08F0CTd9bImEVYIKfYt5D6bqRBr0CxQd3kIk8fun2uehyHCNDnfsHAzK4xpWhQUbB5/dJSxIjBuGUR0ys/AH2wLTKUGmhk61p5m0GITph+Sv+YaLA6OK2mAK2vMcsmuWvamolqnm/wWM8h5lE7SLR6u8mb78hARzfxIt5QIvvVE9eG0MSu0AUEwOJelnDLqLw64YC88UqRclO+5HQU5sXiWI0rcfFamtNsNpc0Y/Aa/3Ww7pIc7aWunCPzlpeTS5z4QYVDRs4dgxDrg0wDRVGpqVIvvcLjRj6Uu5X/JPQUPxV5S3W4kcIMFGbD+vQeHoZPMIpvgFFeN1+l+OAlRTTWkv8C8kS689JtVK+2luQzPmnGLnDYRVYMzb1PvtnwMtWJobAZvqsKZoF7tIG9zMuRTm5R0cRuedLsRtnda7l1RnqnZyDbCbb44x33RGe9g41p6mnrjfAguFcyv9kDSjncgYJCKTbTcUXKRZh/FyjcjGRMd0BkOPCsf/O/m8IgMxtAxU30uS1UrhrTTqeXoVJNJ64UXjPbfw7AgFVm9GyJm8mb62y2636TvqGq0iR0ApDeNw6+QVFROZKExxJfwFgFf8f1+XS85jBiezkEPuvuaJfm/gmX+ZZOYq5GTUbLGS3iAT8PzRMugs6GjU3qHyxHuqdpLSOzPVqUg7n27RuQEqHW1qbTKPgl0YFS3r1F9YUDIZw+d89xe8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(376002)(396003)(39850400004)(136003)(346002)(5660300002)(8936002)(9686003)(478600001)(38100700002)(107886003)(122000001)(52536014)(86362001)(8676002)(15650500001)(26005)(55016002)(316002)(54906003)(110136005)(64756008)(71200400001)(53546011)(4326008)(33656002)(66446008)(6506007)(2906002)(76116006)(66556008)(83380400001)(66476007)(186003)(7696005)(66946007)(11716005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ETf7rjBcS8+OM8scx6Fla4emPWz10VDJhdmLUyyiN382w/0Zxa3ik9N/5lQG?= =?us-ascii?Q?OPjXGsv+BLxEND518yZ8GmIWZJYym7lTce2MlZSpi9VU73aFfh5ARMxi7pSL?= =?us-ascii?Q?QokSieEDd4p8Yrgm4HN+G1RfzE6b7kbilme1SwrmbTtNP06gVcZurhF6E/+O?= =?us-ascii?Q?V5nyv2QDGdX68vkwCQ7bYD3UtNlFc8T9BJB2HpF48KyfoDspw96Y3TA2UsbU?= =?us-ascii?Q?1BzXucsvJng9CCDMAmoN8jvGbdI8VSQ2aAGv5csnIUVZABej7NpUCcocSB9Q?= =?us-ascii?Q?2gI2mTSssjrdOqNt/HPdKD6nTcxHc08tRCANb5PbTAXh24ICFSuWK5TMmVRc?= =?us-ascii?Q?mRV5BhDb39bRjG4cLboTqg+X1r63geglig4aMSwClQiznPZHFa+rJhTaGARD?= =?us-ascii?Q?Ot2mxhSpQQr4yREOu1dUIuf9SrvyIoGRAYcttgKRGxgrAAO3Ny50bBBIy8P6?= =?us-ascii?Q?fczzZeIC+ZgPaNcxISTZR8/UVclCp1F9g3HgZYWjg1oV+SOsVO/YZufK+rHk?= =?us-ascii?Q?uy8PE+VXCn3zua+jXZ8o0u9I1Fls/SSXMvOUXCH/LyTK8XfG2j7fyeIW5yxZ?= =?us-ascii?Q?43LYsCK/tD5aeRTkgt+FW/RzZcT6NmElu4agZlc4eSIrVzy6HYAl8BdMrYTS?= =?us-ascii?Q?sHH5/vX/kVVlHXwlYVzqoZudsSomQ8YnksYuJvaNWDN9NuGuSBypPE3rl7ff?= =?us-ascii?Q?e8tKQ8fmJ7IP6bLMddWUf/Hi8Vam2Nrmv8oCgbdIrXolQAucSVBLqMvbOGeZ?= =?us-ascii?Q?vRW+iOBwTuPyJQPja2dUghuYz2OsAO7/K1/ucIsaeETFNEpSc28kBnQQMTs/?= =?us-ascii?Q?4YAOAxs8vyLmj9sBc3y3SSuKlORatrip0Fvdg1gRhY5W4avmfaSpSLAtSCpc?= =?us-ascii?Q?ED6A5JQdzJvF+DssX4k7s9iQMm9m44RhbMBrb5TfwErExjtGlBy7LAa5jT/J?= =?us-ascii?Q?IwauULI6OLX7T3G9s9fZgQ0YzP44+XJlCSA+klkmrSArQubhgrf5wzRCPFV6?= =?us-ascii?Q?Yv7GPdLIp0ovvEaGDcjv90ZCLD6IVavezWJQZUQahIsDb0ld2N9rPgYintz5?= =?us-ascii?Q?ozLHFNzLck4Dvh1H4NKpSbR6QtZWhyhHN3hIqsHXWJpWeKkGGyX/I4CM+Yk1?= =?us-ascii?Q?YaBcOe6iM8+HhLte/AVA+gJJHdlifP1zkrValdXx6OBEMYgj9hMDrwTVnfU+?= =?us-ascii?Q?rqEi9DRKzZiWLCK3hACY6kV4L+/fW4YmXsCOW4QAe/3efFu0j7s66L8Kb9mJ?= =?us-ascii?Q?KVuSkN46z73g78p3rXDbcwBrJQbYJLI2vlcwjHhz/0dAC1loDXxcNdStqAEu?= =?us-ascii?Q?t44=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82d3dc2e-f95f-496b-ff56-08d91aa44481 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2021 08:58:27.4975 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7HSVSIw9d7WPmVm1vjXrkbg9N+cUVZe6reDJwqoQOsABxvgQ2zV8yA+77DgHbjMqGRjKXJMAEgpd0WcvF+81cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5193 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Wednesday, May 19, 2021 12:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar, Kathappan > > Subject: [edk2-platforms][PATCH v2 20/35] CometlakeOpenBoardPkg: Update > SpiFvbService & SpiFlashCommonLib >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 >=20 > Updates CometlakeOpenBoardPkg to use the SmmSpiFlashCommonLib instance > in IntelSiliconPkg and the SpiFvbServiceSmm driver in IntelSiliconPkg. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Rangasai V Chaganty > Cc: Deepika Kethi Reddy > Cc: Kathappan Esakkithevar > Signed-off-by: Michael Kubacki > --- > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | > 7 +++++-- > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf | > 2 +- > 2 files changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc > index 44a1bd54d6e9..316100e9a599 100644 > --- > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc > +++ > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.ds > +++ c > @@ -254,7 +254,7 @@ [LibraryClasses.X64.DXE_SMM_DRIVER] > ####################################### > # Silicon Initialization Package > ####################################### > - > SpiFlashCommonLib|$(PLATFORM_SI_PACKAGE)/Pch/Library/SmmSpiFlashCom > monLib/SmmSpiFlashCommonLib.inf > + > + > SpiFlashCommonLib|IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiF > + lashCommonLib.inf >=20 > ####################################### > # Platform Package > @@ -401,6 +401,10 @@ [Components.X64] > $(PLATFORM_SI_PACKAGE)/SystemAgent/SaInit/Dxe/SaInitDxe.inf > $(PLATFORM_SI_BIN_PACKAGE)/Microcode/MicrocodeUpdates.inf >=20 > +!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE > + IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf > +!endif > + > ####################################### > # Platform Package > ####################################### > @@ -421,7 +425,6 @@ [Components.X64] >=20 > !if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE >=20 > - $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf > $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf >=20 > $(PLATFORM_PACKAGE)/Acpi/AcpiSmm/AcpiSmm.inf { diff --git > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf > index 6397d80d3895..e341285f4b1a 100644 > --- > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf > +++ > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fd > +++ f > @@ -407,7 +407,7 @@ [FV.FvOsBootUncompact] !if > gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE INF > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > INF > $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf > -INF $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf > +INF IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf >=20 > INF $(PLATFORM_PACKAGE)/Acpi/AcpiTables/AcpiPlatform.inf > INF $(PLATFORM_PACKAGE)/Acpi/AcpiSmm/AcpiSmm.inf > -- > 2.28.0.windows.1