From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.8586.1617890039605079022 for ; Thu, 08 Apr 2021 06:53:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=TaqRDlht; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: chasel.chiu@intel.com) IronPort-SDR: HLup9whCWQ3ww6OEW7Rbh+MGmNG0DgD/2R5/EXmoDzcJDAFxtfXw9xc6PBVuGRj3uySgLTSAOG i8DeraJbdjpA== X-IronPort-AV: E=McAfee;i="6000,8403,9948"; a="191388700" X-IronPort-AV: E=Sophos;i="5.82,206,1613462400"; d="scan'208";a="191388700" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 06:53:12 -0700 IronPort-SDR: qHlKmM8lZubpFMiivGDV2ubF92osKXQ0yngl/9HJU02IOvJwJrWvB7wWC2URdCXx8dvgjrKa8V Qiu/dgVIxyag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,206,1613462400"; d="scan'208";a="415779172" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 08 Apr 2021 06:53:11 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 8 Apr 2021 06:53:11 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 8 Apr 2021 06:53:11 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 8 Apr 2021 06:53:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dp5wE4bwJIL1mt6BOvwfaweAxrWwQkXalwWCuoiZVsf6YOK5Uxvhkg77AJddm/vDFY7IcjLdDuUSF2rQJPl5+JMJOj5uziIWim+GwRbgDdyolJnpZcmcBCUGt1VtS7smGOn2J4d6SAhiWHnkSItezv4Yr2qYXItz6mZrHWTWZzLwxGsl4SE/ezrku2vT7V/P/U95rmnSFUcDhjiorYWh9qHFJ3Llqs9Lx20QhL5Jc88ZLwvz8Rh7GSNfiPlRhMNYu/MAH3jg9mrgM2olJBm4Qa5dizRHD1cMBj4bJM3DKVLpE2qO/tCzi8mAxYncaQw1sSZDg3vd8qI2aVIZYQcxLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R7rXa38Av7nMm03pI2O0S4MshibCn5bTA2xE/twK7o4=; b=mP+GjfP7VABhmSCl4AtPMnuDAC1djOjZMWSwjVZqSCosQ4nV6q2Y1fYM6t9Kc8vOj+ISvIqZ5C9X2KLTvq1a7VMB5I81bkZfHZU87JX9TJZjLLOvGONAGHdX5oYZy2lLnhGQGHALdy2PhrB3PdYxLOqHy/q5BnQyqNiQpDAZVlRr70viFeHdFiGXZwjP+lvyKQ7Mpv8kSxnLB47NruCE3t6YW7+GY2SPYaZKBfy+7zjE4iBZrJaU3zEVeZKxao7Mi272eIqjZNbdYntN1RXr4p9EyGst9XJAw/0pwnl07SYxwy4AM+5KPuj/iwec5ZMSNZHc+vOEv6AK0wUv3j8z5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R7rXa38Av7nMm03pI2O0S4MshibCn5bTA2xE/twK7o4=; b=TaqRDlhtjk2DiBrFcUnwt5qmrHLYUEapmWCSKLdNSLpHZOFI2rsC2oKvCxJGFk/3SXwbyG/egccvk/+5Ep2DAtWlG6xmqgRmMKDXg9pz4AKKAoYeBCj2XBbYYm8jQy5PYT+OcroRu3X2sCB3PjhE2lNRsSmNo7iwVUOk/kD+WI8= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB2607.namprd11.prod.outlook.com (2603:10b6:805:56::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.28; Thu, 8 Apr 2021 13:53:09 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::3101:f483:8348:816]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::3101:f483:8348:816%7]) with mapi id 15.20.4020.018; Thu, 8 Apr 2021 13:53:09 +0000 From: "Chiu, Chasel" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , Liming Gao , "Dong, Eric" Subject: Re: [PATCH v2] MinPlatformPkg: Add PcdMicrocodeOffsetInFv Thread-Topic: [PATCH v2] MinPlatformPkg: Add PcdMicrocodeOffsetInFv Thread-Index: AQHXLH0oi5vCw9DQXEKHJxhZWBUZ2Kqqo/dQ Date: Thu, 8 Apr 2021 13:53:09 +0000 Message-ID: References: <20210408134259.903-1-ray.ni@intel.com> In-Reply-To: <20210408134259.903-1-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [118.161.139.247] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4d37d85b-aa1f-4c29-b5a8-08d8fa95a507 x-ms-traffictypediagnostic: SN6PR11MB2607: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eu84Ct8QMr0fT4KOhIBr9Vo1PugvAk6Ce0i/furMwpeb9lheee7yUNnDD92HL/hHkz/i+VtnLhNTmF+BTTUsC3oTDbU8a3mVP2Ya+VRi4PbVx5oUhgJK4PuIvKzF4F7rrnwnTO6NK+929yfX5Eg3fm24YsXNPFquSRc9t8+7yvnDSDPRFJ1XwjFCuDaVhEPK9Nf4xm1+P6BrfboUuzujUnxB+DSNmtzcfKzHpSr7hrH3IaiZvzJnT7e4G/UePh5lmWXKe/FTX/EXbeZyi1z01FntzX+pDmOuO08q+ckMHeeUkDnbDMOXHwF0+X27Gkv1JaNn43v2JYgW1UwnSv5HqWBK+AbJlAM8M9Oc+Q0VwGmG19P4u1K6Zcogo/RPRB70DHe2Co7a9/YGEe7b8hB6B9ggBYNfVvWTv9qTTFP6pqrjaL9bCgN5yRkeZpphqLOH1fqkRpiigWNJmZvOfIIGLKf1anb53lSZBBC0xHgqKssLW4dNyPlx4aclzXfJjeJOcKRXa8DE349KQE4N0msspFwkoSsHY9VHELTmXUPPRCenNP2cCklGLgJJiQT9Jt3x8qfnd/nVJGRK9B2ws6xj3Olhdknm6CJgZ5TElrgL3qdCnqLI5vZgMnySeyDFo4eBbHE2ZDlKK0f860PZFHGvploaE6T5zt/Lrn6HgT808ok= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(136003)(376002)(396003)(346002)(39860400002)(366004)(52536014)(4326008)(7696005)(9686003)(83380400001)(66446008)(8676002)(186003)(316002)(33656002)(53546011)(54906003)(110136005)(66946007)(5660300002)(38100700001)(66476007)(86362001)(19627235002)(66556008)(71200400001)(478600001)(55236004)(55016002)(76116006)(26005)(107886003)(8936002)(2906002)(6506007)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?efm2+4EGq2k/J535UoN4grSlWdYBZcGTX2IQlz5TxCBV2wKPVvMkmYCF4/VF?= =?us-ascii?Q?kP2UJW2tSReRbIfulWeq/bx2T8WWGqJDvDCE/KSDGSfr8ldzqJJ8HNk/raEZ?= =?us-ascii?Q?zBaoMeezIEsen+seTvA6hb5ByrOyNmCLRHabVCVNo33QIlE3CsdPbqW2Yl8F?= =?us-ascii?Q?dmA9oA2Zu+hj5eOyp9nFeLOXXnVPeDUo9IgMggX2F/uFplrr24MwNsn50p0Z?= =?us-ascii?Q?imB4Z6yYFHuSuQLJPjzEgVA/eJJp7M5lcvHQvnbUlTLiLvN16aY1RYwfdIoz?= =?us-ascii?Q?3pWc6n/EHHy1Q8fdkVVuphR8MWTzemR47AB4xrF6ZnOIENpALEJNW2XDXxU3?= =?us-ascii?Q?/z0WQIfSQ5ePOcdS0kMX83nS9DwsaPzx5dF6gQydjuRJSI8EGMp12UN+uv2A?= =?us-ascii?Q?XJGU+7gHsd3IiBbAX2y1lR/05JkuYefzlvG1SH4PCqob5IYbyJtAjed6Wa0B?= =?us-ascii?Q?22HQJHBh/5jB3AvxpRkhUwT9swJDSfCODze93I1W66tZxDy764iF+SnVEJlz?= =?us-ascii?Q?BExLs6FKdwhjNIiG7cywuMcsHiIInnPGuSbxU9TrS6gZdZ5Dy/EB7e6ORT4t?= =?us-ascii?Q?R99KPhDY5Qll2+c0T/bhvYlwqsDM0MuS95/ADypgsr6jVT4FjJtFdzZ6kCXR?= =?us-ascii?Q?N+uk90Pp/m/Z8J59dMZ1PJjCnKKFzZywGs2Dll/tEeuiWoLS4UL4pXOljl0z?= =?us-ascii?Q?pu61Ms0RznVFalHsIFtlPJxILwyBAYBzkr0KVdfLs9/1om3Y03EnwYJGtfMt?= =?us-ascii?Q?MUQ1fjjjVlPkhUp80NITYTnQRSDImyX2hlCborgPCJ7r6cFVyA2lw0vmMtif?= =?us-ascii?Q?n/wiXXamXhlB7pAjbmAwz0pb0IBHvMLTu5tzI9L8jBBtHJ6IogAhkqZLtLwV?= =?us-ascii?Q?Fkl/yXdvAgAlj0IktwVrm3vchT/smFQhRfEnGfomd6hTszBUnjryEcFUsbV0?= =?us-ascii?Q?W3kcLG2t1lk73rgdWJJD+6vLm+t7WTBQJVNxGwdzdryPFh2pnbfsK3bSGcjP?= =?us-ascii?Q?Rlznl9BSZScv8o1HPzHkU48EFjHwX5qshXh0ItCcCcEDGIqraBwca/CJ7raE?= =?us-ascii?Q?doIizAksWgwKNSJiKHXIvFSgFw/t0Fjsep5CIb3hxJPbnSBJuQfeCBOWHu6/?= =?us-ascii?Q?cWnX0Rh/WdJTkUXXD2IfiLRUVGUYjesPHs5l3mCJMwEXEtt6VLisanW5x15s?= =?us-ascii?Q?pMXEeT/rNTl+Tw7vxiRk/w3NiJF/2HrOnkdS9P5Huyp3mKikDsQhjxrrvLBG?= =?us-ascii?Q?gow1C3AdPooN4YsiTOibPGtSYqI06Yv4KvpdR61n58OSpNvyrEh7FgcPa9ek?= =?us-ascii?Q?pjsjcYJV/R0ePnINnUYJuEJt?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d37d85b-aa1f-4c29-b5a8-08d8fa95a507 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 13:53:09.7722 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: psH4xZX4CgdNFIveO8VahmaNedGxx1NQo3bDZk8XFQ1FxHczMvbW9iSgTQ9DquqYyxlUTAaX1wyNqPQS7dR+Vw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2607 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Ni, Ray > Sent: Thursday, April 8, 2021 9:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [PATCH v2] MinPlatformPkg: Add PcdMicrocodeOffsetInFv >=20 > Add PcdMicrocodeOffsetInFv in MinPlatformPkg.dec and update > SecFspWrapperPlatformSecLib library to use the microcode location PCDs > defined in MinPlatformPkg. >=20 > Signed-off-by: Ray Ni > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > --- > .../SecFspWrapperPlatformSecLib.inf | 8 ++++---- > .../SecFspWrapperPlatformSecLib/SecRamInitData.c | 6 +++--- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 10 +++++++++- > 3 files changed, 16 insertions(+), 8 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatform > SecLib/SecFspWrapperPlatformSecLib.inf > b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatform > SecLib/SecFspWrapperPlatformSecLib.inf > index 4f3fa9fa34..2e0d67eae4 100644 > --- > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatform > SecLib/SecFspWrapperPlatformSecLib.inf > +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlat > +++ formSecLib/SecFspWrapperPlatformSecLib.inf > @@ -1,7 +1,7 @@ > ## @file # Provide FSP wrapper platform sec related function. #-# Copy= right (c) > 2017 - 2019, Intel Corporation. All rights reserved.
+# Copyright (c)= 2017 - > 2021, Intel Corporation. All rights reserved.
# # SPDX-License-Identi= fier: > BSD-2-Clause-Patent #@@ -88,9 +88,9 @@ > gMinPlatformPkgTokenSpaceGuid.PcdSecSerialPortDebugEnable ## > CONSUMES [FixedPcd]- > gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchAddress ## > CONSUMES- > gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize ## > CONSUMES- gIntelFsp2WrapperTokenSpaceGuid.PcdFlashMicrocodeOffset > ## CONSUMES+ gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase > ## CONSUMES+ gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize > ## CONSUMES+ gMinPlatformPkgTokenSpaceGuid.PcdMicrocodeOffsetInFv > ## CONSUMES gIntelFsp2WrapperTokenSpaceGuid.PcdFlashCodeCacheAddress > ## CONSUMES gIntelFsp2WrapperTokenSpaceGuid.PcdFlashCodeCacheSize > ## CONSUMES gIntelFsp2WrapperTokenSpaceGuid.PcdFspmBaseAddress > ## CONSUMESdiff --git > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatform > SecLib/SecRamInitData.c > b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatform > SecLib/SecRamInitData.c > index b356327b4c..355d1e6509 100644 > --- > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatform > SecLib/SecRamInitData.c > +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlat > +++ formSecLib/SecRamInitData.c > @@ -1,7 +1,7 @@ > /** @file Provide TempRamInitParams data. -Copyright (c) 2017, Intel > Corporation. All rights reserved.
+Copyright (c) 2017 - 2021, Intel > Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clau= se- > Patent **/@@ -24,8 +24,8 @@ GLOBAL_REMOVE_IF_UNREFERENCED CONST > FSPT_UPD_CORE_DATA FsptUpdDataPtr =3D { > } }, {- ((UINT32)FixedPcdGet64 (PcdCpuMicrocodePatchAddress) = + > FixedPcdGet32 (PcdFlashMicrocodeOffset)),- ((UINT32)FixedPcdGet64 > (PcdCpuMicrocodePatchRegionSize) - FixedPcdGet32 > (PcdFlashMicrocodeOffset)),+ FixedPcdGet32 (PcdFlashFvMicrocodeBase) + > FixedPcdGet32 (PcdMicrocodeOffsetInFv),+ FixedPcdGet32 > (PcdFlashFvMicrocodeSize) - FixedPcdGet32 (PcdMicrocodeOffsetInFv), 0= , > // Set CodeRegionBase as 0, so that caching will be 4GB-(CodeRegionSize > > LLCSize ? LLCSize : CodeRegionSize) will be used. FixedPcdGet32 > (PcdFlashCodeCacheSize), { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, = 0x00, > 0x00, 0x00,diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index 2b246cf0ac..28d2b1965e 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -6,7 +6,7 @@ > # INF files to generate AutoGen.c and AutoGen.h files # for the build > infrastructure. #-# Copyright (c) 2017 - 2020, Intel Corporation. All rig= hts > reserved.
+# Copyright (c) 2017 - 2021, Intel Corporation. All rights > reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -162,1= 0 > +162,18 @@ >=20 > gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress|0xFF800000|UINT > 32|0x10000001 > gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize|0x00800000|UINT32|0x10 > 000002 + ## Indicates the MMIO base address of the microcode FV in flash= . > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase|0xFFE60000|UINT > 32|0x30000004++ ## Indicates the size of the microcode FV in flash. > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize|0x000A0000|UINT > 32|0x30000005++ ## Indicates the offset of the microcode FV relative to = the > beginning of flash. > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeOffset|0x00660000|UI > NT32|0x30000006 + ## Indicates the offset of the actual microcode conten= t > relative to the beginning of the microcode FV.+ > gMinPlatformPkgTokenSpaceGuid.PcdMicrocodeOffsetInFv|0x90|UINT32|0x30 > 000007+ > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemoryBase|0x00000000|UIN > T32|0x20000004 > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemorySize|0x00000000|UIN > T32|0x20000005 > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemoryOffset|0x00000000|UI > NT32|0x20000006-- > 2.27.0.windows.1