From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web09.837.1608165335075069724 for ; Wed, 16 Dec 2020 16:35:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=VRY5slcr; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: chasel.chiu@intel.com) IronPort-SDR: LSQ6ulMBnXz2IfzjUHQs5q8XIsr6Dnq5iFfT4Gux92Js5REDOk2EN0Lx5fqPHXbqu4lrIrDkgr 9X3OQ4PB0DdA== X-IronPort-AV: E=McAfee;i="6000,8403,9837"; a="236740162" X-IronPort-AV: E=Sophos;i="5.78,425,1599548400"; d="scan'208";a="236740162" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2020 16:35:32 -0800 IronPort-SDR: eka1aosmzfEmLJxFkd81a6nvD2QPsHFnzgJxhvjsZHHA6sTYrSDE6zKMBzsKfZ73jg35sf08k9 66Q49hG/RbrA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,425,1599548400"; d="scan'208";a="379511959" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga007.jf.intel.com with ESMTP; 16 Dec 2020 16:35:32 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 16 Dec 2020 16:35:32 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 16 Dec 2020 16:35:31 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 16 Dec 2020 16:35:31 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 16 Dec 2020 16:35:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aTNqFRTWtp9BZOgIcRV2kSGmI0mkPNcZFTk/4Zj/GskbhN95SRAMdl40WlMBZiqMisDGOr5F7YwRHYv0eyzKbm4TVVvelRhK4JyjrYTxrC80W0dUq0QmSxH3RQTJYlewFAcVA4EIfzz7AiwvM0T6pos+42qSgqKgEmuCGoe5OLNy5wuk+4vtAgIEqJV8a7OjfL5g3KonNFO7jRECT1zRcL8xcZeau8m0uZyWvRJPABCabirxFTY3BEY2L5E857pzBm/puv09qeXMiPAPA4dxlD7z3etj++MzQxQybHBQI0ZlgJtLjroUwfgiROGA1DTh80SWplQF13cUahT2EFZvtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vQ7pgZ1ZuQlH7SwFatC3ACfQn14LLjCX96Sr7VtK8bQ=; b=Iq9ZNEdaYzgiw8n2Qggy8Zq7zL16BP/Hx+0j1DhwdgX95XjS/UGcmRNuVu6Vxvyi7V+7u2c6gqukSd4i1tvJWoWVNPg3xerKeTmwgyyVL38mrSub+XCE55EPNPAJoC/D2ev83S4ChSbg7GWQEXf/fz5G1j538AUOCXgfm64p+bKW2MBUfya2wXHD1ctuKMc8d+TRz09qC5A8nWOiKj+xQWUeKLboo/G/USGqgq4BSm/LXrl0IYDVRw1XHp91YS1KT8hW55pL7ZFMS/Mfb8dy9/vm2XtiyKi9mFRzSeFCuvGlUr1fYVxpNoebYcMcysP/B10b/FHYOxli2Xk5VbHGxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vQ7pgZ1ZuQlH7SwFatC3ACfQn14LLjCX96Sr7VtK8bQ=; b=VRY5slcrzywnv400iK9Ia8MK+kyy/aivUgeaMPHSqZLV766oO3DXF4Ft7bKtvdDEONs7pwGHoGJq9Ju3YOjbjohbUmfUB18QdsFX2VCjR/CrZzLh9wW0gu6ogCPeEQRhumVUhIm+ZWSNg0A8p7BHOFRA+TCU8P9VO1Gbgo8l01U= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB3455.namprd11.prod.outlook.com (2603:10b6:805:bb::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Thu, 17 Dec 2020 00:35:30 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::4967:fbdd:5a6f:e298]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::4967:fbdd:5a6f:e298%2]) with mapi id 15.20.3654.024; Thu, 17 Dec 2020 00:35:30 +0000 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "zhuyanming@byosoft.com.cn" CC: Liming Gao Subject: Re: [edk2-devel] [PATCH 3/3] MinPlatformPkg:change Several modules. Thread-Topic: [edk2-devel] [PATCH 3/3] MinPlatformPkg:change Several modules. Thread-Index: AQHW04cpS+SeVPiyqEu5k0YhmyCD1Kn6cTIA Date: Thu, 17 Dec 2020 00:35:30 +0000 Message-ID: References: <20201216084013.1995-1-zhuyanming@byosoft.com.cn> In-Reply-To: <20201216084013.1995-1-zhuyanming@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [220.129.96.8] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1ba3cb81-926c-47da-ee3e-08d8a223a866 x-ms-traffictypediagnostic: SN6PR11MB3455: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2ke1mJCuKQxjnIXUgAsERWqmz1lgKfCb/5Uy05SWMqaSPNqFLBAZGhRC4kVsai8nbfdV+M44NxUPCleWD3R7S3nlTLlenxszMCFRVhdy/OoBvGCHctuKpfPYIiOglgEEHcRJ+t8zhY0JX4FhRLoutLioRPw1hsLg1OtaBnEpueoZ5Zoy6bntY6DF9xt3PdLhh3GqSbgIBi95MFyq4OuRIn6YMgbQsMbbyN/sJyj7WCWbQsZKjGmrVOpt9g3cmujS63EktqFdCD0XspigZR+IqLoHrfQ2athq2BHN4jzLB2fc35L6yRfZ6IXb/8C14UCXeGO9B/a+hshRjvr73KLTQ8RmJoci8VGp6p0fdYkKcP1XgaEM3VLsykOtqsYfYoDqtyh3a+pwtzpYx3IUJZpRMw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(396003)(39860400002)(136003)(376002)(966005)(8676002)(316002)(110136005)(76116006)(26005)(4326008)(86362001)(66476007)(5660300002)(8936002)(2906002)(7696005)(55016002)(9686003)(6506007)(52536014)(71200400001)(64756008)(66556008)(186003)(66946007)(478600001)(53546011)(83380400001)(33656002)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?7K7o+AWsyFi43RM0QiQoFaGzZdXnyLVeTh0taeRidotSixBCFpUCnqlywdEv?= =?us-ascii?Q?W53qQ0ZVTxH49EkXswAFt/3ksSyv2H7/jyAazt+G1lwwdHfe58+gzdeLnToC?= =?us-ascii?Q?IQX/gfqrui/DtHr8kE0x7MieBOWuJqgzDuWyOneECNzLfhQvZhELP/WT3BIN?= =?us-ascii?Q?xuxRWtt/yP8TcfsjJMTWXPp41meNISsleuikdP+QC9oDe7vCnhEtDoeE4nim?= =?us-ascii?Q?M5ksv4AXamvOF8al0wmPZLTs9W2oDaAi0DPfz0Lia7QxlWesTtjr6Uz6a2dS?= =?us-ascii?Q?C/mB+Fg0VAQx/oJnMn8bMTIfZVkidz0G7h9jLUw2mOJYCLUDQoU9VgPhl/0h?= =?us-ascii?Q?zNc9tw78SPoW6x7wkSvpQ+Ky2qeSO5DASy50laptiC8l1ygjYgqQ/YPYG5mm?= =?us-ascii?Q?rajb+4qYqnOPV/6LyWBicyZ4OCveHSt3LKcC70gXlxYi9BFtHgv5PZK07W4X?= =?us-ascii?Q?v+CtP90QkQL91w0KveJej9Y6LqcXW6A6+aB8q5sxyEBljn4oiuSczI+15swm?= =?us-ascii?Q?nOhs5TcglIZaECoCbahrHrFQMJwwaNBj1uN74mTH/d/ov76VPzGi0LDz33CV?= =?us-ascii?Q?tjB6XHncVFyLXWL6xr2MARN8yUjU1vEE5JGashGqttZL1dDTFXlqCaiw5E8U?= =?us-ascii?Q?IJwAR6YHktZhTELjqb4jPhI0BrxNGjYKiYkS2N1OMy6fvaicCOw+YgSZ5Lh8?= =?us-ascii?Q?3NsXSr1bKk4NbpQGaf0JPWxjz+ahcl2w9jdQpVUPAC93uy1glL6xYLYrf9p9?= =?us-ascii?Q?AIZdc6UnkHaNOKcl1BMb/x41JTgkOEwdZKNwafUqIa6quzR/fbC3XOeOpD1K?= =?us-ascii?Q?8A4b4B2DzRvlVtcbY4B/qtaxiIhyLJlVRLI+qIdW3VVDdq9BkST+Yii6ZafN?= =?us-ascii?Q?iXZAfro7EKAcwwur9IfrLtJLxPSEt7q1c6NdcX8e/pT9TkNL57TGTOgD0jg7?= =?us-ascii?Q?9MWmyZR96L4c9bjJeBb5147wGaxvOelIBW8jsIxaOQE=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ba3cb81-926c-47da-ee3e-08d8a223a866 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2020 00:35:30.4688 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F3OvE/qsXtxYzhIP7Y9xiX5Y97siucz7Ipwf8lyMC+LVi2aZCiFcdN0q4426x5XqUHPrRruBss9/oWiJsw2PNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3455 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Yanming, Thanks for fixing this issue, would you help to use below subject for all = MinPlatform code reviews? --subject-prefix=3D"edk2-platforms: PATCH" Also I cannot find [0/3], [1/3] and [2/3] of this review patch series, if = it was single patch please remove [3/3]. Thanks, Chasel > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yanming > Zhu > Sent: Wednesday, December 16, 2020 4:40 PM > To: devel@edk2.groups.io > Cc: Liming Gao > Subject: [edk2-devel] [PATCH 3/3] MinPlatformPkg:change Several modules. >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3034 >=20 > The duplicated FILE_GUIDS in several files have been changed to make the= ir > GUids unique >=20 > Cc:Chasel Chiu > Cc:Nate DeSimone Cc:Liming Gao > Cc:Eric Dong >=20 > Signed-off-by: Yanming Zhu > Reviewed-by: Liming Gao > --- > .../Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf | 2 +- > .../MultiBoardAcpiSupportLib/SmmMultiBoardAcpiSupportLib.inf | 2 +- > .../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf | 2 +- > .../Test/Library/TestPointCheckLib/SmmTestPointCheckLib.inf | 2 +- > .../Test/Library/TestPointLib/DxeTestPointLib.inf | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdat= e > Lib.inf > b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdat= e > Lib.inf > index 1ddca75e..0b43ab60 100644 > --- > a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdat= e > Lib.inf > +++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslU > +++ pdateLib.inf > @@ -11,7 +11,7 @@ > [Defines] > INF_VERSION =3D 0x00010017 > BASE_NAME =3D DxeAslUpdateLib > -FILE_GUID =3D 8621697D-4E3A-4bf2-ADB0-3E2FF06559CA > +FILE_GUID =3D 1BC79513-CDD5-4993-A161-618015C6C66F > VERSION_STRING =3D 1.0 > MODULE_TYPE =3D BASE > LIBRARY_CLASS =3D AslUpdateLib > diff --git > a/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/Sm= m > MultiBoardAcpiSupportLib.inf > b/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/Sm= m > MultiBoardAcpiSupportLib.inf > index 5415446b..75bdf459 100644 > --- > a/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLib/Sm= m > MultiBoardAcpiSupportLib.inf > +++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/MultiBoardAcpiSupportLi > +++ b/SmmMultiBoardAcpiSupportLib.inf > @@ -10,7 +10,7 @@ > [Defines] > INF_VERSION =3D 0x00010005 > BASE_NAME =3D SmmMultiBoardAcpiSupportLib > - FILE_GUID =3D E0238683-D3FD-4D97-8874-37C6157E29= 06 > + FILE_GUID =3D DEA4470C-706B-42C5-93E1-5F0694182A= 6B > MODULE_TYPE =3D BASE > VERSION_STRING =3D 1.0 > LIBRARY_CLASS =3D MultiBoardAcpiSupportLib > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Rep= or > tCpuHobLib.inf > b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Rep= or > tCpuHobLib.inf > index df1d780e..28b17d39 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/Rep= or > tCpuHobLib.inf > +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib > +++ /ReportCpuHobLib.inf > @@ -10,7 +10,7 @@ > [Defines] > INF_VERSION =3D 0x00010005 > BASE_NAME =3D ReportCpuHobLib > - FILE_GUID =3D F19AA754-CE24-448D-B755-1F939B00C2= 5D > + FILE_GUID =3D 704FC922-D192-42D0-9B10-1BAECC1EDE= 73 > VERSION_STRING =3D 1.0 > MODULE_TYPE =3D PEIM > LIBRARY_CLASS =3D ReportCpuHobLib > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPo= in > tCheckLib.inf > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPo= in > tCheckLib.inf > index cfb9c7b8..8454a4e5 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPo= in > tCheckLib.inf > +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTe > +++ stPointCheckLib.inf > @@ -10,7 +10,7 @@ > [Defines] > INF_VERSION =3D 0x00010005 > BASE_NAME =3D SmmTestPointCheckLib > - FILE_GUID =3D 74A1F91F-AD11-49C5-96B8-A579F4AA65= F1 > + FILE_GUID =3D C1F70E6E-F9A6-46B9-B0F4-9FD0591265= BF > MODULE_TYPE =3D DXE_SMM_DRIVER > VERSION_STRING =3D 1.0 > LIBRARY_CLASS =3D TestPointCheckLib > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLi= b.inf > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLi= b.inf > index 17e5b756..7e53b439 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPointLi= b.inf > +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointLib/DxeTestPoi > +++ ntLib.inf > @@ -10,7 +10,7 @@ > [Defines] > INF_VERSION =3D 0x00010005 > BASE_NAME =3D DxeTestPointLib > - FILE_GUID =3D 9FDFABCE-7931-462F-8EDF-8C43AD5816= 9C > + FILE_GUID =3D 7963837C-17B8-4954-9E26-3D290D54D2= 95 > MODULE_TYPE =3D DXE_DRIVER > VERSION_STRING =3D 1.0 > LIBRARY_CLASS =3D TestPointLib > -- > 2.28.0.windows.1 >=20 >=20 >=20 >=20 >=20 >=20