[edk2-platforms] [PATCH 0/5] Intel: Fix spelling errors

[edk2-platforms] [PATCH 0/5] Intel: Fix spelling errors

[Nate DeSimone]

"implemenations" should be "implementations"
"beggining" should be "beginning"

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>

Nate DeSimone (5):
  MinPlatformPkg: Fix spelling errors
  Vlv2TbltDevicePkg: Fix spelling errors
  CoffeeLakeSiliconPkg: Fix spelling errors
  IntelSiliconPkg: Fix spelling errors
  KabylakeSiliconPkg: Fix spelling errors

 .../Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.c       | 4 ++--
 .../Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c    | 9 +++------
 .../Library/DxeAslUpdateLib/DxeAslUpdateLib.c            | 4 ++--
 .../Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c    | 4 ++--
 .../Library/DxeAslUpdateLib/DxeAslUpdateLib.c            | 4 ++--
 .../Library/DxeAslUpdateLib/DxeAslUpdateLib.c            | 4 ++--
 .../Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c    | 4 ++--
 7 files changed, 15 insertions(+), 18 deletions(-)

-- 
2.26.0.windows.1

[edk2-platforms] [PATCH 1/5] MinPlatformPkg: Fix spelling errors

[Nate DeSimone]

"implemenations" should be "implementations"
"beggining" should be "beginning"

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
---
 .../Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.c            | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.c b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
index 57df18d664..78efc8c0a7 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
@@ -22,14 +22,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/AslUpdateLib.h>
 
 //
-// Function implemenations
+// Function implementations
 //
 static EFI_ACPI_SDT_PROTOCOL      *mAcpiSdt = NULL;
 static EFI_ACPI_TABLE_PROTOCOL    *mAcpiTable = NULL;
 
 /**
   Initialize the ASL update library state.
-  This must be called at the beggining of the function calls in this library.
+  This must be called at the beginning of the function calls in this library.
 
   @retval EFI_SUCCESS          - The function completed successfully.
 **/
-- 
2.26.0.windows.1

[edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix spelling errors

[Nate DeSimone]

"implemenations" should be "implementations"

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
---
 .../Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c    | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
index 8283483ff8..5607997f4e 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
@@ -1,14 +1,11 @@
 /** @file
 
-  Copyright (c) 2004  - 2014, Intel Corporation. All rights reserved.<BR>
-                                                                                   

-  SPDX-License-Identifier: BSD-2-Clause-Patent
+  Copyright (c) 2004  - 2020, Intel Corporation. All rights reserved.<BR>
 
-                                                                                   

+  SPDX-License-Identifier: BSD-2-Clause-Patent
 
 Module Name:
 
-
   MonoStatusCode.c
 
 Abstract:
@@ -35,7 +32,7 @@ EFI_PEI_PPI_DESCRIPTOR  mPpiListStatusCode = {
 };
 
 //
-// Function implemenations
+// Function implementations
 //
 
 /**
-- 
2.26.0.windows.1

[edk2-platforms] [PATCH 3/5] CoffeeLakeSiliconPkg: Fix spelling errors

[Nate DeSimone]

"implemenations" should be "implementations"
"beggining" should be "beginning"

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
---
 .../Library/DxeAslUpdateLib/DxeAslUpdateLib.c                 | 4 ++--
 .../Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c         | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
index 28d20980af..ef30eb23ae 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
@@ -23,14 +23,14 @@
 #include <Library/AslUpdateLib.h>
 
 //
-// Function implemenations
+// Function implementations
 //
 static EFI_ACPI_SDT_PROTOCOL      *mAcpiSdt = NULL;
 static EFI_ACPI_TABLE_PROTOCOL    *mAcpiTable = NULL;
 
 /**
   Initialize the ASL update library state.
-  This must be called at the beggining of the function calls in this library.
+  This must be called at the beginning of the function calls in this library.
 
   @retval EFI_SUCCESS          - The function completed successfully.
 **/
diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c
index f143af981d..5234e6fd19 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c
@@ -23,12 +23,12 @@
 #include <Library/AslUpdateLib.h>
 
 //
-// Function implemenations
+// Function implementations
 //
 
 /**
   Initialize the ASL update library state.
-  This must be called at the beggining of the function calls in this library.
+  This must be called at the beginning of the function calls in this library.
 
   @retval EFI_SUCCESS          - The function completed successfully.
 **/
-- 
2.26.0.windows.1

[edk2-platforms] [PATCH 4/5] IntelSiliconPkg: Fix spelling errors

[Nate DeSimone]

"implemenations" should be "implementations"
"beggining" should be "beginning"

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
---
 .../IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c b/Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
index 6bca596b43..86ca3c753a 100644
--- a/Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
+++ b/Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
@@ -23,14 +23,14 @@
 #include <Library/AslUpdateLib.h>
 
 //
-// Function implemenations
+// Function implementations
 //
 static EFI_ACPI_SDT_PROTOCOL      *mAcpiSdt = NULL;
 static EFI_ACPI_TABLE_PROTOCOL    *mAcpiTable = NULL;
 
 /**
   Initialize the ASL update library state.
-  This must be called at the beggining of the function calls in this library.
+  This must be called at the beginning of the function calls in this library.
 
   @retval EFI_SUCCESS          - The function completed successfully.
 **/
-- 
2.26.0.windows.1

[edk2-platforms] [PATCH 5/5] KabylakeSiliconPkg: Fix spelling errors

[Nate DeSimone]

"implemenations" should be "implementations"
"beggining" should be "beginning"

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
---
 .../Library/DxeAslUpdateLib/DxeAslUpdateLib.c                 | 4 ++--
 .../Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c         | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c b/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
index 67507643ea..699ba1ba0e 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
+++ b/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
@@ -22,14 +22,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/AslUpdateLib.h>
 
 //
-// Function implemenations
+// Function implementations
 //
 static EFI_ACPI_SDT_PROTOCOL      *mAcpiSdt = NULL;
 static EFI_ACPI_TABLE_PROTOCOL    *mAcpiTable = NULL;
 
 /**
   Initialize the ASL update library state.
-  This must be called at the beggining of the function calls in this library.
+  This must be called at the beginning of the function calls in this library.
 
   @retval EFI_SUCCESS          - The function completed successfully.
 **/
diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c b/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c
index 9c0447372d..cd705d738f 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c
+++ b/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c
@@ -22,12 +22,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/AslUpdateLib.h>
 
 //
-// Function implemenations
+// Function implementations
 //
 
 /**
   Initialize the ASL update library state.
-  This must be called at the beggining of the function calls in this library.
+  This must be called at the beginning of the function calls in this library.
 
   @retval EFI_SUCCESS          - The function completed successfully.
 **/
-- 
2.26.0.windows.1

Re: [edk2-platforms] [PATCH 3/5] CoffeeLakeSiliconPkg: Fix spelling errors

[Chaganty, Rangasai V]

Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> 
Sent: Monday, May 18, 2020 11:18 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: [edk2-platforms] [PATCH 3/5] CoffeeLakeSiliconPkg: Fix spelling errors

"implemenations" should be "implementations"
"beggining" should be "beginning"

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
---
 .../Library/DxeAslUpdateLib/DxeAslUpdateLib.c                 | 4 ++--
 .../Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c         | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
index 28d20980af..ef30eb23ae 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
@@ -23,14 +23,14 @@
 #include <Library/AslUpdateLib.h>
 
 //
-// Function implemenations
+// Function implementations
 //
 static EFI_ACPI_SDT_PROTOCOL      *mAcpiSdt = NULL;
 static EFI_ACPI_TABLE_PROTOCOL    *mAcpiTable = NULL;
 
 /**
   Initialize the ASL update library state.
-  This must be called at the beggining of the function calls in this library.
+  This must be called at the beginning of the function calls in this library.
 
   @retval EFI_SUCCESS          - The function completed successfully.
 **/
diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c
index f143af981d..5234e6fd19 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c
@@ -23,12 +23,12 @@
 #include <Library/AslUpdateLib.h>
 
 //
-// Function implemenations
+// Function implementations
 //
 
 /**
   Initialize the ASL update library state.
-  This must be called at the beggining of the function calls in this library.
+  This must be called at the beginning of the function calls in this library.
 
   @retval EFI_SUCCESS          - The function completed successfully.
 **/
-- 
2.26.0.windows.1

Re: [edk2-platforms] [PATCH 4/5] IntelSiliconPkg: Fix spelling errors

[Chaganty, Rangasai V]

Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> 
Sent: Monday, May 18, 2020 11:18 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: [edk2-platforms] [PATCH 4/5] IntelSiliconPkg: Fix spelling errors

"implemenations" should be "implementations"
"beggining" should be "beginning"

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
---
 .../IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c b/Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
index 6bca596b43..86ca3c753a 100644
--- a/Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
+++ b/Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
@@ -23,14 +23,14 @@
 #include <Library/AslUpdateLib.h>
 
 //
-// Function implemenations
+// Function implementations
 //
 static EFI_ACPI_SDT_PROTOCOL      *mAcpiSdt = NULL;
 static EFI_ACPI_TABLE_PROTOCOL    *mAcpiTable = NULL;
 
 /**
   Initialize the ASL update library state.
-  This must be called at the beggining of the function calls in this library.
+  This must be called at the beginning of the function calls in this library.
 
   @retval EFI_SUCCESS          - The function completed successfully.
 **/
-- 
2.26.0.windows.1

Re: [edk2-platforms] [PATCH 5/5] KabylakeSiliconPkg: Fix spelling errors

[Chaganty, Rangasai V]

Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> 
Sent: Monday, May 18, 2020 11:18 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: [edk2-platforms] [PATCH 5/5] KabylakeSiliconPkg: Fix spelling errors

"implemenations" should be "implementations"
"beggining" should be "beginning"

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
---
 .../Library/DxeAslUpdateLib/DxeAslUpdateLib.c                 | 4 ++--
 .../Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c         | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c b/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
index 67507643ea..699ba1ba0e 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
+++ b/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpd
+++ ateLib.c
@@ -22,14 +22,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent  #include <Library/AslUpdateLib.h>
 
 //
-// Function implemenations
+// Function implementations
 //
 static EFI_ACPI_SDT_PROTOCOL      *mAcpiSdt = NULL;
 static EFI_ACPI_TABLE_PROTOCOL    *mAcpiTable = NULL;
 
 /**
   Initialize the ASL update library state.
-  This must be called at the beggining of the function calls in this library.
+  This must be called at the beginning of the function calls in this library.
 
   @retval EFI_SUCCESS          - The function completed successfully.
 **/
diff --git a/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c b/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c
index 9c0447372d..cd705d738f 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c
+++ b/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAs
+++ lUpdateLibNull.c
@@ -22,12 +22,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent  #include <Library/AslUpdateLib.h>
 
 //
-// Function implemenations
+// Function implementations
 //
 
 /**
   Initialize the ASL update library state.
-  This must be called at the beggining of the function calls in this library.
+  This must be called at the beginning of the function calls in this library.
 
   @retval EFI_SUCCESS          - The function completed successfully.
 **/
--
2.26.0.windows.1

Re: [edk2-platforms] [PATCH 1/5] MinPlatformPkg: Fix spelling errors

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Tuesday, May 19, 2020 2:18 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-platforms] [PATCH 1/5] MinPlatformPkg: Fix spelling errors
> 
> "implemenations" should be "implementations"
> "beggining" should be "beginning"
> 
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
>  .../Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.c            | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpda
> teLib.c
> b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpda
> teLib.c
> index 57df18d664..78efc8c0a7 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpda
> teLib.c
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslU
> +++ pdateLib.c
> @@ -22,14 +22,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #include <Library/AslUpdateLib.h>
> 
>  //
> -// Function implemenations
> +// Function implementations
>  //
>  static EFI_ACPI_SDT_PROTOCOL      *mAcpiSdt = NULL;
>  static EFI_ACPI_TABLE_PROTOCOL    *mAcpiTable = NULL;
> 
>  /**
>    Initialize the ASL update library state.
> -  This must be called at the beggining of the function calls in this library.
> +  This must be called at the beginning of the function calls in this library.
> 
>    @retval EFI_SUCCESS          - The function completed successfully.
>  **/
> --
> 2.26.0.windows.1

Re: [edk2-platforms] [PATCH 3/5] CoffeeLakeSiliconPkg: Fix spelling errors

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Tuesday, May 19, 2020 2:18 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [edk2-platforms] [PATCH 3/5] CoffeeLakeSiliconPkg: Fix spelling
> errors
> 
> "implemenations" should be "implementations"
> "beggining" should be "beginning"
> 
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> ---
>  .../Library/DxeAslUpdateLib/DxeAslUpdateLib.c                 | 4 ++--
>  .../Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c         | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git
> a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateL
> ib.c
> b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateL
> ib.c
> index 28d20980af..ef30eb23ae 100644
> ---
> a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateL
> ib.c
> +++
> b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateL
> ib.c
> @@ -23,14 +23,14 @@
>  #include <Library/AslUpdateLib.h>
> 
>  //
> -// Function implemenations
> +// Function implementations
>  //
>  static EFI_ACPI_SDT_PROTOCOL      *mAcpiSdt = NULL;
>  static EFI_ACPI_TABLE_PROTOCOL    *mAcpiTable = NULL;
> 
>  /**
>    Initialize the ASL update library state.
> -  This must be called at the beggining of the function calls in this library.
> +  This must be called at the beginning of the function calls in this library.
> 
>    @retval EFI_SUCCESS          - The function completed successfully.
>  **/
> diff --git
> a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpd
> ateLibNull.c
> b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpd
> ateLibNull.c
> index f143af981d..5234e6fd19 100644
> ---
> a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpd
> ateLibNull.c
> +++
> b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpd
> ateLibNull.c
> @@ -23,12 +23,12 @@
>  #include <Library/AslUpdateLib.h>
> 
>  //
> -// Function implemenations
> +// Function implementations
>  //
> 
>  /**
>    Initialize the ASL update library state.
> -  This must be called at the beggining of the function calls in this library.
> +  This must be called at the beginning of the function calls in this library.
> 
>    @retval EFI_SUCCESS          - The function completed successfully.
>  **/
> --
> 2.26.0.windows.1

Re: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix spelling errors

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate
> DeSimone
> Sent: Tuesday, May 19, 2020 2:18 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix
> spelling errors
> 
> "implemenations" should be "implementations"
> 
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> ---
>  .../Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c    | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git
> a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> index 8283483ff8..5607997f4e 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> +++
> b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> @@ -1,14 +1,11 @@
>  /** @file
> 
> -  Copyright (c) 2004  - 2014, Intel Corporation. All rights reserved.<BR>
> -
> 
> -  SPDX-License-Identifier: BSD-2-Clause-Patent
> +  Copyright (c) 2004  - 2020, Intel Corporation. All rights
> + reserved.<BR>
> 
> -
> 
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  Module Name:
> 
> -
>    MonoStatusCode.c
> 
>  Abstract:
> @@ -35,7 +32,7 @@ EFI_PEI_PPI_DESCRIPTOR  mPpiListStatusCode = {  };
> 
>  //
> -// Function implemenations
> +// Function implementations
>  //
> 
>  /**
> --
> 2.26.0.windows.1
> 
> 
> 

Re: [edk2-devel] [edk2-platforms] [PATCH 4/5] IntelSiliconPkg: Fix spelling errors

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate
> DeSimone
> Sent: Tuesday, May 19, 2020 2:18 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH 4/5] IntelSiliconPkg: Fix
> spelling errors
> 
> "implemenations" should be "implementations"
> "beggining" should be "beginning"
> 
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> ---
>  .../IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
> b/Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
> index 6bca596b43..86ca3c753a 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
> +++
> b/Silicon/Intel/IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
> @@ -23,14 +23,14 @@
>  #include <Library/AslUpdateLib.h>
> 
>  //
> -// Function implemenations
> +// Function implementations
>  //
>  static EFI_ACPI_SDT_PROTOCOL      *mAcpiSdt = NULL;
>  static EFI_ACPI_TABLE_PROTOCOL    *mAcpiTable = NULL;
> 
>  /**
>    Initialize the ASL update library state.
> -  This must be called at the beggining of the function calls in this library.
> +  This must be called at the beginning of the function calls in this library.
> 
>    @retval EFI_SUCCESS          - The function completed successfully.
>  **/
> --
> 2.26.0.windows.1
> 
> 
> 

Re: [edk2-platforms] [PATCH 5/5] KabylakeSiliconPkg: Fix spelling errors

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Tuesday, May 19, 2020 2:18 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [edk2-platforms] [PATCH 5/5] KabylakeSiliconPkg: Fix spelling errors
> 
> "implemenations" should be "implementations"
> "beggining" should be "beginning"
> 
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> ---
>  .../Library/DxeAslUpdateLib/DxeAslUpdateLib.c                 | 4 ++--
>  .../Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c         | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git
> a/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib
> .c
> b/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib
> .c
> index 67507643ea..699ba1ba0e 100644
> ---
> a/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib
> .c
> +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpd
> +++ ateLib.c
> @@ -22,14 +22,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #include <Library/AslUpdateLib.h>
> 
>  //
> -// Function implemenations
> +// Function implementations
>  //
>  static EFI_ACPI_SDT_PROTOCOL      *mAcpiSdt = NULL;
>  static EFI_ACPI_TABLE_PROTOCOL    *mAcpiTable = NULL;
> 
>  /**
>    Initialize the ASL update library state.
> -  This must be called at the beggining of the function calls in this library.
> +  This must be called at the beginning of the function calls in this library.
> 
>    @retval EFI_SUCCESS          - The function completed successfully.
>  **/
> diff --git
> a/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdat
> eLibNull.c
> b/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdat
> eLibNull.c
> index 9c0447372d..cd705d738f 100644
> ---
> a/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdat
> eLibNull.c
> +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAs
> +++ lUpdateLibNull.c
> @@ -22,12 +22,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #include <Library/AslUpdateLib.h>
> 
>  //
> -// Function implemenations
> +// Function implementations
>  //
> 
>  /**
>    Initialize the ASL update library state.
> -  This must be called at the beggining of the function calls in this library.
> +  This must be called at the beginning of the function calls in this library.
> 
>    @retval EFI_SUCCESS          - The function completed successfully.
>  **/
> --
> 2.26.0.windows.1

Re: [edk2-platforms] [PATCH 1/5] MinPlatformPkg: Fix spelling errors

[Dong, Eric]

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Tuesday, May 19, 2020 2:18 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-platforms] [PATCH 1/5] MinPlatformPkg: Fix spelling errors
> 
> "implemenations" should be "implementations"
> "beggining" should be "beginning"
> 
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
>  .../Acpi/Library/DxeAslUpdateLib/DxeAslUpdateLib.c            | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpd
> ateLib.c
> b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpd
> ateLib.c
> index 57df18d664..78efc8c0a7 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpd
> ateLib.c
> +++
> b/Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslU
> +++ pdateLib.c
> @@ -22,14 +22,14 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #include <Library/AslUpdateLib.h>
> 
>  //
> -// Function implemenations
> +// Function implementations
>  //
>  static EFI_ACPI_SDT_PROTOCOL      *mAcpiSdt = NULL;
>  static EFI_ACPI_TABLE_PROTOCOL    *mAcpiTable = NULL;
> 
>  /**
>    Initialize the ASL update library state.
> -  This must be called at the beggining of the function calls in this library.
> +  This must be called at the beginning of the function calls in this library.
> 
>    @retval EFI_SUCCESS          - The function completed successfully.
>  **/
> --
> 2.26.0.windows.1

Re: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix spelling errors

[Michael D Kinney]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Nate DeSimone
> Sent: Monday, May 18, 2020 11:18 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi
> <yi.qian@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH 2/5]
> Vlv2TbltDevicePkg: Fix spelling errors
> 
> "implemenations" should be "implementations"
> 
> Signed-off-by: Nate DeSimone
> <nathaniel.l.desimone@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> ---
>  .../Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git
> a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoS
> tatusCode.c
> b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoS
> tatusCode.c
> index 8283483ff8..5607997f4e 100644
> ---
> a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoS
> tatusCode.c
> +++
> b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoS
> tatusCode.c
> @@ -1,14 +1,11 @@
>  /** @file
> 
> -  Copyright (c) 2004  - 2014, Intel Corporation. All
> rights reserved.<BR>
> -
> 
> -  SPDX-License-Identifier: BSD-2-Clause-Patent
> +  Copyright (c) 2004  - 2020, Intel Corporation. All
> rights reserved.<BR>
> 
> -
> 
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  Module Name:
> 
> -
>    MonoStatusCode.c
> 
>  Abstract:
> @@ -35,7 +32,7 @@ EFI_PEI_PPI_DESCRIPTOR
> mPpiListStatusCode = {
>  };
> 
>  //
> -// Function implemenations
> +// Function implementations
>  //
> 
>  /**
> --
> 2.26.0.windows.1
> 
> 
> 

Re: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix spelling errors

[Guomin Jiang]

Add comment inline

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate
> DeSimone
> Sent: Tuesday, May 19, 2020 2:18 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix
> spelling errors
> 
> "implemenations" should be "implementations"
> 
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> ---
>  .../Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c    | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git
> a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> index 8283483ff8..5607997f4e 100644
> ---
> a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> +++
> b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> @@ -1,14 +1,11 @@
>  /** @file
> 
> -  Copyright (c) 2004  - 2014, Intel Corporation. All rights reserved.<BR>
> -
> 
> -  SPDX-License-Identifier: BSD-2-Clause-Patent
> +  Copyright (c) 2004  - 2020, Intel Corporation. All rights
> + reserved.<BR>
> 
> -
> 
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  Module Name:
> 
> -
>    MonoStatusCode.c

I think that there are too many empty line between the Module Name: with MonoStatusCode.c

I suggest use format as below:
Module Name: MonoStatusCode.c
Or 
Module Name:

MonoStatusCode.c

Others change is good to me.

Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>

> 
>  Abstract:
> @@ -35,7 +32,7 @@ EFI_PEI_PPI_DESCRIPTOR  mPpiListStatusCode = {  };
> 
>  //
> -// Function implemenations
> +// Function implementations
>  //
> 
>  /**
> --
> 2.26.0.windows.1
> 
> 
>