From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Chuang, SofiaX" <sofiax.chuang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
Jeremy Soller <jeremy@system76.com>
Subject: Re: [PATCH 5/7] KabylakeOpenBoard: Move ReportCpuHob library path
Date: Mon, 19 Apr 2021 08:58:47 +0000 [thread overview]
Message-ID: <SN6PR11MB281480FC6A7BED4DD370EC4CE6499@SN6PR11MB2814.namprd11.prod.outlook.com> (raw)
In-Reply-To: <14023c12d08daa19c88722d751dd3672abee00e3.1618821680.git.sofiax.chuang@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Chuang, SofiaX <sofiax.chuang@intel.com>
> Sent: Monday, April 19, 2021 4:44 PM
> To: devel@edk2.groups.io
> Cc: Chuang, SofiaX <sofiax.chuang@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Jeremy Soller <jeremy@system76.com>
> Subject: [PATCH 5/7] KabylakeOpenBoard: Move ReportCpuHob library path
>
> From: SofiaX Chuang <sofiax.chuang@intel.com>
>
> Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> ---
> .../KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 11 ++++++++---
> .../KabylakeRvp3/OpenBoardPkg.dsc | 11 ++++++++---
> 2 files changed, 16 insertions(+), 6 deletions(-)
>
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> index 862e6a6655..302cb679b5 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> @@ -1,7 +1,7 @@
> ## @file
>
> # The main build description file for the GalagoPro3 board.
>
> #
>
> -# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
>
> +# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
>
> #
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> @@ -38,7 +38,8 @@
> #
>
> # Include PCD configuration for this board.
>
> #
>
> - !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
>
>
> + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
>
> +
>
> !include OpenBoardPkgPcd.dsc
>
> !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
>
>
>
> @@ -160,7 +161,11 @@
>
> DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDe
> bugLibReportStatusCode.inf
>
> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
>
>
> SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheM
> trrLibNull.inf
>
> -
> ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHob
> Lib/ReportCpuHobLib.inf
>
> +
>
> + #######################################
>
> + # Silicon Package
>
> + #######################################
>
> +
> ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.i
> nf
>
>
>
> #######################################
>
> # Platform Package
>
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> index 0b30da8f96..8523ab3f4f 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> @@ -1,7 +1,7 @@
> ## @file
>
> # The main build description file for the KabylakeRvp3 board.
>
> #
>
> -# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
>
> +# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR>
>
> #
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> @@ -37,7 +37,8 @@
> #
>
> # Include PCD configuration for this board.
>
> #
>
> - !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
>
>
> + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
>
> +
>
> !include OpenBoardPkgPcd.dsc
>
> !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
>
>
>
> @@ -201,6 +202,11 @@
>
> SecBoardInitLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/SecBoardInitLibN
> ull/SecBoardInitLibNull.inf
>
>
>
> [LibraryClasses.common.PEIM]
>
> + #######################################
>
> + # Silicon Package
>
> + #######################################
>
> +
> ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.i
> nf
>
> +
>
> #######################################
>
> # Platform Package
>
> #######################################
>
> @@ -212,7 +218,6 @@
>
> TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/Pei
> TestPointCheckLib.inf
>
> !endif
>
>
> SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheM
> trrLibNull.inf
>
> -
> ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHob
> Lib/ReportCpuHobLib.inf
>
>
>
> #######################################
>
> # Board Package
>
> --
> 2.27.0
next parent reply other threads:[~2021-04-19 8:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <857a091f9b1354841746b143869b1f17cccbcaa0.1618821680.git.sofiax.chuang@intel.com>
[not found] ` <14023c12d08daa19c88722d751dd3672abee00e3.1618821680.git.sofiax.chuang@intel.com>
2021-04-19 8:58 ` Chiu, Chasel [this message]
[not found] ` <0e4dd81af9e438415eccb32e73e3e17920d05be2.1618821680.git.sofiax.chuang@intel.com>
2021-04-19 8:59 ` [PATCH 7/7] MiniPlatformPkg: Move ReportCpuHob library path Chiu, Chasel
[not found] ` <342b10f298070605571cc6e1762fa95086b43420.1618821680.git.sofiax.chuang@intel.com>
2021-04-19 9:00 ` [PATCH 6/7] WhiskeylakeOpenBoard: Move " Chiu, Chasel
[not found] ` <5cf2561a7791e574268e45eba0028819a2b8f5d0.1618821680.git.sofiax.chuang@intel.com>
2021-04-19 9:00 ` [PATCH 2/7] CometlakeOpenBoard: Move ReportCpuHob " Chiu, Chasel
2021-04-19 11:00 ` Kathappan Esakkithevar
2021-04-26 8:39 ` [PATCH 1/7] IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib Ni, Ray
[not found] ` <083a9641bbcbd28f67b093708c9e4089043fce40.1618821680.git.sofiax.chuang@intel.com>
2021-04-27 1:46 ` [PATCH 3/7] TigerlakeOpenBoard: Move ReportCpuHob library path Heng Luo
2021-04-27 21:02 ` Chaganty, Rangasai V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB281480FC6A7BED4DD370EC4CE6499@SN6PR11MB2814.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox