From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.1007.1587710736981148677 for ; Thu, 23 Apr 2020 23:45:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=TTbgQpnl; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: chasel.chiu@intel.com) IronPort-SDR: uaqq4MbXwiLSdf1O9UNuv7Nt0ZzbA4DcBzh3EaUzjvkwe47tGzs3TPMy+j9ZYuFN1a+jDbb7Ps 3EY5DbBFNCrQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 23:45:35 -0700 IronPort-SDR: S0KAZRsVB7+i1ZyXuOTzKSR8mrdwEXnG8DXgsOIwcwZEY7WO4QgOsAY/6D3OPQR0TdjTzFgL1G N4yFl6Ql/d/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,310,1583222400"; d="scan'208,217";a="256274618" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 23 Apr 2020 23:45:35 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 23:44:42 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 23:44:42 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 23:44:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L66afNYIuTjup4lVxRxQGyvnwxhNMbLRk1pDI7glg1LPe69j5ir4voLeyMyi3vLLF+eUvDP131+nKBITi8S2Ax1gHaOo+lCbMzVUufEowl0i2OeCAVZnciZhgnx2BTp0NYTvtuZSeAyENVAqBaCvDDZk/ISS8NsFLwk5C2hDiDWC0bHHyaqRAzzMfghtf7Oq39PpGkq2qP170nLn8xJQOsXIMwMM/XAdzXH+QaZ8rAW+h23MonTGIktiVvUF+yjngNHFYOuK5YJuDm3/d4iah3es1qN2Y1RwvHohLcmV8Jyf/bjuGfv/dMsBuZaZcTZ1XN7Ezg4Adro/nynMfByfwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Ml54kvetoeGEVRid9i60dE1PlAjAI0nRJRDdGxU4P4=; b=OMC6A3+0NmLCpRioKJHM7oYAg+KxJ51NrBZD3k2uWMYFva5lV8jc9HfE+y5HAJfNvFAIvYP/JW7dmfvaZaoXKLp18cczB54DdkEdvQdC+uWVpBcoS7YE25gQ97Ysl9rhfr4EJcWZCrJi0OW6tjbYkVSvOSrauYSIW5KL/bV8YAHgNP/Oat23wlrpmhHyqs1H/6uL/tOcsr5tIbqG2G/b+8+3dmMeniNVgQ8DbGnLIdXsPKJerHq7A5Q+4Jg4vae/pbala8/hR5/XGeH2lWbLSePD5bPgZOq9fgFFxEzz+22LZsjPJrXE+KB9MSBo+NTYiJ1v9DRr/PQrNH1uB61L9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Ml54kvetoeGEVRid9i60dE1PlAjAI0nRJRDdGxU4P4=; b=TTbgQpnl5cEIAajvPlH6t6T34L96niAqQF1SjAMKOMMXfL7nVzNamD19jSOaam6oKIVq+HPxSuZiFAMYbOknnhsyJBq+APItwEJKfEJiiY9WudPj5MO4zIGADK4k+Ly1r0btVXTLludvGAkJ3S6J0Z7IysdsVU+TotrEQL/qwKg= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB2590.namprd11.prod.outlook.com (2603:10b6:805:54::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Fri, 24 Apr 2020 06:44:41 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584%4]) with mapi id 15.20.2937.020; Fri, 24 Apr 2020 06:44:41 +0000 From: "Chiu, Chasel" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Agyeman, Prince" , Michael Kubacki Subject: Re: [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: Add BDS Hook Dxe Driver Thread-Topic: [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: Add BDS Hook Dxe Driver Thread-Index: AQHWGB0y3ghX/sA+3UyltWjIKppw1aiH11ms Date: Fri, 24 Apr 2020 06:44:40 +0000 Message-ID: References: <20200421204028.10410-1-nathaniel.l.desimone@intel.com>,<20200421204028.10410-3-nathaniel.l.desimone@intel.com> In-Reply-To: <20200421204028.10410-3-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=chasel.chiu@intel.com; x-originating-ip: [134.134.139.72] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7610a16a-ceaf-43b0-7037-08d7e81af733 x-ms-traffictypediagnostic: SN6PR11MB2590: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-forefront-prvs: 03838E948C x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(6029001)(346002)(396003)(366004)(136003)(376002)(39860400002)(478600001)(110136005)(6506007)(19627405001)(86362001)(45080400002)(5660300002)(966005)(55016002)(66476007)(64756008)(53546011)(26005)(71200400001)(66446008)(66556008)(7696005)(66946007)(9686003)(316002)(8936002)(76116006)(4326008)(8676002)(2906002)(186003)(81156014)(54906003)(52536014)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /O+ZsvW5tui4IRycf3RdRu28mOVR6WEddvdTqpV0iorEIwSAJp7Y6dfukj+Dlgc8llsloROt1ghP0Nmg6U/plsON+UixmFqfRRYqjmvysxyJYn2iB6ORx1aZn2yeGX8xfF7bhkkExzRTl7uJ6KN6n1l9ozREEVFrv11FTtquDweiK0HMa2a+bFqXa2BjkfgGsqQ5j6okDO7Bio+I6GuYhjD+J0Lg7PYq7OnldvfO/HN1rWaSAXnvoRl+/39Z2X0GvllDNpiZ8ReX3qTGP7ZAIEE+zvhHbphxvBz3Mj4KB7guAWVRpTOvlC2XtwtSUK6q8/BKWpzDEXzQrjBxfSYkA53Z+sC4eFuYOzbZ2y4VBZTRt/jgSSlK29D3rVMTv8652qxNi8+Gmu56Rvhgy1VtfKXsCMznuMrLeE0cEJ0x5VVn3suPOmRveOj8kpRdIhAwEMSrWf9xCSPT3RLyOXkp16Tl/bNRbr6m/NGouQnxk/umwpQpbuEe6GybdDGlndxGtMK/t52+7z4ijE6OcQEwiQ== x-ms-exchange-antispam-messagedata: fSdgttdaCvLOXF2F8ICY+dtMvHXyGhEOwjNEh/lcbHkBhamZxxTUmvleVAdmnCs1y5D0tgXnivcXyXTqoDO+5/ZCPNkEI/4dvMnZY5iShXqABqxSU+jr2n0jZOFLbcEu922azoeZfEUW2ZZKAZ/e5Q== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7610a16a-ceaf-43b0-7037-08d7e81af733 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2020 06:44:40.9432 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8wGn8jI3tZ0TReomQVlr1sFiCgJTmxLCsvnzwuzFE6v7ub7V+7GmxCxD92P5Zbq31pFaGDoN2r67XxsxSNfreQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2590 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SN6PR11MB2814886F848DBD7DD92934FEE6D00SN6PR11MB2814namp_" --_000_SN6PR11MB2814886F848DBD7DD92934FEE6D00SN6PR11MB2814namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > ________________________________ From: Desimone, Nathaniel L Sent: Wednesday, April 22, 2020 4:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Agyeman, Prince ; Michael Ku= backi Subject: [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: = Add BDS Hook Dxe Driver REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 Added a DXE driver that registers the minimum platform BDS hook points, to WhiskeylakeURvp board. These hooks are triggered on the BDS hook events What was done: * Included an instance of BdsHookLib and BoardBootManagerLib from BoardModulePkg * Included BdsHookDxe to register the callbacks implemented in BdsHookLib Signed-off-by: Nate DeSimone Cc: Chasel Chiu Cc: Rangasai V Chaganty Cc: Prince Agyeman Cc: Michael Kubacki --- .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 4 ++++ .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf | 1 + 2 files changed, 5 insertions(+) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.d= sc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc index 2ab9cb03ea..536ed7fb09 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc @@ -224,6 +224,8 @@ ####################################### DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/DxePolicyUpd= ateLib/DxePolicyUpdateLib.inf DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library/DxeTbtPol= icyLib/DxeTbtPolicyLib.inf + BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.i= nf + BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/BoardBoot= ManagerLib.inf ####################################### # Board-specific @@ -446,3 +448,5 @@ $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf !endif BoardModulePkg/LegacySioDxe/LegacySioDxe.inf + BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf + diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.f= df b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf index 199e3876bf..0d99114961 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf @@ -345,6 +345,7 @@ INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPass= Thru.inf INF MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.in= f INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf +INF BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf # # eMMC/SD Card -- 2.26.0.windows.1 --_000_SN6PR11MB2814886F848DBD7DD92934FEE6D00SN6PR11MB2814namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Chase= l Chiu <chasel.chiu@intel.com>


From: Desimone, Nathaniel L= <nathaniel.l.desimone@intel.com>
Sent: Wednesday, April 22, 2020 4:40 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V= <rangasai.v.chaganty@intel.com>; Agyeman, Prince <prince.agyeman@= intel.com>; Michael Kubacki <Michael.Kubacki@microsoft.com>
Subject: [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpX= treme: Add BDS Hook Dxe Driver
 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336

Added a DXE driver that registers the minimum platform
BDS hook points, to WhiskeylakeURvp board.
These hooks are triggered on the BDS hook events

What was done:

* Included an instance of BdsHookLib and BoardBootManagerLib
from BoardModulePkg

* Included BdsHookDxe to register the callbacks implemented
in BdsHookLib

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Michael Kubacki <Michael.Kubacki@microsoft.com>
---
 .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc &nbs= p; | 4 ++++
 .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf &nbs= p; | 1 +
 2 files changed, 5 insertions(+)

diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.d= sc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
index 2ab9cb03ea..536ed7fb09 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoard= Pkg.dsc
@@ -224,6 +224,8 @@
   #######################################
   DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/Dx= ePolicyUpdateLib/DxePolicyUpdateLib.inf
   DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library= /DxeTbtPolicyLib/DxeTbtPolicyLib.inf
+  BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBds= HookLib.inf
+  BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/= BoardBootManagerLib.inf
 
   #######################################
   # Board-specific
@@ -446,3 +448,5 @@
   $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf  !endif
   BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
+  BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
+
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.f= df b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
index 199e3876bf..0d99114961 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoard= Pkg.fdf
@@ -345,6 +345,7 @@ INF  MdeModulePkg/Bus/Ata/AtaAtapiPassThru/Ata= AtapiPassThru.inf
 INF  MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOu= tputDxe.inf
 INF  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
 INF  BoardModulePkg/LegacySioDxe/LegacySioDxe.inf
+INF  BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf
 
 #
 # eMMC/SD Card
--
2.26.0.windows.1

--_000_SN6PR11MB2814886F848DBD7DD92934FEE6D00SN6PR11MB2814namp_--