From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.9354.1591919640087051154 for ; Thu, 11 Jun 2020 16:54:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=lYrrypQW; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: chasel.chiu@intel.com) IronPort-SDR: MquSk0dk1vEAO11f6kEZlDOUx1JWF5952IXvVUzOOjgrg/V6o4VEHIoZJvbKckLn7JtYA1ryJB 9R+P+J2UjYwA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 16:53:59 -0700 IronPort-SDR: UnTGre+C4FghXci3NYTmnuaDi5MAkl5K0ZAw3qtMTkpNLtPFV0IADCWGuo1dgP0Lsc1nlxk2QQ RoT40YQhjnwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,501,1583222400"; d="scan'208";a="448116045" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga005.jf.intel.com with ESMTP; 11 Jun 2020 16:53:59 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jun 2020 16:53:59 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 11 Jun 2020 16:53:58 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 11 Jun 2020 16:53:58 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jun 2020 16:53:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CzDHD6mCdmrp6UoIDqAt+1lW0GXgA0zyfHVlVXS8ycp9mFT4FgCzkX8poIA4HjLYBIxr0t0M53LRdDh53FOvaWZLj4HMRbu9k/5WRwtbZ1GMgG3/dttaIKTN3ZIf9tgBVYUlGQyMRfhR/VSw6fNA9u1qgi0UdmhzDz+zyHJT58JrvwsIBEn+e8JgIUihx2JuPb761XbHqbKf8Riv3GMGH4POfFMnffKrRjWqZjYFz7gzlkg9ZbYfI8O9OgG81lyjuCGRe2Af41nYTEKgf2IY/GQeQGREDgztg6Gx0XLhGU2AUmWjx3ZAIoqeRa9ESQrx3P6sm85hZek+SDGSWzAEtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VvkYP4oJYJt7oEItSiQtJMIy5XXQTNIqzeJCEagL6YA=; b=VkaI1z+FjaxUgsoUtv5E5pf8fvcS8Yh2zOJ0Cw1N3OPLJcxodn/I5HH2qP05Fe5uzlnsSoT2nSXu+/befQfF135HUOEm4xES33fBnpGpzGO9W8hbXg97dF/M3tiUiNRKN+LvdfBaAKUuwXGaD9aqVpKbnZ3DsLIcS9t9lJ7i/3KtK0JXAue1z5SJRZgptxtSkVcs2LLwWQ6u+rux+6ow83CJtI6oCFz5FKyZpBzxo1jXaNa9qynHHssZqAx7pl9pfkbXB2EomtWZ6f8794onRnW4E6SFXWu+/9Dl1E0K6p+mkwhwojWc6NAnnKOIINvFn2Fqv2Zdj4ujxMH77EnDgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VvkYP4oJYJt7oEItSiQtJMIy5XXQTNIqzeJCEagL6YA=; b=lYrrypQWoRBpsEVTyd69Jgib5Ztt/gLL9hi/Q5AydNJsM+iCWIDOP4mwkex5VwpFRr9TmqN0a+1GK4NI7Lf1VHuOKWPAwBuyzUFJ+Hg726fEy4UmKCBYPrFKaisyugQk7HxT+tI0b+kFJag5rwgoAl5QOFWoMX983IBFvy6tw9s= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SA0PR11MB4736.namprd11.prod.outlook.com (2603:10b6:806:9f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Thu, 11 Jun 2020 23:53:57 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::d5f4:f51f:3a70:5017]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::d5f4:f51f:3a70:5017%3]) with mapi id 15.20.3088.019; Thu, 11 Jun 2020 23:53:57 +0000 From: "Chiu, Chasel" To: "Tan, Ming" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [PATCH 2/5] Platform/Intel/WhiskeylakeOpenBoardPkg: Change some PCDs type Thread-Topic: [PATCH 2/5] Platform/Intel/WhiskeylakeOpenBoardPkg: Change some PCDs type Thread-Index: AQHWPlCP9IEB99+2FU+7TyNbl8yslajUGnxw Date: Thu, 11 Jun 2020 23:53:57 +0000 Message-ID: References: <20200609112353.20824-1-ming.tan@intel.com> <20200609112353.20824-6-ming.tan@intel.com> In-Reply-To: <20200609112353.20824-6-ming.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.134.136.219] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4f165f5e-9139-4d91-6a6f-08d80e62b4b6 x-ms-traffictypediagnostic: SA0PR11MB4736: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 0431F981D8 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kXew34685QDg6L2PhJERIDxYeSuhKxR/iWtxHzquap0IQwgDkOmywphUAiZ8r10kdD2qbD/ON01tDPy4QsvHwXzl+oUvi4nsNsAnaiGs4okgbI3OtZi3dH8+qKNIRolnTacAxNIlAJlVIy8+ToVj7IR8yDjxXMlbt1V6h+cEKNtkXS11TKqP1dw7GPibYb279vUHYuJBuzLkevG5fP3XB6r5OjAshCCHkhsk/z7Eixdw8vXzAD5PrBueJwZfFEh2CtW6SceZU8HksE4urQCjkugtKxGl7ntniBoWQhMQS7/n3nMaJ4gOG3GzhV1RQ4c0der+nVzatdCP9AwxDkphdces96nkqJIaJ3zr06pd0GmnKAiz8OryqF9LvEvY8zTe52xxYVV2Wy63HJYYvW+ewQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(39860400002)(396003)(366004)(346002)(376002)(2906002)(8676002)(8936002)(107886003)(52536014)(83380400001)(33656002)(76116006)(4326008)(55016002)(9686003)(316002)(110136005)(478600001)(966005)(26005)(186003)(71200400001)(53546011)(6506007)(7696005)(66556008)(66476007)(86362001)(66946007)(66446008)(64756008)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: aU+1NMW76YC/bXtnl+fZJA2O4tWihmPBideiAQM1ZRh7G/o5f9xwMsfN3Ic4Dvq91F76rBqprGvX5lgfkPy+9ZE2AVJiu6JikQyOp5U5t3jSJhGTYTuAZboU/CdymL7AHVbyv+1nIm80TLxEGka2D2RcUn8HM3D0RKhav3PzCwSYd3IhjSEp43s0TjADgjCm2GpX9DMKlbprNEOi1m5OdkthArC+9YCQQQQ5bC8iaiYrvpypK7LLk6TY2SrWBZvdxVB+MfBc0Gj1ytiaTE5YhNr8X7g4WkHFSpxopFD79P1gEz4uMj/noxgPdzKYRcJoDT+56eUs9vbyHSUCj77Fa8KD4ps9ScCkUTsSf0XlvU/MI1rQwr7jpsQzB7OgzRFezfUz1jtj/aohhYf9Cwb5I+0d3PkgBetK4n5Hrc/mrq/fMEGkkKK/N2yOS62hId4sr+WCjdB+nDTvKXLhk/2loNeBGSU6yuAZoFRP2EPLZ8S4+ADVyIf6nBYb49XMIIj8 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4f165f5e-9139-4d91-6a6f-08d80e62b4b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2020 23:53:57.2993 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tnU6Elmk75Glk9Y3LhH2lGadEh3s06W6HfE4iOHOt7t4KkyndEwwtMv0EkrEmFU+fLbXiohbEkvMfojl4m2rrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4736 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Tan, Ming > Sent: Tuesday, June 9, 2020 7:24 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [PATCH 2/5] Platform/Intel/WhiskeylakeOpenBoardPkg: Change > some PCDs type >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2791 >=20 > Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in > MdeModulePkg.dec are changed, so change them from PcdsFeatureFlag to > PcdsFixedAtBuild in dsc files. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Ming Tan > --- > .../UpXtreme/OpenBoardPkgPcd.dsc | 13 > +++++++------ > .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 14 > +++++++------- > 2 files changed, 14 insertions(+), 13 deletions(-) >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.d > sc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.d > sc > index af548dc81b..d797ae9d94 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.d > sc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.d > s > +++ c > @@ -71,12 +71,6 @@ > # Edk2 Configuration ###################################### > gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreImageLoaderSearchTeSection > First|FALSE- > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE-!if > $(TARGET) =3D=3D RELEASE- > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE-!else- > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE-!endif > gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmEnableBspElection|FALSE > gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmProfileEnable|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE@@ > -216,6 +210,13 @@ >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl|FALS > E gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|TRUE + > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE+!if > $(TARGET) =3D=3D RELEASE+ > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE+!else+ > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE+!endif+ > gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIoBarEnableMask|0x80 > gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIoPciBarRegisterOffset|0x00 > gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIoPciBusNumber|0x0diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kgPcd.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kgPcd.dsc > index b3dc1ef501..5d769e8153 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > kgPcd.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP > k > +++ gPcd.dsc > @@ -1,7 +1,7 @@ > ## @file # PCD configuration build description file for the > WhiskeylakeURvp board. #-# Copyright (c) 2019, Intel Corporation. All rig= hts > reserved.
+# Copyright (c) 2019 - 2020, Intel Corporation. All rights > reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -71,12 > +71,6 @@ > # Edk2 Configuration ###################################### > gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreImageLoaderSearchTeSection > First|FALSE- > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE-!if > $(TARGET) =3D=3D RELEASE- > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE-!else- > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE-!endif > gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmEnableBspElection|FALSE > gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmProfileEnable|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE@@ > -203,6 +197,12 @@ > !if $(TARGET) =3D=3D DEBUG > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl|FALS > E !endif+ > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE+!if > $(TARGET) =3D=3D RELEASE+ > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE+!else+ > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE+!endif > gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIoBarEnableMask|0x80 > gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIoPciBarRegisterOffset|0x00-- > 2.24.0.windows.2