From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.5959.1607518408903873744 for ; Wed, 09 Dec 2020 04:53:29 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=weO+P30F; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: chasel.chiu@intel.com) IronPort-SDR: 2r498eqdZDaAYp41qTpkLTppG6F+vX9PE/ekMImLA0mgLszv5BTm2Sj5DprF5bwvnLr4otgpG6 wPx4UsSeArbQ== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="192372643" X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="192372643" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 04:53:28 -0800 IronPort-SDR: iA43XQlY7iQNODarNwUxjjq/WPWrdloeuWe+gqp+EfvRXWtsk8mnJ543PRtVmY3Vk1Da7C2Zk3 UNuWMJNyQ1LA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="348316714" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 09 Dec 2020 04:53:28 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Dec 2020 04:53:27 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Dec 2020 04:53:27 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 9 Dec 2020 04:53:27 -0800 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.55) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 9 Dec 2020 04:53:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mhZ+5uqH0VZxxEPnIBOFw5gY1BozU5qEXQhXX+4gx0n9AXzq33q5sHmcuzq8W1d2ohLRlHMqXmOWlmrm+sO+q6fpYCT/MMN9QxzyehYzXubylj1VK1GDN5BZ6vRcTcxfRzzAn2UKNSNHXoDkMFB5QAQbU0IaJOfpAq42/j5tHyIAhDW6Vjpe2sZ/ADYNGBoErEM2oTHyve/EmGI7yDHkHAIcWnGnl8JNDVIGQhGS38/k8m8irUFjA2UBB5byy2uVr3gTbkKowZRzRa02o4v2+2KoIn9IuGgKLnUwbulJiOHbXWYXsoD5eFRPYPoSX5qpJG423jB5MhFW6CngbnlErA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M08M6Vs5REmGJ1w3zCg+w3D8aDVHSVZi8mn/ohfC6+4=; b=mUlcTrcm+0szG7mkGwfZxRqA9WHLNFZT2ivDm6VrmE0eXvHWEMfll3hPXipMfXmpELLYmASIyTxFiHRmTjF85AM5rICu9EpOu0Fcur2fWyiTaquTo1nmJdeUbqrpXRIrftQsar+LWI9eBvJRMFpKonbRGCz5zUBY64fXxR2zu9Ga1KdnM0TGRoe4h7rzm4f0ATK3AhrBxFtAhOv5/fHOdrXwbfzFRc8lBh6entPLgQ6k2esLu3DR9YJnfc0r46hFsGuYIx8AWgnIYhporCCvUXC/3Tgqb8gQ3F2EGqSlaAjAvu22/LZUa8XmaEC20RbRW2Ru2Cx3TjIyY/E7zePAeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M08M6Vs5REmGJ1w3zCg+w3D8aDVHSVZi8mn/ohfC6+4=; b=weO+P30FQJDGhkjtXX0Ms6tt4pTHQUA3UmNsmAFEIe6ZBEDMrsK5+LvRHO+G9LbtBZ4kAllMzG9vrRx6B1qItDharaCPzfkrYP8Iix6rTysLH+r+obI96e5Pr9z3wvUsFj99imJEYSpTSv6v2lWmvHfnL/Fg/MS8SONYQhMHg08= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB3166.namprd11.prod.outlook.com (2603:10b6:805:c5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.21; Wed, 9 Dec 2020 12:53:26 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::4967:fbdd:5a6f:e298]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::4967:fbdd:5a6f:e298%2]) with mapi id 15.20.3654.013; Wed, 9 Dec 2020 12:53:26 +0000 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Ma, Maurice" , "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg/GenCfgOpt.py: Incremental build with UPD in sub DSC. Thread-Topic: [edk2-devel] [PATCH] IntelFsp2Pkg/GenCfgOpt.py: Incremental build with UPD in sub DSC. Thread-Index: AQHWzQg+nn4K2n20MUiityakV/kMAKnuumIw Date: Wed, 9 Dec 2020 12:53:25 +0000 Message-ID: References: <164E9C1EF323E769.6597@groups.io> In-Reply-To: <164E9C1EF323E769.6597@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [118.161.157.128] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 761e35c1-8945-4c90-ccca-08d89c416b50 x-ms-traffictypediagnostic: SN6PR11MB3166: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B11AsT6c6I2JoX0nPyk3FeqDxbSoQPQAJbI57DBwcftPeZgwNp1OdOcIVaOKqbCKB/Kju1Gsz7oZN4d/0kHEp82cH9DRb9iEQi3FlWsFe34xMGvrApjxTsTHOKQMl3q+7VI/7ZO6VRDdxu3l1wcOo+fx5W7ntorNxS0/Yy0PfftNt6yR6icA+pBdWnZzeE3hsOCFLRyjn/ul1rlhXlBafxp6e1GoxM8/ZvVikVV6Sta7Fvc9uEgzsZIV51hYwUBmNmofiFfg5cQmOfYQf5dBPgP5Et3tIxqPR7Bam/PHAUl7nIEJOrT4WE29lcLdil2n80u15SY0tPbqt51mx+xJukdxKFQBDXKMiEQGbdoYrt7bgxWrlylET7c8iVIYmNX7fzg7wFfk+eNe4XqnSEgXTQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(376002)(136003)(26005)(2906002)(966005)(86362001)(8936002)(8676002)(6506007)(107886003)(53546011)(186003)(55236004)(71200400001)(76116006)(4326008)(66946007)(9686003)(19627235002)(64756008)(55016002)(52536014)(7696005)(33656002)(54906003)(5660300002)(66476007)(66556008)(508600001)(66446008)(110136005)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?FfhlqFjRT0vFe3JR/f6Lt1ct5LpXgnxqCx6f+9aJdjHwf4JiX84xyVIunbpc?= =?us-ascii?Q?RyJMGb/SHKzj16XSQAHkZ4kXEy4djdaNVnL+1TRzcO/ECQX3CfrqJsARzz9g?= =?us-ascii?Q?dF2jkQJBzsGRj/e7eMXMFwY4v+KRCYOV5kI8CPG2ezBsmwk4aCF/ImubElwt?= =?us-ascii?Q?LRBy86lJEJQn1uR3YCLtQpE6lr4lE2E9hVAVuPq3A5UHRbSHCzOh3QO48frk?= =?us-ascii?Q?ZrvzCZHaadOttuw9yyMLXpn0lK/BRbXwIpX924RBwHHfH2pLmEwUnVildAvP?= =?us-ascii?Q?3nrnROSy/v25c9fvaz41D7XX0LPHDwbqLNzzTRWxXPq9P/N8cGjc8wr5MRoo?= =?us-ascii?Q?l+QfrxHdi5BNtNbiuGWc0diNKNle9+hs3X87PgjORKnTAVvGPaCLq/YnQvgK?= =?us-ascii?Q?qsaKEtxltn3O7l533JuTJg6UP0GkCrtfghxB1gUSGIHQMNszBGq3tXzfVGqd?= =?us-ascii?Q?TFItG7M+lilew0F/pD6U579Y0IHw27TwC57cpralJwhwl51lVpe0Wle3iQrV?= =?us-ascii?Q?pDg/K+0t8+qDvVLpdjOIou4pm+RiQf4+MZ+iKX8Fl04/xs8UZpaG2u/ewkww?= =?us-ascii?Q?5bQGbANZU1h8sncLKMKt5SLvFarCyTdHCrCwtCcOEcwhMIJQLeFbsmdKOkc8?= =?us-ascii?Q?Bs0giCxyD2rMSgXwRpFf/QKVXEw6jLfMNNH1KpuOGS48yGchxORzRBJJnyyg?= =?us-ascii?Q?sGBiBBxU9pXxZQrpMUYt+1ww72oAujyr7TW5L1ldhv8faUvw9M+hGrdmSMOG?= =?us-ascii?Q?JxnxaX5lXyMLuB+cxrN4Tr8vE8ZYsmogK+ZMFU25XlnOkmMzQh5hT53PujSe?= =?us-ascii?Q?4EQmv1t6x9kVUyc7qT0+8C8Xpd9f+uQsM8lBR2KU7bZeMmDLLQ4F8rfphpWc?= =?us-ascii?Q?ZuG2C0OXFO44hjNU/d+TCC4H3oBSUv+W/V8EFIpSJojeMETsp0u2KvPQxF6K?= =?us-ascii?Q?rnh1XA51GaAUd2Z3HExnPMftonUV+p+i6xDF1y7DIKM=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 761e35c1-8945-4c90-ccca-08d89c416b50 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2020 12:53:25.9170 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RzyExmq150vpk17VLt3Hp96ZyIwHDz7NpsMHUMEl8KBML89u8m9t8spL0k+rLZgXseuxRxeWeqF7cpCIYRDfoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3166 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Commit pushed: f95e80d832e923046c92cd6f0b8208cec147138e > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chiu, Chas= el > Sent: Tuesday, December 8, 2020 10:16 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-devel] [PATCH] IntelFsp2Pkg/GenCfgOpt.py: Incremental buil= d > with UPD in sub DSC. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3107 >=20 > Current script only compares main DSC and output file datetime to determi= ne if > re-generation required or not. > When UPD defined in sub DSC and was modified current script cannot detect= and > will not re-generate output files which caused incremental build issue. >=20 > Since UPD can be defined in any sub DSC the script has been updated to co= mpare > all DSC datetime with output files to determine re-generation is needed o= r not. >=20 > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/Tools/GenCfgOpt.py | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py > b/IntelFsp2Pkg/Tools/GenCfgOpt.py index af7e14a10a..a0b8bba81e 100644 > --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py > +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py > @@ -313,6 +313,7 @@ EndList > self._DscFile =3D '' self._FvDir =3D '' = self._MapVer =3D 0+ > self._DscTime =3D 0 def ParseMacros (self, MacroDefStr): = # ['-DABC=3D1', '- > D', 'CFG_DEBUG=3D1', '-D', 'CFG_OUTDIR=3DBuild']@@ -423,6 +424,9 @@ EndLi= st > self._DscFile =3D DscFile self._FvDir =3D FvDi= r + # Initial DSC time is > parent DSC time.+ self._DscTime =3D os.path.getmtime(DscFile)+ > IsDefSect =3D False IsPcdSect =3D False IsUpd= Sect =3D False@@ - > 530,6 +534,12 @@ EndList > if IncludeDsc =3D=3D None: > print("ERROR: Cannot open file '%s'" % IncludeFilePath) > raise SystemExit++ # Update DscTim= e when newer DSC > time found.+ CurrentDscTime =3D > os.path.getmtime(os.path.realpath(IncludeDsc.name))+ = if > CurrentDscTime > self._DscTime:+ = self._DscTime =3D > CurrentDscTime+ NewDscLines =3D I= ncludeDsc.readlines() > IncludeDsc.close() DscLines =3D N= ewDscLines + DscLines@@ > -815,9 +825,8 @@ EndList > if not os.path.exists(OutPutFile): NoFileChange =3D = False else:- > DscTime =3D os.path.getmtime(self._DscFile) OutputTime =3D > os.path.getmtime(OutPutFile)- if DscTime > OutputTime:+ = if > self._DscTime > OutputTime: NoFileChange =3D False = return > NoFileChange -- > 2.28.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#68417): https://edk2.groups.io/g/devel/message/68417 > Mute This Topic: https://groups.io/mt/78794912/1777047 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com]= -=3D- > =3D-=3D-=3D-=3D-=3D >=20