From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.39695.1622431419536625091 for ; Sun, 30 May 2021 20:23:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=JfI4tzrL; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: chasel.chiu@intel.com) IronPort-SDR: 7xd0conzkurqKrBf3TC9PbkUtmPKpeL/5OXZp+fJ6TK1KW4Ee/0ZQnnUMyHgqOnyVODJgVWBmB BrD4+jkvuXqA== X-IronPort-AV: E=McAfee;i="6200,9189,10000"; a="190646202" X-IronPort-AV: E=Sophos;i="5.83,236,1616482800"; d="scan'208";a="190646202" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2021 20:23:37 -0700 IronPort-SDR: GZRai8m/pf8xwj3QgSm3kyx3Oham3+H5Qb1yZZRZnOD2+Akj6Zzzhy6IuvPJCFswiBqNhDCTfn 2xiJJqECeBwg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,236,1616482800"; d="scan'208";a="548611423" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga004.jf.intel.com with ESMTP; 30 May 2021 20:23:37 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Sun, 30 May 2021 20:23:37 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Sun, 30 May 2021 20:23:37 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Sun, 30 May 2021 20:23:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PfY018wEL/XWhx+08NHAXMg/IYDOXUUURt3/n+ublMrHadxZCEbSr5NKV6LgtO/e3Ff/dSt1q5MpBJogQ9I3JFsk65KBQQxJIOpPESYExdMIuakCfn5/13hF6muJSkKvJFxi8301KIPeQ98ZqCYqq6YSYJBandq/l4dlLYdaOAczY7BtoozSwDdY2OnzOUk4/JHDH4XUdLFWpbUufQK7dwTHnRAM4Q3pK9zoRi0pJf+CF3c0oqW2JudeZwNKR3DBFfQe11mMED9ORUmDkMuTQ7hy8/taM4So0kQrM6su/jv+Q/IGoq1iW7+GE23YHSVH9wJ6cyrkiDT6xAu5VC13/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Zoo2a/oZfYTIy4OT6vjteG/SNwT/XmQR5lkM9M25Zk=; b=JNlAj/saFqAsjBgrEMvEzMXCGciraZzheGCZB7foiHTB5tt5nYYplUr81BBHkVAp3YrM7jgrpbkmIYc90lX/zLE+MhKiJ53ik3b5Pwyb9Bs1ElLaIUaSGdauaDk2AbfE1XgtWUdHrTevrcsY7WoSSrIHip1x1izkeh8xsnS9A5fivfxctqrdkZV5EgPeQspedM5VBNIg42IEy3Ry3Tm5wAzPghAoqdAKiGetKDAg3R473qLYCWiGYxY5QaNXbgHKYlLjdDP44Sb028MH3+sjYijmUSVlHQnwDUBpJNtFjWeY+2OUxskYHpy/nU49uRCVbZWyqjYgHF1OEWcp0jOuhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Zoo2a/oZfYTIy4OT6vjteG/SNwT/XmQR5lkM9M25Zk=; b=JfI4tzrLCaM7mT6J6aBViP/CCIdhANPm2yQ8KZ4z3UPFe3kA1uqvjN4oSxUc9e2yltgmj3XRmvaK6jyWkOHdb4PQMUG9fZFr28adyiAE7K39aZubo6+gVm+GlmF0fywE7fFk0wU9z5DO1Wq/SFXs3JP6mpcGvXQ3Z8kAqrZcou8= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SA0PR11MB4734.namprd11.prod.outlook.com (2603:10b6:806:99::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.21; Mon, 31 May 2021 03:23:33 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::6157:b65c:53b6:a320]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::6157:b65c:53b6:a320%6]) with mapi id 15.20.4173.029; Mon, 31 May 2021 03:23:33 +0000 From: "Chiu, Chasel" To: "Kuo, IanX" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [PATCH v4] MinPlatformPkg: Rebase fail when python tools path exist whitespace exist whitespace REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3412 Thread-Topic: [PATCH v4] MinPlatformPkg: Rebase fail when python tools path exist whitespace exist whitespace REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3412 Thread-Index: AQHXVcxWPk/8xX/I+kCt3EfabikFNQ== Date: Mon, 31 May 2021 03:23:33 +0000 Message-ID: References: <6ba48b2f5b7676eb6bf1199e51ce691b54beff5f.1621846279.git.ianx.kuo@intel.com> In-Reply-To: <6ba48b2f5b7676eb6bf1199e51ce691b54beff5f.1621846279.git.ianx.kuo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [118.161.140.175] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0ae0588-6291-4b5c-b0a9-08d923e37894 x-ms-traffictypediagnostic: SA0PR11MB4734: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:120; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B4RQly2/Pm9TJ5eP8byMajNEOXV+Kdv10S6BWd5RbiwbCKozJp7JMRF9cRTUOF0KBVWdUBBYrp4cw3QjTHibrLg0tqwdEfJOdFp+SwK8ENPSSK3i6pPD3GBLrfBFNlIQ3k2D/tdbjcj5GGHeUpnZh54tckNYT3NIPAxfOwd9ptpw7OUh7zWZYf4fI66fe3uGCbavAAuegLXgsz0MoKHYFERrydCp+ujWDYGRELvfRjK9YjCp+qjAQMPWBLRisGx9eCLi+KjQKEKhAYOYkR3C+TyQHmHaBvLMOIxCzyqp/P+1cOu5pq9j3l/OfF6j/Ob/FXCLF0Arg03zwzCILJukX1kh0YreC3CmoefyHtg15eTRHIWdw+VWqpdXwWSxMXdOxaRCLPL4POpAnO+/5vBoAfYCzdyidPkIvYgWquJpjP/2pRv8naRNL2AXh/W83dV4+QDcwyL0jao2Awmqlz8hU47wusPUeXB/w5E0d0efc86R8y2xfdOMu7Misg2qdNA6ZxW995W26FYpW8rBFUYw2bw1jIkgl5VKO4Y/g1xPaovOzEsFDeEjIEPu8VwNBNgc8oj0+rgH9qMi3H/hZYfDZ35pPpjTlYQUV9QmctgIzNbRFy2yo4TrYLglZNXgugkDqvv2XELpJZRi49m7L2h7c2lxtH+uDObWdwe9MKGcD1g+4gqXk38g6rlABe2jrkX+AV7u+pHyIKGFQW9dShYkwo3xVAvNxUE2T0/gm88gtS8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(39860400002)(376002)(396003)(366004)(136003)(38100700002)(122000001)(55016002)(71200400001)(316002)(110136005)(33656002)(8936002)(86362001)(83380400001)(8676002)(186003)(478600001)(55236004)(966005)(5660300002)(7696005)(4326008)(26005)(53546011)(52536014)(6506007)(2906002)(76116006)(9686003)(66476007)(66446008)(66556008)(66946007)(64756008)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Vl1mDotgOTyFJVasV1XeFCvJD1UIHXsLiGLQnbErqXEhbcDr82cgOyfCRiSG?= =?us-ascii?Q?9gs3WrmFaQpMEANrybovyrL0UVDgKis+EFwVXFZ3OZS/boyS/vl5qXGNGZv8?= =?us-ascii?Q?UPS93XfsBfE6gsa0SVZeJHPBBnxdkmew6Ut6oMevCrGffDhzVhnG6g33VrMK?= =?us-ascii?Q?Xgbzg6eDtbnFuMNSdo7AqIve2M7ORpeLKmsZRLzKzGoC1Wg76BU4r+YvzSlm?= =?us-ascii?Q?r2wvzzeUcPWu9TMufXqihCU3+jAq6XWYTFCKf6boBZrH6WleAeX8/99kcx88?= =?us-ascii?Q?C4aTu7oorDkoa5TrW5LBmApmdBwhzKuD7JXRmdmFn443SVa7sFFnl01rUrUy?= =?us-ascii?Q?FYcLOznyolG3ia2Lg7YKJwKhXEX8LBSQEBrnbxAmdk9vlt3A7D/qWjP2TFM2?= =?us-ascii?Q?PtzXz9zYZPqDm1WEaszxYPSsavmpPN+jZ5L3ddP8HeoTSxOpyAmkQE27DwE4?= =?us-ascii?Q?d+wjjxhr/lVpA4COTb2t3uIzFZesd3W1f4c+fg3sgka/31ytqDIq6JyDlt+8?= =?us-ascii?Q?NldlZgoqfo9NmZOhiuqZqCzGm7brAml67le6Mqz8Z+Br8lkBFjqzGfELCuQj?= =?us-ascii?Q?DseZTU/QB1sFUjvqXZK2E/Gqb47cJEtQvDJmHdO4+GhYjVEFD/z3BTHuXXgl?= =?us-ascii?Q?Dj45XKYP8gfrcA8OIV4Co6z9BiOwVWUkpdBfP9xmMQKVltcKlr7yuiBP5805?= =?us-ascii?Q?Bm9GNXfak4gS0iiAfxPiWb1iCt1NAaYxpF3ZNveQasekKx/tRolVACiV043x?= =?us-ascii?Q?XSqzrDLp5pHQ7peNyYLD6oZX81MsB33FRzJCAgMRy0DGw0rXlfg8Cypx8uZX?= =?us-ascii?Q?3mE5Nqc5YidJHN0cFgUEoYOtBbJQCRjZKxFwZHfvNcqj03Yar6hVsmc1y7IW?= =?us-ascii?Q?FZQXAVzieojvZ6WfY0c29culSvufaOdkwKF/cX9NekEdT41DJE1PtFKjwQms?= =?us-ascii?Q?Z7TfZpxK08xrSkmE0XDSL5bUP/X84AnLnmPnj8scuS4u+2PPAdE1bXPS/EfG?= =?us-ascii?Q?EiLPMwNpM11IIn1/+cYLLmIBVMrNtb1CkuC1gn3/neHoEmpazp7KILo7DmJi?= =?us-ascii?Q?ErkHwnTciMCVC53wJyvFGU0/y+zZhUssISQF0xQkUXiSr+UdfpG1FUWYXTS/?= =?us-ascii?Q?USuY5xIMQrz0Nm9eHGCIPK0+OpY5TNc9qV959ykvIAafw1ezu2bUx2ajGmRF?= =?us-ascii?Q?ZFwbbckBJhN4OI/Nm7AYshdJeBy18107OBKxOvxeTmd0d/UZ1uk9E6RzjIOg?= =?us-ascii?Q?ZR2IqKKVJNxTUJ4FY538LKLpYe0AeGzuhl1e3aQ+hx9uBobnRqoJotcieqGF?= =?us-ascii?Q?HMPShUrbmXjozvTyWnI/qfYg?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0ae0588-6291-4b5c-b0a9-08d923e37894 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2021 03:23:33.6325 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8IdblmKxOtOWXEzdkBEA1Z8gKQpE2B3g5AkoF194rDgjz9dO1kdNUlZA10/UPUaDl1pXUbVAuDkolF6p43U/DA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4734 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch has pushed: 86984c17d562fc60a6dabbc3a479d79163656a0c > -----Original Message----- > From: Kuo, IanX > Sent: Monday, May 24, 2021 6:49 AM > To: devel@edk2.groups.io > Cc: Kuo, IanX ; Chiu, Chasel ; > Desimone, Nathaniel L > Subject: [PATCH v4] MinPlatformPkg: Rebase fail when python tools path ex= ist > whitespace exist whitespace REF: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3412 >=20 > From: IanX Kuo >=20 > (a) C:\Users\\AppData\Local\Program\Python\Python38 > (b) C:\Python38 > (c) C:\Program Files\Python38 > Issue only happens on (a) and (c). > (a) happen on have whitespace. Ex: Tony Chen > (c) happen on "Program Files" have whitespace. >=20 > Reviewed-by: Chasel Chiu > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: IanX Kuo > --- > .../Tools/Fsp/RebaseAndPatchFspBinBaseAddress.py | 6 +++--- > .../MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseAndPatchFspBinBaseAddres > s.py > b/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseAndPatchFspBinBaseAddres > s.py > index 406e5ec130..f3cba2651a 100644 > --- > a/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseAndPatchFspBinBaseAddres > s.py > +++ b/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseAndPatchFspBinBaseAd > +++ dress.py > @@ -1,6 +1,6 @@ > ## @ RebaseAndPatchFspBinBaseAddress.py #-# Copyright (c) 2017 - 2019, I= ntel > Corporation. All rights reserved.
+# Copyright (c) 2017 - 2021, Intel > Corporation. All rights reserved.
# SPDX-License-Identifier: BSD-2-Cl= ause- > Patent # @@ -93,13 +93,13 @@ fspTBaseAddress =3D flashBase + fspTBaseOffs= et > # Re-base FSP bin file to new address and save it as fspBinFileRebased us= ing > SplitFspBin.py # rebaseArguments =3D fspBinFilePath + " -c s m t -b " + > str(hex(fspSBaseAddress).rstrip("L")) + " " + str(hex(fspMBaseAddress).rs= trip("L")) > + " " + str(hex(fspTBaseAddress).rstrip("L")) + " -o" + fspBinPath + " -n= " + > fspBinFileRebased-os.system(pythontool + " " + splitFspBinPath + " rebase= -f" + > rebaseArguments)+os.system('"' + pythontool + '"' + " " + splitFspBinPath= + " > rebase -f" + rebaseArguments) # # Split FSP bin to FSP-S/M/T segments # > splitArguments =3D fspBinPath + os.sep + fspBinFileRebased + " -o " + fsp= BinPath + > " -n Fsp_Rebased.fd"-os.system(pythontool + " " + splitFspBinPath + " spl= it -f" + > splitArguments)+os.system('"' + pythontool + '"' + " " + splitFspBinPath = + " split - > f" + splitArguments) # # Patch dsc file with the re-based FSP-S/M/T addr= ess, so > internally build will use the same.diff --git > a/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > b/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > index fb4cf4f9b7..b7e4bcf5f9 100644 > --- a/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > +++ b/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > @@ -1,6 +1,6 @@ > ## @ RebaseFspBinBaseAddress.py #-# Copyright (c) 2019, Intel Corporatio= n. All > rights reserved.
+# Copyright (c) 2019 - 2021, Intel Corporation. All = rights > reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -87,12 > +87,12 @@ fspTBaseAddress =3D flashBase + fspTBaseOffset # Re-base FSP b= in > file to new address and save it as fspBinFileRebased using SplitFspBin.py= # > rebaseArguments =3D fspBinFilePath + " -c s m t -b " + > str(hex(fspSBaseAddress).rstrip("L")) + " " + str(hex(fspMBaseAddress).rs= trip("L")) > + " " + str(hex(fspTBaseAddress).rstrip("L")) + " -o" + fspBinPath + " -n= " + > fspBinFileRebased-os.system(pythontool + " " + splitFspBinPath + " rebase= -f" + > rebaseArguments)+os.system('"' + pythontool + '"' + " " + splitFspBinPath= + " > rebase -f" + rebaseArguments) # # Split FSP bin to FSP-S/M/T segments # > splitArguments =3D fspBinPath + os.sep + fspBinFileRebased + " -o " + fsp= BinPath + > " -n Fsp_Rebased.fd"-os.system(pythontool + " " + splitFspBinPath + " spl= it -f" + > splitArguments)+os.system('"' + pythontool + '"' + " " + splitFspBinPath = + " split - > f" + splitArguments) exit(0)-- > 2.27.0.windows.1