public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Chuang, SofiaX" <sofiax.chuang@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	Jeremy Soller <jeremy@system76.com>
Subject: Re: [edk2-devel][PATCH v5 4/7] KabylakeOpenBoard: Move ReportCpuHob library path
Date: Tue, 11 May 2021 09:38:08 +0000	[thread overview]
Message-ID: <SN6PR11MB2814A0E829ACAE19B8D6874DE6539@SN6PR11MB2814.namprd11.prod.outlook.com> (raw)
In-Reply-To: <acaf4181e08b0216c67f7d95608083cfbc234f2e.1620675658.git.sofiax.chuang@intel.com>


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Chuang, SofiaX <sofiax.chuang@intel.com>
> Sent: Tuesday, May 11, 2021 3:54 AM
> To: devel@edk2.groups.io
> Cc: Chuang, SofiaX <sofiax.chuang@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Jeremy Soller <jeremy@system76.com>
> Subject: [edk2-devel][PATCH v5 4/7]
> KabylakeOpenBoard: Move ReportCpuHob library path
> 
> From: SofiaX Chuang <sofiax.chuang@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298
> 
> Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> ---
>  .../KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc  | 11 ++++++++---
>  .../KabylakeRvp3/OpenBoardPkg.dsc                     | 11 ++++++++---
>  2 files changed, 16 insertions(+), 6 deletions(-)
> 
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> index 862e6a6655..302cb679b5 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> @@ -1,7 +1,7 @@
>  ## @file
> 
>  #  The main build description file for the GalagoPro3 board.
> 
>  #
> 
> -# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
> 
> +# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
> 
>  #
> 
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  #
> 
> @@ -38,7 +38,8 @@
>    #
> 
>    # Include PCD configuration for this board.
> 
>    #
> 
> -  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> 
> 
> +  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> 
> +
> 
>    !include OpenBoardPkgPcd.dsc
> 
>    !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
> 
> 
> 
> @@ -160,7 +161,11 @@
> 
> DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDe
> bugLibReportStatusCode.inf
> 
>    SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
> 
> 
> SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheM
> trrLibNull.inf
> 
> -
> ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHob
> Lib/ReportCpuHobLib.inf
> 
> +
> 
> +  #######################################
> 
> +  # Silicon Package
> 
> +  #######################################
> 
> +
> ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.i
> nf
> 
> 
> 
>    #######################################
> 
>    # Platform Package
> 
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> index 0b30da8f96..8523ab3f4f 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> @@ -1,7 +1,7 @@
>  ## @file
> 
>  #  The main build description file for the KabylakeRvp3 board.
> 
>  #
> 
> -# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
> 
> +# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR>
> 
>  #
> 
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  #
> 
> @@ -37,7 +37,8 @@
>    #
> 
>    # Include PCD configuration for this board.
> 
>    #
> 
> -  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> 
> 
> +  !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> 
> +
> 
>    !include OpenBoardPkgPcd.dsc
> 
>    !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
> 
> 
> 
> @@ -201,6 +202,11 @@
> 
> SecBoardInitLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/SecBoardInitLibN
> ull/SecBoardInitLibNull.inf
> 
> 
> 
>  [LibraryClasses.common.PEIM]
> 
> +  #######################################
> 
> +  # Silicon Package
> 
> +  #######################################
> 
> +
> ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.i
> nf
> 
> +
> 
>    #######################################
> 
>    # Platform Package
> 
>    #######################################
> 
> @@ -212,7 +218,6 @@
> 
> TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/Pei
> TestPointCheckLib.inf
> 
>  !endif
> 
> 
> SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheM
> trrLibNull.inf
> 
> -
> ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHob
> Lib/ReportCpuHobLib.inf
> 
> 
> 
>    #######################################
> 
>    # Board Package
> 
> --
> 2.27.0


  reply	other threads:[~2021-05-11  9:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10 19:54 [edk2-devel][PATCH v5 0/7] Move ReportCpuHobLib from MiniPlatformPkg to IntelSiliconPkg sofiax.chuang
2021-05-10 19:54 ` [edk2-devel][PATCH v5 1/7] IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib sofiax.chuang
2021-05-12  1:25   ` Ni, Ray
2021-05-12  2:38   ` Chaganty, Rangasai V
2021-05-10 19:54 ` [edk2-devel][PATCH v5 2/7] TigerlakeOpenBoard: Move ReportCpuHob library path sofiax.chuang
2021-05-11  8:40   ` Heng Luo
2021-05-12  1:12   ` Chaganty, Rangasai V
2021-05-10 19:54 ` [edk2-devel][PATCH v5 3/7] SimicsOpenBoard: " sofiax.chuang
2021-05-11  9:37   ` Chiu, Chasel
2021-05-10 19:54 ` [edk2-devel][PATCH v5 4/7] KabylakeOpenBoard: " sofiax.chuang
2021-05-11  9:38   ` Chiu, Chasel [this message]
2021-05-10 19:54 ` [edk2-devel][PATCH v5 5/7] WhiskeylakeOpenBoard: Move " sofiax.chuang
2021-05-11  9:38   ` Chiu, Chasel
2021-05-10 19:54 ` [edk2-devel][PATCH v5 6/7] MiniPlatformPkg: Move ReportCpuHob " sofiax.chuang
2021-05-11  9:39   ` Chiu, Chasel
2021-05-10 19:54 ` [edk2-devel][PATCH v5 7/7] CometlakeOpenBoard: " sofiax.chuang
2021-05-12  1:13   ` Chaganty, Rangasai V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB2814A0E829ACAE19B8D6874DE6539@SN6PR11MB2814.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox