From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.832.1619397759452783555 for ; Sun, 25 Apr 2021 17:42:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=pN8zT78G; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: chasel.chiu@intel.com) IronPort-SDR: YwSZ/QeCgpsYeNCOrU7OZSA5DHdH0JlnNre6r6RqI74Rr0hbLOUawsxPF5q7whw97GAOMwlkk4 dXm6T0u2nxSQ== X-IronPort-AV: E=McAfee;i="6200,9189,9965"; a="196375533" X-IronPort-AV: E=Sophos;i="5.82,250,1613462400"; d="scan'208";a="196375533" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2021 17:42:37 -0700 IronPort-SDR: 6BodPw3WqayXJQ6Bo16wBqLiAlE2+O9/PYzNMXGX3fAVm8PJkp+jbJKZpxSvUjUD9mg4FxQKj6 aXp1YHOukwww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,251,1613462400"; d="scan'208";a="424736597" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga007.jf.intel.com with ESMTP; 25 Apr 2021 17:42:37 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 25 Apr 2021 17:42:36 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 25 Apr 2021 17:42:36 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sun, 25 Apr 2021 17:42:36 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Sun, 25 Apr 2021 17:42:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DnyD0shjiMSb8INk/uBNFfLnpOD/arvKucpGHuGBiav6nO9BrUejpm9r0AWrxx/JGi0qtqLc+c8q6x4iWMQbgu/nptkTIueD+iX02X5TcNSolpDbuzqKB9FwAxhl+HVpGABEeYcyTkS61eSCDEcEyk5C3PtkB2sFE4YzYaqKmCpq65x19hQnvqXu6Tzt1IrwjE1vnofayfoSt4XxFE1m4qp3XZWZIiEN+ThTCQhjr9TviYuV8DOlsdDP48r5c+IQcv32UVYQ+MmrAVdc4cKBN7BGtdIvTmtByRstPwfPq/asYJBgS60XHbWcgZ2HTtC5OjDbPXYa66esrJsgSvtAZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iwztlWVKUnYESIZ+v1sWP+nPMwSOE9d3yPgxOU5VTb8=; b=k+PtY9GyrFba2OEE36DZZkSGzo8XgPOlwQ3XO1ktTkI0U/lJUCec3/LWcXd0QDUEkCh3Vo08uJEY6KHVzL2nS9TvIMwdtsOcXsUcZaygkK+Q52TGaagXJl6ESy3b4+veoOdzoyHu6bzCBkTrLjuS6IPRxQM1lPBXB/nSyiBx5DZIETcPhgCvVvROqlG7kjnHTEoDYYdAr43cI/vdyGvIT5GXNB5/LsVIfs83Mg4vCTd61h0I5occBvhcnuSDqn8rqvMtPSys+VZHoXMI5SvWgk+WMNe/XYS3Dj91ENQKsFtRmEFO3oI3evC9Da/EONbckNlGWLOQqpbb7dgppd9G8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iwztlWVKUnYESIZ+v1sWP+nPMwSOE9d3yPgxOU5VTb8=; b=pN8zT78G9NLcTw11r6yVRmm28VV9WaCxgZ91k5Tmm0Ntf9AsBdz/xqv1E9FF/tCOkvsiXr8gIYWqRQxU1tanxJGqviDVNkmrk56bTBX7zUrP3CdiPRJbJX9WYhcJftue6JZMHdXfZdG0z0r6ZX1RZRQML1HMbwa5+EZQJZ7cWfU= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SA0PR11MB4688.namprd11.prod.outlook.com (2603:10b6:806:72::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Mon, 26 Apr 2021 00:42:35 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::3101:f483:8348:816]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::3101:f483:8348:816%7]) with mapi id 15.20.4065.026; Mon, 26 Apr 2021 00:42:35 +0000 From: "Chiu, Chasel" To: "Lou, Yun" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Zeng, Star" , "Ni, Ray" Subject: Re: [PATCH v1] Intel/CometlakeOpenBoardPkg: Simplify microcode related PCD usage Thread-Topic: [PATCH v1] Intel/CometlakeOpenBoardPkg: Simplify microcode related PCD usage Thread-Index: AQHXOeEex5e+BJky5UaPK+sKpl1lSqrF9kyw Date: Mon, 26 Apr 2021 00:42:35 +0000 Message-ID: References: <20210425144137.16411-1-yun.lou@intel.com> In-Reply-To: <20210425144137.16411-1-yun.lou@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af96603f-f8a6-4852-1351-08d9084c2f4c x-ms-traffictypediagnostic: SA0PR11MB4688: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AVDQzCtfwjpXM9/DYFwBjCLBqWnUcLfa7C3+tZbifyWAQkmT+SzOp2bcP4L2mViiJQuDauG/l6GKeZsAmbvrsL2v83vSrR9+YFgZPOTXI8Blo6xsclibNsAu5c53PLp7Hx2Cy+qla6WAAD4XtZqsR5rRzVL2bJcEMAaapUDWK6SxW6i5LRUWQu41c2no+ZW6fa+ct/nAXJ35olAmWXxiHO+F1HSC3ygh3eo82hs+FNxPvyCmXa/mydFDuRVRy18mGj7Fh2fGZTW8y2q5nHJ3JHVAgQUWkLFNl0ULf8vzIKWATM5kZO/sBK9A8A6bwJ8b+/4wRxii/X4v2qDU4r7UZemLW21SAB2GaQ7Dv2gQYLf4K5eZKiwDx4D6tCcKWKADxlbMkWxe0mh9swn/u/CFx580lP6VY75j4LTRtR/5ghRkOOV4MNDoQ8fbBHPhlLnJalJpTvlqMVZNmh9zlUruK1YfX/tkvq6zv2rLqY78wlKHp4x/ByEsDqzrggrJrFv/XB+FhZ6udmX0v0pcUFkcWasjssoJSWHPdJZEyEB+w2SzPpzV4TWiXhA7IVW6P3JEkn4AKF2nkNu7S7cCkp1b/FICR/HV513fBcqUqZD22pZT2pH1XzlQsORVytGJGFuvqf461gt+dqLwL7VOHF0OtblQxAOBbWRpYoXlYJlN3u5u+7WtmfBpBQedxx1wL8w6 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(396003)(136003)(366004)(376002)(346002)(66556008)(33656002)(83380400001)(64756008)(66446008)(66476007)(66946007)(5660300002)(55016002)(86362001)(54906003)(53546011)(6506007)(76116006)(26005)(122000001)(38100700002)(4326008)(2906002)(966005)(110136005)(71200400001)(9686003)(316002)(478600001)(19627235002)(186003)(107886003)(52536014)(8676002)(8936002)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Im3NnZeMCsBpLUG1Ydn02LpL75YDHkED6AFZqJsi8THd9AXP26TX3yCodCRC?= =?us-ascii?Q?T8hhpxu1m/pYry/FqU4/WFHlpFnEURN2uan/3JWZXTOoxSYAUgcQcImHFcra?= =?us-ascii?Q?HkBxB9mG3BGGjp2IFCiUCXLVs6KlEEDmNttyjGJkIsPcvCoe4C+QGsdUQqra?= =?us-ascii?Q?MTkMyJ+02myI/SqkYyUmIEOhEzsatQpo8mcQL14/Ad6VpEMG0+wbDZ5ePbZd?= =?us-ascii?Q?8U7l2ZioTkz9e/httCzyuxb3rQhLu90YSuBaPdyV7k+jDgBwfAM2LgGJcfC/?= =?us-ascii?Q?ypH8kcRxbL5VFyV4zPIChB6GbZ0QT8XFbur1/BwOx1jS+L2xxSU9ZVbpfhh3?= =?us-ascii?Q?mP9TRsd86QrGT9x9941YjGTwf6mMUtMmCboDVLdjx5OvWffhLv/XrLKdevKr?= =?us-ascii?Q?nRvRAvtsDtrXldoRoTfw88QN1s6dGgaTpUJrlZZsiJIVa58XxOkkN2nnaHHJ?= =?us-ascii?Q?HnaeHnj16+SqqwUwYBwbQXVar+S8YM7gyoFYYYLDVmu9Gvb5Ahd5FytD1vVu?= =?us-ascii?Q?VfI43E5SqR2STxY8cUGfIODJiUmDRL6WgzBTX95sC4nkuOkDao/PmvE+bCJt?= =?us-ascii?Q?gb089VRwxDomLYyGrZ8ygj6dVso7ED7sOUjOLL/z58II2AHezOuYS/ekfQXV?= =?us-ascii?Q?4ymn5xk0GMLCCl+oV0bq40+aTwjBiJ77a9mBbFHVI7hRsGVAaMMRdZXcRAeA?= =?us-ascii?Q?9e0lfnj4GseAAcadEJNWt6APJnNfo994KqcMLwx2eL56LF5FbHbdaRQq0Qnx?= =?us-ascii?Q?zFqzVWivr/Ba8pLEWermKC6SUl09opMhgO1d2V8iXSe/8jRrCWY43N14RDOS?= =?us-ascii?Q?knmKJhXlcIVluUT7RcdoBt+IzDIapbXNMC9ceRO+XX+XlZkAQoLtjTydHpSz?= =?us-ascii?Q?6SMD8HkRgFUSkB9sXZWLj5SPGv9IP9lNKkVXEBTCYbvyWwCGkpYwEFa480ra?= =?us-ascii?Q?1DU4lXLf/lfyMiadK9nFzceK3z8VX4wD8u0KOS52pCPwvRPcNZchrpgNG1BU?= =?us-ascii?Q?OKmoZn4JXmhasMKevTfS09W6+8C5l0dYQaR/d3dBMmSX6Bz1w6zlHXg6OwVY?= =?us-ascii?Q?SQtuFgKBl9Op08UqS74F5zhqfG3Ant6eD7KhvSuq3KFzSat+15NwoRkcpdVS?= =?us-ascii?Q?U/tqrUGdW5BPZU96/oK3Rz3JuyzH6VzsZJJWRvqFigWhXYL9Mgm20Vz31S/Q?= =?us-ascii?Q?Qq1mZLWWCGW8nQPszwV2Dulmfmbv6g2zyoJ+NxkZmPSv/UaeQ3KNR+X2YhZ1?= =?us-ascii?Q?3T0lT1n1huGKP2IUTwEqWlSrUc+GcSXGEuk2gTJ9rUk/44DXEyrZsEn3LlKN?= =?us-ascii?Q?T3hFzODH3k9B12zri1bAyD6T?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af96603f-f8a6-4852-1351-08d9084c2f4c X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2021 00:42:35.3027 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0xyafsAQR55BSKjgJdNkG/6quBEBQ6bEALf88w1PDWhdgzM7rQ0JKCLwhi3N+LYAmpwdfEU1C5EZWHkiihceHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4688 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Lou, Yun > Sent: Sunday, April 25, 2021 10:42 PM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Chiu, Chasel ; > Desimone, Nathaniel L ; Zeng, Star > ; Ni, Ray > Subject: [PATCH v1] Intel/CometlakeOpenBoardPkg: Simplify microcode relat= ed > PCD usage >=20 > From: Jason Lou >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3334 >=20 > There are following PCDs in IntelFsp2WrapperPkg for microcode location: >=20 > * IntelFsp2WrapperPkg: > PcdCpuMicrocodePatchAddress > PcdCpuMicrocodePatchRegionSize > PcdFlashMicrocodeOffset >=20 > The change simplify the platform code to use following PCDs instead: > * MinPlatformPkg > PcdFlashFvMicrocodeOffset > PcdFlashFvMicrocodeBase =3D $(BIOS_BASE) + PcdFlashFvMicrocodeOffset > PcdFlashFvMicrocodeSize > PcdMicrocodeOffsetInFv >=20 > Signed-off-by: Jason Lou > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Ray Ni > --- > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf | > 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf > index 31f4d22311..795cc0da75 100644 > --- > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf > +++ > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf > @@ -2,7 +2,7 @@ > # FDF file of Platform. >=20 > # >=20 > # >=20 > -# Copyright (c) 2020, Intel Corporation. All rights reserved.
>=20 > +# Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved. >=20 > # >=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > @@ -47,9 +47,7 @@ SET gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase =3D > $(gSiPkgTokenSpaceGuid.PcdBio > SET gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize =3D > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize) >=20 > SET gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress =3D > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase) + 0x60 >=20 > SET gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize =3D > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize) - 0x60 >=20 > -SET gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchAddress =3D > $(gSiPkgTokenSpaceGuid.PcdBiosAreaBaseAddress) + > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset) >=20 > -SET gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize =3D > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize) >=20 > -SET gIntelFsp2WrapperTokenSpaceGuid.PcdFlashMicrocodeOffset =3D 0x60 >=20 > +SET gMinPlatformPkgTokenSpaceGuid.PcdMicrocodeOffsetInFv =3D 0x60 >=20 > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase =3D > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase >=20 > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize =3D > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize >=20 > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeOffset =3D > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset >=20 > -- > 2.28.0.windows.1