From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.434.1588215322077616304 for ; Wed, 29 Apr 2020 19:55:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=OrbE8xdo; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: chasel.chiu@intel.com) IronPort-SDR: zITtgdkCt7xcLVv6pCeW2ZkzsmMV7ToLqGmjwUB3ZvPMBJPcOuuxNq6M68vWyIV9ezP3Wa+R6/ nNJZqa/TILaA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 19:55:20 -0700 IronPort-SDR: ZNbFfDJt8W15e8gh4+UFkz70x2LlkLv44UGqchzgnf9clbIZqXWjN41qY8/42mG63Dz9GzSCK/ +7QTqnkOD4Zg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,333,1583222400"; d="scan'208";a="405252735" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga004.jf.intel.com with ESMTP; 29 Apr 2020 19:55:20 -0700 Received: from orsmsx153.amr.corp.intel.com (10.22.226.247) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 19:55:20 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX153.amr.corp.intel.com (10.22.226.247) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 19:55:20 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 19:55:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M5vNIp0+ov7KYY1tzDUjbBUhh3MhwgF2jMo/lzMH8ZsevLCp4/Mq9LUtKnA98Q9N/yfA2FLk2a61YcCZ7lk5vVq3PyGzyGaMIiNiUZCtl09p5++CQK8zybRkzMp7Tb4H4GbosptjKtUi9iiiBdFVK+lsHbmME7kxoy56h8ktoLOl7yS5381/X141NTxYknB/+E09O7t9wgmZEM9ulpd5hyth6LNbxIL+bVK3JhK0O2/dTNG8UsbDReXQSldwPyd1zJ2MaU7y4I/8PT2u44zgYSHSE53w2jywOUC/H+VR10TbgIR/Cpqm09LdKwH4Q73H3kbgpk0Q6e9ajyb8BcJw3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5oEtryo+NfDvhdY5hNLpeuoPR5hUwPrc/5fkFxJokys=; b=HwVwgxzJ9+BHbgdADQRZ+oRicKXeh7C549/4PGOqm8n2x8jWjqWSbLcXYTSsz2Dx1vwDZ+S4cufampbaAaoPX+31sewwjQrU4vqAnG9C4bUT7t+Y16XsfiRRK4skyLApgpbyvSV53e5pCae8IyMiiDIBPRuBRlN+yOc6B4TzQXN4PXBRtmOmz0arH9G181kA295K+DyJ5UVJbnkZ8pbY/Kmzfoixsz2AoRQrRmE5H3YIDd7DajBuDdaS9HqZmZrfMmRQJSWmt4frgP4YiGRZFO2HTd7t0p6A/durvmptLGTkKxuL+CQdgcflpxBv0jpND+j31zIjxNWcp5tKbEJajQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5oEtryo+NfDvhdY5hNLpeuoPR5hUwPrc/5fkFxJokys=; b=OrbE8xdo8L4tPSMyFrRYCUUKuwLhIhgKsF0xc8mceyl1IEXL2Lb2Ys9foCk298ALLOy2OxzHdkbHcywlF5S1tTQHkHvelSKTsXWNVyI9XHjnVNubId9gFnHYh1yyAxcLYqaaFRIjkqlFzf04jGSD358Hn/PMtA4m7wsOZBquPrk= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB2991.namprd11.prod.outlook.com (2603:10b6:805:db::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Thu, 30 Apr 2020 02:55:18 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584%4]) with mapi id 15.20.2937.023; Thu, 30 Apr 2020 02:55:18 +0000 From: "Chiu, Chasel" To: "Shindo, Miki" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" , "Agyeman, Prince" , "Ni, Ray" Subject: Re: [edk2-platforms:PATCH v4 3/7] CometlakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Topic: [edk2-platforms:PATCH v4 3/7] CometlakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Index: AQHWHc5+KVOEkHcXZEqiRdi5wzNlZqiQ+ehw Date: Thu, 30 Apr 2020 02:55:18 +0000 Message-ID: References: <20200429023203.37544-1-miki.shindo@intel.com> <20200429023203.37544-4-miki.shindo@intel.com> In-Reply-To: <20200429023203.37544-4-miki.shindo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b03b5a51-fc8d-4d68-a9ea-08d7ecb1ea9c x-ms-traffictypediagnostic: SN6PR11MB2991: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:114; x-forefront-prvs: 0389EDA07F x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(366004)(346002)(136003)(376002)(39860400002)(66446008)(966005)(7696005)(107886003)(86362001)(33656002)(4326008)(66476007)(76116006)(52536014)(8676002)(66946007)(71200400001)(2906002)(5660300002)(55016002)(316002)(9686003)(8936002)(186003)(478600001)(66556008)(64756008)(26005)(110136005)(54906003)(6506007)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0MxRv0RHAf6c22CDUAv0DIJKcERB8aoTS46chlqETu7iZNlRtjvJDjU1poNjZmzccnECdZckHIppub9MbUUbGs8jDBTzKjJgxaQJNjl/e7+TITExg7jONjXFjgs39/dHxrJcskmS/eiwiPvoNxZqg8Tobd9bIkdAv2RmxVWwosjluU3F1l1MUPfPc6uFsOxjkOYVs6ymV7JxJvOvGg1VWHgHQZ+FD7oyij3yqgyTYhVwwaiCcUvxlE3dNnVWn1aq8VQZwhIlHHSnMhhVvfe9Tn6VAegH1PkqtFkPpBRtRhUaITSTUMu9zqLjyRHBS5qE2tcNuOPkWysTPKJ1M38Tz/Vd8gKL/YtM4WXj/PIBqp5v/M5PIo/8fitloYc4CYIL0BAIW+x/lpCNG3ll97laesp7tzwRG3UAWNHpUDrfaCnygk0jcvXQcXEF0QreaTRAJX4RmxJ+cUUXsnP9ZG9CegXw4zO9+JvYMA/Lghh4dccFuPH3XpKI7ke0Xl0TK66QMwZjI+aqdgeu4hDB0cXHVQ== x-ms-exchange-antispam-messagedata: FsbQxeb7vWzDZRxzIliY+NaVsV0CoOfXsZJDdMdFjsz4+A3md8X/i93ImLW7EOJGk/7EiQWY2vJr9yU/AybE1uJA61u1tE10xdaimKoIJtNXab4fw79xQsnmAHe/HbWChUJWpTuVN0u/eq7YZVyD7omSgKukRtTE2ZRVzLMUEUHDo0GSJggfoJvKR9QYqDEUtcHdbbt0q0RZO8e3jUYh0EvqGmk0bGFsOW/ocyhaz6BjSIztxHEl53DZ8S/LsJlW//xjEqUmEpCouLegE7omT/Npl7ZmgsequU8sQCViE0V3X+oFNPZmvJ5imZmWafKjRt+4r0XC0W9VIGmkjBIV4CB3xSiNvNG0e4jRim3IhybH6yzbRuKI6vmAkqgywlmG21WaKt4dbLfY+diXr1HsJblP4Q9f6JdiPzVwrag1pAK2ic7lTo4s2nTb+yO2OKiPC4Za8/ylkN7Q0jw0GSenjwsu44pbmD6kCCiRukVzc2yzYjvjqvsTe8mRTad6WpeJdW5IYP689emBqCDjh61DATiNEh5/w1Ml6O0aL1lTNsQhpq3iTgQkMQp6OQ1lGMRJzM53TmAuaLR7bJvgZehWJBERRYX0pGhWHWxr6itQj7xy/2B3kA+Y+UYC0Oj5iB04cIO5DGE8+s3rmLWHqr/HFTkrBfqsdZGGFqii2rVNq/0cagXoqYXM0juED5vntARUL9Ur9p9bhgPBvUmN6wG45XbM+xznhzQxJJursNIrbErDHFLRGGaDkIWGPBWP6f/fWM5fnEcu6HTP4J9tpzukxCiXvD+RmmsmR7Xje07mA+IhRnhE6W3PWdhhzwVYZ+3y MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b03b5a51-fc8d-4d68-a9ea-08d7ecb1ea9c X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2020 02:55:18.4777 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lIUv6sckjOJyAa4IGsSBPjdKfTOsrPm177mYUHVexFVC6ZbGsNaJOJEghuOPL6ztHC5tkRTLWdJVa7jTma1QXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2991 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Shindo, Miki > Sent: Wednesday, April 29, 2020 10:32 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Agyeman, Prince > ; Ni, Ray > Subject: [edk2-platforms:PATCH v4 3/7] CometlakeOpenBoardPkg/TbtDxe: > Removes redundant InitializeAslUpdateLib >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2536 >=20 > This commit removes redundant InitializeAslUpdateLib calls as > DxeAslUpdateLib itself calls it internally. >=20 > Signed-off-by: Miki Shindo > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Prince Agyeman > Cc: Ray Ni > --- > Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c > | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git > a/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe. > c > b/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe. > c > index ef6201de94..e43c5c2fa1 100644 > --- > a/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe. > c > +++ > b/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtD > +++ xe.c > @@ -125,9 +125,6 @@ TbtAcpiEndOfDxeCallback ( > UINT16 Length; > UINT32 Signature; >=20 > - Status =3D InitializeAslUpdateLib (); > - ASSERT_EFI_ERROR (Status); > - > Address =3D (UINT32) (UINTN) mTbtNvsAreaProtocol.Area; > Length =3D (UINT16) sizeof (TBT_NVS_AREA); > DEBUG ((DEBUG_INFO, "Patch TBT NvsAreaAddress: TBT NVS Address %x > Length %x\n", Address, Length)); > -- > 2.16.2.windows.1