public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: fengyunhua <fengyunhua@byosoft.com.cn>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Zeng, Star" <star.zeng@intel.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Subject: Re: [PATCH] IntelFsp2Pkg/Tools: Fix a typo issue
Date: Tue, 13 Oct 2020 02:47:48 +0000	[thread overview]
Message-ID: <SN6PR11MB2814B180891BB009D7E9A32AE6040@SN6PR11MB2814.namprd11.prod.outlook.com> (raw)
In-Reply-To: <000301d6a10a$aa373ce0$fea5b6a0$@byosoft.com.cn>

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: fengyunhua <fengyunhua@byosoft.com.cn>
> Sent: Tuesday, October 13, 2020 10:44 AM
> To: devel@edk2.groups.io
> Cc: Zeng, Star <star.zeng@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [PATCH] IntelFsp2Pkg/Tools: Fix a typo issue
> 
> Error message:
> raise Exception ("'%s' is not a valid directory!" % FvDir)
> NameError: name 'FvDir' is not defined
> 
> FvDir should be fvDir.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
> ---
>  IntelFsp2Pkg/Tools/PatchFv.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/IntelFsp2Pkg/Tools/PatchFv.py b/IntelFsp2Pkg/Tools/PatchFv.py
> index edb30c816b..0c8d908063 100644
> --- a/IntelFsp2Pkg/Tools/PatchFv.py
> +++ b/IntelFsp2Pkg/Tools/PatchFv.py
> @@ -163,7 +163,7 @@ class Symbols:
>          # If the fvDir is not a directory, then raise an exception
>          #
>          if not os.path.isdir(fvDir):
> -            raise Exception ("'%s' is not a valid directory!" % FvDir)
> +            raise Exception ("'%s' is not a valid directory!" % fvDir)
> 
>          #
>          # If the Guid.xref is not existing in fvDir, then raise an exception
> --
> 2.27.0.windows.1
> 
> 


  reply	other threads:[~2020-10-13  2:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13  2:43 [PATCH] IntelFsp2Pkg/Tools: Fix a typo issue fengyunhua
2020-10-13  2:47 ` Chiu, Chasel [this message]
2020-10-14  2:38 ` Nate DeSimone
2020-10-20  1:14 ` Chiu, Chasel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB2814B180891BB009D7E9A32AE6040@SN6PR11MB2814.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox