From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web09.20951.1621850994051799706 for ; Mon, 24 May 2021 03:09:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=TGVoert2; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: chasel.chiu@intel.com) IronPort-SDR: okRjuMd4wU47p9Fdrk2S/42nK3/K17m1ZjqVSCJGIaWlP5Q+EpwGz+I4n+daVtuA8nv5HXcwRq algWUhTqnGAA== X-IronPort-AV: E=McAfee;i="6200,9189,9993"; a="189022616" X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="189022616" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2021 03:09:52 -0700 IronPort-SDR: bgKWrO2mq/AnbANCp001RWJ/56zIb59hizhWz73OM2G8z8NY2DOFVe9KdKrNj1jWP7ybYymqRI ZaJzSw57OdgQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="470508703" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 24 May 2021 03:09:52 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 24 May 2021 03:09:52 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Mon, 24 May 2021 03:09:52 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Mon, 24 May 2021 03:09:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IcYhBBW8HaLDoHNgRuNS20+tSLcB05YhYw6hjttJEC8WvD+ra3WrWOhsG/q66T6ewV1KVqD/WC7SiTzrv/RxLhSzkvavSTGAuI7wq1IeLtlu7CM57YXhHedoD3dLuYzXrng9woXjea0aj5vF1LoSukGbgJgzmG33RP+8SYShw/3vgwens0/ze4n4zjBeC4j4LGg2QsnHz8wVYLyALyVsbIzUwfRFdoL7x9DdJdUjuNNqMqiOIQ5sRD//F5M5XSQyahbuzShuuN0Up0YnYrk/J9+L1AqZm4lIiCAtWu5NGE+5wT0EldXHPdS7pTnzwJahk0wSgOFx8dSEzSJnq67Lcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=beeKHum7xe2xGhH8sVl7uszchoqI9lbK5rNQdcleTFs=; b=YwFJUO15xpyVmLq+BNAjLwuyAmJFhCzF5whaWryVx5OXMiiG+23YosCrlIojrlclR3lc+jkAJ2MSLhvl5RwkND7B9WIXzsNjJX2szt4sEYOrfPsoz6vs112SkTBgtU6tQmQMnu5IjFGMwFcMxvEuaNPDCaTM0fqYRw9D9WTP7vdc/N+m1fBq8Vsc0/xgnU5Wh9g6P+bGL3pFefEUWjUgxEotFRekj4bqH9GNILIDB1A7zu12TaBp7HsAdyBLx+C2GRNHn81t4bZV6f3vRdQig1Gl1SeZCIkiDVfMHY/K+JRFEyhHCQ/6yymxY038bjixl4q7tntTvSk7gwzLXe0fOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=beeKHum7xe2xGhH8sVl7uszchoqI9lbK5rNQdcleTFs=; b=TGVoert2UhBDdpJzxbAT7OV573imZZnM4NMJx4xfx9hDgjPrT5Lc4Yep+SB2lMc/4OEdmkgHcsQQoI8ANTaZW4hsFf2/9/Dq3jCxYygyWsv/kCxrft0CHqr5Ho4AWNPRBModPfV6/m7pS6hJFI70M1JfmSgyKZKw5bWeXQMj8YY= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SA2PR11MB4860.namprd11.prod.outlook.com (2603:10b6:806:11b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.25; Mon, 24 May 2021 10:09:50 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::6157:b65c:53b6:a320]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::6157:b65c:53b6:a320%6]) with mapi id 15.20.4150.027; Mon, 24 May 2021 10:09:50 +0000 From: "Chiu, Chasel" To: "Kuo, IanX" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [PATCH v3] MinPlatformPkg/Fsp: Rebase fail when python tools path exist whitespace REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3412 Thread-Topic: [PATCH v3] MinPlatformPkg/Fsp: Rebase fail when python tools path exist whitespace REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3412 Thread-Index: AQHXUIO6WbqGQGcb3ku94xm38p7VoqryaKPQ Date: Mon, 24 May 2021 10:09:50 +0000 Message-ID: References: <6ba48b2f5b7676eb6bf1199e51ce691b54beff5f.1621846279.git.ianx.kuo@intel.com> In-Reply-To: <6ba48b2f5b7676eb6bf1199e51ce691b54beff5f.1621846279.git.ianx.kuo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [36.228.168.39] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5afc876f-49f6-4de9-6787-08d91e9c119d x-ms-traffictypediagnostic: SA2PR11MB4860: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:120; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: A+gG7DM5tTa51vADwfSp2gYxEEPopMDPc0d1AVS48iVY4bBAcvZzxB3yzUTD5U4RoVJDYMQK3WtFft+1xl8V0dZjB6d7pYnefIeCn7wUdKFwmMTteSmt7NgMQ3fBOZE5u0BO9Zlc1vWMLUZLRgqzxGzLcPgy4T8xKgLaGu4XU66f1Wgt7FtjGNY+SWvMrz+726QeYwtOXQnv2DtggT0HXuksYQEY/Xmpow69foPeISMkxRgBW0GN4qG7AwcIf5g3N0gqvNWQB75piegJR69gSdBb+TTldY+StuK0aSD6Z3LeViYqRr80B6lSs+layZciVcGoavx+tryzw6wR5xFvH35qR9hpr7EVlwimQloBXQY7q50wiClPct/2Q4LiSCNTUwzqpNOdCR7vMfPaUXkFHMCzb+NUuc/mIQsFg2uHb0bpJ0uMSmmCcePeMDAmel+Xr7iwK3LLjz3KmvfAXE3Ao7x+CW1CMXLf+4TJvwPimNWz2/xc0ILhDf/ePbFDEYS4f82LxyKPVAi7wirxPfgWoSIZ/19la81LTuFetfx5o+c9TEArE2+1vclkTH3f41qNdNz/A4sv3LbPJc4X+wbiq34wGSRMqeY8xzQMqWUusHYpuPmV7VMXq/1iT6OajFb9yWYubo7yG+gmbvTvyOBPByTVrdDrdnmIbdzAZY2NTYiACg23nWS/NaiAXuxrm70ucr+8Sl61gWeMPg/uPZGh/fjQ7Lle++JTILrWIMO9rNc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(366004)(136003)(346002)(39860400002)(396003)(110136005)(52536014)(26005)(33656002)(71200400001)(316002)(83380400001)(8936002)(122000001)(53546011)(107886003)(4326008)(186003)(2906002)(5660300002)(6506007)(9686003)(38100700002)(66446008)(55016002)(66476007)(966005)(8676002)(478600001)(66556008)(86362001)(7696005)(66946007)(64756008)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?RwoHLPtVOFk9piMPixmSHt2rlZEmI0CdEN7cUmjMZI/cjcqiPEYjZHxrKX26?= =?us-ascii?Q?t9C7Xls6GtRczfUrcJTHfm+luTQ9xrJO2RcvimJuoSbg2I2WBX0R/jZae/28?= =?us-ascii?Q?5Qfxb/Kx5ypU6PRVuQTgeR57YVuoSZtYucLDqa5J2//ClenGeJq5fuvxfXr+?= =?us-ascii?Q?5zBOPiAswJXkdcYqYQFcvKh0Zm42yCZQ09S1QRMhf8mLSEeIX31gqv4I3nZr?= =?us-ascii?Q?a10kEOw9rFALRo84OTjN/IYAplndrEmx7QQwohNopn9lEpippOOsNos+bHAV?= =?us-ascii?Q?zPBQifQgSrxPJ6G61St4UvkcrDnU+KLvOYxOk3kOxW4dY06xzR4yvyGZz3VM?= =?us-ascii?Q?YUmXpjgo8Ak1MWIqFu4ZhggOKEPXW97eEcjtgxlfHfDvOHG0YGvUmBdmPALE?= =?us-ascii?Q?Z8u3oLCpU673RM4CRmyTc8e4q0QSKiWmNRNHqtrMHrzj1h1DeArKQ7281FKx?= =?us-ascii?Q?ZL1MO5IkQ9BvfgHDCbkp8zjXbrDMaCphlBeH5e1Gib+NcadbBIbYyb/UJIJM?= =?us-ascii?Q?itOKSyWkAVU+i8gZku9CgoGvEVr+uR30brjLa5ztlJnjy1bs5rCr6arQsFmg?= =?us-ascii?Q?aqqFCKew5ljxDlfMvEdh18quu3pssrGc6XqO+Txqs9COsL7drC1l8ACGLVqa?= =?us-ascii?Q?upBtWF0hcbuI+VxLddKYaUTQI1gEEUOFtkPMsXIULVr+9v4SCMfyyih9vX4n?= =?us-ascii?Q?k6OBI2SJhAGkBCAiptGAIuxTJpTbwEVQjH9w/vbTtMmybvoobeJ9CRR8ogXH?= =?us-ascii?Q?xszUdICYVtNO1MPmEsWuFRnGNi4NABgwFIchuPnS0tMeCOAmz9EEw7Kos8Ja?= =?us-ascii?Q?oUXyKqgg3TArfOb5hfZzm83IsR1C+rYOgssbxKKtfqyrpMJNrIZd0iS+Xbn9?= =?us-ascii?Q?aUCUHFtDd8etbXajnJQLAgW5Bbysk7pm4ro27tgPKK4zCKXr8qhox6wMGrxN?= =?us-ascii?Q?0DLqew7Szdof62Jwg3urapWoMFk3KNU2Qu89CfHQEKJlU4sbVCwlPPpxCQQQ?= =?us-ascii?Q?9PMu94zisXrquP8HacHvzeRriNwm8W6ksRtXfpYOdv5Ay0vXYI1/b1BXFjht?= =?us-ascii?Q?m1WHEyET85sV+oSLmo/KDw63alv6EkraHq40jFLXaJkx4zyqV47w6o48rDiO?= =?us-ascii?Q?FFRGtNyL2OYQrknpph9uHRJbFeigcHDTZKm3E/rb3DpkawEMNdemRDJc314C?= =?us-ascii?Q?9Yg0R/73WRR05DXGgXVW51oMaR80RFXYVgsHavm671fkISfhhSDcGdgoG76k?= =?us-ascii?Q?nb4JGvFw6FPdvMMmtCq8inz/Ww4Nn2Q35Q59kHbNG3T5QjFa9MJKLJgo4x5n?= =?us-ascii?Q?1nCYvwz0YD4FP9q1BkSM6cSI?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5afc876f-49f6-4de9-6787-08d91e9c119d X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2021 10:09:50.7996 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wAaKEl0lM1uqNMtsh/7xR5BRf3tXzeqmCLsjLl7FVXRURn7G10RjFaKneKTVKcn/ySqi7GgK8OyeqDMhDCU9jQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4860 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable With subject format correction, Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kuo, IanX > Sent: Monday, May 24, 2021 6:38 AM > To: devel@edk2.groups.io > Cc: Kuo, IanX ; Chiu, Chasel ; > Desimone, Nathaniel L > Subject: [PATCH v3] MinPlatformPkg/Fsp: Rebase fail when python tools pat= h > exist whitespace REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D34= 12 >=20 > From: IanX Kuo >=20 > (a) C:\Users\\AppData\Local\Program\Python\Python38 > (b) C:\Python38 > (c) C:\Program Files\Python38 > Issue only happens on (a) and (c). > (a) happen on have whitespace. Ex: Tony Chen > (c) happen on "Program Files" have whitespace. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: IanX Kuo > --- > .../Tools/Fsp/RebaseAndPatchFspBinBaseAddress.py | 6 +++--- > .../MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseAndPatchFspBinBaseAddres > s.py > b/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseAndPatchFspBinBaseAddres > s.py > index 406e5ec130..f3cba2651a 100644 > --- > a/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseAndPatchFspBinBaseAddres > s.py > +++ b/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseAndPatchFspBinBaseAd > +++ dress.py > @@ -1,6 +1,6 @@ > ## @ RebaseAndPatchFspBinBaseAddress.py #-# Copyright (c) 2017 - 2019, I= ntel > Corporation. All rights reserved.
+# Copyright (c) 2017 - 2021, Intel > Corporation. All rights reserved.
# SPDX-License-Identifier: BSD-2-Cl= ause- > Patent # @@ -93,13 +93,13 @@ fspTBaseAddress =3D flashBase + fspTBaseOffs= et > # Re-base FSP bin file to new address and save it as fspBinFileRebased us= ing > SplitFspBin.py # rebaseArguments =3D fspBinFilePath + " -c s m t -b " + > str(hex(fspSBaseAddress).rstrip("L")) + " " + str(hex(fspMBaseAddress).rs= trip("L")) > + " " + str(hex(fspTBaseAddress).rstrip("L")) + " -o" + fspBinPath + " -n= " + > fspBinFileRebased-os.system(pythontool + " " + splitFspBinPath + " rebase= -f" + > rebaseArguments)+os.system('"' + pythontool + '"' + " " + splitFspBinPath= + " > rebase -f" + rebaseArguments) # # Split FSP bin to FSP-S/M/T segments # > splitArguments =3D fspBinPath + os.sep + fspBinFileRebased + " -o " + fsp= BinPath + > " -n Fsp_Rebased.fd"-os.system(pythontool + " " + splitFspBinPath + " spl= it -f" + > splitArguments)+os.system('"' + pythontool + '"' + " " + splitFspBinPath = + " split - > f" + splitArguments) # # Patch dsc file with the re-based FSP-S/M/T addr= ess, so > internally build will use the same.diff --git > a/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > b/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > index fb4cf4f9b7..b7e4bcf5f9 100644 > --- a/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > +++ b/Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > @@ -1,6 +1,6 @@ > ## @ RebaseFspBinBaseAddress.py #-# Copyright (c) 2019, Intel Corporatio= n. All > rights reserved.
+# Copyright (c) 2019 - 2021, Intel Corporation. All = rights > reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -87,12 > +87,12 @@ fspTBaseAddress =3D flashBase + fspTBaseOffset # Re-base FSP b= in > file to new address and save it as fspBinFileRebased using SplitFspBin.py= # > rebaseArguments =3D fspBinFilePath + " -c s m t -b " + > str(hex(fspSBaseAddress).rstrip("L")) + " " + str(hex(fspMBaseAddress).rs= trip("L")) > + " " + str(hex(fspTBaseAddress).rstrip("L")) + " -o" + fspBinPath + " -n= " + > fspBinFileRebased-os.system(pythontool + " " + splitFspBinPath + " rebase= -f" + > rebaseArguments)+os.system('"' + pythontool + '"' + " " + splitFspBinPath= + " > rebase -f" + rebaseArguments) # # Split FSP bin to FSP-S/M/T segments # > splitArguments =3D fspBinPath + os.sep + fspBinFileRebased + " -o " + fsp= BinPath + > " -n Fsp_Rebased.fd"-os.system(pythontool + " " + splitFspBinPath + " spl= it -f" + > splitArguments)+os.system('"' + pythontool + '"' + " " + splitFspBinPath = + " split - > f" + splitArguments) exit(0)-- > 2.27.0.windows.1